RFR: 8191758: Match WebKit's font weight rendering with JavaFX

As per JavaFx 700 font weight is considered to be bold but webkit is using 600 font weight for text to become bold. to fix issue, use boldWeightValue() function which uses 700 font weight rather than isFontWeightBold() which compare against 600 font weight. - Commit messages: -

GitHub glitch - merging master into an old pull request

I was surprised to see GitHub listing in my pull request all of the changes I merged from the upstream master branch, as I commented here: Did I merge the upstream master branch correctly? https://github.com/openjdk/jfx/pull/60#issuecomment-614885532 Unfortunately, GitHub also pulled into my

Re: RFR: 8227425: Add support for e-paper displays on i.MX6 devices

On Thu, 16 Apr 2020 20:45:17 GMT, John Neffenger wrote: > Let me know if you would like me to rebase my changes and force push a > cleaner update. Yes, this is what you will need to do. More than just being needed for a cleaner update, the PR lists 6,151 changed files! Either the merge went

WIP version with PI compile (Re: A WIP for JDK-8238080 for review/discussion (Re: "Internal review ID 9063426: "FXMLLoader: if script engines implement javax.script.Compilabel compile scripts"

There is a new WIP at which adds a compile PI (process instruction) for turning on and off script compilation if the script engine implements the Compilable interface. By default compilation is off (no compilation), such that one needs to add a compile

Re: RFR: 8191758: Match WebKit's font weight rendering with JavaFX

On Tue, 14 Apr 2020 10:25:52 GMT, Bhawesh Choudhary wrote: > As per JavaFx 700 font weight is considered to be bold but webkit is using > 600 font weight for text to become bold. to > fix issue, use boldWeightValue() function which uses 700 font weight rather > than isFontWeightBold() which

Re: [Rev 03] RFR: 8217472: Add attenuation for PointLight

On Wed, 15 Apr 2020 20:59:40 GMT, Kevin Rushforth wrote: >> Here are the results on Phil's machine, which is a Mac Book Pro with a >> graphics accelerator (Nvidia, I think). >> >> Without the patch: >> 2000 quads average 8.805 fps >> >> With the patch: >> 2000 quads average 4.719 fps >> >>

Re: RFR: 8191758: Match WebKit's font weight rendering with JavaFX

On Thu, 16 Apr 2020 12:40:24 GMT, Kevin Rushforth wrote: >> As per JavaFx 700 font weight is considered to be bold but webkit is using >> 600 font weight for text to become bold. to >> fix issue, use boldWeightValue() function which uses 700 font weight rather >> than isFontWeightBold() which

Windows Installation Instructions, All DLL Files Missing

I manage a project[0]  that leverages JavaFX. It's been a while since I've worked on this project, almost two years. At that time JavaFX was bundled with the Java runtime from Oracle. The few customers I had would simply run the application from the bundled launcher and as long as they had

Re: RFR: 8227425: Add support for e-paper displays on i.MX6 devices

On Fri, 17 Apr 2020 15:05:22 GMT, Kevin Rushforth wrote: >> @kevinrushforth Did I merge the upstream master branch correctly? The [last >> time I did >> this](https://github.com/javafxports/openjdk-jfx/pull/522/commits) on the >> old *openjdk-jfx* repository, the pull >> request showed only

Re: GitHub glitch - merging master into an old pull request

Yeah, something went wrong here. Either the merge went wrong (a quick glance suggests that it didn't) or it has managed to confuse GitHub (that seems likely). I also added a comment to the PR. I do not recommend changing the base branch. Even if that were to fix it, it would be much better

Re: Windows Installation Instructions, All DLL Files Missing

From where are you getting your OpenJDK build? https://jdk.java.net/14 ? Somewhere else? -- Kevin On 4/17/2020 2:16 PM, Christopher Miles wrote: Yeah, I've tried it with both. The instructions on the JavaFX page tell you to add the "lib" directory to the `javac` path and the "mods" to the

Re: Windows Installation Instructions, All DLL Files Missing

I build several JavaFX projects with cross-builds for Windows, Mac, Linux. Note that I build the projects with Java 11, then use Java 14 packager to build the final installer. So my examples require that you set a JPACKAGE_HOME env variable that points at the Java 14 home. Anyway, here’s an

Re: Windows Installation Instructions, All DLL Files Missing

Yeah, I've tried it with both. The instructions on the JavaFX page tell you to add the "lib" directory to the `javac` path and the "mods" to the `jlink` path. I figured, since nothing is working, why not try them the other way around? In all cases the results are the same. I'm using OpenJDK,

Re: Windows Installation Instructions, All DLL Files Missing

I use jlink and jpackage to distribute JavaFX applications. You suggest there will be a problem if you use jlink, but it will work if you include the needed javafx modules. The .jmod files contain the necessary native libraries and jlink will build a JRE that has the DLLs in the right place for

Re: Windows Installation Instructions, All DLL Files Missing

I have downloaded both the "mods" and the SDK. I put them alongside the JDK on my workstation. C:\Program Files\Java\jdk-14.0.1 C:\Program Files\Java\javafx-sdk-14 C:\Program Files\Java\javafx-jmods-14.0.1 If I remove the path `C:\Program Files\Java\javafx-sdk-14\bin` and point`jlink`

Re: Windows Installation Instructions, All DLL Files Missing

Where are you getting JDK 14.0.1 from? Does it include the Microsoft VS2017 DLLs and Windows SDK DLLs in jdk-14.0.1/bin? There are 45 of them (40 of them are of the form api-ms-win-*.dll). The JavaFX 14.0.1 sdk includes them, but the jmods do not. See JDK-8207015 [1] for why not. If the JDK

Re: [Rev 02] RFR: 8227425: Add support for e-paper displays on i.MX6 devices

> This pull request adds support for e-paper displays with the i.MX 6 Series of > Applications Processors and implements > [Issue #521](https://github.com/javafxports/openjdk-jfx/issues/521) in the > obsolete *javafxports/openjdk-jfx* > repository. Some of the changes were made to support the

Re: RFR: 8185886: Improve scrolling performance of TableView and TreeTableView

On Fri, 17 Apr 2020 07:22:20 GMT, dannygonzalez wrote: >> @hjon >> >>> 3. Even though the current version of this pull request takes care to >>> notify duplicate listeners the correct amount of >>> times, it does not notify them in the correct order with respect to other >>> listeners. If

Re: RFR: 8185886: Improve scrolling performance of TableView and TreeTableView

On Fri, 17 Apr 2020 08:07:08 GMT, John Hendrikx wrote: >> @hjohn >> >>> 2. There is a significant increase in memory use. Where before each >>> listener occupied an entry in an array, now each >>> listener is wrapped by Map.Entry (the Integer instance used per entry can >>> be disregarded). I

Re: RFR: 8129123: ComboBox popup list view does not scrollTo when ComboBox value/selection is set

On Thu, 9 Apr 2020 09:37:30 GMT, Craig Cavanaugh wrote: > https://bugs.openjdk.java.net/browse/JDK-8129123 > > This pull request fixes JDK-8129123. This bug also effects Windows and Linux > platforms. > Also, I believe JDK-8196037 is a duplicate of this issue. > > I've tested this against

Re: RFR: 8129123: ComboBox popup list view does not scrollTo when ComboBox value/selection is set

On Thu, 16 Apr 2020 10:01:14 GMT, Craig Cavanaugh wrote: >> I think you will need to rebase and force push your branch. > > Seems I've made a further mess attempting to rebase. I apologize as I know > the list is not intended to be tech support for git usage, but I'm at a > loss and don't want

Re: RFR: 8185886: Improve scrolling performance of TableView and TreeTableView

On Fri, 17 Apr 2020 08:48:35 GMT, dannygonzalez wrote: >> @dannygonzalez I added a proof of concept here if you want to play with it: >> https://github.com/openjdk/jfx/pull/185 > > @hjohn Thanks for looking into this. It looks like your changes do improve > the issue with the JavaFX thread

Re: RFR: 8129123: ComboBox popup list view does not scrollTo when ComboBox value/selection is set

On Thu, 9 Apr 2020 09:37:30 GMT, Craig Cavanaugh wrote: > https://bugs.openjdk.java.net/browse/JDK-8129123 > > This pull request fixes JDK-8129123. This bug also effects Windows and Linux > platforms. > Also, I believe JDK-8196037 is a duplicate of this issue. > > I've tested this against

Re: RFR: 8129123: ComboBox popup list view does not scrollTo when ComboBox value/selection is set

On Tue, 14 Apr 2020 09:04:40 GMT, Ajit Ghaisas wrote: >> was: https://github.com/openjdk/jfx/pull/136 > > I am taking a look at your changes now. > @ccavanaugh can you make jcheck pass while I review. Please see the details > of the failing jcheck. Thank you. I've updated the pull request

RFR: 8129123: ComboBox popup list view does not scrollTo when ComboBox value/selection is set

https://bugs.openjdk.java.net/browse/JDK-8129123 This pull request fixes JDK-8129123. This bug also effects Windows and Linux platforms. Also, I believe JDK-8196037 is a duplicate of this issue. I've tested this against OpenJDK 11.0.6 on Ubuntu 18.04, Arch Linux and Windows 10. Thanks!

Re: RFR: 8129123: ComboBox popup list view does not scrollTo when ComboBox value/selection is set

On Thu, 16 Apr 2020 12:30:20 GMT, Kevin Rushforth wrote: >> Seems I've made a further mess attempting to rebase. I apologize as I know >> the list is not intended to be tech support for git usage, but I'm at a >> loss and don't want to make it worse. >> >> Below is the log after an interactive

Re: RFR: 8129123: ComboBox popup list view does not scrollTo when ComboBox value/selection is set

On Tue, 14 Apr 2020 10:43:30 GMT, Craig Cavanaugh wrote: >> I am taking a look at your changes now. >> @ccavanaugh can you make jcheck pass while I review. Please see the details >> of the failing jcheck. > > Thank you. I've updated the pull request comments with what I thought was > the

Re: RFR: 8129123: ComboBox popup list view does not scrollTo when ComboBox value/selection is set

On Fri, 10 Apr 2020 10:22:29 GMT, Jeanette Winzenburg wrote: >> https://bugs.openjdk.java.net/browse/JDK-8129123 >> >> This pull request fixes JDK-8129123. This bug also effects Windows and Linux >> platforms. >> Also, I believe JDK-8196037 is a duplicate of this issue. >> >> I've tested

Re: RFR: 8129123: ComboBox popup list view does not scrollTo when ComboBox value/selection is set

On Tue, 14 Apr 2020 11:11:13 GMT, Kevin Rushforth wrote: >> Thank you. I've updated the pull request comments with what I thought was >> the necessary changes, but jcheck is still failing with >> >> "the commits in this PR have inconsistent user names and/or email >> addresses. Please amend

Re: RFR: 8129123: ComboBox popup list view does not scrollTo when ComboBox value/selection is set

On Fri, 17 Apr 2020 09:21:25 GMT, Craig Cavanaugh wrote: >> The following should work: >> >> $ git rebase -i master >> >> If the rebase is successful, it will pop you into your EDITOR. You then >> select "pick" for the first commit (which is >> already selected by default) and "s"quash or

Re: RFR: 8185886: Improve scrolling performance of TableView and TreeTableView

On Thu, 16 Apr 2020 16:15:20 GMT, John Hendrikx wrote: >> @hjohn I have 12136 change listeners when debugging our application as you >> suggested. >> >> Please note that I see the issue when the TableView is having items added to >> it. If you just have a static TableView I >> do not see the

Re: RFR: 8185886: Improve scrolling performance of TableView and TreeTableView

On Fri, 17 Apr 2020 07:22:20 GMT, dannygonzalez wrote: >> @hjon >> >>> 3. Even though the current version of this pull request takes care to >>> notify duplicate listeners the correct amount of >>> times, it does not notify them in the correct order with respect to other >>> listeners. If

Re: RFR: 8185886: Improve scrolling performance of TableView and TreeTableView

On Fri, 17 Apr 2020 07:08:01 GMT, dannygonzalez wrote: >> I've tested this pull request locally a few times, and the performance >> improvement is quite significant. A test with >> 20.000 nested stack panes resulted in these average times: >> - Add all 51 ms >> - Remove all 25 ms >> >>

Re: RFR: 8129123: ComboBox popup list view does not scrollTo when ComboBox value/selection is set

On Fri, 17 Apr 2020 10:34:54 GMT, Ajit Ghaisas wrote: >> That did it! >> >> Thanks! >> >> On Thu, Apr 16, 2020 at 8:30 AM Kevin Rushforth >> wrote: >> >>> The following should work: >>> >>> $ git rebase -i master >>> >>> If the rebase is successful, it will pop you into your EDITOR. You then

Re: RFR: 8185886: Improve scrolling performance of TableView and TreeTableView

On Fri, 17 Apr 2020 10:22:15 GMT, John Hendrikx wrote: >> @hjohn Thanks for looking into this. It looks like your changes do improve >> the issue with the JavaFX thread being >> swamped with listener de-registrations. Looking at the JavaFX thread in >> VisualVM, the removeListener call has

Re: [Rev 02] RFR: 8223298: SVG patterns are drawn wrong

On Wed, 15 Apr 2020 15:14:49 GMT, Arun Joseph wrote: >> Issue: Assuming the pixelScale is 2, the tile image size is doubled at the >> native side which is propagated to the java >> side as well. But, as transform initialization takes place after scaling, >> the transform is reset to default

Re: [Rev 01] RFR: 8241840: Memoryleak: Closed focused Stages are not collected with Monocle.

On Tue, 14 Apr 2020 11:15:32 GMT, Florian Kirmaier wrote: >> Closed focused Stages are not collected with Monocle >> >> This commit adds a unit-test and a fix for collecting focused closed stages. >> >> ticket: https://bugs.openjdk.java.net/browse/JDK-8241840 > > Florian Kirmaier has updated

Re: [Rev 01] RFR: 8241840: Memoryleak: Closed focused Stages are not collected with Monocle.

On Tue, 14 Apr 2020 10:47:55 GMT, Florian Kirmaier wrote: >> tests/system/src/test/java/test/javafx/stage/FocusedWindowTest.java line 77: >> >>> 76: Platform.runLater(() -> stage.close()); >>> 77: } >>> 78: >> >> Looks like the primary `stage` is not required for actual test, and

Re: [Rev 01] RFR: 8241840: Memoryleak: Closed focused Stages are not collected with Monocle.

On Thu, 16 Apr 2020 19:19:16 GMT, Ambarish Rapte wrote: >> I wasn't able to reproduce the Problem on Window10 with VirtualBox. >> >> How should I do it? Add a second test class without the static code? Do you >> have a good recommendation on how to add it? > > The previous version of test

[jfx14] RFR: 8242839: Create release notes for JavaFX 14.0.1

Add release notes for 14.0.1 Fix for JDK-8242839 - Commit messages: - Add release notes for 14.0.1 Changes: https://git.openjdk.java.net/jfx/pull/186/files Webrev: https://webrevs.openjdk.java.net/jfx/186/webrev.00 Issue: https://bugs.openjdk.java.net/browse/JDK-8242839 Stats:

Re: [jfx14] RFR: 8242839: Create release notes for JavaFX 14.0.1

On Fri, 17 Apr 2020 14:34:01 GMT, Johan Vos wrote: > Add release notes for 14.0.1 > Fix for JDK-8242839 Marked as reviewed by kcr (Lead). - PR: https://git.openjdk.java.net/jfx/pull/186