Remove JavaFX JPMS enforcement

2020-04-18 Thread Michael Paus
Getting started with JavaFX is made overly complicated by the fact that the use of the module system is enforced by some code in the JDK. Especially for beginners, who just want to get some small program running, this is almost always a big source of frustration. It is not very good marketing

Re: [Rev 01] RFR: 8129123: ComboBox popup list view does not scrollTo when ComboBox value/selection is set

2020-04-18 Thread Craig Cavanaugh
On Fri, 17 Apr 2020 10:38:06 GMT, Ajit Ghaisas wrote: >> Craig Cavanaugh has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update unit test for JDK_8129123 to check midpoint of the list > >

Re: Remove JavaFX JPMS enforcement

2020-04-18 Thread Michael Paus
Hi, I would just like to add that many of the problems you have cited would just vanish if the JPMS enforcement would be removed from the JDK. There would be no "JavaFX requiring absurd runtime module VM arguments" anymore and the IDE integration would just be straight forward. JavaFX would

Re: [Rev 01] RFR: 8129123: ComboBox popup list view does not scrollTo when ComboBox value/selection is set

2020-04-18 Thread Craig Cavanaugh
> https://bugs.openjdk.java.net/browse/JDK-8129123 > > This pull request fixes JDK-8129123. This bug also effects Windows and Linux > platforms. > Also, I believe JDK-8196037 is a duplicate of this issue. > > I've tested this against OpenJDK 11.0.6 on Ubuntu 18.04, Arch Linux and > Windows 10.

Re: Remove JavaFX JPMS enforcement

2020-04-18 Thread Ty Young
On 4/18/20 5:01 AM, Michael Paus wrote: Getting started with JavaFX is made overly complicated by the fact that the use of the module system is enforced by some code in the JDK. Especially for beginners, who just want to get some small program running, this is almost always a big source of

Re: Remove JavaFX JPMS enforcement

2020-04-18 Thread Glenn Holmer
On 4/18/20 5:01 AM, Michael Paus wrote: > Getting started with JavaFX is made overly complicated by the fact > that the use of the module system is enforced by some code in the > JDK. Especially for beginners, who just want to get some small > program running, this is almost always a big source of

Re: [Rev 01] RFR: 8185886: Improve scrolling performance of TableView and TreeTableView

2020-04-18 Thread yosbits
On Fri, 3 Apr 2020 03:55:37 GMT, yosbits wrote: >> Hi, >> I couldn't find you listed at >> https://www.oracle.com/technetwork/community/oca-486395.html . Please send >> me an e-mail >> at dalibor.to...@oracle.com with information about your OCA, so that I can >> look it up. > > My name is

Re: Windows Installation Instructions, All DLL Files Missing

2020-04-18 Thread Christopher Miles
Yep, that's where I downloaded it from. > PS C:\Users\cmiles\source\repos\xmltool> java --version > openjdk 14.0.1 2020-04-14 > OpenJDK Runtime Environment (build 14.0.1+7) > OpenJDK 64-Bit Server VM (build 14.0.1+7, mixed mode, sharing) When I look at the "bin" directory that came with the

FYI: 8243112: Skip failing test SVGTest.testSVGRenderingWithPattern

2020-04-18 Thread Arun Joseph
SVGTest.testSVGRenderingWithPattern is failing frequently due to [JDK-8243110](https://bugs.openjdk.java.net/browse/JDK-8243110). We should skip this test until it is fixed. - Commit messages: - 8243112: Skip failing test SVGTest.testSVGRenderingWithPattern Changes:

Re: FYI: 8243112: Skip failing test SVGTest.testSVGRenderingWithPattern

2020-04-18 Thread Kevin Rushforth
On Sat, 18 Apr 2020 17:38:17 GMT, Arun Joseph wrote: > SVGTest.testSVGRenderingWithPattern is failing frequently due to > [JDK-8243110](https://bugs.openjdk.java.net/browse/JDK-8243110). We should > skip this test until it is fixed. Marked as reviewed by kcr (Lead). - PR:

Re: Windows Installation Instructions, All DLL Files Missing

2020-04-18 Thread Michael Paus
Hi Christopher, I do not know what your specific problem is but maybe you just have to shift your goals a little bit. Continuing like you did in the Java 8 days is not a good idea for various reasons. The current trend for distributing desktop software with Java is to build a platform specific

Re: [Rev 03] RFR: 8217472: Add attenuation for PointLight

2020-04-18 Thread Kevin Rushforth
On Fri, 17 Apr 2020 16:02:12 GMT, Nir Lisker wrote: >> Conclusion: The new shaders that support attenuation don't seem to have much >> of a performance impact on machines with >> an Intel HD, but on systems with a graphics accelerator, it is a significant >> slowdown. >> So we are left with

Re: RFR: 8198402: ToggleButton.setToggleGroup causes memory leak when button is removed via ToggleGroup.getToggles()

2020-04-18 Thread Kevin Rushforth
On Thu, 9 Apr 2020 09:58:27 GMT, Jesper Skov wrote: > Make the two ways of associating a ToggleButton with a ToggleGroup interact > correctly. > > This fixes https://bugs.openjdk.java.net/browse/JDK-8198402 The fix looks correct to me. Have you run all tests to ensure no regressions? I left

Re: RFR: 8242490: Upgrade to gcc 9.2 on Linux

2020-04-18 Thread Kevin Rushforth
On Sat, 18 Apr 2020 15:52:36 GMT, Johan Vos wrote: >> This is a compiler upgrade on Linux from the current gcc 8.3 compiler to gcc >> 9.2. This will match a recent upgrade done >> for JDK 15 -- see >> [JDK-8241721](https://bugs.openjdk.java.net/browse/JDK-8241721). >> On a related note, using

Re: Remove JavaFX JPMS enforcement

2020-04-18 Thread Tom Eugelink
I'm in the process of porting an app from Java 8 to Java 11. Just getting it to run in classpath mode is not that hard anymore; upgrade a bunch of libraries and you're set. As an experiment I'm now activating JPMS. Right! What a lot of work! Do you have any idea how many fairly common

Re: Remove JavaFX JPMS enforcement

2020-04-18 Thread Weiqi Gao
I have built both non-modular and modular JavaFX apps in the past five years, and I agree that bootstrapping a modular Hello World JavaFX application is not as trivial as bootstrapping a non-modular one. The big challenges are related to the JPMS. These challenges are not unique to JavaFX.

Re: RFR: 8198402: ToggleButton.setToggleGroup causes memory leak when button is removed via ToggleGroup.getToggles()

2020-04-18 Thread Kevin Rushforth
On Thu, 9 Apr 2020 10:00:49 GMT, Jesper Skov wrote: >> Make the two ways of associating a ToggleButton with a ToggleGroup interact >> correctly. >> >> This fixes https://bugs.openjdk.java.net/browse/JDK-8198402 > > /signed @arapte can you also review? - PR:

Re: [Rev 01] RFR: 8185886: Improve scrolling performance of TableView and TreeTableView

2020-04-18 Thread yosbits
> If there are many columns, the current TableView will stall scrolling. > Resolving this performance issue requires column > virtualization. Virtualization mode is enabled when the row height is fixed > by the following method. > `tableView.setFixedCellSize(height)` > > This proposal includes

Re: RFR: 8129123: ComboBox popup list view does not scrollTo when ComboBox value/selection is set

2020-04-18 Thread Kevin Rushforth
On Fri, 17 Apr 2020 10:42:30 GMT, Jeanette Winzenburg wrote: >> I think, selection and scrolling are two separate operations. Here we use >> these two operations to achieve the desired >> result for ComboBox. It is nice to have behavior and I am OK with the fix. >>> Also, I believe

Re: RFR: 8242490: Upgrade to gcc 9.2 on Linux

2020-04-18 Thread Johan Vos
On Mon, 13 Apr 2020 16:12:38 GMT, Kevin Rushforth wrote: > This is a compiler upgrade on Linux from the current gcc 8.3 compiler to gcc > 9.2. This will match a recent upgrade done > for JDK 15 -- see > [JDK-8241721](https://bugs.openjdk.java.net/browse/JDK-8241721). > On a related note, using

RE: Remove JavaFX JPMS enforcement

2020-04-18 Thread Mohammad Saleem Yusuf
Michael, I completely agree with you. I am Professor at a community college (NHTI) and teach entry level courses to students who have just graduated from high school. About a year ago (JDK 8 to 11), I started including Java FX in my Java course, but after that I had to remove it (JDK > 11.03) as