On Mon, 27 Jul 2020 20:32:46 GMT, Nir Lisker wrote:
> Adds clarifications to the documentation in various places. Some notes:
>
> * Point 6 should probably be deferred until it is verified that the tutorials
> are correct enough, seeing as they were
> updated to Java 8 only.
> * Point 8 has
Hi everyone,
Can someone look into my small fix for mac minimize?
https://github.com/openjdk/jfx/pull/280
Greetings Florian Kirmaier
ticket: https://bugs.openjdk.java.net/browse/JDK-8251241
This small change fixing the minimize for mac.
Changes are property registered.
Calling setIconize(true) no longer resets to false.
-
Commit messages:
- JDK-8251241
Changes: https://git.openjdk.java.net/jfx/pull/280/files
On Thu, 13 Aug 2020 12:47:32 GMT, Kevin Rushforth wrote:
>> ticket: https://bugs.openjdk.java.net/browse/JDK-8251241
>>
>> This small change fixing the minimize for mac.
>> Changes are property registered.
>> Calling setIconize(true) no longer resets to false.
>
>> JDK-8251241: macOS: iconify
On Thu, 13 Aug 2020 12:37:11 GMT, Florian Kirmaier
wrote:
> ticket: https://bugs.openjdk.java.net/browse/JDK-8251241
>
> This small change fixing the minimize for mac.
> Changes are property registered.
> Calling setIconize(true) no longer resets to false.
> JDK-8251241: macOS: iconify
Can you change the PR title to be properly formatted? That will allow
Skara to initiate the RFR, and is needed for a formal review (and
eventual integration).
-- Kevin
On 8/13/2020 5:39 AM, Florian Kirmaier wrote:
Hi everyone,
Can someone look into my small fix for mac minimize?
On Thu, 13 Aug 2020 12:37:11 GMT, Florian Kirmaier
wrote:
> ticket: https://bugs.openjdk.java.net/browse/JDK-8251241
>
> This small change fixing the minimize for mac.
> Changes are property registered.
> Calling setIconize(true) no longer resets to false.
This looks good based on my initial
On Thu, 13 Aug 2020 16:35:51 GMT, Kevin Rushforth wrote:
>> Florian Kirmaier has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> JDK-8251241
>> Added missing spaces to match the coding style.
>
>
> ticket: https://bugs.openjdk.java.net/browse/JDK-8251241
>
> This small change fixing the minimize for mac.
> Changes are property registered.
> Calling setIconize(true) no longer resets to false.
Florian Kirmaier has updated the pull request incrementally with one additional
commit since the
On Thu, 13 Aug 2020 16:37:44 GMT, Kevin Rushforth wrote:
>> Florian Kirmaier has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> JDK-8251241
>> Added missing spaces to match the coding style.
>
> This looks good based on my initial
On Thu, 13 Aug 2020 17:09:43 GMT, Florian Kirmaier
wrote:
>> This looks good based on my initial testing, including a modified version of
>> the test program that doesn't temporarily
>> set resizable to true. Nice.
>> I want to do some additional testing.
>>
>> I left one minor comment on the
On Thu, 13 Aug 2020 18:11:25 GMT, Kevin Rushforth wrote:
>> Thank you for the very quick feedback!
>> In the application, the fix was developed for, it also seems to fix all
>> issues related to iconified.
>
> You may have seen my comment in JBS: This PR also fixes
>
On Sun, 9 Aug 2020 17:11:27 GMT, Florian Kirmaier wrote:
>> tests/system/src/test/java/test/javafx/stage/FocusedWindowTestBase.java line
>> 60:
>>
>>> 59: static WeakReference closedFocusedStageWeak = null;
>>> 60: static Stage closedFocusedStage = null;
>>> 61:
>>
>> These two can be
On Fri, 7 Aug 2020 21:34:49 GMT, Kevin Rushforth wrote:
>> Florian Kirmaier has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> JDK-8241840
>> The tests are now reused for native and monocle tests.
>
>
On Wed, 22 Apr 2020 12:03:34 GMT, Florian Kirmaier
wrote:
>> Closed focused Stages are not collected with Monocle
>>
>> This commit adds a unit-test and a fix for collecting focused closed stages.
>>
>> ticket: https://bugs.openjdk.java.net/browse/JDK-8241840
>
> Florian Kirmaier has updated
> ticket: https://bugs.openjdk.java.net/browse/JDK-8251241
>
> This small change fixing the minimize for mac.
> Changes are property registered.
> Calling setIconize(true) no longer resets to false.
Florian Kirmaier has updated the pull request incrementally with one additional
commit since the
On Fri, 7 Aug 2020 20:39:56 GMT, Kevin Rushforth wrote:
>> As mentioned - I don't have a good setup to test this code on Windows.
>>
>> But I've checked where focusedWindow/getFocusedWindow is used, and I can
>> verify your assumption. I've searched through
>> the whole project and the
On Thu, 13 Aug 2020 19:21:56 GMT, Kevin Rushforth wrote:
>> You may have seen my comment in JBS: This PR also fixes
>> [JDK-8249202](https://bugs.openjdk.java.net/browse/JDK-8249202), which I
>> discovered while testing
>> [JDK-8248490](https://bugs.openjdk.java.net/browse/JDK-8248490). This
On Thu, 13 Aug 2020 19:45:49 GMT, Florian Kirmaier
wrote:
>> ticket: https://bugs.openjdk.java.net/browse/JDK-8251241
>>
>> This small change fixing the minimize for mac.
>> Changes are property registered.
>> Calling setIconize(true) no longer resets to false.
>
> Florian Kirmaier has updated
On Fri, 7 Aug 2020 21:38:27 GMT, Kevin Rushforth wrote:
>> Florian Kirmaier has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> JDK-8241840
>> The tests are now reused for native and monocle tests.
>
>
On Thu, 13 Aug 2020 19:40:02 GMT, Kevin Rushforth wrote:
>> Florian Kirmaier has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> JDK-8241840
>> The tests are now reused for native and monocle tests.
>
> The fix looks good now. I'll file a
On Sun, 2 Aug 2020 10:27:17 GMT, Tobias Diez
wrote:
>> Currently, loading a style sheet file using
>> `WebView.getEngine().setUserStyleSheetLocation(url)` fails if the url
>> start's with `jrt`, i.e. if the file is packaged in an application image
>> using jlink. This is fixed with this PR.
>
22 matches
Mail list logo
