On Thu, 21 Jan 2021 15:57:04 GMT, Arun Joseph wrote:
>> Update JavaFX WebKit to GTK WebKit 2.30 (610.2)
>
> Arun Joseph has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Fix color in DefaultPlugin
Changes looks good to me. Did a local build
On Thu, 21 Jan 2021 23:15:09 GMT, Kevin Rushforth wrote:
>> By using the anchor location facility of PopupWindows we can avoid
>> miscalculation of the
>> menu's height entirely.
>> This fix also cleans up some documentation issues.
>> This fix introduces tests that check the correct
On Fri, 22 Jan 2021 10:53:00 GMT, Robert Lichtenberger
wrote:
>> modules/javafx.controls/src/main/java/javafx/scene/control/ContextMenu.java
>> line 241:
>>
>>> 239: * the {@code ContextMenu} such that its top-left (0,0) position
>>> would be attached
>>> 240: * to the top-right
> By using the anchor location facility of PopupWindows we can avoid
> miscalculation of the
> menu's height entirely.
> This fix also cleans up some documentation issues.
> This fix introduces tests that check the correct positioning (test_position_)
> test_position_withCSS reproduces the
This particular issue JDK-8256283, is a specific case of IOOBE when, rootItem
is not shown, some children including first child are selected, then all
children are removed and sort() is invoked. The sort() fails with an IOOBE.
This PR only addresses this specific IOOBE.
Root cause of this issue
On Thu, 21 Jan 2021 23:11:44 GMT, Kevin Rushforth wrote:
>> By using the anchor location facility of PopupWindows we can avoid
>> miscalculation of the
>> menu's height entirely.
>> This fix also cleans up some documentation issues.
>> This fix introduces tests that check the correct
On Fri, 22 Jan 2021 11:02:29 GMT, Robert Lichtenberger
wrote:
>> While trying to come up with a good documentation I've detected a real
>> change in behaviour in connection with the NodeOrientation of the anchor
>> node.
>> Although this has never been documented, when
On Thu, 21 Jan 2021 23:07:23 GMT, Kevin Rushforth wrote:
>> By using the anchor location facility of PopupWindows we can avoid
>> miscalculation of the
>> menu's height entirely.
>> This fix also cleans up some documentation issues.
>> This fix introduces tests that check the correct
On Fri, 22 Jan 2021 10:08:51 GMT, Ambarish Rapte wrote:
> This particular issue JDK-8256283, is a specific case of IOOBE when, rootItem
> is not shown, some children including first child are selected, then all
> children are removed and sort() is invoked. The sort() fails with an IOOBE.
>
On Fri, 22 Jan 2021 12:01:55 GMT, Robert Lichtenberger
wrote:
>> Oh wow. Further experimentation has shown, that if
>> NodeOrientation.RIGHT_TO_LEFT is used on the anchor, then Side.LEFT used to
>> make the menu appear on the **right** hand side and Side.RIGHT used to make
>> the menu appear
On Fri, 22 Jan 2021 12:02:13 GMT, Robert Lichtenberger
wrote:
>> By using the anchor location facility of PopupWindows we can avoid
>> miscalculation of the
>> menu's height entirely.
>> This fix also cleans up some documentation issues.
>> This fix introduces tests that check the correct
On Wed, 20 Jan 2021 08:46:13 GMT, John Hendrikx wrote:
>> @hjohn Per [this
>> message](https://mail.openjdk.java.net/pipermail/openjfx-dev/2020-September/027534.html)
>> on the openjfx-dev mailing list, I have filed a new JBS issue for this PR
>> to use. Please change the title to:
>>
>>
On Fri, 17 Apr 2020 08:06:23 GMT, John Hendrikx wrote:
> This is a PoC for performance testing.
>
> It contains commented out code in PopupWindow and ProgressIndicatorSkin and
> two tests are failing because of that.
>
> This code avoids registering two listeners (on Scene and on Window)
13 matches
Mail list logo
