Integrated: 8244075: Accelerator of ContextMenu's MenuItem is not removed when ContextMenu is removed from Scene

2021-06-11 Thread Ambarish Rapte
On Mon, 24 May 2021 11:07:12 GMT, Ambarish Rapte wrote: > Issue: > There are several issues related to Accelerator of MenuItem of a ConextMenu > set on Control. > 1. Accelerator of ContextMenu's MenuItem is not removed when ContextMenu is > removed from Scene > 2. Accelerator is not updated

Re: RFR: 8196065: ListChangeListener getRemoved() returns items that were not removed. [v9]

2021-06-11 Thread Michael Strauß
On Fri, 11 Jun 2021 20:26:24 GMT, Michael Strauß wrote: >> The documentation for `ObservableListBase.nextRemove` states that a single >> change always refers to the current state of the list, which likely means >> that multiple disjoint removed ranges need to be applied in order, otherwise >>

RFR: 8268219: Investigate gstmpegaudioparse PTS issue

2021-06-11 Thread Alexander Matveev
- Reverted JDK-8268152 fix in gstbaseparse.c, since it is no longer needed. - Our hlsprogressbuffer outputs buffers in time format, but without any PTS. After GStreamer update mpregparser no longer tries to figure out timestamps if stream in time format and it will assume that upstream provides

Re: RFR: 8196065: ListChangeListener getRemoved() returns items that were not removed. [v9]

2021-06-11 Thread Michael Strauß
> The documentation for `ObservableListBase.nextRemove` states that a single > change always refers to the current state of the list, which likely means > that multiple disjoint removed ranges need to be applied in order, otherwise > the next change's `getFrom` doesn't refer to the correct

Re: RFR: 8255015: Inconsistent illumination of 3D shape by PointLight

2021-06-11 Thread Kevin Rushforth
On Wed, 9 Jun 2021 18:22:31 GMT, Andreas Heger wrote: > The inconsistent illumination happens on Macs with retina displays only if > the 3D shape is placed in a SubScene. The light sources are located with > wrong coordinates in sub scenes and this causes a different illumination. The >

Re: RFR: 8234920: Add SpotLight to the selection of 3D light types [v22]

2021-06-11 Thread Kevin Rushforth
On Fri, 11 Jun 2021 01:30:27 GMT, Nir Lisker wrote: >> Added a SpotLight only to the D3D pipeline currently. >> >> ### API discussion points >> >> - [X] Added `SpotLight` as a subclass of `LightBase`. However, it could >> also be a subclass of `PointLight` as it's a point light with

Re: RFR: 8196065: ListChangeListener getRemoved() returns items that were not removed. [v8]

2021-06-11 Thread Ambarish Rapte
On Sat, 29 May 2021 12:31:33 GMT, Michael Strauß wrote: >> The documentation for `ObservableListBase.nextRemove` states that a single >> change always refers to the current state of the list, which likely means >> that multiple disjoint removed ranges need to be applied in order, otherwise >>

Re: RFR: 8234920: Add SpotLight to the selection of 3D light types [v15]

2021-06-11 Thread Ambarish Rapte
On Tue, 25 May 2021 09:36:55 GMT, Ambarish Rapte wrote: >> Nir Lisker has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update documentation > > Hello Nir, could you please merge this branch with latest master. > I think so too. Did you