Re: Proposal: Migrate official jfx repo to GitHub + Skara tooling

2019-09-12 Thread Kevin Rushforth
Hearing no objection, we plan to switch the official jfx repo from the 
existing HG openjfx/jfx-dev/rt [1] repo to the GIT openjdk/jfx [2] repo 
hosted on GitHub on Thursday, September 26, two weeks from today. By way 
of disclaimer, please be aware that the JEP for moving the JDK repos to 
GIT [3] is not yet completed, nor has the follow-on JEP to specify the 
hosting provider for the JDK repos been filed. As such, this should be 
considered "early access", although I don't anticipate further changes.


Here is an overview of the transition timeline. More details, including 
actions that OpenJFX Contributors need to take, will be communicated 
after next week's Oracle Code One.


Now through Tuesday, September 24
* Follow the existing procedures for code reviews: either use a PR 
against the javafxports/openjdk-jfx [4] sandbox repo on GitHub or a 
webrev posted at cr.openjdk.java.net [5] -- in either case send an RFR email
* Approved fixes will continue to be pushed to the HG openjfx/jfx-dev/rt 
repo by a Committer


Wednesday, September 25
* The HG openjfx/jfx-dev/rt repo will be made read-only (exact time tbd, 
probably around noon Pacific time)
* The javafxports/openjdk-jfx sandbox repo will be "retired" at this 
time. Developers will be responsible for migrating open pull requests to 
openjdk/jfx (I will send out instructions to make this as easy as possible).


Thursday, September 26
* The Skara team will turn off the mirroring of HG openjfx/jfx-dev/rt 
--> GIT openjdk/jfx

* I will push a commit to enable jcheck to the openjdk/jfx repo on GitHub
* The Skara team will enable the Skara tooling
* I will send an announcement that openjdk/jfx is open for pull requests 
on GitHub


Please let me know if there are any questions about the transition.

-- Kevin

[1] https://hg.openjdk.java.net/openjfx/jfx-dev/rt
[2] https://github.com/openjdk/jfx
[3] https://openjdk.java.net/jeps/357
[4] https://github.com/javafxports/openjdk-jfx
[5] https://cr.openjdk.java.net/


On 8/20/2019 3:14 PM, Kevin Rushforth wrote:

To: OpenJFX Contributors,

As most of you are aware, Project Skara is moving forward with a 
proposed JEP [1] to migrate various OpenJDK projects to git, likely 
hosted on GitHub. A read-only git mirror of the HG openjfx/jfx-dev/rt 
repo [2] is available on GitHub at openjdk/jfx [3]. Similarly, there 
is a read-only mirror of the jdk/jdk repo [4] as well.


We've been talking with the Skara team about having OpenJFX be one of 
the "early adopters" in the git transition. Since a large percentage 
of the JavaFX code reviews are already happening on GitHub as pull 
requests against the javafxports/openjdk-jfx (sandbox) mirror, the 
OpenJFX project would be a natural fit for this.


For contributors who are not Committers, there won't be many 
differences, other than some of the steps will go away (e.g., the 
Skara tooling will automate the RFR email). For Committers, there will 
be some minor differences, primarily around eliminating steps -- no 
more need to merge the pull request into "develop", export the patch, 
import it into a Mercurial repo, and push it to the official HG repo. 
Instead, you will use the "/integrate" command as a PR comment to 
merge the pull request, and then you are done. You will still need to 
update JBS, at least initially, to resolve the bug as fixed and add 
the URL to the commit, but even that will be automated at some point.


Developers who are interested in leaning more about the Skara tools 
and workflow can find information on the Skara Wiki [5], GitHub 
project [6], and mailing list [7]. I note that using the Skara 
client-side tools on your desktop is completely optional. I expect 
many (most?) developers will use the GitHub workflow they are already 
used to via the web interface, but there is an option for those who 
want to use the command line tools like "git pr".


As a final note, I recommend waiting to create a personal fork of the 
openjdk/jfx mirror, since the Skara team is going to re-convert all 
openjdk/* mirrors in a couple days [8], and you will just end up 
having to delete and refork.


Comments on this proposal are welcome.

-- Kevin

[1] https://openjdk.java.net/jeps/357
[2] http://hg.openjdk.java.net/openjfx/jfx-dev/rt
[3] https://github.com/openjdk/jfx
[4] https://github.com/openjdk/jdk
[5] https://wiki.openjdk.java.net/display/skara
[6] https://github.com/openjdk/skara
[7] https://mail.openjdk.java.net/mailman/listinfo/skara-dev
[8] 
https://mail.openjdk.java.net/pipermail/skara-dev/2019-August/000327.html






Re: Proposal: Migrate official jfx repo to GitHub + Skara tooling

2019-08-21 Thread Robert Lichtenberger
Am 21.08.19 um 00:14 schrieb Kevin Rushforth:
> Comments on this proposal are welcome.

Best news I've had this week ;-). I appreciate and support this
proposal, it will make contributing much easier, especially for people
like me who contribute only occasionally.






Re: Proposal: Migrate official jfx repo to GitHub + Skara tooling

2019-08-20 Thread Michael Paus

Hi

Am 21.08.19 um 00:14 schrieb Kevin Rushforth:
I expect many (most?) developers will use the GitHub workflow they are 
already used to via the web interface, but there is an option for 
those who want to use the command line tools like "git pr". 


I just wanted to add that there is even a third option which is 
GitHub-Desktop.


https://desktop.github.com/

A standalone application from GitHub which simplifies some of the work.

(A pitty it is written in Electron and not in JavaFX ;-))

Michael



Proposal: Migrate official jfx repo to GitHub + Skara tooling

2019-08-20 Thread Kevin Rushforth

To: OpenJFX Contributors,

As most of you are aware, Project Skara is moving forward with a 
proposed JEP [1] to migrate various OpenJDK projects to git, likely 
hosted on GitHub. A read-only git mirror of the HG openjfx/jfx-dev/rt 
repo [2] is available on GitHub at openjdk/jfx [3]. Similarly, there is 
a read-only mirror of the jdk/jdk repo [4] as well.


We've been talking with the Skara team about having OpenJFX be one of 
the "early adopters" in the git transition. Since a large percentage of 
the JavaFX code reviews are already happening on GitHub as pull requests 
against the javafxports/openjdk-jfx (sandbox) mirror, the OpenJFX 
project would be a natural fit for this.


For contributors who are not Committers, there won't be many 
differences, other than some of the steps will go away (e.g., the Skara 
tooling will automate the RFR email). For Committers, there will be some 
minor differences, primarily around eliminating steps -- no more need to 
merge the pull request into "develop", export the patch, import it into 
a Mercurial repo, and push it to the official HG repo. Instead, you will 
use the "/integrate" command as a PR comment to merge the pull request, 
and then you are done. You will still need to update JBS, at least 
initially, to resolve the bug as fixed and add the URL to the commit, 
but even that will be automated at some point.


Developers who are interested in leaning more about the Skara tools and 
workflow can find information on the Skara Wiki [5], GitHub project [6], 
and mailing list [7]. I note that using the Skara client-side tools on 
your desktop is completely optional. I expect many (most?) developers 
will use the GitHub workflow they are already used to via the web 
interface, but there is an option for those who want to use the command 
line tools like "git pr".


As a final note, I recommend waiting to create a personal fork of the 
openjdk/jfx mirror, since the Skara team is going to re-convert all 
openjdk/* mirrors in a couple days [8], and you will just end up having 
to delete and refork.


Comments on this proposal are welcome.

-- Kevin

[1] https://openjdk.java.net/jeps/357
[2] http://hg.openjdk.java.net/openjfx/jfx-dev/rt
[3] https://github.com/openjdk/jfx
[4] https://github.com/openjdk/jdk
[5] https://wiki.openjdk.java.net/display/skara
[6] https://github.com/openjdk/skara
[7] https://mail.openjdk.java.net/mailman/listinfo/skara-dev
[8] 
https://mail.openjdk.java.net/pipermail/skara-dev/2019-August/000327.html