http://cr.openjdk.java.net/~psadhukhan/fxswinterop/webrev.9/
with sorting and whitespace fixed, hopefully.
Regards
Prasanta
On 7/13/2018 9:16 PM, Kevin Rushforth wrote:
Hi Prasanta,
> I had done "gradle checkrepo" followed by "checkWhiteSpace -F" to
get rid of whitespace problem.
It looks
Hi Prasanta,
> I had done "gradle checkrepo" followed by "checkWhiteSpace -F" to get
rid of whitespace problem.
It looks like you either didn't refresh your patch, or you subsequently
introduced additional white space problems. Here is the output of
applying your .8 patch and running
Hi Kevin,Ambarish,
Please find modified webrev taking care of review comments.
http://cr.openjdk.java.net/~psadhukhan/fxswinterop/webrev.8/
I had done "gradle checkrepo" followed by "checkWhiteSpace -F" to get
rid of whitespace problem.
Regards
Prasanta
On 7/13/2018 5:29 AM, Kevin Rushforth
Hi Prasanta,
I confirm that the test failures are gone now. I need to do some final
testing (e.g., a clean build using both JDK 11 and JDK 10 on all three
platforms). I also want a second look at a couple of the implementation
files, but overall it's close I think. Here are my review comments
Hi Kevin,
Please find modified webrev fixing the other test failures by modifying
the overrideNativeWindowHandle JNI method
http://cr.openjdk.java.net/~psadhukhan/fxswinterop/webrev.7/
Regards
Prasanta
On 7/10/2018 3:58 PM, Prasanta Sadhukhan wrote:
Hi Kevin,
Please find modified webrev
Hi Kevin,
Please find modified webrev with some more refactoring to move more
common code to SwingNode
and also this solves SwingNodeMemoryLeakTest failure
http://cr.openjdk.java.net/~psadhukhan/fxswinterop/webrev.6/
Regards
Prasanta
On 7/10/2018 7:13 AM, Kevin Rushforth wrote:
Hi Prasanta,
Hi Prasanta,
The public API looks fine now. I sent you an offline note about one of
the test failures (SwingNodeMemoryLeakTest).
There are still whitespace problems that will cause a failure in 'gradle
checkrepo' (and 'hg jcheck').
I'll do a more thorough review in the next day or so.
--
Hi Kevin,
Modified webrev to address the "public" leakage
http://cr.openjdk.java.net/~psadhukhan/fxswinterop/webrev.5/
I am looking into the test failures.
Regards
Prasanta
On 7/7/2018 4:30 AM, Kevin Rushforth wrote:
Most things are working with either mode (JDK 10 with qualified
exports or
Most things are working with either mode (JDK 10 with qualified exports
or JDK 11 without), although I do get a few test failures.
There is a serious issue with leakage into the public API that needs to
be addressed before worrying about the failures, but I'll list the test
failures at the
Thanks.
As a note to reviewers, if you want to test the new functionality, and
be able to run JavaFX swing interop applications without adding
qualified exports, you will need to use a recent OpenJDK 11 ea build as
the boot JDK. If you use OpenJDK 10, it will work no better (and
hopefully no
My Bad. Please find modified webrev restoring the filter
http://cr.openjdk.java.net/~psadhukhan/fxswinterop/webrev.4/
Regards
Prasanta
On 7/6/2018 6:47 AM, Kevin Rushforth wrote:
One quick comment:
This no longer compiles with OpenJDK10. It looks like the logic to
optionally filter out
One quick comment:
This no longer compiles with OpenJDK10. It looks like the logic to
optionally filter out jdk.unsupported.desktop from javafx.swing's
module-info.java got lost between the .2 and .3 versions.
-- Kevin
On 7/4/2018 4:35 AM, Prasanta Sadhukhan wrote:
Hi All,
Please review
12 matches
Mail list logo
