On Tue, 14 Jan 2020 14:55:31 GMT, Robert Lichtenberger
wrote:
>> Oh, I see the problem. In addition to rebasing you need to exclude any
>> commits that are from the `master` branch and are not your. So what you
>> really need to do is:
>>
>> git rebase -i upstream/jfx14
>>
>> git push --forc
On Tue, 14 Jan 2020 14:43:03 GMT, Kevin Rushforth wrote:
>> Partially reviewed, Need to re-check after the change of branch.
>
> Oh, I see the problem. In addition to rebasing you need to exclude any
> commits that are from the `master` branch and are not your. So what you
> really need to do
On Tue, 14 Jan 2020 14:13:45 GMT, Guru Hb wrote:
>> The pull request has been updated with a new target base due to a merge or a
>> rebase. The incremental webrev excludes the unrelated changes brought in by
>> the merge/rebase.
>
> Partially reviewed, Need to re-check after the change of bran
On Tue, 14 Jan 2020 14:00:08 GMT, Kevin Rushforth wrote:
>> I've rebased my branch like this:
>> git fetch upstream
>> git rebase upstream/jfx14
>> git pull
>> git push
>> and changed the base branch of this PR to jfx14. Hope that was the correct
>> way to do this ;-).
>
> Your branch still has
On Tue, 14 Jan 2020 14:13:54 GMT, Robert Lichtenberger
wrote:
>> As documented in JDK-8236912, WebView did not check whether the idMap really
>> contained a mapping for the given button, making it prone to errors, when
>> things are extended (as has happened here).
>>
>> The fix consists of t
> As documented in JDK-8236912, WebView did not check whether the idMap really
> contained a mapping for the given button, making it prone to errors, when
> things are extended (as has happened here).
>
> The fix consists of two test cases that show the problem in unfixed WebViews
> and a fix w
On Tue, 14 Jan 2020 12:56:32 GMT, Robert Lichtenberger
wrote:
>> NOTE that this PR is not yet ready for integration. In addition to needing
>> one more reviewer (me), there is the open question of which branch it should
>> be targeted to.
>>
>> @effad I think that this should go into openjfx1
On Tue, 14 Jan 2020 12:40:16 GMT, Kevin Rushforth wrote:
>> @effad - The extra commits and merge are no problem, provided that you want
>> to get this into openjfx15.
>>
>> However, if you intend to get this into openjfx14, as currently targeted in
>> JBS, then you will need to:
>>
>> 1. Reba
