Re: RFR: 8090547: Allow for transparent backgrounds in WebView [v6]

2021-09-10 Thread Jose Pereda
On Mon, 6 Sep 2021 13:30:46 GMT, Kevin Rushforth wrote: >> Jose Pereda has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Use color to int32 converter instead of hash > >> The other option, as you mention, is finding out if the 32-bit int

Re: RFR: 8090547: Allow for transparent backgrounds in WebView [v6]

2021-09-08 Thread Kevin Rushforth
On Mon, 6 Sep 2021 09:28:20 GMT, Jose Pereda wrote: >> modules/javafx.web/src/main/java/com/sun/webkit/WebPage.java line 97: >> >>> 95: >>> 96: private int fontSmoothingType; >>> 97: private Color backgroundColor = Color.WHITE; >> >> This might be a problem, since there are code paths

Re: RFR: 8090547: Allow for transparent backgrounds in WebView [v6]

2021-09-06 Thread Jose Pereda
On Mon, 6 Sep 2021 13:30:46 GMT, Kevin Rushforth wrote: >> Jose Pereda has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Use color to int32 converter instead of hash > >> The other option, as you mention, is finding out if the 32-bit int

Re: RFR: 8090547: Allow for transparent backgrounds in WebView [v6]

2021-09-06 Thread Kevin Rushforth
On Fri, 27 Aug 2021 17:01:00 GMT, Jose Pereda wrote: >> Currently, `WebPage` has already a public `setBackgroundColor()` method, but >> the class is not public. Therefore, public API is needed in `WebView` to >> allow developers access to it. >> >> In line with the `fontSmoothingType`

Re: RFR: 8090547: Allow for transparent backgrounds in WebView [v6]

2021-09-06 Thread Michael Paus
On Fri, 27 Aug 2021 17:01:00 GMT, Jose Pereda wrote: >> Currently, `WebPage` has already a public `setBackgroundColor()` method, but >> the class is not public. Therefore, public API is needed in `WebView` to >> allow developers access to it. >> >> In line with the `fontSmoothingType`

Re: RFR: 8090547: Allow for transparent backgrounds in WebView [v6]

2021-09-06 Thread Jose Pereda
On Fri, 3 Sep 2021 21:19:09 GMT, Kevin Rushforth wrote: >> Jose Pereda has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Use color to int32 converter instead of hash > > modules/javafx.web/src/main/java/com/sun/webkit/WebPage.java line

Re: RFR: 8090547: Allow for transparent backgrounds in WebView [v6]

2021-09-03 Thread Kevin Rushforth
On Fri, 27 Aug 2021 17:01:00 GMT, Jose Pereda wrote: >> Currently, `WebPage` has already a public `setBackgroundColor()` method, but >> the class is not public. Therefore, public API is needed in `WebView` to >> allow developers access to it. >> >> In line with the `fontSmoothingType`

Re: RFR: 8090547: Allow for transparent backgrounds in WebView [v6]

2021-08-27 Thread Jose Pereda
> Currently, `WebPage` has already a public `setBackgroundColor()` method, but > the class is not public. Therefore, public API is needed in `WebView` to > allow developers access to it. > > In line with the `fontSmoothingType` property, this PR provides public > support for setting the