On Tue, 26 Nov 2019 18:40:10 GMT, Scott Palmer wrote:
> On Thu, 7 Nov 2019 14:56:58 GMT, Kevin Rushforth wrote:
>
>> On Wed, 6 Nov 2019 19:11:48 GMT, Scott Palmer wrote:
>>
>>> Added tabSize property to Text and TextFlow and -fx-tab-size CSS attribute
>>> to both. TextFlow's tab size overri
On Thu, 7 Nov 2019 14:56:58 GMT, Kevin Rushforth wrote:
> On Wed, 6 Nov 2019 19:11:48 GMT, Scott Palmer wrote:
>
>> Added tabSize property to Text and TextFlow and -fx-tab-size CSS attribute
>> to both. TextFlow's tab size overrides that of contained Text nodes.
>>
>>
>>
>>
Yes, I suppose this should behave like anything else that uses an
IntegerProperty as far as bindings are concerned. I'll wait for further
review before reverting that last change. If tabSize=0 worked reasonably it
would be much simpler. I'm not sure if I will have the time to hunt down
why things
On Wed, 6 Nov 2019 19:11:48 GMT, Scott Palmer wrote:
> Added tabSize property to Text and TextFlow and -fx-tab-size CSS attribute to
> both. TextFlow's tab size overrides that of contained Text nodes.
>
>
>
> Commits:
> - 68d221c7: 8130738: TextFlow's tab width is static
>
setValue(null) is interpreted as set(0) by IntegerProperty. This in turn will
be clamped to 1 by the TextLayout. The property on the Text node will still
read as 0.
So now that you mention it, I don’t like where the clamping is implemented. I
should clamp so it reads back as 1 - Fixed.
Scott
What happens if you do text.tabSizeProperty().setValue(null) ?
> -Original Message-
> From: openjfx-dev On Behalf Of
> Scott Palmer
> Sent: Wednesday, November 6, 2019 11:12 AM
> To: openjfx-dev@openjdk.java.net
> Subject: RFR: 8130738: TextFlow's tab width is static
>
> Added tabSize p
