Re: RFR: 8257512: Remove use of deprecated primitive constructors in JavaFX [v3]

2021-03-11 Thread Ambarish Rapte
On Thu, 11 Mar 2021 15:07:49 GMT, Nir Lisker wrote: >> The array is of type Object. When LHS is Object then autobox chooses a >> suitable type by itself. >> So here, if we autobox then the values get autoboxed to `Integer`. We do not >> intend to change the test behavior as part of this fix so

Re: RFR: 8257512: Remove use of deprecated primitive constructors in JavaFX [v3]

2021-03-11 Thread Ambarish Rapte
On Thu, 11 Mar 2021 15:18:51 GMT, Nir Lisker wrote: >> modules/javafx.graphics/src/main/java/com/sun/prism/j2d/J2DPipeline.java >> line 64: >> >>> 62: @Override >>> 63: public ResourceFactory getResourceFactory(Screen screen) { >>> 64: Integer index =

Re: RFR: 8257512: Remove use of deprecated primitive constructors in JavaFX [v3]

2021-03-11 Thread Nir Lisker
On Thu, 11 Mar 2021 07:34:29 GMT, Ambarish Rapte wrote: >> modules/javafx.graphics/src/main/java/com/sun/prism/es2/X11GLFactory.java >> line 171: >> >>> 169: deviceDetails.put("XVisualID", >>> Long.valueOf(nGetVisualID(nativeCtxInfo))); >>> 170: deviceDetails.put("XDisplay",

Re: RFR: 8257512: Remove use of deprecated primitive constructors in JavaFX [v3]

2021-03-11 Thread Nir Lisker
On Thu, 11 Mar 2021 00:31:10 GMT, Nir Lisker wrote: >> Ambarish Rapte has updated the pull request incrementally with one >> additional commit since the last revision: >> >> correct Float.valueOf() > > modules/javafx.graphics/src/main/java/com/sun/prism/j2d/J2DPipeline.java line > 64: > >>

Re: RFR: 8257512: Remove use of deprecated primitive constructors in JavaFX [v3]

2021-03-11 Thread Nir Lisker
On Thu, 11 Mar 2021 06:01:04 GMT, Ambarish Rapte wrote: >> apps/samples/Ensemble8/src/samples/java/ensemble/samples/language/swing/SampleTableModel.java >> line 54: >> >>> 52: {Double.valueOf(567), Double.valueOf(956), >>> Double.valueOf(1154)}, >>> 53: {Double.valueOf(1292),

Re: RFR: 8257512: Remove use of deprecated primitive constructors in JavaFX [v3]

2021-03-11 Thread Kevin Rushforth
On Thu, 11 Mar 2021 05:47:31 GMT, Ambarish Rapte wrote: >> modules/javafx.web/src/ios/java/javafx/scene/web/JSONDecoder.java line 101: >> >>> 99: long val = Long.parseLong(sNum); >>> 100: if ((val <= Integer.MAX_VALUE) && (Integer.MIN_VALUE <= >>> val)) { >>> 101:

Re: RFR: 8257512: Remove use of deprecated primitive constructors in JavaFX [v3]

2021-03-10 Thread Ambarish Rapte
On Thu, 11 Mar 2021 00:29:41 GMT, Nir Lisker wrote: >> Ambarish Rapte has updated the pull request incrementally with one >> additional commit since the last revision: >> >> correct Float.valueOf() > > modules/javafx.graphics/src/main/java/com/sun/prism/es2/X11GLFactory.java > line 171: >

Re: RFR: 8257512: Remove use of deprecated primitive constructors in JavaFX [v3]

2021-03-10 Thread Ambarish Rapte
On Wed, 10 Mar 2021 23:59:05 GMT, Nir Lisker wrote: >> Ambarish Rapte has updated the pull request incrementally with one >> additional commit since the last revision: >> >> correct Float.valueOf() > > apps/toys/LayoutDemo/src/layout/CustomPane.java line 92: > >> 90:

Re: RFR: 8257512: Remove use of deprecated primitive constructors in JavaFX [v3]

2021-03-10 Thread Ambarish Rapte
On Thu, 11 Mar 2021 00:18:17 GMT, Nir Lisker wrote: >> Ambarish Rapte has updated the pull request incrementally with one >> additional commit since the last revision: >> >> correct Float.valueOf() > > modules/javafx.base/src/test/java/test/javafx/util/DurationTest.java line 289: > >> 287:

Re: RFR: 8257512: Remove use of deprecated primitive constructors in JavaFX [v3]

2021-03-10 Thread Ambarish Rapte
On Thu, 11 Mar 2021 00:23:48 GMT, Nir Lisker wrote: >> Ambarish Rapte has updated the pull request incrementally with one >> additional commit since the last revision: >> >> correct Float.valueOf() > > modules/javafx.controls/src/test/java/test/javafx/scene/chart/XYChartTest.java > line 85:

Re: RFR: 8257512: Remove use of deprecated primitive constructors in JavaFX [v3]

2021-03-10 Thread Ambarish Rapte
On Thu, 11 Mar 2021 00:12:25 GMT, Nir Lisker wrote: >> Ambarish Rapte has updated the pull request incrementally with one >> additional commit since the last revision: >> >> correct Float.valueOf() > > modules/javafx.base/src/test/java/test/com/sun/javafx/collections/MappingChangeTest.java >

Re: RFR: 8257512: Remove use of deprecated primitive constructors in JavaFX [v3]

2021-03-10 Thread Ambarish Rapte
On Thu, 11 Mar 2021 00:26:38 GMT, Nir Lisker wrote: >> Ambarish Rapte has updated the pull request incrementally with one >> additional commit since the last revision: >> >> correct Float.valueOf() > > modules/javafx.controls/src/test/java/test/javafx/scene/control/ComboBoxTest.java > line

Re: RFR: 8257512: Remove use of deprecated primitive constructors in JavaFX [v3]

2021-03-10 Thread Ambarish Rapte
On Thu, 11 Mar 2021 00:41:48 GMT, Nir Lisker wrote: >> Ambarish Rapte has updated the pull request incrementally with one >> additional commit since the last revision: >> >> correct Float.valueOf() > > modules/javafx.web/src/ios/java/javafx/scene/web/JSONDecoder.java line 101: > >> 99:

Re: RFR: 8257512: Remove use of deprecated primitive constructors in JavaFX [v3]

2021-03-10 Thread Nir Lisker
On Wed, 10 Mar 2021 19:49:25 GMT, Ambarish Rapte wrote: >> The following primitive constructors were deprecated in JDK 9 and are >> deprecated for removal in JDK 16. >> >> java.lang.Byte >> java.lang.Short >> java.lang.Integer >> java.lang.Long >> java.lang.Float >> java.lang.Double >>

Re: RFR: 8257512: Remove use of deprecated primitive constructors in JavaFX [v3]

2021-03-10 Thread Kevin Rushforth
On Wed, 10 Mar 2021 19:49:25 GMT, Ambarish Rapte wrote: >> The following primitive constructors were deprecated in JDK 9 and are >> deprecated for removal in JDK 16. >> >> java.lang.Byte >> java.lang.Short >> java.lang.Integer >> java.lang.Long >> java.lang.Float >> java.lang.Double >>

Re: RFR: 8257512: Remove use of deprecated primitive constructors in JavaFX [v3]

2021-03-10 Thread Kevin Rushforth
On Wed, 10 Mar 2021 19:37:51 GMT, Kevin Rushforth wrote: >> Ambarish Rapte has updated the pull request incrementally with one >> additional commit since the last revision: >> >> correct Float.valueOf() > > Looks good with a couple problems (in code that we must not be building) > noted

Re: RFR: 8257512: Remove use of deprecated primitive constructors in JavaFX [v3]

2021-03-10 Thread Ambarish Rapte
> The following primitive constructors were deprecated in JDK 9 and are > deprecated for removal in JDK 16. > > java.lang.Byte > java.lang.Short > java.lang.Integer > java.lang.Long > java.lang.Float > java.lang.Double > java.lang.Character > java.lang.Boolean > > This change removes call to