Re: RFR: 8267554: Support loading stylesheets from data-URIs [v4]
On Wed, 23 Jun 2021 12:57:10 GMT, Kevin Rushforth wrote: > One thing I noticed is that the diffs don't exactly match what you pasted in > the CSR (looks like a copy/paste issue). The `Scene::setUserAgentStylesheet` > and `SubScene::setUserAgentStylesheet` methods each have three unchanged > lines that are marked with the `+` diff indicator. Can you double-check? I've fixed that, and also cleaned up the `` tags for the new paragraphs. - PR: https://git.openjdk.java.net/jfx/pull/536
Re: RFR: 8267554: Support loading stylesheets from data-URIs [v4]
On Tue, 22 Jun 2021 23:15:55 GMT, Michael Strauß wrote: >> This PR extends data URI support to allow stylesheets to be loaded from data >> URIs. > > Michael Strauß has updated the pull request incrementally with one additional > commit since the last revision: > > simplified branch in StyleManager.loadStylesheetUnPrivileged The API and spec changes look good. As I mentioned in a comment added to the CSR, it is ready to move to "Proposed". Once we are farther along in the code review, I'll formally review the CSR. One thing I noticed is that the diffs don't exactly match what you pasted in the CSR (looks like a copy/paste issue). The `Scene::setUserAgentStylesheet` and `SubScene::setUserAgentStylesheet` methods each have three unchanged lines that are marked with the `+` diff indicator. Can you double-check? I'll review the implementation next. - PR: https://git.openjdk.java.net/jfx/pull/536
Re: RFR: 8267554: Support loading stylesheets from data-URIs [v4]
> This PR extends data URI support to allow stylesheets to be loaded from data > URIs. Michael Strauß has updated the pull request incrementally with one additional commit since the last revision: simplified branch in StyleManager.loadStylesheetUnPrivileged - Changes: - all: https://git.openjdk.java.net/jfx/pull/536/files - new: https://git.openjdk.java.net/jfx/pull/536/files/39ff7583..7dfbc0cb Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jfx=536=03 - incr: https://webrevs.openjdk.java.net/?repo=jfx=536=02-03 Stats: 46 lines in 1 file changed: 15 ins; 24 del; 7 mod Patch: https://git.openjdk.java.net/jfx/pull/536.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/536/head:pull/536 PR: https://git.openjdk.java.net/jfx/pull/536
