Review: Disapprove
We're moving away from Python generated HTML, and using a JS system based on
Reveal.js. Come chat with tgc and myself in IRC.
--
https://code.launchpad.net/~sam92/openlp/bug-1695620/+merge/325043
Your team OpenLP Core is subscribed to branch lp:openlp.
Review: Needs Fixing
Just some minor things.
Also, I really would prefer to see 1 new test, not just updates to tests.
Diff comments:
>
> === modified file 'openlp/plugins/bibles/lib/mediaitem.py'
> --- openlp/plugins/bibles/lib/mediaitem.py2017-05-07 18:39:17 +
> +++
Azaziah has proposed merging
lp:~suutari-olli/openlp/azaziah-fixes-and-improvements into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
Related bugs:
Bug #1639860 in OpenLP: "Close button is disabled in numerous windows"
https://bugs.launchpad.net/openlp/+bug/1639860
Bug
The proposal to merge lp:~suutari-olli/openlp/azaziah-fixes-and-improvements
into lp:openlp has been updated.
Status: Needs review => Superseded
For more details, see:
https://code.launchpad.net/~suutari-olli/openlp/azaziah-fixes-and-improvements/+merge/325049
--
Your team OpenLP Core is
Azaziah has proposed merging
lp:~suutari-olli/openlp/azaziah-fixes-and-improvements into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
Related bugs:
Bug #1639860 in OpenLP: "Close button is disabled in numerous windows"
https://bugs.launchpad.net/openlp/+bug/1639860
Bug
The proposal to merge lp:~suutari-olli/openlp/azaziah-fixes-and-improvements
into lp:openlp has been updated.
Status: Work in progress => Superseded
For more details, see:
https://code.launchpad.net/~suutari-olli/openlp/azaziah-fixes-and-improvements/+merge/325041
--
Your team OpenLP Core
** Changed in: openlp
Status: New => In Progress
** Changed in: openlp
Assignee: (unassigned) => Azaziah (suutari-olli)
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1652559
Title:
** Changed in: openlp
Status: New => In Progress
** Changed in: openlp
Assignee: (unassigned) => Azaziah (suutari-olli)
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1666272
Title:
** Changed in: openlp
Status: New => In Progress
** Changed in: openlp
Assignee: (unassigned) => Azaziah (suutari-olli)
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1639860
Title:
** Changed in: openlp
Status: New => In Progress
** Changed in: openlp
Assignee: (unassigned) => Azaziah (suutari-olli)
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1694732
Title:
** Changed in: openlp
Status: New => In Progress
** Changed in: openlp
Assignee: (unassigned) => Azaziah (suutari-olli)
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1678292
Title:
** Changed in: openlp
Status: Won't Fix => In Progress
** Changed in: openlp
Assignee: (unassigned) => Azaziah (suutari-olli)
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1695268
Title:
Once you've fixed up the issues, you'll need to resubmit the merge proposal
(link in the top right hand corner)
--
https://code.launchpad.net/~samothjtm/openlp/bug-1695587/+merge/325035
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Here, I've fixed your issues for you and written a test for you. Next time it's
on you.
=== modified file 'openlp/plugins/songs/lib/mediaitem.py'
--- openlp/plugins/songs/lib/mediaitem.py 2017-06-03 10:44:28 +
+++ openlp/plugins/songs/lib/mediaitem.py 2017-06-04 20:18:23 +
@@
Review: Needs Fixing
--
https://code.launchpad.net/~samothjtm/openlp/bug-1695587/+merge/325035
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
I've got a couple of comments below for you to take a look at.
Also, as previously noted, you need a code test before we'll accept your merge
proposal. I'm afraid that manual testing, while nice, does not constitute a
test for merging purposes.
Diff comments:
> === modified file
Review: Needs Fixing
You need to run CI on this to show the success of tests.
Not sure why but this request did a full download when I did a check out. Also
cannot run due to chord issues.
Cannot run this but there seem to be lots of line breaks in the footer display.
As the footer area is
I did a test search with 1629 songs in a Database taking aproximately 1 second
searching for "1" in Entire Song with my patch. It only seems to take this long
to load all the results into the GUI as searching for "11" takes only an
instant...
--
There are still some other tests failing not done by me - even after merging
the trunk with some test fixing
lp:~samothjtm/openlp/bug-1695587 (revision 2747)
[←[1;32mSUCCESS←[1;m] https://ci.openlp.io/job/Branch-01-Pull/2060/
[←[1;31mFAILURE←[1;m]
The actual code to search in "Entire Song" does only do a indirect
database call over the plugin manager to search for a match in either of
song.search_title, song.search_lyrics and song.comments. That's not
searching in all possible attributes but only in three (admittedly the
main ones).
I
** Branch linked: lp:~suutari-olli/openlp/azaziah-fixes-and-improvements
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1694732
Title:
wizard sub title does not wrap
Status in OpenLP:
New
Bug
I did some manual testing...
My new code is only using one database call - I can't find an example of how
and if at all any database calls are being tested. I'd need some help on
this... is there a test database with example data that I can just query to
proof my code working?
--
Samuel Mehrbrodt has proposed merging lp:~sam92/openlp/bug-1695620 into
lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
Related bugs:
Bug #1694430 in OpenLP: "Allow to show alternate title in footer"
https://bugs.launchpad.net/openlp/+bug/1694430
Bug #1695620 in OpenLP: "Make
** Branch linked: lp:~sam92/openlp/bug-1695620
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1694430
Title:
Allow to show alternate title in footer
Status in OpenLP:
New
Bug description:
Add
** Branch linked: lp:~sam92/openlp/bug-1695620
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1695620
Title:
Make footer elements customizable
Status in OpenLP:
New
Bug description:
This
** Changed in: openlp
Status: New => Fix Released
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1672230
Title:
"Volunteer" button link is broken
Status in OpenLP:
Fix Released
Bug
** Branch linked: lp:~suutari-olli/openlp/azaziah-fixes-and-improvements
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1666272
Title:
Linked audio "next" button results in traceback
Status in
** Summary changed:
- Close button on song editor disabled
+ Close button is disabled in numerous windows
** Branch linked: lp:~suutari-olli/openlp/azaziah-fixes-and-improvements
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
** Branch linked: lp:~suutari-olli/openlp/azaziah-fixes-and-improvements
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1652559
Title:
Find duplicates wizard does not reset cursor if closed from "x"
Has the right click menu functionality been removed from library items?
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1650358
Title:
Replace Live background item right click uses wrong icon
Status
** Branch linked: lp:~suutari-olli/openlp/azaziah-fixes-and-improvements
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1678292
Title:
Space after Bible book name auto-completion is missing
Status
Question #633038 on OpenLP changed:
https://answers.launchpad.net/openlp/+question/633038
Status: Needs information => Expired
Launchpad Janitor expired the question:
This question was expired because it remained in the 'Needs information'
state without activity for the last 15 days.
--
Question #633171 on OpenLP changed:
https://answers.launchpad.net/openlp/+question/633171
Status: Open => Expired
Launchpad Janitor expired the question:
This question was expired because it remained in the 'Open' state
without activity for the last 15 days.
--
You received this question
The proposal to merge lp:~phill-ridout/openlp/test-fixes into lp:openlp has
been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~phill-ridout/openlp/test-fixes/+merge/325039
--
Your team OpenLP Core is subscribed to branch lp:openlp.
Review: Approve
--
https://code.launchpad.net/~phill-ridout/openlp/test-fixes/+merge/325039
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Review: Needs Fixing
Hi Johannes,
Thank you for contributing to OpenLP!
To get your code merged you must create a test that proves it actually works.
Have a look at the wiki for inspiration:
https://wiki.openlp.org/Development:Unit_Tests
--
36 matches
Mail list logo
