Review: Needs Fixing
Ok, I'm happy with adding pymupdf, however, I've spoken to Tomas, and we think
it would be better if pymupdf was in the first if block and then it would take
precedence over the binary if pymupdf was installed.
Also, can you add a test please?
--
Review: Approve
Thanks
--
https://code.launchpad.net/~tomasgroth/openlp/portable-path/+merge/366785
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to :
Also tests failed!
--
https://code.launchpad.net/~tomasgroth/openlp/portable-path/+merge/366734
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Review: Needs Fixing
Sorry, a few nit picks...
Diff comments:
> === modified file 'openlp/core/app.py'
> --- openlp/core/app.py2019-03-28 21:03:32 +
> +++ openlp/core/app.py2019-04-30 19:47:11 +
> @@ -301,6 +302,8 @@
> help='Set logging to LEVEL
Review: Needs Information
So what you're saying is that if we merge this proposed code, we will need to
include the source code for MuPDF with OpenLP?
What advantage does this have over the current method?
--
https://code.launchpad.net/~bastian-germann/openlp/pymupdf/+merge/366749
Your team
Spoke to superfly last night Qt 5.12 is fine!
--
https://code.launchpad.net/~bastian-germann/openlp/depends/+merge/365421
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to :
Review: Needs Fixing
See inline comment about wrong minimum version of Qt
Diff comments:
>
> === modified file 'scripts/check_dependencies.py'
> --- scripts/check_dependencies.py 2019-02-14 15:09:09 +
> +++ scripts/check_dependencies.py 2019-04-02 00:15:48 +
> @@ -40,8 +40,8 @@
Hi, Could you attach a debug log?
https://manual.openlp.org/troubleshooting.html#mac-os-x
Start OpenLP as specified, repeat the steps to cause the error and
attach the log here please.
** Changed in: openlp
Assignee: (unassigned) => Phill (phill-ridout)
** Changed in: openlp
Sta
Couple of other small things
Diff comments:
>
> === added file 'openlp/core/ui/media/mediatab.py'
> --- openlp/core/ui/media/mediatab.py 1970-01-01 00:00:00 +
> +++ openlp/core/ui/media/mediatab.py 2019-03-27 19:21:41 +
> @@ -0,0 +1,147 @@
> +# -*- coding: utf-8 -*-
> +# vim:
Review: Needs Fixing
Sorry, that should have been a needs fixing!
Diff comments:
>
> === modified file 'openlp/core/ui/media/mediacontroller.py'
> --- openlp/core/ui/media/mediacontroller.py 2019-02-14 15:09:09 +
> +++ openlp/core/ui/media/mediacontroller.py 2019-03-27 19:21:41 +
>
Wont start on widnows 10
check_dependencies.py passes
Traceback (most recent call last):
File "C:/Users/sroom/Documents/Phill
Ridout/play_ground/openlp/media_state/run_openlp.py", line 71, in
start()
File "C:/Users/sroom/Documents/Phill
Ridout/play_ground/ope
Review: Approve
--
https://code.launchpad.net/~raoul-snyman/openlp/fix-macos-pdf-test/+merge/365153
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to :
** Changed in: openlp
Status: In Progress => Fix Committed
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1748719
Title:
deleting a bible causes a traceback
Status in OpenLP:
Fix Committed
** Changed in: openlp
Status: In Progress => Fix Committed
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1650910
Title:
Not Handling OSErrors
Status in OpenLP:
Fix Committed
Bug
** Changed in: openlp
Status: In Progress => Fix Committed
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1750447
Title:
Can't import webbible
Status in OpenLP:
Fix Committed
Bug
** Changed in: openlp
Status: In Progress => Fix Committed
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1819763
Title:
Option to scale logo picture used at startup
Status in OpenLP:
Fix
Phill has proposed merging lp:~phill-ridout/openlp/fixes-I into lp:openlp.
Commit message:
Fixes a few bugs, and some path lib refactors
Requested reviews:
Tim Bentley (trb143)
Related bugs:
Bug #1650910 in OpenLP: "Not Handling OSErrors"
https://bugs.launchpad.net/openlp/+b
The proposal to merge lp:~phill-ridout/openlp/fixes-I into lp:openlp has been
updated.
Status: Needs review => Superseded
For more details, see:
https://code.launchpad.net/~phill-ridout/openlp/fixes-I/+merge/364651
--
Your team OpenLP Core is subscribed to branch lp:ope
** Branch linked: lp:~trb143/openlp/svg
** Branch linked: lp:~trb143/openlp/fonts
** Changed in: openlp
Status: Confirmed => Fix Committed
** Changed in: openlp
Assignee: (unassigned) => Tim Bentley (trb143)
--
You received this bug notification because you are a member of OpenLP
This is would only be possible on certain OSes, as QScreen.model ,.make,
etc is not implemented for all OSes
** Changed in: openlp
Assignee: (unassigned) => Phill (phill-ridout)
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to Ope
** Changed in: openlp
Assignee: (unassigned) => Phill (phill-ridout)
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1717780
Title:
Automatic secondary display selection
Status in OpenLP:
** Changed in: openlp
Assignee: (unassigned) => Phill (phill-ridout)
** Changed in: openlp
Status: New => In Progress
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1730476
Title:
** Changed in: openlp
Assignee: (unassigned) => Phill (phill-ridout)
** Changed in: openlp
Status: New => In Progress
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1730475
Title:
** Changed in: openlp
Importance: Wishlist => Low
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1798651
Title:
Impress Presentation Console should be disabled by OpenLP
Status in OpenLP:
Phill has proposed merging lp:~phill-ridout/openlp/fixes-I into lp:openlp.
Commit message:
Fixes a few bugs, and some path lib refactors
Requested reviews:
OpenLP Core (openlp-core)
Related bugs:
Bug #1650910 in OpenLP: "Not Handling OSErrors"
https://bugs.launchpad.net/openlp/+b
The proposal to merge lp:~phill-ridout/openlp/fixes-I into lp:openlp has been
updated.
Status: Needs review => Superseded
For more details, see:
https://code.launchpad.net/~phill-ridout/openlp/fixes-I/+merge/364649
--
Your team OpenLP Core is requested to review the proposed merge of
Phill has proposed merging lp:~phill-ridout/openlp/fixes-I into lp:openlp.
Commit message:
Fixes a few bugs, and some path lib refactors
Requested reviews:
OpenLP Core (openlp-core)
Related bugs:
Bug #1650910 in OpenLP: "Not Handling OSErrors"
https://bugs.launchpad.net/openlp/+b
Can confirm on trunk with webengine
** Changed in: openlp
Status: New => Confirmed
** Changed in: openlp
Importance: Undecided => Medium
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
** Branch linked: lp:~phill-ridout/openlp/fixes-I
** Changed in: openlp
Status: New => In Progress
** Changed in: openlp
Importance: Undecided => Medium
** Changed in: openlp
Assignee: (unassigned) => Phill (phill-ridout)
--
You received this bug notification be
** Changed in: openlp
Assignee: (unassigned) => Phill (phill-ridout)
** Changed in: openlp
Importance: Undecided => Medium
** Changed in: openlp
Status: New => In Progress
--
You received this bug notification because you are a member of OpenLP
Core, which is s
Azaziah, what was the source of this CSV file?
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1624847
Title:
Invalid CSV import results in traceback
Status in OpenLP:
New
Bug description:
I
** Changed in: openlp
Assignee: (unassigned) => Phill (phill-ridout)
** Changed in: openlp
Importance: Undecided => Low
** Changed in: openlp
Status: New => In Progress
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed
** Changed in: openlp
Status: New => Opinion
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1582943
Title:
send to live shortcut for media manager no longer works under bibles
Status in
Works the same as songs in the latest development code. One caveat is
that the list has to have focus, ie you need to select an item first. In
the songs plugin results are not automatically selected after searching,
where in the bible plugin, the results are automatically selected (but
the list
** Changed in: openlp
Importance: Undecided => Low
** Changed in: openlp
Importance: Low => Medium
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1537609
Title:
Powerpoints do not unblank
** Changed in: openlp
Importance: Undecided => Low
** Changed in: openlp
Milestone: 2.9.1 => None
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1508582
Title:
Lock panels and hide projector
** Changed in: openlp
Milestone: 2.9.1 => None
** Changed in: openlp
Importance: Undecided => Medium
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1531691
Title:
Song is sent back to live
** Changed in: openlp
Status: New => Incomplete
** Changed in: openlp
Importance: Undecided => Medium
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1786601
Title:
Error while upgrading
Simon, I cannot replicate this. I don't suppose you can share an old
copy of the settings file could you? You can find backed up versions in
~/.local/share/openlp/{time/date}.config
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
Fixed in https://bazaar.launchpad.net/~openlp-
core/openlp/trunk/revision/2692
** Changed in: openlp
Status: New => Fix Committed
** Changed in: openlp
Assignee: (unassigned) => Phill (phill-ridout)
** Changed in: openlp
Importance: Undecided => Low
** Branch linked:
Fixed in https://bazaar.launchpad.net/~openlp-
core/openlp/trunk/revision/2692
** Changed in: openlp
Status: New => Fix Committed
** Changed in: openlp
Importance: Undecided => Low
** Changed in: openlp
Assignee: (unassigned) => Phill (phill-ridout)
** Branch linked:
** Changed in: openlp
Importance: Undecided => High
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1797121
Title:
Android app license violations
Status in OpenLP:
Confirmed
Status in OpenLP
** Branch linked: lp:~phill-ridout/openlp/fixes-mkII
** Changed in: openlp
Status: New => Fix Committed
** Changed in: openlp
Assignee: (unassigned) => Phill (phill-ridout)
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to
Phill has proposed merging lp:~phill-ridout/openlp/ftw-refactors into lp:openlp.
Commit message:
Add proxy settings to ftw. Option to skip sample data
Requested reviews:
Tomas Groth (tomasgroth)
Tim Bentley (trb143)
For more details, see:
https://code.launchpad.net/~phill-ridout/openlp/ftw
The proposal to merge lp:~phill-ridout/openlp/ftw-refactors into lp:openlp has
been updated.
Status: Needs review => Superseded
For more details, see:
https://code.launchpad.net/~phill-ridout/openlp/ftw-refactors/+merge/364209
--
Your team OpenLP Core is subscribed to branch lp:ope
** Changed in: openlp
Assignee: (unassigned) => Phill (phill-ridout)
** Changed in: openlp
Status: Confirmed => In Progress
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1080597
Phill has proposed merging lp:~phill-ridout/openlp/ftw-refactors into lp:openlp.
Commit message:
Add proxy settings to ftw. Option to skip sample data
Requested reviews:
Tomas Groth (tomasgroth)
Tim Bentley (trb143)
For more details, see:
https://code.launchpad.net/~phill-ridout/openlp/ftw
The proposal to merge lp:~phill-ridout/openlp/ftw-refactors into lp:openlp has
been updated.
Status: Needs review => Superseded
For more details, see:
https://code.launchpad.net/~phill-ridout/openlp/ftw-refactors/+merge/364186
--
Your team OpenLP Core is subscribed to branch lp:ope
Review: Approve
Looks good. Others may say a test is required ;-)
--
https://code.launchpad.net/~sam92/openlp/songbook-first-slide/+merge/363538
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list:
Review: Approve
--
https://code.launchpad.net/~alisonken1/openlp/pjlink2-u/+merge/364200
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Phill has proposed merging lp:~phill-ridout/openlp/ftw-refactors into lp:openlp.
Commit message:
Add proxy settings to ftw. Option to skip sample data
Requested reviews:
Tomas Groth (tomasgroth)
Tim Bentley (trb143)
For more details, see:
https://code.launchpad.net/~phill-ridout/openlp/ftw
The proposal to merge lp:~phill-ridout/openlp/ftw-refactors into lp:openlp has
been updated.
Status: Needs review => Superseded
For more details, see:
https://code.launchpad.net/~phill-ridout/openlp/ftw-refactors/+merge/364184
--
Your team OpenLP Core is subscribed to branch lp:ope
Phill has proposed merging lp:~phill-ridout/openlp/ftw-refactors into lp:openlp.
Commit message:
Add proxy settings to ftw. Option to skip sample data
Requested reviews:
Tomas Groth (tomasgroth)
For more details, see:
https://code.launchpad.net/~phill-ridout/openlp/ftw-refactors/+merge/364184
Phill has proposed merging lp:~phill-ridout/openlp/ftw-refactors into lp:openlp.
Commit message:
Add proxy settings to ftw. Option to skip sample data
Requested reviews:
Tomas Groth (tomasgroth)
For more details, see:
https://code.launchpad.net/~phill-ridout/openlp/ftw-refactors/+merge/364183
The proposal to merge lp:~phill-ridout/openlp/ftw-refactors into lp:openlp has
been updated.
Status: Needs review => Superseded
For more details, see:
https://code.launchpad.net/~phill-ridout/openlp/ftw-refactors/+merge/363751
--
Your team OpenLP Core is subscribed to branch lp:ope
Review: Needs Fixing
Few minor inlines.
Diff comments:
> === modified file 'openlp/core/projectors/manager.py'
> --- openlp/core/projectors/manager.py 2019-02-14 15:09:09 +
> +++ openlp/core/projectors/manager.py 2019-03-08 11:58:35 +
> @@ -505,7 +484,8 @@
> projector =
Review: Approve
--
https://code.launchpad.net/~tomasgroth/openlp/appveyor-pytest/+merge/364116
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Review: Approve
Looks good
--
https://code.launchpad.net/~tomasgroth/openlp/packaging-webengine/+merge/364054
Your team OpenLP Core is subscribed to branch lp:openlp/packaging.
___
Mailing list: https://launchpad.net/~openlp-core
Post to :
** Branch linked: lp:~phill-ridout/openlp/pathlib12
** Changed in: openlp
Status: Confirmed => In Progress
** Changed in: openlp
Assignee: (unassigned) => Phill (phill-ridout)
--
You received this bug notification because you are a member of OpenLP
Core, which is subs
Phill has proposed merging lp:~phill-ridout/openlp/ftw-refactors into lp:openlp.
Commit message:
Add proxy settings to ftw. Option to skip sample data
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~phill-ridout/openlp/ftw-refactors/+merge
The proposal to merge lp:~phill-ridout/openlp/ftw-refactors into lp:openlp has
been updated.
Status: Needs review => Superseded
For more details, see:
https://code.launchpad.net/~phill-ridout/openlp/ftw-refactors/+merge/363750
--
Your team OpenLP Core is requested to review the propo
Phill has proposed merging lp:~phill-ridout/openlp/ftw-refactors into lp:openlp.
Commit message:
Add proxy settings to ftw. Option to skip sample data
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~phill-ridout/openlp/ftw-refactors/+merge
The proposal to merge lp:~phill-ridout/openlp/ftw-refactors into lp:openlp has
been updated.
Status: Needs review => Superseded
For more details, see:
https://code.launchpad.net/~phill-ridout/openlp/ftw-refactors/+merge/363747
--
Your team OpenLP Core is requested to review the propo
Phill has proposed merging lp:~phill-ridout/openlp/ftw-refactors into lp:openlp.
Commit message:
Add proxy settings to ftw. Option to skip sample data
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~phill-ridout/openlp/ftw-refactors/+merge
Closing as ios 9 market share is negligible
** Changed in: openlp
Status: Confirmed => Won't Fix
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1503689
Title:
iOS9 browser zooms randomly at
Bug #1503689 status changed in OpenLP:
Confirmed => Won't Fix
https://bugs.launchpad.net/openlp/+bug/1503689
"iOS9 browser zooms randomly at stage-view update"
This bug is linked to #271659.
Stagemonitor and iOS9
https://answers.launchpad.net/openlp/+question/271659
--
You received this
Phill has proposed merging lp:~phill-ridout/openlp/ftw-json-theme-list into
lp:openlp.
Commit message:
move ftw to new json config format. spruce up theme list page
Requested reviews:
Raoul Snyman (raoul-snyman)
For more details, see:
https://code.launchpad.net/~phill-ridout/openlp/ftw-json
The proposal to merge lp:~phill-ridout/openlp/ftw-json-theme-list into
lp:openlp has been updated.
Status: Needs review => Superseded
For more details, see:
https://code.launchpad.net/~phill-ridout/openlp/ftw-json-theme-list/+merge/363282
--
Your team OpenLP Core is subscribed to bra
Review: Approve
--
https://code.launchpad.net/~danielborges93/openlp/website-2019-copyright/+merge/363247
Your team OpenLP Core is subscribed to branch lp:openlp/website.
___
Mailing list: https://launchpad.net/~openlp-core
Post to :
Review: Needs Information
See in lines.
Diff comments:
> === modified file 'builders/builder.py'
> --- builders/builder.py 2018-12-02 06:07:08 +
> +++ builders/builder.py 2019-02-16 21:23:26 +
> @@ -90,6 +90,7 @@
>
> Return text from stdout.
> """
> +
Phill has proposed merging lp:~phill-ridout/openlp/ftw-json-theme-list into
lp:openlp.
Commit message:
move ftw to new json config format. spruce up theme list page
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~phill-ridout/openlp/ftw-json
The proposal to merge lp:~phill-ridout/openlp/ftw-json-theme-list into
lp:openlp has been updated.
Status: Needs review => Superseded
For more details, see:
https://code.launchpad.net/~phill-ridout/openlp/ftw-json-theme-list/+merge/363275
--
Your team OpenLP Core is requested to rev
Phill has proposed merging lp:~phill-ridout/openlp/ftw-json-theme-list into
lp:openlp.
Commit message:
move ftw to new json config format. spruce up theme list page
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~phill-ridout/openlp/ftw-json
Phill has proposed merging lp:~phill-ridout/openlp/ftw-json into
lp:openlp/ftw-data.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~phill-ridout/openlp/ftw-json/+merge/362981
--
Your team OpenLP Core is requested to review the proposed merge
Phill has proposed merging lp:~phill-ridout/openlp/ftw-json into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~phill-ridout/openlp/ftw-json/+merge/362975
--
Your team OpenLP Core is requested to review the proposed merge of
lp
Review: Approve
--
https://code.launchpad.net/~trb143/openlp/media_state/+merge/361688
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
L7953: I'm not convinced the user will want to see a dialog box every time the
preview, go live, or edit a song that has audio
Could you comment this out for no, I'mo concerned that this would too easily be
overlooked. (Its only going to happen for people who try to load a song with
Review: Needs Information
I assume the commented out code is a work in progress?
L7027: if statement not needed
L7953: I'm not convinced the user will want to see a dialog box every time the
preview, go live, or edit a song that has audio
Also it looks like you've removed the background
Only got to line 1023, will take another look later, just a few minor issues
with doc strings (see inline comments)
Diff comments:
>
> === added file 'openlp/core/state.py'
> --- openlp/core/state.py 1970-01-01 00:00:00 +
> +++ openlp/core/state.py 2019-01-04 21:05:41 +
> @@
Hi Kyle,
Looks ok to me, but you need to resubmit the merge proposal. (Top right
'Resubmit proposal')
--
https://code.launchpad.net/~lambda-calculist/openlp/run_search/+merge/358137
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing
Public bug reported:
The thread termination code in
openlp/core/ui/mainwindow.py:_wait_for_threads is cumulative, meaning
that if lots of long running threads are running it could potentially
take a long time for OpenLP to shut down.
We should request that each worker stops and then give all
Public bug reported:
in openlp/core/ui/mainwindow.py method: _wait_for_threads the progress
dialog text is not translated
** Affects: openlp
Importance: Medium
Status: New
** Changed in: openlp
Importance: Undecided => Medium
--
You received this bug notification because you
Phill has proposed merging lp:~phill-ridout/openlp/bible_proxies into lp:openlp.
Commit message:
Migrate bibles to use the centeral proxy settings. Upgrade settings and bible
meta data accordingly.
Add this to your merge proposal
Review: Needs Information
I'm not sure about those patches that were changed (see in line) isn't patching
supposed to take place in the module they're imported in to?
Diff comments:
>
> === modified file 'tests/functional/openlp_plugins/bibles/test_csvimport.py'
> ---
** Branch linked: lp:~bkylerussell/openlp/documentation
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1738968
Title:
Manual - Dead link
Status in OpenLP:
In Progress
Bug description:
As
Review: Approve
Looks good. Well done
--
https://code.launchpad.net/~bkylerussell/openlp/documentation/+merge/353491
Your team OpenLP Core is subscribed to branch lp:openlp/documentation.
___
Mailing list: https://launchpad.net/~openlp-core
Post to
Hey,
I wrote the WoW importer, but unfortunately I no longer have access to WoW
anymore! Would you be able to send several songs without any of the mentioned
formatting, and then modify the songs to include the formatting. Do not change
anything else, do not edit the text in any way, just add
Review: Needs Fixing
--
https://code.launchpad.net/~phill-ridout/openlp/ftw-json/+merge/348037
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Hmm, something isn't quite right with this MR. Will have to look at it this eve!
--
https://code.launchpad.net/~phill-ridout/openlp/ftw-json/+merge/348037
Your team OpenLP Core is requested to review the proposed merge of
lp:~phill-ridout/openlp/ftw-json into lp:openlp
Phill has proposed merging lp:~phill-ridout/openlp/ftw-json into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~phill-ridout/openlp/ftw-json/+merge/348037
Use JSON for the config file. It allows tree structures, it easier and cleaner
Public bug reported:
In some cases the function `download_sha256` will return a tuple of values, in
others just False or None.
Whilst this isn't a bug in itself, in each case of the code that calls this
function, the return value is expected to be a tuple.
Phill has proposed merging lp:~phill-ridout/openlp/proxies into lp:openlp.
Commit message:
Implement a proxy configuration widget. This is just a start other tasks that
still need completing (to follow) are changing the web bibles over to use this,
and allow setting up of proxy from FTW (else
The proposal to merge lp:~phill-ridout/openlp/proxies into lp:openlp has been
updated.
Status: Needs review => Superseded
For more details, see:
https://code.launchpad.net/~phill-ridout/openlp/proxies/+merge/347720
--
Your team OpenLP Core is subscribed to branch lp:ope
Phill has proposed merging lp:~phill-ridout/openlp/proxies into lp:openlp.
Commit message:
Implement a proxy configuration widget. This is just a start other tasks that
still need completing (to follow) are changing the web bibles over to use this,
and allow setting up of proxy from FTW (else
The proposal to merge lp:~phill-ridout/openlp/proxies into lp:openlp has been
updated.
Status: Needs review => Superseded
For more details, see:
https://code.launchpad.net/~phill-ridout/openlp/proxies/+merge/347673
--
Your team OpenLP Core is subscribed to branch lp:ope
Review: Needs Fixing
Just noticed an issue in the diff. DO NOT MERGE until I've re subbed.
--
https://code.launchpad.net/~phill-ridout/openlp/proxies/+merge/347673
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https
Phill has proposed merging lp:~phill-ridout/openlp/proxies into lp:openlp.
Commit message:
Implement a proxy configuration widget. This is just a start other tasks that
still need completing (to follow) are changing the web bibles over to use this,
and allow setting up of proxy from FTW (else
** Changed in: openlp
Status: In Progress => Fix Committed
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1734432
Title:
Progress bar does not show whilst loading a service
Status in OpenLP:
Review: Approve
--
https://code.launchpad.net/~alisonken1/openlp/pjlink2-r/+merge/345965
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
** Branch unlinked: lp:~phill-ridout/openlp/bible-refactors-take2
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/917164
Title:
Bible importers - not localized language list
Status in OpenLP:
Fix
101 - 200 of 1843 matches
Mail list logo
