Re: [Openlp-core] [Merge] lp:~alisonken1/openlp/pjlink2-r into lp:openlp

2018-05-11 Thread Phill
Review: Approve Looks good -- https://code.launchpad.net/~alisonken1/openlp/pjlink2-r/+merge/345041 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to :

Re: [Openlp-core] [Merge] lp:~alisonken1/openlp/pjlink2-r into lp:openlp

2018-05-01 Thread Phill
Review: Needs Fixing Sorry, reviewed a previous version. Diff comments: > > === modified file 'openlp/core/projectors/pjlink.py' > --- openlp/core/projectors/pjlink.py 2018-04-20 06:04:43 + > +++ openlp/core/projectors/pjlink.py 2018-04-28 07:52:45 + > @@ -108,22 +111,20 @@ >

Re: [Openlp-core] [Merge] lp:~alisonken1/openlp/pjlink2-r into lp:openlp

2018-04-30 Thread Phill
Review: Needs Fixing -- https://code.launchpad.net/~alisonken1/openlp/pjlink2-r/+merge/344795 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net

Re: [Openlp-core] [Merge] lp:~alisonken1/openlp/pjlink2-r into lp:openlp

2018-04-30 Thread Phill
See inlines please. Diff comments: > > === modified file 'openlp/core/projectors/pjlink.py' > --- openlp/core/projectors/pjlink.py 2018-04-20 06:04:43 + > +++ openlp/core/projectors/pjlink.py 2018-04-28 07:12:35 + > @@ -108,22 +111,20 @@ > if read_size < 0: >

Re: [Openlp-core] [Merge] lp:~alisonken1/openlp/pjlink2-q into lp:openlp

2018-04-20 Thread Phill
Review: Approve Looks good to me. Thanks! -- https://code.launchpad.net/~alisonken1/openlp/pjlink2-q/+merge/343669 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to :

Re: [Openlp-core] [Merge] lp:~alisonken1/openlp/pjlink2-q into lp:openlp

2018-04-18 Thread Phill
Review: Needs Fixing A few issues / questions. See in line. Diff comments: > > === modified file 'openlp/core/projectors/editform.py' > --- openlp/core/projectors/editform.py2017-12-29 09:15:48 + > +++ openlp/core/projectors/editform.py2018-03-24 08:24:22 + > @@ -58,10

Re: [Openlp-core] [Merge] lp:~thelinuxguy/openlp/fix-newline-bug into lp:openlp

2018-04-18 Thread Phill
Review: Approve Good, thanks for you patience -- https://code.launchpad.net/~thelinuxguy/openlp/fix-newline-bug/+merge/343465 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to :

Re: [Openlp-core] [Merge] lp:~thelinuxguy/openlp/fix-newline-bug into lp:openlp

2018-04-16 Thread Phill
> One small typo, and a couple comments that need changing. Sorry! -- https://code.launchpad.net/~thelinuxguy/openlp/fix-newline-bug/+merge/343306 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list:

Re: [Openlp-core] [Merge] lp:~thelinuxguy/openlp/fix-newline-bug into lp:openlp

2018-04-16 Thread Phill
Review: Needs Fixing One small typo, and a couple comments that need changing. Diff comments: > === modified file 'openlp/core/common/__init__.py' > --- openlp/core/common/__init__.py2018-02-24 16:10:02 + > +++ openlp/core/common/__init__.py2018-04-16 11:33:07 + > @@ -44,7 +44,7

Re: [Openlp-core] [Merge] lp:~thelinuxguy/openlp/fix-newline-bug into lp:openlp

2018-04-16 Thread Phill
Review: Needs Fixing I've done some research in to this. Officially the only code points allowed are: " [2] Char ::= #x9 | #xA | #xD | [#x20-#xD7FF] | [#xE000-#xFFFD] | [#x1-#x10] /* any Unicode character, excluding the surrogate blocks, FFFE, and . */ " (

Re: [Openlp-core] [Merge] lp:~thelinuxguy/openlp/fix-newline-bug into lp:openlp

2018-04-15 Thread Phill
Review: Needs Fixing See in line. One question and a few (more) minor fixes please. Diff comments: > === modified file 'openlp/core/common/__init__.py' > --- openlp/core/common/__init__.py2018-02-24 16:10:02 + > +++ openlp/core/common/__init__.py2018-04-14 20:05:07 + > @@ -44,7

[Openlp-core] [Merge] lp:~phill-ridout/openlp/pathlib12 into lp:openlp

2018-01-24 Thread Phill
Phill has proposed merging lp:~phill-ridout/openlp/pathlib12 into lp:openlp. Requested reviews: Tim Bentley (trb143) Related bugs: Bug #1734432 in OpenLP: "Progress bar does not show whilst loading a service" https://bugs.launchpad.net/openlp/+bug/1734432 For more details,

[Openlp-core] [Merge] lp:~phill-ridout/openlp/pathlib12 into lp:openlp

2018-01-24 Thread Phill
The proposal to merge lp:~phill-ridout/openlp/pathlib12 into lp:openlp has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~phill-ridout/openlp/pathlib12/+merge/336398 -- Your team OpenLP Core is subscribed to branch lp:ope

[Openlp-core] [Merge] lp:~phill-ridout/openlp/pathlib12 into lp:openlp

2018-01-21 Thread Phill
Phill has proposed merging lp:~phill-ridout/openlp/pathlib12 into lp:openlp. Requested reviews: OpenLP Core (openlp-core) Related bugs: Bug #1734432 in OpenLP: "Progress bar does not show whilst loading a service" https://bugs.launchpad.net/openlp/+bug/1734432 For more details,

Re: [Openlp-core] [Merge] lp:~raoul-snyman/openlp/better-threading into lp:openlp

2018-01-07 Thread Phill
Review: Needs Fixing Just a few minor things Diff comments: > > === modified file 'openlp/core/api/websockets.py' > --- openlp/core/api/websockets.py 2017-12-29 09:15:48 + > +++ openlp/core/api/websockets.py 2018-01-07 05:37:57 + > @@ -28,37 +28,88 @@ > import logging >

[Openlp-core] [Merge] lp:~phill-ridout/openlp/moar_test_cleanups into lp:openlp

2017-12-24 Thread Phill
Phill has proposed merging lp:~phill-ridout/openlp/moar_test_cleanups into lp:openlp. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~phill-ridout/openlp/moar_test_cleanups/+merge/335579 Move song test resources lp:~phill-ridout/openlp

[Openlp-core] [Merge] lp:~phill-ridout/openlp/pathlib11 into lp:openlp

2017-12-23 Thread Phill
Phill has proposed merging lp:~phill-ridout/openlp/pathlib11 into lp:openlp. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~phill-ridout/openlp/pathlib11/+merge/335578 Some more pathlib refactors. Test tidy ups lp:~phill-ridout/openlp

Re: [Openlp-core] [Merge] lp:~trb143/openlp/asserts2 into lp:openlp

2017-12-23 Thread Phill
Review: Approve -- https://code.launchpad.net/~trb143/openlp/asserts2/+merge/335577 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net

Re: [Openlp-core] [Merge] lp:~trb143/openlp/asserts2 into lp:openlp

2017-12-23 Thread Phill
Review: Needs Fixing Just a few to fix up Diff comments: > > === modified file 'tests/functional/openlp_plugins/bibles/test_lib.py' > --- tests/functional/openlp_plugins/bibles/test_lib.py2017-06-05 > 02:58:38 + > +++ tests/functional/openlp_plugins/bibles/test_lib.py

Re: [Openlp-core] [Merge] lp:~trb143/openlp/asserts into lp:openlp

2017-12-22 Thread Phill
Review: Approve -- https://code.launchpad.net/~trb143/openlp/asserts/+merge/335548 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe

Re: [Openlp-core] [Merge] lp:~trb143/openlp/asserts into lp:openlp

2017-12-22 Thread Phill
Review: Needs Fixing That's quite a diff! See inline comments. First couple need more info rest need fixing Diff comments: > > === modified file 'tests/functional/openlp_core/ui/media/test_systemplayer.py' > --- tests/functional/openlp_core/ui/media/test_systemplayer.py > 2017-10-07

[Openlp-core] [Bug 1738968] [NEW] Manual - Dead link

2017-12-19 Thread Phill
Public bug reported: As reported by user: https://support.openlp.org/scp/tickets.php?id=4578 Hi, Trying to find ways to batch convert over 1000 songs in .txt files with some basic internal structure similar to Unix/Linux man files (currently using Presenter:See presentersoftware.com) so that

Re: [Openlp-core] [Merge] lp:~trb143/openlp/asserts into lp:openlp

2017-12-18 Thread Phill
Review: Approve Great thanks -- https://code.launchpad.net/~trb143/openlp/asserts/+merge/335334 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net

Re: [Openlp-core] [Merge] lp:~trb143/openlp/asserts into lp:openlp

2017-12-18 Thread Phill
Review: Needs Fixing I bet you're beginning to wished you black balled me! ;-) A few issues. 1st inline comment is just a comment only, I'm not expecting you to take action on this case. A few other inline comments after that are minor edits Diff comments: > > === modified file

Re: [Openlp-core] [Merge] lp:~phill-ridout/openlp/fixes-V into lp:openlp

2017-12-17 Thread Phill
lp:~phill-ridout/openlp/fixes-V (revision 2798) https://ci.openlp.io/job/Branch-01-Pull/2359/ [WAITING] [RUNNING] [SUCCESS] https://ci.openlp.io/job/Branch-02-Functional-Tests/2260

Re: [Openlp-core] [Merge] lp:~trb143/openlp/asserts into lp:openlp

2017-12-17 Thread Phill
Review: Approve Thanks, looks good now. -- https://code.launchpad.net/~trb143/openlp/asserts/+merge/335289 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to :

[Openlp-core] [Merge] lp:~phill-ridout/openlp/fixes-V into lp:openlp

2017-12-16 Thread Phill
Phill has proposed merging lp:~phill-ridout/openlp/fixes-V into lp:openlp. Requested reviews: OpenLP Core (openlp-core) Related bugs: Bug #1736274 in OpenLP: "SWORD importer - Information text not wrapped" https://bugs.launchpad.net/openlp/+bug/1736274 Bug #1738047 in OpenL

Re: [Openlp-core] [Merge] lp:~trb143/openlp/asserts into lp:openlp

2017-12-15 Thread Phill
Review: Needs Fixing should also be is True -- https://code.launchpad.net/~trb143/openlp/asserts/+merge/335263 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to :

Re: [Openlp-core] [Merge] lp:~trb143/openlp/asserts into lp:openlp

2017-12-15 Thread Phill
A few more Truthy value issues Diff comments: > > === modified file 'tests/functional/openlp_core/common/test_common.py' > --- tests/functional/openlp_core/common/test_common.py2017-10-07 > 07:05:07 + > +++ tests/functional/openlp_core/common/test_common.py2017-12-15 >

[Openlp-core] [Bug 954373] Re: use simplejson in web remote

2017-12-15 Thread Phill
** Changed in: openlp Status: Confirmed => Won't Fix -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/954373 Title: use simplejson in web remote Status in OpenLP: Won't Fix Bug description:

[Openlp-core] [Bug 1738047] Re: OpenLP picks up macOS hidden files when loading plugins

2017-12-15 Thread Phill
** Changed in: openlp Assignee: (unassigned) => Phill (phill-ridout) ** Changed in: openlp Status: New => In Progress -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1738047

[Openlp-core] [Bug 1608024] Re: DVD Media Time Stamps Not Working

2017-12-13 Thread Phill
** Changed in: openlp Importance: Undecided => Low ** Changed in: openlp Assignee: (unassigned) => Phill (phill-ridout) -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1608024 Title:

[Openlp-core] [Bug 1582164] Re: Add support for alternative/new presentationmanager song format

2017-12-13 Thread Phill
** Changed in: openlp Importance: Undecided => Wishlist -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1582164 Title: Add support for alternative/new presentationmanager song format Status in

[Openlp-core] [Bug 1612841] Re: Afrikaans Translation is marked as "Engels"

2017-12-13 Thread Phill
** Changed in: openlp Importance: Undecided => Medium -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1612841 Title: Afrikaans Translation is marked as "Engels" Status in OpenLP: New Bug

[Openlp-core] [Bug 1645050] Re: Two Help Menus on macOS

2017-12-13 Thread Phill
** Changed in: openlp Importance: Undecided => Low -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1645050 Title: Two Help Menus on macOS Status in OpenLP: New Bug description: There are two

[Openlp-core] [Bug 1736274] Re: SWORD importer - Information text not wrapped

2017-12-11 Thread Phill
** Changed in: openlp Status: New => In Progress ** Changed in: openlp Assignee: (unassigned) => Phill (phill-ridout) -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1736274 Title:

Re: [Openlp-core] [Merge] lp:~trb143/openlp/asserts into lp:openlp

2017-12-09 Thread Phill
Review: Needs Fixing generally ok, but there's several assert statements where you have change the meaning, checking for Falsey/Truthy values rather than checking that the the result is True, is False, is None, etc. I've highlight a few with inline comments, but there are some others. Diff

Re: [Openlp-core] [Merge] lp:~alisonken1/openlp/pjlink2-m into lp:openlp

2017-12-09 Thread Phill
Review: Approve Great. Thanks for those changes :-) -- https://code.launchpad.net/~alisonken1/openlp/pjlink2-m/+merge/335001 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to :

Re: [Openlp-core] [Merge] lp:~alisonken1/openlp/pjlink2-m into lp:openlp

2017-12-05 Thread Phill
Just some style fixes please. There's a couple inline comments. Also you've got a right mismatch between single and double quoted strings. Can you change these so that strings use single quotes. I'm not sure there is a standard for quotes within the string, but double quotes are tidier as they

[Openlp-core] [Bug 1736274] [NEW] SWORD importer - Information text not wrapped

2017-12-04 Thread Phill
Public bug reported: Ubuntu 17.10 trunk revision 2793 The information text is cut short rather than wrapping. See the attached image. ** Affects: openlp Importance: Low Status: New ** Attachment added: "Screenshot from 2017-12-04 22-34-33.png"

[Openlp-core] [Merge] lp:~phill-ridout/openlp/fixes-mkIV into lp:openlp

2017-12-04 Thread Phill
Phill has proposed merging lp:~phill-ridout/openlp/fixes-mkIV into lp:openlp. Requested reviews: OpenLP Core (openlp-core) Related bugs: Bug #1514545 in OpenLP: "DVD audio/subtitle track selection is broken" https://bugs.launchpad.net/openlp/+bug/1514545 Bug #1735765 in OpenLP:

[Openlp-core] [Bug 1734432] Re: Progress bar does not show whilst loading a service

2017-12-04 Thread Phill
** Changed in: openlp Assignee: (unassigned) => Phill (phill-ridout) ** Changed in: openlp Status: New => In Progress -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1734432

[Openlp-core] [Bug 1735765] Re: Launching OpenLP in portable mode results in a traceback

2017-12-02 Thread Phill
I've already spotted this one, and have a fix waiting. ** Changed in: openlp Importance: Undecided => Medium ** Changed in: openlp Status: New => In Progress ** Changed in: openlp Assignee: (unassigned) => Phill (phill-ridout) -- You received this bug notification be

[Openlp-core] [Bug 1735766] Re: Launching Openlp with -w results in a traceback

2017-12-02 Thread Phill
** Changed in: openlp Status: Confirmed => Fix Committed ** Changed in: openlp Milestone: None => 2.9.1 -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1735766 Title: Launching Openlp

Re: [Openlp-core] [Merge] lp:~trb143/openlp/fixwebabend into lp:openlp

2017-12-02 Thread Phill
Review: Approve -- https://code.launchpad.net/~trb143/openlp/fixwebabend/+merge/334632 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net

[Openlp-core] [Bug 1562566] Re: Projector manager exception when connecting

2017-11-27 Thread Phill
** Changed in: openlp Importance: Critical => Medium -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1562566 Title: Projector manager exception when connecting Status in OpenLP: New Bug

[Openlp-core] [Bug 1734275] Re: Non-standard PJLink reply to LAMP command

2017-11-24 Thread Phill
** Changed in: openlp Milestone: None => 2.9.1 ** Changed in: openlp Status: In Progress => Fix Committed -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1734275 Title: Non-standard

Re: [Openlp-core] [Merge] lp:~alisonken1/openlp/bug-1734275 into lp:openlp

2017-11-24 Thread Phill
Review: Approve -- https://code.launchpad.net/~alisonken1/openlp/bug-1734275/+merge/334254 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net

[Openlp-core] [Bug 1514545] Re: DVD audio/subtitle track selection is broken

2017-11-24 Thread Phill
** Branch unlinked: lp:~phill-ridout/openlp/fixes-mkIII ** Branch linked: lp:~phill-ridout/openlp/fixes-mkIV -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1514545 Title: DVD audio/subtitle track

Re: [Openlp-core] [Merge] lp:~alisonken1/openlp/bug-1734275 into lp:openlp

2017-11-24 Thread Phill
Review: Needs Fixing -- https://code.launchpad.net/~alisonken1/openlp/bug-1734275/+merge/334254 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to :

Re: [Openlp-core] [Merge] lp:~alisonken1/openlp/bug-1734275 into lp:openlp

2017-11-24 Thread Phill
You've just missed removing the pjlink instance in the test file. (see inline) Diff comments: > > === added file > 'tests/functional/openlp_core/projectors/test_projector_bugfixes_01.py' > --- tests/functional/openlp_core/projectors/test_projector_bugfixes_01.py > 1970-01-01 00:00:00

Re: [Openlp-core] [Merge] lp:~alisonken1/openlp/bug-1734275 into lp:openlp

2017-11-24 Thread Phill
Review: Needs Fixing A few inline comments, nothing major Sorry if it seems like I be tripping on my new status! :-p Diff comments: > === modified file 'openlp/core/projectors/manager.py' > --- openlp/core/projectors/manager.py 2017-11-10 11:59:38 + > +++ openlp/core/projectors/manager.py

[Openlp-core] [Bug 1734275] Re: Non-standard PJLink reply to LAMP command

2017-11-24 Thread Phill
** Changed in: openlp Status: Confirmed => In Progress ** Changed in: openlp Milestone: 3.0 => 2.9.1 ** Changed in: openlp Milestone: 2.9.1 => None -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP.

[Openlp-core] [Bug 1514545] Re: DVD audio/subtitle track selection is broken

2017-11-22 Thread Phill
** Changed in: openlp Status: New => In Progress ** Changed in: openlp Importance: Undecided => Medium ** Changed in: openlp Assignee: (unassigned) => Mike (mikey74) -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP.

[Openlp-core] [Merge] lp:~phill-ridout/openlp/pathlib10 into lp:openlp

2017-11-20 Thread Phill
Phill has proposed merging lp:~phill-ridout/openlp/pathlib10 into lp:openlp. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~phill-ridout/openlp/pathlib10/+merge/334022 More pathlib refactors Add this to your merge proposal

Re: [Openlp-core] [Merge] lp:~alisonken1/openlp/pjlink2-l into lp:openlp

2017-11-17 Thread Phill
Review: Needs Information You've got a load of test files that appear to have been removed, and the re-added in another place. e.g.: === removed file 'tests/functional/openlp_core/lib/test_projector_db.py' === added file 'tests/functional/openlp_core/projectors/test_projector_db.py' Have you

[Openlp-core] [Merge] lp:~phill-ridout/openlp/fixes-mkIII into lp:openlp

2017-11-16 Thread Phill
Phill has proposed merging lp:~phill-ridout/openlp/fixes-mkIII into lp:openlp. Requested reviews: Raoul Snyman (raoul-snyman) Related bugs: Bug #1625087 in OpenLP: "Image insertion doesn't respect natural order" https://bugs.launchpad.net/openlp/+bug/1625087 Bug #1650358

[Openlp-core] [Merge] lp:~phill-ridout/openlp/fixes-mkIII into lp:openlp

2017-11-16 Thread Phill
The proposal to merge lp:~phill-ridout/openlp/fixes-mkIII into lp:openlp has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~phill-ridout/openlp/fixes-mkIII/+merge/333834 -- Your team OpenLP Core is subscribed to branch lp:ope

[Openlp-core] [Merge] lp:~phill-ridout/openlp/fixes-mkIII into lp:openlp

2017-11-16 Thread Phill
Phill has proposed merging lp:~phill-ridout/openlp/fixes-mkIII into lp:openlp. Requested reviews: OpenLP Core (openlp-core) Related bugs: Bug #1625087 in OpenLP: "Image insertion doesn't respect natural order" https://bugs.launchpad.net/openlp/+bug/1625087 Bug #1650358 in OpenLP

[Openlp-core] [Bug 1473670] Re: Remove current clock time from default save name

2017-11-16 Thread Phill
I agree with Tim. ** Changed in: openlp Status: New => Won't Fix -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1473670 Title: Remove current clock time from default save name Status in

[Openlp-core] [Bug 1543571] Re: Korean Language Mishaps

2017-11-15 Thread Phill
Hi Sameum, To a non Korean speaker this issue is a little difficult to understand. I've done some research, and it seems in certain situations like the text should only be broken on white space, while in other cases its permissible to break in word (between syllables)

[Openlp-core] [Bug 1732348] Re: MediaInfo's XML output has changed

2017-11-14 Thread Phill
I haven't looked at the code but the change log states 'Use Option("Inform", "OLDXML") for keeping previous behaviour' Perhaps we should use this until we can be sure all systems have received the update, then in the future switch to the json interface (introduced in 7.99) -- You received this

[Openlp-core] [Merge] lp:~phill-ridout/openlp/pathlib9 into lp:openlp

2017-11-14 Thread Phill
Phill has proposed merging lp:~phill-ridout/openlp/pathlib9 into lp:openlp. Requested reviews: Raoul Snyman (raoul-snyman) Tim Bentley (trb143) For more details, see: https://code.launchpad.net/~phill-ridout/openlp/pathlib9/+merge/333718 Add this to your merge proposal

[Openlp-core] [Merge] lp:~phill-ridout/openlp/pathlib9 into lp:openlp

2017-11-14 Thread Phill
The proposal to merge lp:~phill-ridout/openlp/pathlib9 into lp:openlp has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~phill-ridout/openlp/pathlib9/+merge/332092 -- Your team OpenLP Core is subscribed to branch lp:ope

[Openlp-core] [Bug 1673251] Re: Incorrect file type suggested for Save As

2017-11-14 Thread Phill
** Changed in: openlp Status: New => In Progress ** Changed in: openlp Assignee: (unassigned) => Phill (phill-ridout) -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1673251

[Openlp-core] [Bug 863178] Re: Use rectangle splashscreen, not circular

2017-11-14 Thread Phill
** Changed in: openlp Status: Confirmed => Won't Fix -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/863178 Title: Use rectangle splashscreen, not circular Status in OpenLP: Won't Fix

[Openlp-core] [Bug 1490955] Re: Default image background does not go away

2017-11-14 Thread Phill
Azaziah, Does this happen when using a transparent background, or other types as well? I can replicate this with transparent backgrounds -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1490955 Title:

[Openlp-core] [Bug 1016106] Re: Watch for changes to images on disk

2017-11-14 Thread Phill
** Changed in: openlp Status: Confirmed => Won't Fix -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1016106 Title: Watch for changes to images on disk Status in OpenLP: Won't Fix Status in

[Openlp-core] [Bug 1641617] Re: Window behind OpenLP logo after update prevents initialization

2017-11-14 Thread Phill
Also apparently fixed in http://bazaar.launchpad.net/~openlp- core/openlp/trunk/revision/2711 ** Changed in: openlp/trunk Status: Confirmed => Fix Committed ** Changed in: openlp/trunk Milestone: None => 2.5.1 -- You received this bug notification because you are a member of OpenLP

[Openlp-core] [Bug 1650358] Re: Replace Live background item right click uses wrong icon

2017-11-13 Thread Phill
** Changed in: openlp Status: New => In Progress ** Changed in: openlp Assignee: (unassigned) => Phill (phill-ridout) -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1650358

[Openlp-core] [Bug 1625087] Re: Image insertion doesn't respect natural order

2017-11-13 Thread Phill
** Changed in: openlp Status: New => In Progress ** Changed in: openlp Importance: Undecided => Low ** Changed in: openlp Assignee: (unassigned) => Phill (phill-ridout) -- You received this bug notification because you are a member of OpenLP Core, which is subscribed

[Openlp-core] [Bug 1225760] Re: Unsupported fields in WorshipCenter Pro importer

2017-11-13 Thread Phill
** Changed in: openlp/trunk Status: Confirmed => Fix Released ** Changed in: openlp/trunk Assignee: (unassigned) => Tomas Groth (tomasgroth) -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP.

[Openlp-core] [Bug 863178] Re: Use rectangle splashscreen, not circular

2017-11-13 Thread Phill
** Changed in: openlp/trunk Status: Confirmed => Won't Fix -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/863178 Title: Use rectangle splashscreen, not circular Status in OpenLP: Confirmed

[Openlp-core] [Bug 1672777] Re: Right click menu on expanded Service item always sends the first slide to Live

2017-11-13 Thread Phill
** Changed in: openlp Status: Confirmed => In Progress ** Changed in: openlp Assignee: (unassigned) => Phill (phill-ridout) -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1672777

[Openlp-core] [Bug 1532193] Re: Typos in songusageplugin.py

2017-11-10 Thread Phill
** Changed in: openlp/trunk Status: In Progress => Fix Committed -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1532193 Title: Typos in songusageplugin.py Status in OpenLP: Fix Committed

[Openlp-core] [Bug 1400415] Re: Multiple exceptions merged into OSError

2017-11-10 Thread Phill
** Changed in: openlp Status: In Progress => Fix Committed -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1400415 Title: Multiple exceptions merged into OSError Status in OpenLP: Fix

[Openlp-core] [Bug 1661416] Re: Initial "extract song usage data" produces a traceback

2017-11-10 Thread Phill
** Changed in: openlp/trunk Status: In Progress => Fix Committed -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1661416 Title: Initial "extract song usage data" produces a traceback Status

[Openlp-core] [Bug 1698021] Re: Copying and Pasting from Word inserts invalid characters

2017-11-10 Thread Phill
** Changed in: openlp Status: In Progress => Fix Committed -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1698021 Title: Copying and Pasting from Word inserts invalid characters Status in

[Openlp-core] [Bug 1660486] Re: Dragging item in service manager without changes triggeres "unsaved"

2017-11-10 Thread Phill
** Changed in: openlp Status: In Progress => Fix Committed -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1660486 Title: Dragging item in service manager without changes triggeres "unsaved"

[Openlp-core] [Bug 1672229] Re: Media Library duplicates on boot and when a new item is added

2017-11-10 Thread Phill
** Changed in: openlp Status: In Progress => Fix Committed -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1672229 Title: Media Library duplicates on boot and when a new item is added Status

[Openlp-core] [Bug 1660478] Re: Opening recent file does not prompt to save changes

2017-11-10 Thread Phill
** Changed in: openlp Status: In Progress => Fix Committed -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1660478 Title: Opening recent file does not prompt to save changes Status in OpenLP:

[Openlp-core] [Bug 1660473] Re: OSZL is ignored on save (inconsistent gui)

2017-11-10 Thread Phill
** Changed in: openlp Status: In Progress => Fix Committed -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1660473 Title: OSZL is ignored on save (inconsistent gui) Status in OpenLP: Fix

[Openlp-core] [Bug 1715125] Re: Missing .osz file extension on save service

2017-11-10 Thread Phill
** Changed in: openlp Status: In Progress => Fix Committed -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1715125 Title: Missing .osz file extension on save service Status in OpenLP: Fix

[Openlp-core] [Bug 1727517] Re: Unicode control chars causes song importer to crash

2017-11-10 Thread Phill
** Changed in: openlp Status: In Progress => Fix Committed -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1727517 Title: Unicode control chars causes song importer to crash Status in OpenLP:

[Openlp-core] [Merge] lp:~phill-ridout/openlp/fixes-mkII into lp:openlp

2017-11-10 Thread Phill
Phill has proposed merging lp:~phill-ridout/openlp/fixes-mkII into lp:openlp. Requested reviews: Tim Bentley (trb143) Raoul Snyman (raoul-snyman) Related bugs: Bug #1400415 in OpenLP: "Multiple exceptions merged into OSError" https://bugs.launchpad.net/openlp/+bug/1400415 Bu

[Openlp-core] [Merge] lp:~phill-ridout/openlp/fixes-mkII into lp:openlp

2017-11-10 Thread Phill
The proposal to merge lp:~phill-ridout/openlp/fixes-mkII into lp:openlp has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~phill-ridout/openlp/fixes-mkII/+merge/333570 -- Your team OpenLP Core is subscribed to branch lp:ope

[Openlp-core] [Merge] lp:~phill-ridout/openlp/fixes-mkII into lp:openlp

2017-11-10 Thread Phill
Phill has proposed merging lp:~phill-ridout/openlp/fixes-mkII into lp:openlp. Requested reviews: Tim Bentley (trb143) Related bugs: Bug #1400415 in OpenLP: "Multiple exceptions merged into OSError" https://bugs.launchpad.net/openlp/+bug/1400415 Bug #1532193 in Open

[Openlp-core] [Merge] lp:~phill-ridout/openlp/fixes-mkII into lp:openlp

2017-11-10 Thread Phill
The proposal to merge lp:~phill-ridout/openlp/fixes-mkII into lp:openlp has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~phill-ridout/openlp/fixes-mkII/+merge/333491 -- Your team OpenLP Core is subscribed to branch lp:ope

Re: [Openlp-core] [Merge] lp:~raoul-snyman/openlp/update-jenkins-script into lp:openlp

2017-11-10 Thread Phill
Review: Approve Looks good to me! -- https://code.launchpad.net/~raoul-snyman/openlp/update-jenkins-script/+merge/333558 Your team OpenLP Core is requested to review the proposed merge of lp:~raoul-snyman/openlp/update-jenkins-script into lp:openlp.

[Openlp-core] [Bug 1723293] Re: Remote bible search fails to show full chapter

2017-11-10 Thread Phill
Possibly related to: https://bugs.launchpad.net/openlp/+bug/1638620 "Unexpected results from bible passage regex parsing" -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1723293 Title: Remote bible

[Openlp-core] [Merge] lp:~phill-ridout/openlp/fixes-mkII into lp:openlp

2017-11-09 Thread Phill
Phill has proposed merging lp:~phill-ridout/openlp/fixes-mkII into lp:openlp. Requested reviews: OpenLP Core (openlp-core) Related bugs: Bug #1400415 in OpenLP: "Multiple exceptions merged into OSError" https://bugs.launchpad.net/openlp/+bug/1400415 Bug #1532193 in Open

[Openlp-core] [Merge] lp:~phill-ridout/openlp/fixes-mkII into lp:openlp

2017-11-09 Thread Phill
The proposal to merge lp:~phill-ridout/openlp/fixes-mkII into lp:openlp has been updated. Status: Work in progress => Superseded For more details, see: https://code.launchpad.net/~phill-ridout/openlp/fixes-mkII/+merge/332952 -- Your team OpenLP Core is requested to review the propo

[Openlp-core] [Bug 1668652] Re: Error trace everytime live service moves into new item

2017-11-09 Thread Phill
Hi Simon, Any chance you are still getting this error? If so, would it be possible to export your settings and attach them here please? -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1668652 Title:

[Openlp-core] [Bug 1673108] Re: Create New Custom Slide button is misleading

2017-11-09 Thread Phill
How about "Copy to custom slides"? We could then flash the tab bar for custom slides to indicate that an action has taken place. I did think we could switch to the custom slide tab, but that might be a bit disjointed if a user wants to convert multiple songs. -- You received this bug

[Openlp-core] [Bug 1673108] Re: Create New Custom Slide button is misleading

2017-11-09 Thread Phill
** Changed in: openlp Status: New => Confirmed ** Changed in: openlp Importance: Undecided => Low -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1673108 Title: Create New Custom Slide

[Openlp-core] [Bug 1673113] Re: "Save & Preview" Button in Song Editor behaves in a strange way

2017-11-09 Thread Phill
Simon, I agree! Its almost like the "save and preview" button should be visible when you click edit from the song manager, and not from the "Edit and reload song preview" (the edit button under the preview). I'd recommend posting a link to this bug on the mailing list to see what others think.

[Openlp-core] [Bug 1674217] Re: Print service window will not close

2017-11-07 Thread Phill
*** This bug is a duplicate of bug 1639860 *** https://bugs.launchpad.net/bugs/1639860 Just done some investigating looks like Azaiah solved this one earlier this year. It will be in the next release! ** This bug has been marked a duplicate of bug 1639860 Close button is disabled in

[Openlp-core] [Bug 1516171] Re: Alert with line break from remote makes desktop report a bug

2017-11-06 Thread Phill
** Changed in: openlp/2.2 Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1516171 Title: Alert with line break from remote makes desktop report a bug

[Openlp-core] [Bug 1518634] Re: Saved Service with Unavailable player crashes

2017-11-06 Thread Phill
** Changed in: openlp/2.2 Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1518634 Title: Saved Service with Unavailable player crashes Status in OpenLP:

[Openlp-core] [Bug 1674217] Re: Print service window will not close

2017-11-06 Thread Phill
See also https://support.openlp.org/scp/tickets.php?id=4514 ** Changed in: openlp Status: New => Confirmed ** Changed in: openlp Importance: Undecided => Medium -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP.

<    1   2   3   4   5   6   7   8   9   10   >