Phill has proposed merging lp:~phill-ridout/openlp/path_edit into lp:openlp.
Requested reviews:
Tim Bentley (trb143)
For more details, see:
https://code.launchpad.net/~phill-ridout/openlp/path_edit/+merge/324026
Add a custom widget for editing and selecting paths. Implemented in OpenLP,
with
The proposal to merge lp:~phill-ridout/openlp/path_edit into lp:openlp has been
updated.
Status: Needs review => Superseded
For more details, see:
https://code.launchpad.net/~phill-ridout/openlp/path_edit/+merge/324018
--
Your team OpenLP Core is subscribed to branch lp:ope
Phill has proposed merging lp:~phill-ridout/openlp/import-depreciations into
lp:openlp.
Requested reviews:
Tim Bentley (trb143)
For more details, see:
https://code.launchpad.net/~phill-ridout/openlp/import-depreciations/+merge/324025
Fix the depreciated code, and refactor it.
lp:~phill
I had merged with trunk, but forgot to update trunk!
--
https://code.launchpad.net/~phill-ridout/openlp/import-depreciations/+merge/324025
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
The proposal to merge lp:~phill-ridout/openlp/import-depreciations into
lp:openlp has been updated.
Status: Needs review => Superseded
For more details, see:
https://code.launchpad.net/~phill-ridout/openlp/import-depreciations/+merge/324024
--
Your team OpenLP Core is subscribed to bra
Phill has proposed merging lp:~phill-ridout/openlp/import-depreciations into
lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~phill-ridout/openlp/import-depreciations/+merge/324024
Fix the depreciated code, and refactor it.
Add this
Phill has proposed merging lp:~phill-ridout/openlp/path_edit into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~phill-ridout/openlp/path_edit/+merge/324018
Add a custom widget for editing and selecting paths. Implemented in OpenLP
Phill has proposed merging lp:~phill-ridout/openlp/saved_bible_verses into
lp:openlp.
Requested reviews:
Tim Bentley (trb143)
For more details, see:
https://code.launchpad.net/~phill-ridout/openlp/saved_bible_verses/+merge/323727
Adds more flexibility to 'locking' bible ver
The proposal to merge lp:~phill-ridout/openlp/saved_bible_verses into lp:openlp
has been updated.
Status: Needs review => Superseded
For more details, see:
https://code.launchpad.net/~phill-ridout/openlp/saved_bible_verses/+merge/323722
--
Your team OpenLP Core is subscribed to bra
Phill has proposed merging lp:~phill-ridout/openlp/saved_bible_verses into
lp:openlp.
Requested reviews:
Tim Bentley (trb143)
For more details, see:
https://code.launchpad.net/~phill-ridout/openlp/saved_bible_verses/+merge/323722
Adds more flexibility to 'locking' bible ver
The proposal to merge lp:~phill-ridout/openlp/saved_bible_verses into lp:openlp
has been updated.
Status: Needs review => Superseded
For more details, see:
https://code.launchpad.net/~phill-ridout/openlp/saved_bible_verses/+merge/321949
--
Your team OpenLP Core is subscribed to bra
Phill has proposed merging lp:~phill-ridout/openlp/test_fixes into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~phill-ridout/openlp/test_fixes/+merge/323709
Fix the QFormLayout in BibleImportForm
Fix one of the tests that was
Phill has proposed merging lp:~phill-ridout/openlp/saved_bible_verses into
lp:openlp.
Requested reviews:
Tim Bentley (trb143)
For more details, see:
https://code.launchpad.net/~phill-ridout/openlp/saved_bible_verses/+merge/321949
Adds more flexibility to 'locking' bible ver
The proposal to merge lp:~phill-ridout/openlp/saved_bible_verses into lp:openlp
has been updated.
Status: Needs review => Superseded
For more details, see:
https://code.launchpad.net/~phill-ridout/openlp/saved_bible_verses/+merge/321783
--
Your team OpenLP Core is subscribed to bra
The proposal to merge lp:~phill-ridout/openlp/saved_bible_verses into lp:openlp
has been updated.
Status: Needs review => Superseded
For more details, see:
https://code.launchpad.net/~phill-ridout/openlp/saved_bible_verses/+merge/321648
--
Your team OpenLP Core is requested to review
I would disagree that this is a bug. It works the same way as other auto
completers do, just try few examples in OpenLP and Google. I think its
best to emulate the way others do it from a usability point of view.
--
You received this bug notification because you are a member of OpenLP
Core, which
** Changed in: openlp/website
Assignee: (unassigned) => Raoul Snyman (raoul-snyman)
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1085205
Title:
website translation on transifex
Status in Open
The proposal to merge lp:~phill-ridout/openlp/bible_media_item_refactors into
lp:openlp has been updated.
Status: Needs review => Superseded
For more details, see:
https://code.launchpad.net/~phill-ridout/openlp/bible_media_item_refactors/+merge/317701
--
Your team OpenLP Core
lugin after this, but my time is limited atm. Can you submit this as a wish
list bug?
--
https://code.launchpad.net/~phill-ridout/openlp/bible_media_item_refactors/+merge/317701
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing
quot;", which already has a
> layout
> QLayout: Attempting to add QLayout "" to QGroupBox "", which already has a
> layout
I'll take a look at these other issues.
--
https://code.launchpad.net/~phill-ridout/openlp/bible_media_item_refactors/+merge/317701
Y
Forgot:
lp:~phill-ridout/openlp/bible_media_item_refactors (revision 2731)
[SUCCESS] https://ci.openlp.io/job/Branch-01-Pull/1900/
[SUCCESS] https://ci.openlp.io/job/Branch-02-Functional-Tests/1811/
[SUCCESS] https://ci.openlp.io/job/Branch-03-Interface-Tests/1750/
[SUCCESS] https://ci.openlp.io
Fixed the above issues!
--
https://code.launchpad.net/~phill-ridout/openlp/bible_media_item_refactors/+merge/317701
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core
The proposal to merge lp:~phill-ridout/openlp/bible_media_item_refactors into
lp:openlp has been updated.
Status: Needs review => Superseded
For more details, see:
https://code.launchpad.net/~phill-ridout/openlp/bible_media_item_refactors/+merge/313506
--
Your team OpenLP Core
** Summary changed:
- QMessageBox has obsoleted static methods
+ QMessageBox has changed return types
** Description changed:
- Several static methods that we use have been obsoleted. See:
-
+ QMessageBox has changed the return types of several static methods that we
use. See:
http://doc.qt.
Public bug reported:
Several static methods that we use have been obsoleted. See:
http://doc.qt.io/qt-5/qmessagebox-obsolete.html
** Affects: openlp
Importance: Low
Status: New
** Changed in: openlp
Importance: Undecided => Low
--
You received this bug notification because yo
** Changed in: openlp
Status: New => In Progress
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1593455
Title:
Bible Search field does not get focus on startup
Status in OpenLP:
In Progress
Phill has proposed merging lp:~phill-ridout/openlp/no-results into lp:openlp.
Requested reviews:
Raoul Snyman (raoul-snyman)
For more details, see:
https://code.launchpad.net/~phill-ridout/openlp/no-results/+merge/310703
Move the "no results" code in to the list widget.
lp:~ph
The proposal to merge lp:~phill-ridout/openlp/no-results into lp:openlp has
been updated.
Status: Needs review => Superseded
For more details, see:
https://code.launchpad.net/~phill-ridout/openlp/no-results/+merge/310690
--
Your team OpenLP Core is subscribed to branch lp:ope
Phill has proposed merging lp:~phill-ridout/openlp/search_edit into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~phill-ridout/openlp/search_edit/+merge/310697
Move some code in to the searchedit module
lp:~phill-ridout/openlp
The proposal to merge lp:~phill-ridout/openlp/search_edit into lp:openlp has
been updated.
Status: Needs review => Superseded
For more details, see:
https://code.launchpad.net/~phill-ridout/openlp/search_edit/+merge/310691
--
Your team OpenLP Core is requested to review the proposed me
> Question inline
My track record isn't to great at the moment isn't it!?!
I split this change out a refactor of the bible plugin I'm working on, this
inadvertently moved across! I'll remove the comment.
--
https://code.launchpad.net/~phill-ridout/openlp/search_edit/
Phill has proposed merging lp:~phill-ridout/openlp/search_edit into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~phill-ridout/openlp/search_edit/+merge/310691
Move some code in to the searchedit module
lp:~phill-ridout/openlp
The proposal to merge lp:~phill-ridout/openlp/no-results into lp:openlp has
been updated.
Status: Needs review => Superseded
For more details, see:
https://code.launchpad.net/~phill-ridout/openlp/no-results/+merge/310686
--
Your team OpenLP Core is requested to review the proposed merge
Phill has proposed merging lp:~phill-ridout/openlp/no-results into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~phill-ridout/openlp/no-results/+merge/310690
Move the "no results" code in to the list widget.
lp:~phill-rid
The proposal to merge lp:~phill-ridout/openlp/no-results into lp:openlp has
been updated.
Status: Needs review => Superseded
For more details, see:
https://code.launchpad.net/~phill-ridout/openlp/no-results/+merge/310627
--
Your team OpenLP Core is requested to review the proposed merge
Phill has proposed merging lp:~phill-ridout/openlp/no-results into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~phill-ridout/openlp/no-results/+merge/310686
Move the "no results" code in to the list widget.
lp:~phill-rid
_typing_short()
> +self.list_view.clear(search_while_typing=True)
> else:
> """
> Start search if no chars are entered or deleted for 0.2 s
--
https://code.launchpad.net/~phill-ridout/openlp/no
Phill has proposed merging lp:~phill-ridout/openlp/no-results into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~phill-ridout/openlp/no-results/+merge/310627
Move the "no results" code in to the list widget.
Tests pass lo
Great, thanks!
On Sat, 5 Nov 2016 at 07:43 Tim Bentley wrote:
> As I have said before this is a lift and shift so no changes to
> functionality.
> The next merge will remove all the web code and replace it so why bother.
>
> Small stages for big jobs. This was big enough as it has to work with
Is there a particular reason for using an outdated version of jquery?
Shouldn't it be the minified version too?
--
https://code.launchpad.net/~trb143/openlp/websockets/+merge/310102
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing li
I managed to get some time on an iPhone (iOS 10 I think) and iPad (iOS
9.3) and couldn't reproduce this issue on trunk. I should have tried
2.4, but I forgot!
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/b
Public bug reported:
I come across this potential issue whilst writing a test for the bible
reference regex.
The easiest way to reproduce it is to do the following:
1. Put a breakpoint on:
to_verse = range_match.group('to_verse')
in openlp.plugins.bibles.lib.parse_reference
2. Run OpenLP with a
** Changed in: openlp
Importance: Undecided => Wishlist
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1627468
Title:
Crossfade between Themes?
Status in OpenLP:
New
Bug description:
Would i
** Changed in: openlp
Assignee: (unassigned) => Phill (phill-ridout)
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1593455
Title:
Bible Search field does not get focus on startup
Status
** Branch linked: lp:~phill-ridout/openlp/bug1623711-2.4
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1623711
Title:
Unable to delete web bibles or more than one bible
Status in OpenLP:
In
Phill has proposed merging lp:~phill-ridout/openlp/bug1623711-2.4 into
lp:openlp/2.4.
Requested reviews:
OpenLP Core (openlp-core)
Related bugs:
Bug #1623711 in OpenLP: "Unable to delete web bibles or more than one bible"
https://bugs.launchpad.net/openlp/+bug/1623711
For mo
** Branch unlinked: lp:~phill-ridout/openlp/bug1623711-2.4
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1623711
Title:
Unable to delete web bibles or more than one bible
Status in OpenLP:
In
** Branch linked: lp:~phill-ridout/openlp/bug1623711
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1623711
Title:
Unable to delete web bibles or more than one bible
Status in OpenLP:
In Progress
Phill has proposed merging lp:~phill-ridout/openlp/bug1623711 into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
Related bugs:
Bug #1623711 in OpenLP: "Unable to delete web bibles or more than one bible"
https://bugs.launchpad.net/openlp/+bug/1623711
For more details,
** Branch unlinked: lp:~phill-ridout/openlp/bug1623711
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1623711
Title:
Unable to delete web bibles or more than one bible
Status in OpenLP:
In
** Also affects: openlp/trunk
Importance: Medium
Assignee: Phill (phill-ridout)
Status: In Progress
** Also affects: openlp/2.4
Importance: Undecided
Status: New
** Changed in: openlp/2.4
Status: New => In Progress
** Changed in: openlp/2.4
Importa
Review: Needs Fixing
Gah forgot test!
--
https://code.launchpad.net/~phill-ridout/openlp/bug1623711-2.4/+merge/309730
Your team OpenLP Core is subscribed to branch lp:openlp/2.4.
___
Mailing list: https://launchpad.net/~openlp-core
Post to
Phill has proposed merging lp:~phill-ridout/openlp/bug1623711-2.4 into
lp:openlp/2.4.
Requested reviews:
Raoul Snyman (raoul-snyman)
For more details, see:
https://code.launchpad.net/~phill-ridout/openlp/bug1623711-2.4/+merge/309730
lp:~phill-ridout/openlp/bug1623711-2.4 (revision 2652
That should be it!
--
https://code.launchpad.net/~phill-ridout/openlp/bug1623711-2.4/+merge/309730
Your team OpenLP Core is subscribed to branch lp:openlp/2.4.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core
The proposal to merge lp:~phill-ridout/openlp/bug1623711-2.4 into lp:openlp has
been updated.
Status: Needs review => Superseded
For more details, see:
https://code.launchpad.net/~phill-ridout/openlp/bug1623711-2.4/+merge/309726
--
Your team OpenLP Core is subscribed to branch lp:ope
hmm, thought I had!
--
https://code.launchpad.net/~phill-ridout/openlp/bug1623711-2.4/+merge/309726
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core
** Branch linked: lp:~phill-ridout/openlp/bug1623711
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1623711
Title:
Unable to delete web bibles or more than one bible
Status in OpenLP:
In Progress
Phill has proposed merging lp:~phill-ridout/openlp/bug1623711 into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
Related bugs:
Bug #1623711 in OpenLP: "Unable to delete web bibles or more than one bible"
https://bugs.launchpad.net/openlp/+bug/1623711
For more details,
The proposal to merge lp:~phill-ridout/openlp/bug1623711 into lp:openlp has
been updated.
Status: Needs review => Superseded
For more details, see:
https://code.launchpad.net/~phill-ridout/openlp/bug1623711/+merge/309723
--
Your team OpenLP Core is requested to review the proposed merge
Phill has proposed merging lp:~phill-ridout/openlp/bug1623711 into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~phill-ridout/openlp/bug1623711/+merge/309723
lp:~phill-ridout/openlp/bug1623711 (revision 2701)
[SUCCESS] https
** Branch linked: lp:~trb143/openlp/reporting
** Changed in: openlp
Assignee: Phill (phill-ridout) => Tim Bentley (trb143)
** Changed in: openlp
Status: Confirmed => Fix Committed
** Changed in: openlp
Milestone: None => 2.5.1
--
You received this bug notification be
I've marked this fix released as this bug was for the previous website!
** Changed in: openlp/website
Status: Confirmed => Fix Released
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1085813
Ti
Phill has proposed merging lp:~phill-ridout/openlp/resource_clean_up into
lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~phill-ridout/openlp/resource_clean_up/+merge/309636
Added a script to clean up the resource folder.
Ran script
Updated resource file to follow after merge
--
https://code.launchpad.net/~phill-ridout/openlp/resource_clean_up/+merge/309636
Your team OpenLP Core is requested to review the proposed merge of
lp:~phill-ridout/openlp/resource_clean_up into lp:openlp
** Changed in: openlp
Status: Confirmed => In Progress
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1511016
Title:
Importing in-correct file format to OSIS/CSV > Traceback
Status in OpenLP:
** Changed in: openlp
Status: Confirmed => In Progress
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1623711
Title:
Unable to delete web bibles or more than one bible
Status in OpenLP:
In
Just walked in to this on trunk 2700 Ubuntu. Unable to produce it
reliably.
Looks like the lines mentioned by Ken still need removing!
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1625767
Title:
C
normalise css has this:
/ * 3. Prevent adjustments of font size after orientation changes in
*IE on Windows Phone and in iOS.
*/
-webkit-text-size-adjust: 100%; /* 3 */
Not sure if this would fix it or not. I don't have an iOS device to test
on!
--
You received this bug notification bec
** Changed in: openlp
Assignee: (unassigned) => Phill (phill-ridout)
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1623711
Title:
Unable to delete web bibles or more than one bible
Status
** Changed in: openlp
Status: New => Confirmed
** Changed in: openlp
Assignee: (unassigned) => Phill (phill-ridout)
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1621273
This bug has vanished for me! There's nothing I've done differently as
far as I know. But after further investigation I found you need to run
OpenLP from the foleder openlp.py is in.
** Changed in: openlp
Status: In Progress => New
** Changed in: openlp
Assignee: Phill
http://bazaar.launchpad.net/~openlp-
core/openlp/trunk/view/head:/openlp/plugins/bibles/lib/manager.py#L181
bible.session.close()
change it to:
bible.session.close_all()
** Changed in: openlp
Status: New => Confirmed
--
You received this bug notification because you are a membe
Can we confirm that this has indeed been fixed now that we've moved to
PyQt5?
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1266270
Title:
OpenLP hides dialogs whe using "play slides in loop" on OSX
Could not reproduce the first traceback, but it looks like the line in
question has been modified since this report.
I can confirm the second traceback.
http://bazaar.launchpad.net/~openlp-
core/openlp/trunk/view/head:/openlp/plugins/songs/lib/openlyricsxml.py#L461
in trunk:
text = text.repl
This is just a symptom of the actual problem!
Line openlp.core.common.applocation line 84, we assume that a path taken
from the settings exists, where as if we are using the default location
we actually check that it exists (and create it if we dont)!
(openlp.core.common line 65)
openlp.core.comm
** Changed in: openlp
Status: New => Confirmed
** Changed in: openlp
Status: Confirmed => In Progress
** Changed in: openlp
Importance: Undecided => High
** Changed in: openlp
Assignee: (unassigned) => Phill (phill-ridout)
--
You received this bug notifica
I've spoke to superfly, and he's happy with you adding the \n so looks good to
me!
--
https://code.launchpad.net/~suutari-olli/openlp/change-blank-to-desktop-hotkey-to-esc/+merge/305465
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Maili
You've got a lot of conflicts there!
--
https://code.launchpad.net/~raoul-snyman/openlp/re-enable-version-checking-2.4/+merge/306809
Your team OpenLP Core is requested to review the proposed merge of
lp:~raoul-snyman/openlp/re-enable-version-checking-2.4 into lp:openlp.
_
Can this still be reproduced on Ubuntu 16.04 LTS?
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1171064
Title:
Graphics issues with x11 bypass enabled in Ubuntu 13.04
Status in OpenLP:
Confirmed
** Changed in: openlp
Status: New => In Progress
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1612187
Title:
Changing shortcut to a key that is already used produces traceback
Status in Ope
** Changed in: openlp
Status: New => In Progress
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1616441
Title:
Missing in String
Status in OpenLP:
In Progress
Bug description:
In openlp
** Changed in: openlp
Status: New => In Progress
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1497637
Title:
Escape item does not work with .ppt or .odp
Status in OpenLP:
In Progress
Bug
** Changed in: openlp
Status: Confirmed => In Progress
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1557579
Title:
Make the song-footer text "Written by" optional
Status in OpenLP:
In Pro
** Changed in: openlp
Status: New => In Progress
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1623631
Title:
Add "Full License" field for Bibles
Status in OpenLP:
In Progress
Bug descrip
Should note that I've not tested this
--
https://code.launchpad.net/~suutari-olli/openlp/change-blank-to-desktop-hotkey-to-esc/+merge/305465
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Po
Looks good, just one question (see my in line comment).
Also don't forget to regenerate the resource file and submit it in a separate
merge request (after this one has gone in)
Diff comments:
>
> === modified file 'openlp/core/ui/shortcutlistform.py'
> --- openlp/core/ui/shortcutlistform.py
Review: Approve
Looks ok to me, but I've not tested it!
--
https://code.launchpad.net/~tomasgroth/openlp/25bugfixes5/+merge/306676
Your team OpenLP Core is requested to review the proposed merge of
lp:~tomasgroth/openlp/25bugfixes5 into lp:openlp.
___
Still missing tests for your new module. Guess its up to superfly if he's happy
with that.
Also, just a few inline comments
Diff comments:
>
> === added file 'openlp/plugins/songs/reporting.py'
> --- openlp/plugins/songs/reporting.py 1970-01-01 00:00:00 +
> +++ openlp/plugins/songs/reporti
Review: Approve
Looks good! Thanks for the extra effort!
--
https://code.launchpad.net/~suutari-olli/openlp/fix-advanced-bible-search-clear-button-giving-focus-to-quick/+merge/306037
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing
your test 'test_on_lock_button_toggled_search_tab' is only really testing the
last two lines of on_lock_button_toggled
As, you've gone to all the trouble of setting this test up it would be easy to
test the if condition which sets the appropriate icon. In your current test add:
# GIVEN:
See my inline comments about your test doc stings and comments.
And also see my inline comments with regard to the Unicode literals. They're
not required, and seem only to be implemented to ease porting from py2!
https://www.python.org/dev/peps/pep-0414/#proposal
Are there any tests for the new
Review: Needs Fixing
on_lock_button_toggled is such a small method, any changes of tests for that?
Also can you include the parameters in the doc string please. (See inline
comments)
Diff comments:
>
> === modified file 'openlp/plugins/bibles/lib/mediaitem.py'
> --- openlp/plugins/bibles/lib/
> Sorry one small change needed.
Any chance you can let this one slide? I'm not going to be in a position to
correct this for a week. I'll sort it in my next round of Bible refractors if
that's ok with you? Unless tgc or superfly pick up on something else!
--
https://code.la
Found in pluginmanager.py
https://bazaar.launchpad.net/~openlp-core/openlp/trunk/view/head:/openlp/core/lib/pluginmanager.py#L26
On Mon, 5 Sep 2016 at 18:10 Raoul Snyman wrote:
> Interesting. Thought we were already using importlib. Easy to change.
>
> --
> You received this bug notification bec
Public bug reported:
"Deprecated since version 3.4: The imp package is pending deprecation in favor
of importlib."
-https://docs.python.org/3/library/imp.html
** Affects: openlp
Importance: Low
Status: Confirmed
** Changed in: openlp
Importance: Undecided => Low
** Changed in:
gt;
> We tried to change this test to use @patch with phill, but failed.
I spent a couple hours on this and couldn't figure it out.
media_item.list_view is set in a super class
media_item.quick_search_edit is set in a method called from _setup which is
patched
All from memory that is.
--
h
The proposal to merge lp:~phill-ridout/openlp/yet-more-refactors into lp:openlp
has been updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~phill-ridout/openlp/yet-more-refactors/+merge/303497
--
Your team OpenLP Core is subscribed
Public bug reported:
Trunk r2695
Click on the red cross on the toolbar of the bibles tab in the media manager.
A pop up appears to confirm the deletion. The "Yes" button receives by default.
This should be "no" by default.
** Affects: openlp
Importance: Undecided
Status: New
** At
Phill has proposed merging lp:~phill-ridout/openlp/yet-more-refactors into
lp:openlp.
Commit message:
OpenSongBible refactors
Requested reviews:
Raoul Snyman (raoul-snyman)
For more details, see:
https://code.launchpad.net/~phill-ridout/openlp/yet-more-refactors/+merge/303497
More refactors
The proposal to merge lp:~phill-ridout/openlp/yet-more-refactors into lp:openlp
has been updated.
Status: Needs review => Superseded
For more details, see:
https://code.launchpad.net/~phill-ridout/openlp/yet-more-refactors/+merge/303490
--
Your team OpenLP Core is subscribed to bra
501 - 600 of 1994 matches
Mail list logo
