Review: Approve
--
https://code.launchpad.net/~springermac/openlp/bzr-tag-test/+merge/215754
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
The proposal to merge lp:~springermac/openlp/bzr-tag-test into lp:openlp has
been updated.
Status: Approved = Merged
For more details, see:
https://code.launchpad.net/~springermac/openlp/bzr-tag-test/+merge/215754
--
https://code.launchpad.net/~springermac/openlp/bzr-tag-test/+merge/215754
Review: Approve
--
https://code.launchpad.net/~springermac/openlp/bzr-tag-test/+merge/214587
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
The proposal to merge lp:~springermac/openlp/bzr-tag-test into lp:openlp has
been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~springermac/openlp/bzr-tag-test/+merge/214587
--
The proposal to merge lp:~springermac/openlp/bzr-tag-test into lp:openlp has
been updated.
Status: Approved = Merged
For more details, see:
https://code.launchpad.net/~springermac/openlp/bzr-tag-test/+merge/214587
--
https://code.launchpad.net/~springermac/openlp/bzr-tag-test/+merge/214587
Jonathan Springer has proposed merging lp:~springermac/openlp/bzr-tag-test into
lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~springermac/openlp/bzr-tag-test/+merge/215751
Fix bzr tag test to handle being run from different
Jonathan Springer has proposed merging lp:~springermac/openlp/bzr-tag-test into
lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~springermac/openlp/bzr-tag-test/+merge/215754
Fix bzt tag test to handle being run from a different
Review: Approve
--
https://code.launchpad.net/~springermac/openlp/bzr-tag-test/+merge/214587
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Review: Needs Information
Please run the tests (you can use the script in
trunk/scripts/jenkins_script.py). This is always needed (even tough you just
added a test). This is because we also have a job which tests if your code is
pep8 compliant).
Otherwise you consider this APPROVED.
A side
[SUCCESS] http://ci.openlp.org/job/Branch-01-Pull/243/
[SUCCESS] http://ci.openlp.org/job/Branch-02-Functional-Tests/204/
[SUCCESS] http://ci.openlp.org/job/Branch-03-Interface-Tests/153/
[FAILURE] http://ci.openlp.org/job/Branch-04-Windows_Tests/114/ # No bzr
installed in wine on the ci server
Jonathan Springer has proposed merging lp:~springermac/openlp/bzr-tag-test into
lp:openlp.
Requested reviews:
Andreas Preikschat (googol)
For more details, see:
https://code.launchpad.net/~springermac/openlp/bzr-tag-test/+merge/214467
Add test to check for proper tags on the current branch.
Changes this back to a white list as that made the most sense as we only what
approved tags and no others.
--
https://code.launchpad.net/~springermac/openlp/bzr-tag-test/+merge/214467
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Review: Approve
I approve this. I don't know if it should be in another place... that's up to
the others
--
https://code.launchpad.net/~springermac/openlp/bzr-tag-test/+merge/210735
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing
A white list would trap any incorrect values.
The list could be updated apart of the release tag process.
--
https://code.launchpad.net/~springermac/openlp/bzr-tag-test/+merge/210735
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing
A blacklist in this case would be better than a whitelist. The only tags we
currently don't want to see are 2.2.2 and help.
But I like the idea. It should help us catch them if they slip through.
--
https://code.launchpad.net/~springermac/openlp/bzr-tag-test/+merge/210735
Your team OpenLP Core
Where should this test go?
I didn't put this test in the functional or interface tests because it doesn't
test OpenLP's code. Problem is currently Jenkins only run the tests in the
functional and interfaces folders so this test wouldn't be run where it is.
--
could this be a pre commit bzr hook so we cannot commit rubbish tags to trunk?
--
https://code.launchpad.net/~springermac/openlp/bzr-tag-test/+merge/210735
Your team OpenLP Core is requested to review the proposed merge of
lp:~springermac/openlp/bzr-tag-test into lp:openlp.
Jonathan Springer has proposed merging lp:~springermac/openlp/bzr-tag-test into
lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~springermac/openlp/bzr-tag-test/+merge/210735
Add test to check for proper tags on the current branch.
--
This may be going in the wrong direction or may be done wrong but it seemed
like a good idea so feedback is welcome.
--
https://code.launchpad.net/~springermac/openlp/bzr-tag-test/+merge/210735
Your team OpenLP Core is requested to review the proposed merge of
19 matches
Mail list logo
