Review: Approve
--
https://code.launchpad.net/~suutari-olli/openlp/change-blank-to-desktop-hotkey-to-esc/+merge/308660
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to :
Review: Approve
--
https://code.launchpad.net/~suutari-olli/openlp/change-blank-to-desktop-hotkey-to-esc/+merge/308660
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to :
Review: Needs Fixing
Sorry conflicts with trunk.
--
https://code.launchpad.net/~suutari-olli/openlp/change-blank-to-desktop-hotkey-to-esc/+merge/307572
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list:
Review: Approve
--
https://code.launchpad.net/~suutari-olli/openlp/change-blank-to-desktop-hotkey-to-esc/+merge/307572
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to :
Review: Approve
--
https://code.launchpad.net/~suutari-olli/openlp/change-blank-to-desktop-hotkey-to-esc/+merge/307572
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to :
I've spoke to superfly, and he's happy with you adding the \n so looks good to
me!
--
https://code.launchpad.net/~suutari-olli/openlp/change-blank-to-desktop-hotkey-to-esc/+merge/305465
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Looks good, just one question (see my in line comment).
Also don't forget to regenerate the resource file and submit it in a separate
merge request (after this one has gone in)
Diff comments:
>
> === modified file 'openlp/core/ui/shortcutlistform.py'
> --- openlp/core/ui/shortcutlistform.py
A new blank-only shortcut sounds great to me :-)
--
https://code.launchpad.net/~suutari-olli/openlp/change-blank-to-desktop-hotkey-to-esc/+merge/303995
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list:
> Looks good to me!
> The only thing that nags me is that pressing Esc will also unblank. In my
> perception of the world Esc should only exit something - not bring it back!
> If Tim and Raoul thinks it fine as it is, feel free to ignore me...
Good point which I hadn't thought of before.
Perhaps
Review: Needs Information
Looks good to me!
The only thing that nags me is that pressing Esc will also unblank. In my
perception of the world Esc should only exit something - not bring it back!
If Tim and Raoul thinks it fine as it is, feel free to ignore me...
--
Review: Needs Fixing
See below and tests would be nice.
Diff comments:
>
> === modified file 'openlp/core/ui/shortcutlistform.py'
> --- openlp/core/ui/shortcutlistform.py2016-05-20 16:22:06 +
> +++ openlp/core/ui/shortcutlistform.py2016-08-14 21:23:25 +
> @@ -430,7
11 matches
Mail list logo
