Azaziah has proposed merging
lp:~suutari-olli/openlp/fix-advanced-bible-search-clear-button-giving-focus-to-quick
into lp:openlp.
Requested reviews:
Tim Bentley (trb143)
Raoul Snyman (raoul-snyman)
Phill (phill-ridout)
For more details, see:
It was my initial thought but I failed to set up the test within a reasonable
time.
Iv'e managed to increase the coverage by your instructions, thank you.
> your test 'test_on_lock_button_toggled_search_tab' is only really testing the
> last two lines of on_lock_button_toggled
>
> As, you've
The proposal to merge
lp:~suutari-olli/openlp/fix-advanced-bible-search-clear-button-giving-focus-to-quick
into lp:openlp has been updated.
Status: Needs review => Superseded
For more details, see:
The proposal to merge
lp:~suutari-olli/openlp/fix-advanced-bible-search-clear-button-giving-focus-to-quick
into lp:openlp has been updated.
Status: Needs review => Superseded
For more details, see:
your test 'test_on_lock_button_toggled_search_tab' is only really testing the
last two lines of on_lock_button_toggled
As, you've gone to all the trouble of setting this test up it would be easy to
test the if condition which sets the appropriate icon. In your current test add:
# GIVEN:
Public bug reported:
When data folder was moved from E: to D:, the following traceback
appears on startup after a few "Missing DB messages.
Trunk 2696 | Win 10
Traceback (most recent call last):
File "openlp.py", line 44, in
main()
File "D:\bzr\openlp\trunk\openlp\core\__init__.py",
6 matches
Mail list logo
