Re: [Openlp-core] [Merge] lp:~phill-ridout/openlp/1194610 into lp:openlp

2013-08-17 Thread Oliver Wieland
Why do you check the charset each time? Line 14 changed to data = unicode( song_data.read(length_descriptor), chardet.detect(data)['encoding'] ) should be enough -- https://code.launchpad.net/~phill-ridout/openlp/1194610/+merge/178456 Your team OpenLP Core is subscribed to branch lp:openlp.

[Openlp-core] [Merge] lp:~phill-ridout/openlp/1213254_2.0 into lp:openlp/2.0

2013-08-17 Thread Phill
Phill has proposed merging lp:~phill-ridout/openlp/1213254_2.0 into lp:openlp/2.0. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~phill-ridout/openlp/1213254_2.0/+merge/180683 Fix the importing of some OpenLP 1 databases by filtering out

[Openlp-core] [Bug 1213254] Re: OpenLP 1 database importer crashes when encountering control chars

2013-08-17 Thread Phill
** Branch linked: lp:~phill-ridout/openlp/1213254_2.0 ** Changed in: openlp/2.0 Importance: Undecided = Medium ** Changed in: openlp/2.0 Assignee: (unassigned) = Phill (phill-ridout) -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to

[Openlp-core] [Merge] lp:~phill-ridout/openlp/1209515_2.0 into lp:openlp/2.0

2013-08-17 Thread Phill
Phill has proposed merging lp:~phill-ridout/openlp/1209515_2.0 into lp:openlp/2.0. Requested reviews: Phill (phill-ridout) Raoul Snyman (raoul-snyman) Andreas Preikschat (googol) Related bugs: Bug #1209515 in OpenLP: getFileNames corrupts file names that use special chars

Re: [Openlp-core] [Merge] lp:~phill-ridout/openlp/1211913_2.0 into lp:openlp/2.0

2013-08-17 Thread Phill
Should the strings be u' Tim, I would say no. The data is apparently stored in us-ascii. The importer does unicode(data, self.encoding) where self.encoding is us-ascii. Unless somebody else knows better? -- https://code.launchpad.net/~phill-ridout/openlp/1211913_2.0/+merge/180234 Your team

Re: [Openlp-core] [Merge] lp:~phill-ridout/openlp/1194610 into lp:openlp

2013-08-17 Thread Phill
Why do you check the charset each time? Line 14 changed to data = unicode( song_data.read(length_descriptor), chardet.detect(data)['encoding'] ) should be enough This would not work, because the length descriptor has no encoding. It is a byte of which the binary value specifies the

Re: [Openlp-core] [Bug 1211049] Re: Can no long download bible verses

2013-08-17 Thread JerryP40
The page loaded immediately. This has been my work around, I highlight the versus I need, copy them, then paste them into a custom slide. A little editing to make them friendly with my projection scheme and I am good to go. It is just much easier to click on the bible tab, tell it what I

Re: [Openlp-core] [Bug 1211049] Re: Can no long download bible verses

2013-08-17 Thread JerryP40
I just now started OpenLP, clicked on bibles and was able to do a search for Genesis 15:1-6 successfully. I will try others but I am sure they will work also. Thanks again for your help. Gherel E Platis On 8/15/2013 16:26 PM, Raoul Snyman wrote: Can you try visiting

Re: [Openlp-core] [Merge] lp:~phill-ridout/openlp/1194610_2.0 into lp:openlp/2.0

2013-08-17 Thread Raoul Snyman
Review: Approve -- https://code.launchpad.net/~phill-ridout/openlp/1194610_2.0/+merge/180662 Your team OpenLP Core is subscribed to branch lp:openlp/2.0. ___ Mailing list: https://launchpad.net/~openlp-core Post to :

Re: [Openlp-core] [Merge] lp:~phill-ridout/openlp/1194610_2.0 into lp:openlp/2.0

2013-08-17 Thread Tim Bentley
Review: Needs Information Retrieve_windows_encoding is not used? -- https://code.launchpad.net/~phill-ridout/openlp/1194610_2.0/+merge/180662 Your team OpenLP Core is subscribed to branch lp:openlp/2.0. ___ Mailing list:

Re: [Openlp-core] [Merge] lp:~phill-ridout/openlp/1194610_2.0 into lp:openlp/2.0

2013-08-17 Thread Phill
Retrieve_windows_encoding is not used? It was, but the Raoul told me to: Fall back to cp1252 (https://code.launchpad.net/~phill-ridout/openlp/1194610_2.0/+merge/17/comments/406874) -- https://code.launchpad.net/~phill-ridout/openlp/1194610_2.0/+merge/180662 Your team OpenLP Core is