Re: [Openlp-core] [Merge] lp:~thelinuxguy/openlp/change-dropdown-to-checkbox into lp:openlp

2016-01-03 Thread Simon Hanna
I created a MR for the static methods here: https://code.launchpad.net/~thelinuxguy/openlp/make-methods-static/+merge/281488 -- https://code.launchpad.net/~thelinuxguy/openlp/change-dropdown-to-checkbox/+merge/281481 Your team OpenLP Core is subscribed to branch lp:openlp.

[Openlp-core] [Merge] lp:~thelinuxguy/openlp/make-methods-static into lp:openlp

2016-01-03 Thread Simon Hanna
Simon Hanna has proposed merging lp:~thelinuxguy/openlp/make-methods-static into lp:openlp. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~thelinuxguy/openlp/make-methods-static/+merge/281488 Make some methods static where possible Add

[Openlp-core] [Bug 1530598] [NEW] Contextmenu is shown over live view

2016-01-02 Thread Simon Hanna
Public bug reported: Setup: OpenLP is running fullscreen and the external screen is extended to the right. Show anything on the projector. Running on Linux but I doubt this makes a difference If you rightclick any entry in the ServiceManager and descend into "Auto play slides" or "Change item

[Openlp-core] [Bug 1530599] Re: No text on the buttons in Library Plasma 5.5

2016-01-02 Thread Simon Hanna
** Attachment added: "working screenshot" https://bugs.launchpad.net/openlp/+bug/1530599/+attachment/4543325/+files/openlp2.jpg -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1530599 Title: No

[Openlp-core] [Bug 1530599] [NEW] No text on the buttons in Library Plasma 5.5

2016-01-02 Thread Simon Hanna
Public bug reported: The buttons "Songs", "Bibles", "Presentations", etc have no text when running on plasma 5.5.1 Note using openbox on the same computer renders everything fine. ** Affects: openlp Importance: Undecided Status: New ** Attachment added: "broken screenshot"

[Openlp-core] [Bug 1530597] [NEW] Importing Songbeamer songs using latin1 encoding doesn't get decoded correctly

2016-01-02 Thread Simon Hanna
Public bug reported: When exporting Songbeamer songs from Windows and then importing them on Linux, the encoding of the songs is latin1. During the import OpenLP seems to assume they are UTF-8. This works for "normal" characters but breaks for german "Umlaute" ** Affects: openlp

[Openlp-core] [Bug 1530597] Re: Importing Songbeamer songs using latin1 encoding doesn't get decoded correctly

2016-01-02 Thread Simon Hanna
It looks like chardet is the culprit that detects the file being MacCyrillic -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1530597 Title: Importing Songbeamer songs using latin1 encoding doesn't

[Openlp-core] [Merge] lp:~thelinuxguy/openlp/strip-whitespace-from-titles-songbeamer-import into lp:openlp

2016-01-02 Thread Simon Hanna
Simon Hanna has proposed merging lp:~thelinuxguy/openlp/strip-whitespace-from-titles-songbeamer-import into lp:openlp. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~thelinuxguy/openlp/strip-whitespace-from-titles-songbeamer-import/+merge

[Openlp-core] [Bug 1530597] Re: Importing Songbeamer songs using latin1 encoding doesn't get decoded correctly

2016-01-02 Thread Simon Hanna
turns out it is a registered bug in chardet https://github.com/chardet/chardet/issues/24 -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1530597 Title: Importing Songbeamer songs using latin1

Re: [Openlp-core] [Merge] lp:~thelinuxguy/openlp/strip-whitespace-from-titles-songbeamer-import into lp:openlp

2016-01-03 Thread Simon Hanna
technically speaking I added a test using the space, but I can add another too. (It just takes me more time to look for something to test, than the other code) -- https://code.launchpad.net/~thelinuxguy/openlp/strip-whitespace-from-titles-songbeamer-import/+merge/281476 Your team OpenLP Core is

[Openlp-core] [Merge] lp:~thelinuxguy/openlp/change-dropdown-to-checkbox into lp:openlp

2016-01-03 Thread Simon Hanna
Simon Hanna has proposed merging lp:~thelinuxguy/openlp/change-dropdown-to-checkbox into lp:openlp. Requested reviews: OpenLP Core (openlp-core) Related bugs: Bug #1530073 in OpenLP: "Dropdown in 'Manage plugins' should be a checkbox" https://bugs.launchpad.net/openlp/+b

[Openlp-core] [Bug 1530073] Re: Dropdown in 'Manage plugins' should be a checkbox

2016-01-03 Thread Simon Hanna
** Branch linked: lp:~thelinuxguy/openlp/change-dropdown-to-checkbox -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1530073 Title: Dropdown in 'Manage plugins' should be a checkbox Status in

[Openlp-core] [Bug 1530598] Re: Contextmenu is shown over live view

2016-01-03 Thread Simon Hanna
Yes, it's kde and plasma. It doesn't occur when running openbox -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1530598 Title: Contextmenu is shown over live view Status in OpenLP: New Bug

[Openlp-core] [Bug 1530598] Re: Contextmenu is shown over live view

2016-01-03 Thread Simon Hanna
I just checked, other programs (chromium for instance) are not affected from this -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1530598 Title: Contextmenu is shown over live view Status in OpenLP:

[Openlp-core] [Bug 1530597] Re: Importing Songbeamer songs using latin1 encoding doesn't get decoded correctly

2016-01-06 Thread Simon Hanna
I have at least one song that uses utf-8 -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1530597 Title: Importing Songbeamer songs using latin1 encoding doesn't get decoded correctly Status in

[Openlp-core] [Merge] lp:~thelinuxguy/openlp/fix-delete-songs into lp:openlp

2016-01-07 Thread Simon Hanna
Simon Hanna has proposed merging lp:~thelinuxguy/openlp/fix-delete-songs into lp:openlp. Requested reviews: Tomas Groth (tomasgroth) For more details, see: https://code.launchpad.net/~thelinuxguy/openlp/fix-delete-songs/+merge/281852 CodecForTr was dropped in Qt5 The deletion of songs still

[Openlp-core] [Merge] lp:~thelinuxguy/openlp/fix-delete-songs into lp:openlp

2016-01-07 Thread Simon Hanna
The proposal to merge lp:~thelinuxguy/openlp/fix-delete-songs into lp:openlp has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~thelinuxguy/openlp/fix-delete-songs/+merge/281704 -- Your team OpenLP Core is subscribed to branch lp:openlp.

[Openlp-core] [Merge] lp:~thelinuxguy/openlp/fix-1510572 into lp:openlp

2015-12-29 Thread Simon Hanna
Simon Hanna has proposed merging lp:~thelinuxguy/openlp/fix-1510572 into lp:openlp. Requested reviews: OpenLP Core (openlp-core) Related bugs: Bug #1510572 in OpenLP: "Double verses at end of song shows as 1 on stageview" https://bugs.launchpad.net/openlp/+bug/1510572 For mo

[Openlp-core] [Merge] lp:~thelinuxguy/openlp/fix-1510572 into lp:openlp

2015-12-29 Thread Simon Hanna
The proposal to merge lp:~thelinuxguy/openlp/fix-1510572 into lp:openlp has been updated. Description changed to: Show double verses at the end of songs in stageview. They used to be hidden because the function checked to see if there are enough slides remaining. This is a simple off by one

[Openlp-core] [Bug 1510572] Re: Double verses at end of song shows as 1 on stageview

2015-12-29 Thread Simon Hanna
** Changed in: openlp Assignee: (unassigned) => Simon Hanna (thelinuxguy) -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1510572 Title: Double verses at end of song shows as 1 on stagev

[Openlp-core] [Bug 933277] Re: Song author system doesn't support single word authors, like bands

2016-01-09 Thread Simon Hanna
Are the first and last names actually used somewhere? (It might be the searching, I didn't check) Currently it is possible to add authors that only have one name. When adding authors from the song edit form, the form doesn't enforce more than one word. Adding one word there, just adds the text to

[Openlp-core] [Bug 1266270] Re: OpenLP hides dialogs whe using "play slides in loop" on OSX

2016-01-09 Thread Simon Hanna
Can someone confirm, that it's fixed in trunk? -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1266270 Title: OpenLP hides dialogs whe using "play slides in loop" on OSX Status in OpenLP:

[Openlp-core] [Bug 848316] Re: Highlight the current slide in the slidecontroller

2016-01-09 Thread Simon Hanna
For me this looks like it's fixed in trunk... -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/848316 Title: Highlight the current slide in the slidecontroller Status in OpenLP: Confirmed Bug

[Openlp-core] [Merge] lp:~thelinuxguy/openlp/make-methods-static into lp:openlp

2016-01-09 Thread Simon Hanna
Simon Hanna has proposed merging lp:~thelinuxguy/openlp/make-methods-static into lp:openlp. Requested reviews: Tim Bentley (trb143) Raoul Snyman (raoul-snyman) Tomas Groth (tomasgroth) For more details, see: https://code.launchpad.net/~thelinuxguy/openlp/make-methods-static/+merge/282098

[Openlp-core] [Merge] lp:~thelinuxguy/openlp/make-methods-static into lp:openlp

2016-01-09 Thread Simon Hanna
The proposal to merge lp:~thelinuxguy/openlp/make-methods-static into lp:openlp has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~thelinuxguy/openlp/make-methods-static/+merge/282098 -- Your team OpenLP Core is subscribed to branch

[Openlp-core] [Merge] lp:~thelinuxguy/openlp/make-methods-static into lp:openlp

2016-01-09 Thread Simon Hanna
Simon Hanna has proposed merging lp:~thelinuxguy/openlp/make-methods-static into lp:openlp. Requested reviews: Tim Bentley (trb143) Tomas Groth (tomasgroth) Raoul Snyman (raoul-snyman) For more details, see: https://code.launchpad.net/~thelinuxguy/openlp/make-methods-static/+merge/282107

[Openlp-core] [Merge] lp:~thelinuxguy/openlp/make-methods-static into lp:openlp

2016-01-09 Thread Simon Hanna
The proposal to merge lp:~thelinuxguy/openlp/make-methods-static into lp:openlp has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~thelinuxguy/openlp/make-methods-static/+merge/282096 -- Your team OpenLP Core is subscribed to branch

[Openlp-core] [Merge] lp:~thelinuxguy/openlp/make-methods-static into lp:openlp

2016-01-09 Thread Simon Hanna
Simon Hanna has proposed merging lp:~thelinuxguy/openlp/make-methods-static into lp:openlp. Requested reviews: Raoul Snyman (raoul-snyman) Tomas Groth (tomasgroth) For more details, see: https://code.launchpad.net/~thelinuxguy/openlp/make-methods-static/+merge/282096 Make some methods

[Openlp-core] [Merge] lp:~thelinuxguy/openlp/strip-whitespace-from-titles-songbeamer-import into lp:openlp

2016-01-09 Thread Simon Hanna
Simon Hanna has proposed merging lp:~thelinuxguy/openlp/strip-whitespace-from-titles-songbeamer-import into lp:openlp. Requested reviews: Tim Bentley (trb143) For more details, see: https://code.launchpad.net/~thelinuxguy/openlp/strip-whitespace-from-titles-songbeamer-import/+merge/282097

[Openlp-core] [Merge] lp:~thelinuxguy/openlp/make-methods-static into lp:openlp

2016-01-09 Thread Simon Hanna
The proposal to merge lp:~thelinuxguy/openlp/make-methods-static into lp:openlp has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~thelinuxguy/openlp/make-methods-static/+merge/281997 -- Your team OpenLP Core is subscribed to branch

[Openlp-core] [Merge] lp:~thelinuxguy/openlp/strip-whitespace-from-titles-songbeamer-import into lp:openlp

2016-01-09 Thread Simon Hanna
The proposal to merge lp:~thelinuxguy/openlp/strip-whitespace-from-titles-songbeamer-import into lp:openlp has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~thelinuxguy/openlp/strip-whitespace-from-titles-songbeamer-import/+merge/282037

Re: [Openlp-core] [Merge] lp:~thelinuxguy/openlp/change-dropdown-to-checkbox into lp:openlp

2016-01-09 Thread Simon Hanna
I just checked, when a plugin is disabled (you can just replace the songs.sqlite with a normal file) The whole entry becomes disabled. So there really is no reason for the dropdown. Currently the branch throws an Exception when a plugin is disabled, but that can be fixed. What do you think? --

[Openlp-core] [Merge] lp:~thelinuxguy/openlp/fix-song-import into lp:openlp

2016-01-09 Thread Simon Hanna
Simon Hanna has proposed merging lp:~thelinuxguy/openlp/fix-song-import into lp:openlp. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~thelinuxguy/openlp/fix-song-import/+merge/282108 Fix SongImport Ignore Case for versetags when importing

[Openlp-core] [Merge] lp:~thelinuxguy/openlp/make-methods-static into lp:openlp

2016-01-05 Thread Simon Hanna
The proposal to merge lp:~thelinuxguy/openlp/make-methods-static into lp:openlp has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~thelinuxguy/openlp/make-methods-static/+merge/281488 -- Your team OpenLP Core is subscribed to branch

[Openlp-core] [Merge] lp:~thelinuxguy/openlp/make-methods-static into lp:openlp

2016-01-05 Thread Simon Hanna
Simon Hanna has proposed merging lp:~thelinuxguy/openlp/make-methods-static into lp:openlp. Requested reviews: Raoul Snyman (raoul-snyman) For more details, see: https://code.launchpad.net/~thelinuxguy/openlp/make-methods-static/+merge/281702 Make some methods static where possible Move some

[Openlp-core] [Merge] lp:~thelinuxguy/openlp/fix-1490184 into lp:openlp

2016-01-05 Thread Simon Hanna
Simon Hanna has proposed merging lp:~thelinuxguy/openlp/fix-1490184 into lp:openlp. Requested reviews: Tomas Groth (tomasgroth) Tim Bentley (trb143) Related bugs: Bug #1490184 in OpenLP: "‘?’ help buttons not working" https://bugs.launchpad.net/openlp/+bug/1490184 For more de

[Openlp-core] [Merge] lp:~thelinuxguy/openlp/fix-1490184 into lp:openlp

2016-01-05 Thread Simon Hanna
The proposal to merge lp:~thelinuxguy/openlp/fix-1490184 into lp:openlp has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~thelinuxguy/openlp/fix-1490184/+merge/281428 -- Your team OpenLP Core is subscribed to branch lp:openlp.

Re: [Openlp-core] [Merge] lp:~thelinuxguy/openlp/change-dropdown-to-checkbox into lp:openlp

2016-01-03 Thread Simon Hanna
But the third state doesn't allow the user to change anything. I guess the third state could be emulated by either disabling the checkbox or replacing it with a label saying it's missing a dependency. About the change to about: I only changed about because I was looking for something to test and

Re: [Openlp-core] [Merge] lp:~thelinuxguy/openlp/change-dropdown-to-checkbox into lp:openlp

2016-01-03 Thread Simon Hanna
and replacing it with a label? -- https://code.launchpad.net/~thelinuxguy/openlp/change-dropdown-to-checkbox/+merge/281481 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to :

Re: [Openlp-core] [Merge] lp:~thelinuxguy/openlp/fix-delete-songs into lp:openlp

2016-01-05 Thread Simon Hanna
turns out custom slides did as well... nothing else does (checked using grep) -- https://code.launchpad.net/~thelinuxguy/openlp/fix-delete-songs/+merge/281704 Your team OpenLP Core is requested to review the proposed merge of lp:~thelinuxguy/openlp/fix-delete-songs into lp:openlp.

[Openlp-core] [Merge] lp:~thelinuxguy/openlp/fix-delete-songs into lp:openlp

2016-01-05 Thread Simon Hanna
Simon Hanna has proposed merging lp:~thelinuxguy/openlp/fix-delete-songs into lp:openlp. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~thelinuxguy/openlp/fix-delete-songs/+merge/281704 CodecForTr was dropped in Qt5 The deletion of songs

Re: [Openlp-core] [Merge] lp:~thelinuxguy/openlp/fix-1490184 into lp:openlp

2015-12-30 Thread Simon Hanna
It's not the greatest test, it's the first I found, that I knew I would be able to write a test for -- https://code.launchpad.net/~thelinuxguy/openlp/fix-1490184/+merge/281428 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list:

Re: [Openlp-core] [Merge] lp:~thelinuxguy/openlp/strip-whitespace-from-titles-songbeamer-import into lp:openlp

2016-01-08 Thread Simon Hanna
I hope I did it right -- https://code.launchpad.net/~thelinuxguy/openlp/strip-whitespace-from-titles-songbeamer-import/+merge/282037 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to

Re: [Openlp-core] [Merge] lp:~thelinuxguy/openlp/make-methods-static into lp:openlp

2016-01-08 Thread Simon Hanna
I hope this did it -- https://code.launchpad.net/~thelinuxguy/openlp/make-methods-static/+merge/281997 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to :

[Openlp-core] [Bug 1530073] [NEW] Dropdown in 'Manage plugins' should be a checkbox

2015-12-30 Thread Simon Hanna
Public bug reported: In 'Manage Plugins' the state of a plugin can be changed used a dropdown. Since it's only a true or false setting, this should be replaced with a checkbox or something like the on-off toggles of android/ios ** Affects: openlp Importance: Undecided Status: New

[Openlp-core] [Bug 1510572] Re: Double verses at end of song shows as 1 on stageview

2015-12-30 Thread Simon Hanna
** Changed in: openlp Status: Confirmed => In Progress -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1510572 Title: Double verses at end of song shows as 1 on stageview Status in OpenLP:

[Openlp-core] [Merge] lp:~thelinuxguy/openlp/fix-1490184 into lp:openlp

2015-12-30 Thread Simon Hanna
Simon Hanna has proposed merging lp:~thelinuxguy/openlp/fix-1490184 into lp:openlp. Requested reviews: OpenLP Core (openlp-core) Related bugs: Bug #1490184 in OpenLP: "‘?’ help buttons not working" https://bugs.launchpad.net/openlp/+bug/1490184 For more details,

[Openlp-core] [Bug 1490184] Re: ‘?’ help buttons not working

2015-12-30 Thread Simon Hanna
** Changed in: openlp Status: New => In Progress ** Changed in: openlp Assignee: (unassigned) => Simon Hanna (thelinuxguy) -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1490184

[Openlp-core] [Merge] lp:~thelinuxguy/openlp/make-methods-static into lp:openlp

2016-01-08 Thread Simon Hanna
The proposal to merge lp:~thelinuxguy/openlp/make-methods-static into lp:openlp has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~thelinuxguy/openlp/make-methods-static/+merge/281857 -- Your team OpenLP Core is subscribed to branch

Re: [Openlp-core] [Merge] lp:~thelinuxguy/openlp/make-methods-static into lp:openlp

2016-01-08 Thread Simon Hanna
Note this also fixes a bug in trunk: Dragging items to the serviceManager results in an Exception, So it should be merged before the next release -- https://code.launchpad.net/~thelinuxguy/openlp/make-methods-static/+merge/281857 Your team OpenLP Core is subscribed to branch lp:openlp.

[Openlp-core] [Bug 1532193] [NEW] Typos in songusageplugin.py

2016-01-08 Thread Simon Hanna
Public bug reported: the __default_settings__ in songusageplugin.py have some typos sometimes 'songusage' is spelled 'songuasge' ** Affects: openlp Importance: Undecided Status: New -- You received this bug notification because you are a member of OpenLP Core, which is

[Openlp-core] [Bug 1532169] [NEW] Expanding or Collapsing a Song in ServiceManager raises an Exception

2016-01-08 Thread Simon Hanna
Public bug reported: When expanding or Collapsing a Song in ServiceManager a IndexError occurs. This only happens when using the buttons in the Service Manager. I guess the error occurs because of the -1 when accessing the items. However the -1 is being used 5 times all over the class. I'm not

[Openlp-core] [Merge] lp:~thelinuxguy/openlp/make-methods-static into lp:openlp

2016-01-08 Thread Simon Hanna
Simon Hanna has proposed merging lp:~thelinuxguy/openlp/make-methods-static into lp:openlp. Requested reviews: Raoul Snyman (raoul-snyman) Tomas Groth (tomasgroth) For more details, see: https://code.launchpad.net/~thelinuxguy/openlp/make-methods-static/+merge/281997 Make some methods

Re: [Openlp-core] [Merge] lp:~thelinuxguy/openlp/rework-remote into lp:openlp

2016-01-12 Thread Simon Hanna
Yeah, I didn't think it would make into 2.4 I'm not so good with webdesign, so if someone wants to write a theme to have something other than the default look, go ahead! -- https://code.launchpad.net/~thelinuxguy/openlp/rework-remote/+merge/282342 Your team OpenLP Core is requested to review

[Openlp-core] [Bug 1533401] [NEW] Remote plugin stays active until a restart

2016-01-12 Thread Simon Hanna
Public bug reported: Deactivating the remote plugin has no effect until OpenLP is restarted ** Affects: openlp Importance: Undecided Status: New -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP.

Re: [Openlp-core] [Merge] lp:~thelinuxguy/openlp/rework-remote into lp:openlp

2016-01-12 Thread Simon Hanna
fixed the buttons -- https://code.launchpad.net/~thelinuxguy/openlp/rework-remote/+merge/282342 Your team OpenLP Core is requested to review the proposed merge of lp:~thelinuxguy/openlp/rework-remote into lp:openlp. ___ Mailing list:

[Openlp-core] [Bug 1404669] Re: KDE Plasma 5 is breaking the look of OpenLP

2016-01-11 Thread Simon Hanna
** Branch linked: lp:~thelinuxguy/openlp/fix-stylesheet -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1404669 Title: KDE Plasma 5 is breaking the look of OpenLP Status in OpenLP: Confirmed Bug

[Openlp-core] [Merge] lp:~thelinuxguy/openlp/strip-whitespace-from-titles-songbeamer-import into lp:openlp

2016-01-08 Thread Simon Hanna
The proposal to merge lp:~thelinuxguy/openlp/strip-whitespace-from-titles-songbeamer-import into lp:openlp has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~thelinuxguy/openlp/strip-whitespace-from-titles-songbeamer-import/+merge/281476

[Openlp-core] [Merge] lp:~thelinuxguy/openlp/strip-whitespace-from-titles-songbeamer-import into lp:openlp

2016-01-08 Thread Simon Hanna
Simon Hanna has proposed merging lp:~thelinuxguy/openlp/strip-whitespace-from-titles-songbeamer-import into lp:openlp. Requested reviews: Tim Bentley (trb143) For more details, see: https://code.launchpad.net/~thelinuxguy/openlp/strip-whitespace-from-titles-songbeamer-import/+merge/282037

[Openlp-core] [Bug 1404669] Re: KDE Plasma 5 is breaking the look of OpenLP

2016-01-10 Thread Simon Hanna
I went asking on #kde and #qt about this issue: It's not a bug, it's a feature in plasma. If I got it right, plasma either displays the icons or the text, not both. This behavior can only be changed by having the users themselves edit their plasma configurations. My personal opinion that the

[Openlp-core] [Merge] lp:~thelinuxguy/openlp/make-methods-static into lp:openlp

2016-01-10 Thread Simon Hanna
Simon Hanna has proposed merging lp:~thelinuxguy/openlp/make-methods-static into lp:openlp. Requested reviews: Raoul Snyman (raoul-snyman) Tomas Groth (tomasgroth) Tim Bentley (trb143) For more details, see: https://code.launchpad.net/~thelinuxguy/openlp/make-methods-static/+merge/282119

[Openlp-core] [Merge] lp:~thelinuxguy/openlp/make-methods-static into lp:openlp

2016-01-10 Thread Simon Hanna
The proposal to merge lp:~thelinuxguy/openlp/make-methods-static into lp:openlp has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~thelinuxguy/openlp/make-methods-static/+merge/282107 -- Your team OpenLP Core is subscribed to branch

[Openlp-core] [Merge] lp:~thelinuxguy/openlp/fix-stylesheet into lp:openlp

2016-01-10 Thread Simon Hanna
Simon Hanna has proposed merging lp:~thelinuxguy/openlp/fix-stylesheet into lp:openlp. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~thelinuxguy/openlp/fix-stylesheet/+merge/282126 Reenable the stylesheet remove the icons from mediamanager so

[Openlp-core] [Merge] lp:~thelinuxguy/openlp/fix-remote into lp:openlp

2016-01-13 Thread Simon Hanna
Simon Hanna has proposed merging lp:~thelinuxguy/openlp/fix-remote into lp:openlp. Requested reviews: OpenLP Core (openlp-core) Related bugs: Bug #1533401 in OpenLP: "Remote plugin stays active until a restart" https://bugs.launchpad.net/openlp/+bug/1533401 For more details,

Re: [Openlp-core] [Merge] lp:~thelinuxguy/openlp/fix-remote into lp:openlp

2016-01-14 Thread Simon Hanna
This didn't happen to me. What exactly did you do? Are you running something other than linux? -- https://code.launchpad.net/~thelinuxguy/openlp/fix-remote/+merge/282447 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list:

[Openlp-core] [Merge] lp:~thelinuxguy/openlp/change-dropdown-to-checkbox into lp:openlp

2016-02-22 Thread Simon Hanna
Simon Hanna has proposed merging lp:~thelinuxguy/openlp/change-dropdown-to-checkbox into lp:openlp. Requested reviews: Tim Bentley (trb143) Related bugs: Bug #1530073 in OpenLP: "Dropdown in 'Manage plugins' should be a checkbox" https://bugs.launchpad.net/openlp/+bug/1530073

[Openlp-core] [Merge] lp:~thelinuxguy/openlp/change-dropdown-to-checkbox into lp:openlp

2016-02-22 Thread Simon Hanna
The proposal to merge lp:~thelinuxguy/openlp/change-dropdown-to-checkbox into lp:openlp has been updated. Description changed to: * Change the Combobox used for the state of plugins to a checkbox. * Do not show the plugins version numbers as they provide no additional information * Show the

[Openlp-core] [Bug 1536802] Re: Add "Launch remote" under "Tools" menu

2016-01-23 Thread Simon Hanna
Currenlty there is an icon that is displayed when the remote plugin is active. It would be nice to attach a context menu to it with options to open the different links -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP.

[Openlp-core] [Merge] lp:~thelinuxguy/openlp/skip-bzr-test into lp:openlp

2016-02-15 Thread Simon Hanna
Simon Hanna has proposed merging lp:~thelinuxguy/openlp/skip-bzr-test into lp:openlp. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~thelinuxguy/openlp/skip-bzr-test/+merge/286073 Currently testing the releases is failing because

Re: [Openlp-core] [Merge] lp:~thelinuxguy/openlp/skip-bzr-test into lp:openlp

2016-02-15 Thread Simon Hanna
I meant the released archives. I would like to enable tests in the process of building the package for archlinux. I know I could patch it, but I guess other distros also (should) run the testsuite -- https://code.launchpad.net/~thelinuxguy/openlp/skip-bzr-test/+merge/286073 Your team OpenLP

Re: [Openlp-core] [Merge] lp:~thelinuxguy/openlp/rework-remote into lp:openlp

2016-03-09 Thread Simon Hanna
I used bootstrap, because I'm familiar with it and get it done :-) Since there are mobile apps for android and ios, I thought that having the remote a responsive website makes it usable from computers (or just tablets with bigger screens). I think having the remote somewhat responsive is a

[Openlp-core] [Merge] lp:~thelinuxguy/openlp/change-dropdown-to-checkbox into lp:openlp

2016-05-17 Thread Simon Hanna
The proposal to merge lp:~thelinuxguy/openlp/change-dropdown-to-checkbox into lp:openlp has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~thelinuxguy/openlp/change-dropdown-to-checkbox/+merge/286812 -- Your team OpenLP Core is

[Openlp-core] [Merge] lp:~thelinuxguy/openlp/change-dropdown-to-checkbox into lp:openlp

2016-05-17 Thread Simon Hanna
The proposal to merge lp:~thelinuxguy/openlp/change-dropdown-to-checkbox into lp:openlp has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~thelinuxguy/openlp/change-dropdown-to-checkbox/+merge/294886 -- Your team OpenLP Core is

[Openlp-core] [Merge] lp:~thelinuxguy/openlp/change-dropdown-to-checkbox into lp:openlp

2016-05-17 Thread Simon Hanna
Simon Hanna has proposed merging lp:~thelinuxguy/openlp/change-dropdown-to-checkbox into lp:openlp. Requested reviews: Tim Bentley (trb143) Related bugs: Bug #1530073 in OpenLP: "Dropdown in 'Manage plugins' should be a checkbox" https://bugs.launchpad.net/openlp/+bug/1530073

Re: [Openlp-core] [Merge] lp:~thelinuxguy/openlp/rework-remote into lp:openlp

2016-07-22 Thread Simon Hanna
Ok, I got started with angular. All the fetching works like a charm. I have issues with posting though. It's because the current remote doesn't actually use post requests and there doesn't seem to be a nice way in angular2 to send data along a get request. Could this be changed along the

Re: [Openlp-core] [Merge] lp:~trb143/openlp/websockets into lp:openlp

2016-07-23 Thread Simon Hanna
Could you convert the polls to strings before sending them in websockets -> handle_websocket ? current_poll = str(current_poll, 'utf-8') main_poll = str(main_poll, 'utf-8') That way parsing them in js is straightforward -- https://code.launchpad.net/~trb143/openlp/websockets/+merge/296703 Your

Re: [Openlp-core] [Merge] lp:~thelinuxguy/openlp/rework-remote into lp:openlp

2016-07-23 Thread Simon Hanna
I'm tracking my work here https://github.com/simonsmiley/openlp-remote It currently requires Tim's branch (With a minor fix that's comented on his merge request) To get it running, clone the repo and run "npm install" followed by "npm start" you will need to enable cross origin resource

Re: [Openlp-core] [Merge] lp:~thelinuxguy/openlp/rework-remote into lp:openlp

2016-06-30 Thread Simon Hanna
So, after quite some time, I'm coming back to this :-) In the meantime I played around a little with material frameworks (materializecss.com) and also with angular. I don't think ionic is the way to go, because it's mainly targeting mobile phone displays. I would go for plain html with

[Openlp-core] [Bug 1659094] Re: Traceback on exit with py36

2017-01-26 Thread Simon Hanna
I can confirm this running on Archlinux using the same versions as mentioned above. ** Bug watch added: github.com/Flexget/Flexget/issues #1596 https://github.com/Flexget/Flexget/issues/1596 -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to

[Openlp-core] [Bug 1659094] Re: Traceback on exit with py36

2017-01-26 Thread Simon Hanna
It might be related to the following bug I found https://github.com/Flexget/Flexget/issues/1596#issuecomment-271146518 -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1659094 Title: Traceback on exit

[Openlp-core] [Bug 1616649] [NEW] Reason why song importers are disabled is unclear

2016-08-24 Thread Simon Hanna
Public bug reported: There are a couple of Song importers that are OS specific. Mediashout for instance has the following string hardcoded "... only supported on Windows. It has been disabled due to a missing python dependency ..." The error confused me because I had the dependencies installed.

[Openlp-core] [Bug 1675587] [NEW] Allow creating Custom Slides from Library

2017-03-23 Thread Simon Hanna
Public bug reported: Currently creating custom slides based on some item from the library is only supported, if it's added to a service. It would be nice if items that support this feature have it in the context-menu in the library itself. Based on issue reported in the forum

[Openlp-core] [Bug 1677262] [NEW] Two tests with same name

2017-03-29 Thread Simon Hanna
Public bug reported: In `tests/functional/openlp_plugins/songs/test_lib.py` two functions with the name `test_remove_typos_beginning_negated` exist. They are different, but I'm not sure if both are valid. One should be either removed or renamed. ** Affects: openlp Importance: Undecided

[Openlp-core] [Merge] lp:~thelinuxguy/openlp/backport-fix into lp:openlp/2.4

2017-03-29 Thread Simon Hanna
The proposal to merge lp:~thelinuxguy/openlp/backport-fix into lp:openlp/2.4 has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~thelinuxguy/openlp/backport-fix/+merge/321284 -- Your team OpenLP Core is subscribed to branch lp:openlp/2.4.

[Openlp-core] [Merge] lp:~thelinuxguy/openlp/backport-fix into lp:openlp/2.4

2017-03-29 Thread Simon Hanna
Simon Hanna has proposed merging lp:~thelinuxguy/openlp/backport-fix into lp:openlp/2.4. Requested reviews: Tim Bentley (trb143) For more details, see: https://code.launchpad.net/~thelinuxguy/openlp/backport-fix/+merge/321379 Backport songbeamer fix -- Your team OpenLP Core is subscribed

[Openlp-core] [Bug 1677152] [NEW] Why is all the projector stuff not a plugin?

2017-03-29 Thread Simon Hanna
Public bug reported: Shouldn't the projector stuff be a plugin so it can be enabled/disabled? I'm pretty sure a lot of churches don't have a compatible projector so they can't use it. ** Affects: openlp Importance: Undecided Status: New -- You received this bug notification

[Openlp-core] [Bug 1666006] Re: Song Editor alway saves theme

2017-03-29 Thread Simon Hanna
I can also confirm this is happening on 2.4.5 (archlinux) BUT it appears to be fixed in trunk -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1666006 Title: Song Editor alway saves theme Status in

[Openlp-core] [Merge] lp:~thelinuxguy/openlp/backport-fix into lp:openlp/2.4

2017-03-29 Thread Simon Hanna
Simon Hanna has proposed merging lp:~thelinuxguy/openlp/backport-fix into lp:openlp/2.4. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~thelinuxguy/openlp/backport-fix/+merge/321284 Backport songbeamer fix -- Your team OpenLP Core

Re: [Openlp-core] [Merge] lp:~thelinuxguy/openlp/website-fixes into lp:openlp/website

2017-03-17 Thread Simon Hanna
You're right, it can be removed. I don't think there are any conflicting elements... -- https://code.launchpad.net/~thelinuxguy/openlp/website-fixes/+merge/320184 Your team OpenLP Core is requested to review the proposed merge of lp:~thelinuxguy/openlp/website-fixes into lp:openlp/website.

[Openlp-core] [Merge] lp:~thelinuxguy/openlp/website-fixes into lp:openlp/website

2017-03-17 Thread Simon Hanna
Simon Hanna has proposed merging lp:~thelinuxguy/openlp/website-fixes into lp:openlp/website. Requested reviews: Raoul Snyman (raoul-snyman) For more details, see: https://code.launchpad.net/~thelinuxguy/openlp/website-fixes/+merge/320271 A fix for the social buttons appearing on more than

[Openlp-core] [Merge] lp:~thelinuxguy/openlp/website-fixes into lp:openlp/website

2017-03-17 Thread Simon Hanna
The proposal to merge lp:~thelinuxguy/openlp/website-fixes into lp:openlp/website has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~thelinuxguy/openlp/website-fixes/+merge/320184 -- Your team OpenLP Core is subscribed to branch

[Openlp-core] [Bug 1673113] [NEW] "Save & Preview" Button in Song Editor behaves in a strange way

2017-03-15 Thread Simon Hanna
Public bug reported: When you get to the Song Editor by pressing the "edit and reload song preview" button in the Preview Section, you get three button to process the form "Save & Preview", "Save" and "Cancel". My issue is with the first. Upon pressing it apparently nothing happens. The editor

[Openlp-core] [Bug 1673108] [NEW] Create New Custom Slide button is misleading

2017-03-15 Thread Simon Hanna
Public bug reported: In the context menu of items in the Service Manager there is an entry labeled "Create New Custom Slide". Upon pressing it you get no visual feedback (unless you happen to have the Custom slides open and see that something is added there) The other issue I have with it, is

[Openlp-core] [Merge] lp:~thelinuxguy/openlp/website-fixes into lp:openlp/website

2017-03-17 Thread Simon Hanna
Simon Hanna has proposed merging lp:~thelinuxguy/openlp/website-fixes into lp:openlp/website. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~thelinuxguy/openlp/website-fixes/+merge/320184 A fix for the social buttons appearing on more than one

[Openlp-core] [Merge] lp:~thelinuxguy/openlp/fix-encoding-songbeamer into lp:openlp

2017-03-13 Thread Simon Hanna
Simon Hanna has proposed merging lp:~thelinuxguy/openlp/fix-encoding-songbeamer into lp:openlp. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~thelinuxguy/openlp/fix-encoding-songbeamer/+merge/319685 Minor fix that makes sure that songbeamer

Re: [Openlp-core] [Merge] lp:~thelinuxguy/openlp/fix-encoding-songbeamer into lp:openlp

2017-03-13 Thread Simon Hanna
Btw. my remark on irc that it was "dumb" might have come over a little harsh. I meant it as a silly little mistake. :-) I don't want to know how many of those I had over the years... -- https://code.launchpad.net/~thelinuxguy/openlp/fix-encoding-songbeamer/+merge/319685 Your team OpenLP Core is

[Openlp-core] [Bug 1735765] [NEW] Launching OpenLP in portable mode results in a traceback

2017-12-01 Thread Simon Hanna
Public bug reported: Here is a traceback: ~/dev/openlp/trunk 27s env ❯ python openlp.py -p Traceback (most recent call last): File "openlp.py", line 60, in main() File "/home/sim/dev/openlp/trunk/openlp/core/app.py", line 409, in main settings.upgrade_settings() File

[Openlp-core] [Bug 1735766] [NEW] Launching Openlp with -w results in a traceback

2017-12-01 Thread Simon Hanna
Public bug reported: The traceback isn't shown on the command line but in a Bug report window. Here is the traceback: Traceback (most recent call last): File "openlp.py", line 60, in main() File "/home/sim/dev/openlp/trunk/openlp/core/app.py", line 425, in main

[Openlp-core] [Merge] lp:~thelinuxguy/openlp/fix-version-check into lp:openlp

2017-12-29 Thread Simon Hanna
Simon Hanna has proposed merging lp:~thelinuxguy/openlp/fix-version-check into lp:openlp. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~thelinuxguy/openlp/fix-version-check/+merge/335602 Fixed the version checking to be more robust * Strip

[Openlp-core] [Bug 1744553] Re: replace live background with image causes crash

2018-01-21 Thread Simon Hanna
hmm.. can't reproduce it again... But now it takes two clicks on replace live background to get it to actually replace it... -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1744553 Title: replace

  1   2   >