** Changed in: openlp/trunk
Status: In Progress => Fix Committed
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1600510
Title:
Deleting a songbook throws "song" attribute exception
Status in
** Changed in: openlp
Status: In Progress => Fix Committed
** Changed in: openlp
Milestone: None => 2.9.1
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1832942
Title:
version 2880
** Changed in: openlp
Status: In Progress => Fix Committed
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1673113
Title:
"Save & Preview" Button in Song Editor behaves in a strange way
** Changed in: openlp
Status: In Progress => Fix Committed
** Changed in: openlp
Milestone: None => 2.9.1
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1799005
Title:
Searching for
I'm not sure about this. This is the page that will show up on GitLab? Has it
been discussed in IRC? There seems to be some duplication with the wiki. Will
this be removed from the wiki?
--
https://code.launchpad.net/~johnmfl/openlp/developer_readme/+merge/371011
Your team OpenLP Core is
Phill has proposed merging lp:~phill-ridout/openlp/fixes-IV into lp:openlp.
Commit message:
Refactors and fixes
Requested reviews:
OpenLP Core (openlp-core)
Related bugs:
Bug #1600510 in OpenLP: "Deleting a songbook throws "song" attribute
exception"
https://bugs.launc
Review: Approve
--
https://code.launchpad.net/~trb143/openlp/alpha_fixes/+merge/370938
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Just a few more inline comments.
Diff comments:
> === modified file 'openlp/plugins/songs/lib/importer.py'
> --- openlp/plugins/songs/lib/importer.py 2019-04-13 13:00:22 +
> +++ openlp/plugins/songs/lib/importer.py 2019-07-28 08:47:32 +
> @@ -343,6 +345,15 @@
>
One more, sorry I didn't mention it earlier
Diff comments:
> === modified file 'openlp/core/common/settings.py'
> --- openlp/core/common/settings.py2019-06-21 20:53:42 +
> +++ openlp/core/common/settings.py2019-08-04 14:06:37 +
> @@ -90,12 +90,13 @@
> number: {
>
Review: Needs Fixing
See inlines
Diff comments:
>
> === modified file 'openlp/core/ui/mainwindow.py'
> --- openlp/core/ui/mainwindow.py 2019-07-01 22:36:14 +
> +++ openlp/core/ui/mainwindow.py 2019-08-04 08:10:26 +
> @@ -635,7 +635,8 @@
> # if
** Changed in: openlp/ftw-data
Status: New => Fix Released
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1320631
Title:
Need to run DB Migrations on example data
Status in OpenLP:
Invalid
** Changed in: openlp
Status: In Progress => Fix Released
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1694713
Title:
FRW themes are xml based
Status in OpenLP:
Fix Released
Bug
It appears this has been long supported. Tested with trunk and imports
fine.
** Changed in: openlp
Status: Confirmed => Fix Released
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1391015
This error is caused because we assume that the book name is the same as
that used in the url.
OpenLP gets the book name here:
https://bazaar.launchpad.net/~openlp-core/openlp/trunk/view/head:/openlp/plugins/bibles/lib/importers/http.py#L521
reading the content in the h4 tag, but in the case of
** Changed in: openlp
Status: New => Incomplete
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1701879
Title:
Import from OpenLP xml sometimes skips "-" inside text (non english
text)
Hi Maarts,
Which version of OpenLP is this and which file?
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1817433
Title:
fonts separated with white-spaces are not supported
Status in OpenLP:
New
** Changed in: openlp
Importance: Undecided => Wishlist
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1796506
Title:
Making listening network connections opt-in
Status in OpenLP:
Confirmed
Hi Derek,
Our forums are our primary place for support. If you are still having this
issue please submit a debug log.
Follow these instructions and try to recreate the issue.
http://manual.openlp.org/troubleshooting.html#linux-freebsd
--
You received this bug notification because you are a
Simotsa, have you resolved this issue? if not can you try deleting the
bible database file.
Open the data folder ( http://manual.openlp.org/faq.html#id4 ) open
bibles and delete the selected bible and try again.
--
You received this bug notification because you are a member of OpenLP
Core,
*** This bug is a duplicate of bug 1698021 ***
https://bugs.launchpad.net/bugs/1698021
99% Sure this is fixed in trunk...
** This bug has been marked a duplicate of bug 1698021
Copying and Pasting from Word inserts invalid characters
--
You received this bug notification because you are
** Changed in: openlp
Importance: Undecided => Wishlist
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1838558
Title:
Feature Request presentation thumbnail view
Status in OpenLP:
New
Bug
** Branch linked: lp:~raoul-snyman/openlp/webengine-migrate
** Changed in: openlp
Status: New => Fix Committed
** Changed in: openlp
Assignee: (unassigned) => Raoul Snyman (raoul-snyman)
** Changed in: openlp
Milestone: None => 2.9.1
--
You received this bug notification
There are quite a few instances of this bug in the support system all
appear to be on MacOS
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1674130
Title:
QAction object does not support indexing
** Changed in: openlp
Status: Confirmed => In Progress
** Changed in: openlp
Assignee: (unassigned) => Phill (phill-ridout)
** Changed in: openlp
Milestone: None => 2.9.1
--
You received this bug notification because you are a member of OpenLP
Core, which is s
I cannot seem to find this menu item. Is it still there in 3.0?
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1673108
Title:
Create New Custom Slide button is misleading
Status in OpenLP:
** Branch linked: lp:~raoul-snyman/openlp/fix-author-type-2.4
** Branch linked: lp:~raoul-snyman/openlp/fix-author_type
** Changed in: openlp
Status: New => Fix Committed
** Changed in: openlp
Assignee: (unassigned) => Raoul Snyman (raoul-snyman)
** Changed in: openlp
** Branch linked: lp:~phill-ridout/openlp/bible_media_item_refactors
** Changed in: openlp
Status: Confirmed => Fix Committed
** Changed in: openlp
Assignee: (unassigned) => Phill (phill-ridout)
** Changed in: openlp
Milestone: None => 2.9.1
--
You received
** Branch linked: lp:~tomasgroth/openlp/fix-theme-thumb
** Changed in: openlp
Status: Confirmed => Fix Committed
** Changed in: openlp
Assignee: (unassigned) => Tomas Groth (tomasgroth)
** Changed in: openlp
Milestone: None => 2.9.1
--
You received this bug notification
** Changed in: openlp/trunk
Status: Confirmed => In Progress
** Changed in: openlp/trunk
Assignee: (unassigned) => Phill (phill-ridout)
** Changed in: openlp/trunk
Milestone: None => 2.9.1
--
You received this bug notification because you are a member of OpenLP
Co
** Changed in: openlp
Status: New => In Progress
** Changed in: openlp
Importance: Undecided => Medium
** Changed in: openlp
Assignee: (unassigned) => Phill (phill-ridout)
--
You received this bug notification because you are a member of OpenLP
Core, which is s
** Branch linked: lp:~tomasgroth/openlp/portable-path
** Changed in: openlp
Assignee: (unassigned) => Tomas Groth (tomasgroth)
** Changed in: openlp
Milestone: None => 2.9.1
** Changed in: openlp
Status: Confirmed => Fix Committed
--
You received this bug notification because
** Changed in: openlp
Assignee: (unassigned) => Phill (phill-ridout)
** Changed in: openlp
Importance: Undecided => Low
** Changed in: openlp
Status: New => In Progress
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed
Hi Johnathan,
I can't reproduce this issue on trunk 2887.
Do you have a copy of the original database available? and the log file?
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1832954
Title:
** Changed in: openlp/trunk
Assignee: Phill (phill-ridout) => (unassigned)
** Changed in: openlp/trunk
Status: In Progress => New
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1
** Changed in: openlp/trunk
Status: In Progress => Fix Committed
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1095742
Title:
Portable apps storing drive letter in db
Status in OpenLP:
** Changed in: openlp
Assignee: Phill (phill-ridout) => (unassigned)
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1608024
Title:
DVD Media Time Stamps Not Working
Status in OpenLP:
** Branch linked: lp:~phill-ridout/openlp/ftw-update
** Changed in: openlp
Status: New => In Progress
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1694713
Title:
FRW themes are xml ba
** Branch linked: lp:~phill-ridout/openlp/ftw-update
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1320631
Title:
Need to run DB Migrations on example data
Status in OpenLP:
Invalid
Status
Phill has proposed merging lp:~phill-ridout/openlp/ftw-update into
lp:openlp/ftw-data.
Commit message:
Update all resources to the latest versions. Put them in folders identifying
their version number, so as to avoid overwriting data that previous versions of
OpenLP use.
Requested reviews
The proposal to merge lp:~phill-ridout/openlp/ftw-update into lp:openlp has
been updated.
Status: Needs review => Superseded
For more details, see:
https://code.launchpad.net/~phill-ridout/openlp/ftw-update/+merge/370401
--
Your team OpenLP Core is requested to review the proposed me
Phill has proposed merging lp:~phill-ridout/openlp/ftw-update into lp:openlp.
Commit message:
Update all resources to the latest versions. Put them in folders identifying
their version number, so as to avoid overwriting data that previous versions of
OpenLP use.
Requested reviews:
OpenLP
Just checked, this is the case now
** Changed in: openlp/trunk
Status: Confirmed => Fix Committed
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1065973
Title:
theme list in firstime wizard
Looks like this was fixed before the FTW files were added to launchpad
** Changed in: openlp/ftw-data
Status: New => Invalid
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1397604
Title:
** Branch linked: lp:~phill-ridout/openlp/wow_import_fixes
** Changed in: openlp
Status: New => Fix Committed
** Changed in: openlp
Milestone: None => 2.9.1
** Changed in: openlp
Assignee: (unassigned) => Phill (phill-ridout)
--
You received this bug notification be
** Changed in: openlp
Assignee: (unassigned) => Phill (phill-ridout)
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1746350
Title:
Exception importing Words of Worship songs
Status in Ope
** Branch linked: lp:~phill-ridout/openlp/wow_import_fixes
** Changed in: openlp
Status: Confirmed => Fix Committed
** Changed in: openlp
Milestone: None => 2.9.1
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
slide_height = max_img_row_height
> elif max_img_row_height < 0:
> # If auto setting, show that number of slides, or if
> the resulting slides too small, 100px.
--
https://code.launchpad.net/~phill-r
Phill has proposed merging lp:~phill-ridout/openlp/fixes-III into lp:openlp.
Commit message:
Minor fixes and changes
Requested reviews:
Tomas Groth (tomasgroth)
For more details, see:
https://code.launchpad.net/~phill-ridout/openlp/fixes-III/+merge/370337
--
Your team OpenLP Core
The proposal to merge lp:~phill-ridout/openlp/fixes-III into lp:openlp has been
updated.
Status: Needs review => Superseded
For more details, see:
https://code.launchpad.net/~phill-ridout/openlp/fixes-III/+merge/370336
--
Your team OpenLP Core is subscribed to branch lp:ope
Phill has proposed merging lp:~phill-ridout/openlp/fixes-III into lp:openlp.
Commit message:
Minor fixes and changes
Requested reviews:
Tomas Groth (tomasgroth)
For more details, see:
https://code.launchpad.net/~phill-ridout/openlp/fixes-III/+merge/370336
--
Your team OpenLP Core
The proposal to merge lp:~phill-ridout/openlp/fixes-III into lp:openlp has been
updated.
Status: Needs review => Superseded
For more details, see:
https://code.launchpad.net/~phill-ridout/openlp/fixes-III/+merge/369653
--
Your team OpenLP Core is subscribed to branch lp:ope
Review: Needs Fixing
Please change your string formatting to use the 'new' style with the format
function. ( https://pyformat.info/ ) also string formatting is preferred over
concatenation (i.e, "part1" + var + "part2")
single quotes for strings, not double quotes
do_import_file is very long
Phill has proposed merging lp:~phill-ridout/openlp/fixes-III into lp:openlp.
Commit message:
Minor fixes and changes
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~phill-ridout/openlp/fixes-III/+merge/369653
--
Your team OpenLP Core
The proposal to merge lp:~phill-ridout/openlp/wow_import_fixes into lp:openlp
has been updated.
Commit message changed to:
Fix up and improve the Words Of Worship importer
For more details, see:
https://code.launchpad.net/~phill-ridout/openlp/wow_import_fixes/+merge/369468
--
Your team OpenLP
A few in-line comments. Also you don't need to use parenthesis around the
expressions in the if statements.
Diff comments:
>
> === added file 'openlp/plugins/songs/lib/importers/singingthefaith.py'
> --- openlp/plugins/songs/lib/importers/singingthefaith.py 1970-01-01
> 00:00:00 +
>
Phill has proposed merging lp:~phill-ridout/openlp/wow_import_fixes into
lp:openlp.
Requested reviews:
Tim Bentley (trb143)
For more details, see:
https://code.launchpad.net/~phill-ridout/openlp/wow_import_fixes/+merge/369468
--
Your team OpenLP Core is subscribed to branch lp:openlp
The proposal to merge lp:~phill-ridout/openlp/wow_import_fixes into lp:openlp
has been updated.
Status: Needs review => Superseded
For more details, see:
https://code.launchpad.net/~phill-ridout/openlp/wow_import_fixes/+merge/369467
--
Your team OpenLP Core is subscribed to bra
Phill has proposed merging lp:~phill-ridout/openlp/wow_import_fixes into
lp:openlp.
Requested reviews:
Tim Bentley (trb143)
For more details, see:
https://code.launchpad.net/~phill-ridout/openlp/wow_import_fixes/+merge/369467
--
Your team OpenLP Core is subscribed to branch lp:openlp
The proposal to merge lp:~phill-ridout/openlp/wow_import_fixes into lp:openlp
has been updated.
Status: Needs review => Superseded
For more details, see:
https://code.launchpad.net/~phill-ridout/openlp/wow_import_fixes/+merge/369466
--
Your team OpenLP Core is subscribed to bra
Phill has proposed merging lp:~phill-ridout/openlp/wow_import_fixes into
lp:openlp.
Requested reviews:
Tim Bentley (trb143)
For more details, see:
https://code.launchpad.net/~phill-ridout/openlp/wow_import_fixes/+merge/369466
--
Your team OpenLP Core is subscribed to branch lp:openlp
The proposal to merge lp:~phill-ridout/openlp/wow_import_fixes into lp:openlp
has been updated.
Status: Needs review => Superseded
For more details, see:
https://code.launchpad.net/~phill-ridout/openlp/wow_import_fixes/+merge/369463
--
Your team OpenLP Core is subscribed to bra
Phill has proposed merging lp:~phill-ridout/openlp/wow_import_fixes into
lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~phill-ridout/openlp/wow_import_fixes/+merge/369463
--
Your team OpenLP Core is requested to review the proposed
Phill has proposed merging lp:~phill-ridout/openlp/wow_import_fixes into
lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~phill-ridout/openlp/wow_import_fixes/+merge/369462
--
Your team OpenLP Core is requested to review the proposed
The proposal to merge lp:~phill-ridout/openlp/wow_import_fixes into lp:openlp
has been updated.
Status: Needs review => Superseded
For more details, see:
https://code.launchpad.net/~phill-ridout/openlp/wow_import_fixes/+merge/369462
--
Your team OpenLP Core is requested to rev
The proposal to merge lp:~phill-ridout/openlp/wow_import_fixes into lp:openlp
has been updated.
Status: Work in progress => Superseded
For more details, see:
https://code.launchpad.net/~phill-ridout/openlp/wow_import_fixes/+merge/369460
--
Your team OpenLP Core is requested to rev
Phill has proposed merging lp:~phill-ridout/openlp/path_fixes into lp:openlp.
Commit message:
Path fix ups
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~phill-ridout/openlp/path_fixes/+merge/369195
--
Your team OpenLP Core is requested
The proposal to merge lp:~phill-ridout/openlp/path_fixes into lp:openlp has
been updated.
Status: Needs review => Superseded
For more details, see:
https://code.launchpad.net/~phill-ridout/openlp/path_fixes/+merge/369192
--
Your team OpenLP Core is requested to review the proposed me
Phill has proposed merging lp:~phill-ridout/openlp/path_fixes into lp:openlp.
Commit message:
Path fix ups
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~phill-ridout/openlp/path_fixes/+merge/369192
--
Your team OpenLP Core is requested
The proposal to merge lp:~phill-ridout/openlp/path_fixes into lp:openlp has
been updated.
Status: Needs review => Superseded
For more details, see:
https://code.launchpad.net/~phill-ridout/openlp/path_fixes/+merge/369191
--
Your team OpenLP Core is requested to review the proposed me
Phill has proposed merging lp:~phill-ridout/openlp/path_fixes into lp:openlp.
Commit message:
Path fix ups
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~phill-ridout/openlp/path_fixes/+merge/369191
--
Your team OpenLP Core is requested
Public bug reported:
Songs with custom tags and square brackets cannot be exported.
For example, songs with the following snippets fail to export:
Public bug reported:
Add a custom formatting tag to a song causes some issues:
1. The closing tags shows on the main display
2. Other formatting tags do not render correctly when custom tags are used
When inserting a custom tag by right clicking in the song editor the
closing tag is inserted
Review: Approve
--
https://code.launchpad.net/~trb143/openlp/more_media/+merge/368843
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Review: Approve
--
https://code.launchpad.net/~trb143/openlp/more_media/+merge/368841
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Review: Needs Fixing
Just one inconsistency with text labels (see inline) and the failed linting,
but other than that looks ok!
Diff comments:
>
> === modified file 'openlp/core/ui/media/mediatab.py'
> --- openlp/core/ui/media/mediatab.py 2019-05-04 19:47:06 +
> +++
** Changed in: openlp
Importance: Undecided => Medium
** Changed in: openlp
Status: New => Confirmed
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1790942
Title:
SongSelect dialog should
*** This bug is a duplicate of bug 1790942 ***
https://bugs.launchpad.net/bugs/1790942
** This bug has been marked a duplicate of bug 1790942
SongSelect dialog should be closeable
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to
** Changed in: openlp
Status: In Progress => Confirmed
** Changed in: openlp
Importance: Undecided => Low
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1617592
Title:
Delete bible
** Changed in: openlp/website
Status: Confirmed => Won't Fix
--
You received this bug notification because you are a member of OpenLP
Core, which is a bug assignee.
https://bugs.launchpad.net/bugs/1314131
Title:
Screenshots link broken on Launchpad
Status in OpenLP:
Invalid
Status
Review: Approve
Looks ok to me, but I cant test it!!!
--
https://code.launchpad.net/~raoul-snyman/openlp/packaging-macos-pyro/+merge/368364
Your team OpenLP Core is subscribed to branch lp:openlp/packaging.
___
Mailing list:
Review: Approve
--
https://code.launchpad.net/~tomasgroth/openlp/presentation-beyond-last/+merge/368353
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to :
Review: Approve
Looks ok to me...
--
https://code.launchpad.net/~bastian-germann/openlp/dependencies/+merge/367931
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to :
Review: Needs Fixing
See line 189 for my main comment.
Others are just me being nit-picky!
Diff comments:
>
> === modified file 'openlp/plugins/presentations/lib/impresscontroller.py'
> --- openlp/plugins/presentations/lib/impresscontroller.py 2019-05-22
> 06:47:00 +
> +++
Just a comment on implementation.
Diff comments:
>
> === modified file 'openlp/core/ui/servicemanager.py'
> --- openlp/core/ui/servicemanager.py 2019-05-24 18:50:51 +
> +++ openlp/core/ui/servicemanager.py 2019-05-27 18:44:30 +
> @@ -509,7 +510,8 @@
> service = []
>
The proposal to merge lp:~phill-ridout/openlp/media_ext_refactors into
lp:openlp has been updated.
Status: Needs review => Superseded
For more details, see:
https://code.launchpad.net/~phill-ridout/openlp/media_ext_refactors/+merge/368212
--
Your team OpenLP Core is subscribed to bra
Phill has proposed merging lp:~phill-ridout/openlp/media_ext_refactors into
lp:openlp.
Commit message:
refactor media extensions
Requested reviews:
Tim Bentley (trb143)
For more details, see:
https://code.launchpad.net/~phill-ridout/openlp/media_ext_refactors/+merge/368221
--
Your team
Phill has proposed merging lp:~phill-ridout/openlp/media_ext_refactors into
lp:openlp.
Commit message:
refactor media extensions
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~phill-ridout/openlp/media_ext_refactors/+merge/368212
--
Your team
Whats happrning with the commented out code?
Diff comments:
>
> === modified file 'openlp/plugins/presentations/lib/impresscontroller.py'
> --- openlp/plugins/presentations/lib/impresscontroller.py 2019-04-13
> 13:00:22 +
> +++ openlp/plugins/presentations/lib/impresscontroller.py
Phill has proposed merging lp:~phill-ridout/openlp/json_refactors into
lp:openlp.
Commit message:
rework json handling for custom objects
refactor path file
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~phill-ridout/openlp/json_refactors
** Changed in: openlp
Assignee: (unassigned) => Raoul Snyman (raoul-snyman)
** Branch linked: lp:~raoul-snyman/openlp/wix-packaging
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1660480
Title:
** Changed in: openlp/trunk
Status: Confirmed => Fix Released
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1266270
Title:
OpenLP hides dialogs whe using "play slides in loop" on OSX
Status
2.4.x is running PyQt5 could somebody test if this bug still exists?
** Changed in: openlp
Status: Confirmed => Fix Released
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1168493
Title:
Review: Needs Fixing
You have quite a few "assert (chk == E_NO_AUTHENTICATION), ''" the brackets
are not needed.
Also you're "@patch.object(openlp.core.projectors.pjlinkcommands, 'log')" a
lot, have you considered putting it in the setUp method?
Other than that looks good to me!
--
Phill has proposed merging lp:~phill-ridout/openlp/fixes-II into lp:openlp.
Commit message:
Just to trigger the tests :-)
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~phill-ridout/openlp/fixes-II/+merge/366951
--
Your team OpenLP Core
Phill has proposed merging lp:~phill-ridout/openlp/fixes-II into lp:openlp.
Commit message:
Just to trigger the tests :-)
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~phill-ridout/openlp/fixes-II/+merge/366949
--
Your team OpenLP Core
Phill has proposed merging lp:~phill-ridout/openlp/fixes-II into lp:openlp.
Commit message:
Just to trigger the tests :-)
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~phill-ridout/openlp/fixes-II/+merge/366950
--
Your team OpenLP Core
The proposal to merge lp:~phill-ridout/openlp/fixes-II into lp:openlp has been
updated.
Status: Needs review => Superseded
For more details, see:
https://code.launchpad.net/~phill-ridout/openlp/fixes-II/+merge/366950
--
Your team OpenLP Core is requested to review the proposed merge of
The proposal to merge lp:~phill-ridout/openlp/fixes-II into lp:openlp has been
updated.
Status: Work in progress => Superseded
For more details, see:
https://code.launchpad.net/~phill-ridout/openlp/fixes-II/+merge/366948
--
Your team OpenLP Core is requested to review the proposed me
Review: Approve
Looks ok to me
--
https://code.launchpad.net/~alisonken1/openlp/pjlink2_v04/+merge/366946
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to :
Review: Approve
--
https://code.launchpad.net/~bastian-germann/openlp/pymupdf/+merge/366851
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
1 - 100 of 1843 matches
Mail list logo
