[Openlp-core] [Merge] lp:~bastian-germann/openlp/setup into lp:openlp

2018-10-16 Thread Bastian Germann
The proposal to merge lp:~bastian-germann/openlp/setup into lp:openlp has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~bastian-germann/openlp/setup/+merge/356675 -- Your team OpenLP Core is subscribed to branch lp:openlp.

[Openlp-core] [Merge] lp:~bastian-germann/openlp/setup into lp:openlp

2018-10-16 Thread Bastian Germann
Bastian Germann has proposed merging lp:~bastian-germann/openlp/setup into lp:openlp. Commit message: This fixes setuptools' dependencies according to scripts/check_dependencies.py. The minimum Python version is set to 3.6 because this was agreed to on the mailing list. To overcome the module

[Openlp-core] Linux Test Results: Passed

2018-10-16 Thread Raoul Snyman
Linux tests passed! -- https://code.launchpad.net/~bastian-germann/openlp/setup/+merge/356801 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net

[Openlp-core] Linting: Passed

2018-10-16 Thread Raoul Snyman
Linting passed! -- https://code.launchpad.net/~bastian-germann/openlp/setup/+merge/356801 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net

Re: [Openlp-core] [Merge] lp:~bkylerussell/openlp/choosegroupform-fixes into lp:openlp

2018-10-16 Thread Tomas Groth
Review: Approve -- https://code.launchpad.net/~bkylerussell/openlp/choosegroupform-fixes/+merge/354159 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to :

Re: [Openlp-core] [Merge] lp:~bastian-germann/openlp/setup into lp:openlp

2018-10-16 Thread Tomas Groth
Review: Needs Fixing I highlighted some minor things with diff-comments. Also you should not add more changes to this merge requests: It is starting to become to broad. Diff comments: > === renamed file 'openlp.py' => 'openlp/__main__.py' As mentioned in mailinglist thread linked to above, it

[Openlp-core] [Merge] lp:~bkylerussell/openlp/choosegroupform-fixes into lp:openlp

2018-10-16 Thread noreply
The proposal to merge lp:~bkylerussell/openlp/choosegroupform-fixes into lp:openlp has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~bkylerussell/openlp/choosegroupform-fixes/+merge/354159 -- Your team OpenLP Core is subscribed to branch

[Openlp-core] [Merge] lp:~bastian-germann/openlp/setup into lp:openlp

2018-10-16 Thread Bastian Germann
Bastian Germann has proposed merging lp:~bastian-germann/openlp/setup into lp:openlp. Commit message: This fixes setuptools' dependencies according to scripts/check_dependencies.py. The minimum Python version is set to 3.6 because this was agreed to on the mailing list. To overcome the module

[Openlp-core] [Merge] lp:~bastian-germann/openlp/setup into lp:openlp

2018-10-16 Thread Bastian Germann
The proposal to merge lp:~bastian-germann/openlp/setup into lp:openlp has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~bastian-germann/openlp/setup/+merge/356801 -- Your team OpenLP Core is subscribed to branch lp:openlp.

[Openlp-core] [Merge] lp:~bastian-germann/openlp/documentation into lp:openlp/documentation

2018-10-16 Thread Bastian Germann
Bastian Germann has proposed merging lp:~bastian-germann/openlp/documentation into lp:openlp/documentation. Commit message: Fix a missing import Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~bastian-germann/openlp/documentation/+merge/356852

[Openlp-core] [Merge] lp:~bastian-germann/openlp/setup into lp:openlp

2018-10-16 Thread Bastian Germann
Bastian Germann has proposed merging lp:~bastian-germann/openlp/setup into lp:openlp. Commit message: This fixes setuptools' dependencies according to scripts/check_dependencies.py. The minimum Python version is set to 3.6 because this was agreed to on the mailing list. Some packages which are

Re: [Openlp-core] [Merge] lp:~bastian-germann/openlp/setup into lp:openlp

2018-10-16 Thread Tim Bentley
Review: Needs Fixing Please removed all pymediainfo changes as the media code is been extensively refactored and this will cause issues when that is merged. Your changes have been taken on board but implemented differently. Why has run_openlp been restructured instead of just being renamed?

Re: [Openlp-core] [Merge] lp:~bastian-germann/openlp/setup into lp:openlp

2018-10-16 Thread Bastian Germann
> Please removed all pymediainfo changes as the media code is been extensively > refactored and this will cause issues when that is merged. Your changes have > been taken on board but implemented differently. Did you get the latest utf8 decoding change in 2860? I will remove the changes in the

[Openlp-core] [Merge] lp:~bastian-germann/openlp/setup into lp:openlp

2018-10-16 Thread Bastian Germann
The proposal to merge lp:~bastian-germann/openlp/setup into lp:openlp has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~bastian-germann/openlp/setup/+merge/356868 -- Your team OpenLP Core is subscribed to branch lp:openlp.

[Openlp-core] [Merge] lp:~bastian-germann/openlp/setup into lp:openlp

2018-10-16 Thread Bastian Germann
Bastian Germann has proposed merging lp:~bastian-germann/openlp/setup into lp:openlp. Commit message: This fixes setuptools' dependencies according to scripts/check_dependencies.py. The minimum Python version is set to 3.6 because this was agreed to on the mailing list. Some packages which are

[Openlp-core] Linux Test Results: Passed

2018-10-16 Thread Raoul Snyman
Linux tests passed! -- https://code.launchpad.net/~bastian-germann/openlp/setup/+merge/356881 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net

[Openlp-core] Linting: Passed

2018-10-16 Thread Raoul Snyman
Linting passed! -- https://code.launchpad.net/~bastian-germann/openlp/setup/+merge/356881 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net

[Openlp-core] Linux Test Results: Passed

2018-10-16 Thread Raoul Snyman
Linux tests passed! -- https://code.launchpad.net/~bastian-germann/openlp/setup/+merge/356868 Your team OpenLP Core is requested to review the proposed merge of lp:~bastian-germann/openlp/setup into lp:openlp. ___ Mailing list:

[Openlp-core] Linting: Passed

2018-10-16 Thread Raoul Snyman
Linting passed! -- https://code.launchpad.net/~bastian-germann/openlp/setup/+merge/356868 Your team OpenLP Core is requested to review the proposed merge of lp:~bastian-germann/openlp/setup into lp:openlp. ___ Mailing list: