The proposal to merge lp:~bastian-germann/openlp/setup into lp:openlp has been
updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~bastian-germann/openlp/setup/+merge/356881
--
Your team OpenLP Core is subscribed to branch lp:openlp.
Review: Approve
--
https://code.launchpad.net/~bastian-germann/openlp/setup/+merge/356881
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Review: Approve
--
https://code.launchpad.net/~bastian-germann/openlp/setup/+merge/356881
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
@trb143 I just checked your media_state branch for the mentioned pymediainfo
change. You did not include
https://bazaar.launchpad.net/~bastian-germann/openlp/setup/revision/2860. It
took me some debugging (no error thrown) to find this.
--
The proposal to merge lp:~bastian-germann/openlp/setup into lp:openlp has been
updated.
Status: Needs review => Superseded
For more details, see:
https://code.launchpad.net/~bastian-germann/openlp/setup/+merge/356868
--
Your team OpenLP Core is subscribed to branch lp:openlp.
Bastian Germann has proposed merging lp:~bastian-germann/openlp/setup into
lp:openlp.
Commit message:
This fixes setuptools' dependencies according to scripts/check_dependencies.py.
The minimum Python version is set to 3.6 because this was agreed to on the
mailing list.
Some packages which are
> Please removed all pymediainfo changes as the media code is been extensively
> refactored and this will cause issues when that is merged. Your changes have
> been taken on board but implemented differently.
Did you get the latest utf8 decoding change in 2860? I will remove the changes
in the
Review: Needs Fixing
Please removed all pymediainfo changes as the media code is been extensively
refactored and this will cause issues when that is merged. Your changes have
been taken on board but implemented differently.
Why has run_openlp been restructured instead of just being renamed?
Bastian Germann has proposed merging lp:~bastian-germann/openlp/setup into
lp:openlp.
Commit message:
This fixes setuptools' dependencies according to scripts/check_dependencies.py.
The minimum Python version is set to 3.6 because this was agreed to on the
mailing list.
Some packages which are
Bastian Germann has proposed merging lp:~bastian-germann/openlp/setup into
lp:openlp.
Commit message:
This fixes setuptools' dependencies according to
scripts/check_dependencies.py.
The minimum Python version is set to 3.6 because this was agreed to on the
mailing list.
To overcome the module
The proposal to merge lp:~bastian-germann/openlp/setup into lp:openlp has been
updated.
Status: Needs review => Superseded
For more details, see:
https://code.launchpad.net/~bastian-germann/openlp/setup/+merge/356801
--
Your team OpenLP Core is subscribed to branch lp:openlp.
Review: Needs Fixing
I highlighted some minor things with diff-comments.
Also you should not add more changes to this merge requests: It is starting to
become to broad.
Diff comments:
> === renamed file 'openlp.py' => 'openlp/__main__.py'
As mentioned in mailinglist thread linked to above, it
Bastian Germann has proposed merging lp:~bastian-germann/openlp/setup into
lp:openlp.
Commit message:
This fixes setuptools' dependencies according to
scripts/check_dependencies.py.
The minimum Python version is set to 3.6 because this was agreed to on the
mailing list.
To overcome the module
The proposal to merge lp:~bastian-germann/openlp/setup into lp:openlp has been
updated.
Status: Needs review => Superseded
For more details, see:
https://code.launchpad.net/~bastian-germann/openlp/setup/+merge/356675
--
Your team OpenLP Core is subscribed to branch lp:openlp.
That is right. I tested on Linux and Windows.
--
https://code.launchpad.net/~bastian-germann/openlp/setup/+merge/356675
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to :
Review: Needs Information
Which platforms have you tested this on? If I understand correctly the changes
would effect both Linux, Windows and Mac OS.
--
https://code.launchpad.net/~bastian-germann/openlp/setup/+merge/356675
Your team OpenLP Core is subscribed to branch lp:openlp.
Bastian Germann has proposed merging lp:~bastian-germann/openlp/setup into
lp:openlp.
Commit message:
This fixes setuptools' dependencies according to
scripts/check_dependencies.py.
The minimum Python version is set to 3.6 because this was agreed to on the
mailing list.
To overcome the module
The proposal to merge lp:~bastian-germann/openlp/setup into lp:openlp has been
updated.
Status: Needs review => Superseded
For more details, see:
https://code.launchpad.net/~bastian-germann/openlp/setup/+merge/356602
--
Your team OpenLP Core is subscribed to branch lp:openlp.
@raoul-snyman Can you add python3-appdirs and python3-pymediainfo to the build
machine or point me to where I can do it?
--
https://code.launchpad.net/~bastian-germann/openlp/setup/+merge/356602
Your team OpenLP Core is subscribed to branch lp:openlp.
Bastian Germann has proposed merging lp:~bastian-germann/openlp/setup into
lp:openlp.
Commit message:
This fixes setuptools' dependencies according to
scripts/check_dependencies.py.
The minimum Python version is set to 3.6 because this was agreed to on the
mailing list.
To overcome the module
The proposal to merge lp:~bastian-germann/openlp/setup into lp:openlp has been
updated.
Status: Needs review => Superseded
For more details, see:
https://code.launchpad.net/~bastian-germann/openlp/setup/+merge/356560
--
Your team OpenLP Core is subscribed to branch lp:openlp.
Bastian Germann has proposed merging lp:~bastian-germann/openlp/setup into
lp:openlp.
Commit message:
This fixes setuptools' dependencies according to
scripts/check_dependencies.py.
The minimum Python version is set to 3.6 because this was agreed to on the
mailing list.
To overcome the module
The proposal to merge lp:~bastian-germann/openlp/setup into lp:openlp has been
updated.
Status: Needs review => Superseded
For more details, see:
https://code.launchpad.net/~bastian-germann/openlp/setup/+merge/356147
--
Your team OpenLP Core is subscribed to branch lp:openlp.
The proposal to merge lp:~bastian-germann/openlp/setup into lp:openlp has been
updated.
Commit message changed to:
This fixes setuptools' dependencies according to
scripts/check_dependencies.py.
The minimum Python version is set to 3.6 because this was agreed to on the
mailing list.
To
The proposal to merge lp:~bastian-germann/openlp/setup into lp:openlp has been
updated.
Commit message changed to:
This fixes setuptools' dependencies according to
scripts/check_dependencies.py.
The minimum Python version is set to 3.6 because this was agreed to on the
mailing list.
To
The proposal to merge lp:~bastian-germann/openlp/setup into lp:openlp has been
updated.
Commit message changed to:
This fixes setuptools' dependencies according to
scripts/check_dependencies.py.
The minimum Python version is set to 3.6 because this was agreed to on the
mailing list.
Some
All of my contributions can be used under GPLv2 or later. So that relicensing
the codebase is not a blocker for this merge proposal to be integrated.
--
https://code.launchpad.net/~bastian-germann/openlp/setup/+merge/356147
Your team OpenLP Core is subscribed to branch lp:openlp.
This includes the external dependency pymediainfo now. This is available on all
officially supported Linux distributions, so this should be okay. It also fixes
a MIT license violation.
--
https://code.launchpad.net/~bastian-germann/openlp/setup/+merge/356147
Your team OpenLP Core is subscribed
Please note that I already removed the vlc changes.
--
https://code.launchpad.net/~bastian-germann/openlp/setup/+merge/356147
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to :
Removing VLC is moving against the direction agreed where VLC is going to be
packaged into the windows installer to prevent issues caused by bad vlc
installs.
--
https://code.launchpad.net/~bastian-germann/openlp/setup/+merge/356147
Your team OpenLP Core is subscribed to branch lp:openlp.
I always wondered why there is a setup.py that is not really functional...
Making sure it can install openlp would be a good idea. It would greatly
simplify packaging OpenLP (at least for archlinux)
I don't see a downside to doing that. We only need to set it up once and then
we only need to
Hi Bastian,
We're not trying to discourage you from contributing at all, and we'd never
stop someone from contributing. We just want the contribution to line up better
with the project's greater goals.
If you have the motivation and the time to do it, that is awesome and we'd love
you to do
I see. The only change that would influence distributing via a Linux packaging
system is the introduction of the vlc module as a new dependency. The other
changes do not interfere if the Linux packages install python packages with
their Python dist information which is the case for all the
Review: Disapprove
Hi Bastian,
Thank you for contributing to OpenLP! It's great to see some of the issues I've
seen in OpenLP finally addressed. We have not had the time to look into these
issues, and we're happy to see someone looking into them.
Unfortunately your changes are not compatible
The proposal to merge lp:~bastian-germann/openlp/setup into lp:openlp has been
updated.
Commit message changed to:
This fixes setuptools' dependencies according to
scripts/check_dependencies.py.
The minimum Python version is set to 3.5 because the async/await feature is in
use in the code
The proposal to merge lp:~bastian-germann/openlp/setup into lp:openlp has been
updated.
Description changed to:
For more details, see:
https://code.launchpad.net/~bastian-germann/openlp/setup/+merge/356147
--
Your team OpenLP Core is requested to review the proposed merge of
The proposal to merge lp:~bastian-germann/openlp/setup into lp:openlp has been
updated.
Description changed to:
This fixes setuptools' dependencies according to
scripts/check_dependencies.py.
The minimum Python version is set to 3.5 because the async/await feature is in
use in the code base.
37 matches
Mail list logo
