Controllers are now completely self contained. Therefore no references to
PowerPoint/Impress or u'nt' outside the relevant *controller.py.
This will make it easier to just drop in say a keynotecontroller.py should
someone buy me a Mac with Keynote installed.
I got an email notification as
Review: Approve
Simples
--
https://code.launchpad.net/~j-corwin/openlp/presentations/+merge/12547
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to :
Review: Approve
Works for me.
--
https://code.launchpad.net/~j-corwin/openlp/presentations/+merge/12547
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to :
Review: Approve
Looks good
--
https://code.launchpad.net/~j-corwin/openlp/presentations/+merge/12472
Your team openlp.org Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to :
Review: Approve
Simples
Approved
--
https://code.launchpad.net/~j-corwin/openlp/presentations/+merge/12498
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to :
Review: Approve
I can see you're a VB programmer, goto :-P
--
https://code.launchpad.net/~j-corwin/openlp/presentations/+merge/12498
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to
Note my idea for presentationcontrollers is for them to be loaded dynamically
like the plugins are. I.e. for PresentationPlugin to have no hardcoded
knowledge of which controllers exist, what they are called or which platforms
they work on.
PresentationTab could be passed the controllers array
Review: Needs Fixing
Very good I like it.
There is some strangeness on line 281 , 289 and a bit further down.
Looks like a class during a merge which will lead to a compile problem.
--
https://code.launchpad.net/~j-corwin/openlp/presentations/+merge/12472
Your team openlp.org Core is subscribed
Review: Approve
--
https://code.edge.launchpad.net/~j-corwin/openlp/presentations/+merge/12388
Your team openlp.org Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to :
Review: Approve
We don't have C++ coding standards, so I unfortunately don't have grounds to
moan about your coding style :-P
--
https://code.edge.launchpad.net/~j-corwin/openlp/presentations/+merge/12310
Your team openlp.org Core is subscribed to branch lp:openlp.
I pushed some more incomplete changes after my original merge request, since I
was expecting the merge to only merge the revision I'd requested and not
later ones on the same branch.
However it seems this is not the case, and my later incomplete changes ended up
merged in trunk.
This appears
Review: Approve
Looks good.
--
https://code.launchpad.net/~j-corwin/openlp/presentations/+merge/12370
Your team openlp.org Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to :
Review: Approve
There should be a blank line between the copyright notice and import os
--
https://code.edge.launchpad.net/~j-corwin/openlp/presentations/+merge/12370
Your team openlp.org Core is subscribed to branch lp:openlp.
___
Mailing list:
Review: Approve
Looks good.
--
https://code.launchpad.net/~j-corwin/openlp/presentations/+merge/12388
Your team openlp.org Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to :
Review: Approve
Totally meaningful!
Approved
--
https://code.launchpad.net/~j-corwin/openlp/presentations/+merge/12310
Your team openlp.org Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to :
15 matches
Mail list logo
