Re: [openlp-dev] Removing test_pylint.py and test_bzr_tags.py

2018-10-27 Thread Bill
Since I'm so new here, the value of my Yea/Nay is certainly questionable. I will say that I certainly support removing any redundancy. Best Regards, MrBillC On 10/25/18 10:32 PM, Raoul Snyman via openlp-dev wrote: Hi folks, I'd like to remove tests/utils/test_pylint.py and

Re: [openlp-dev] Removing test_pylint.py and test_bzr_tags.py

2018-10-26 Thread Philip Ridout
No objections from me! On Fri, 26 Oct 2018, 07:43 Tim and Alison Bentley, wrote: > Seems reasonable to me. > > On Fri, 26 Oct 2018, 05:43 Raoul Snyman via openlp-dev, < > openlp-dev@openlp.io> wrote: > >> On 2018-10-25 21:35, Tomas Groth wrote: >> > The test_pylint is not as old as you think

Re: [openlp-dev] Removing test_pylint.py and test_bzr_tags.py

2018-10-26 Thread Tim and Alison Bentley
Seems reasonable to me. On Fri, 26 Oct 2018, 05:43 Raoul Snyman via openlp-dev, < openlp-dev@openlp.io> wrote: > On 2018-10-25 21:35, Tomas Groth wrote: > > The test_pylint is not as old as you think and is actually responsible > > for > > linting on Jenkins on the old setup... Also it should

Re: [openlp-dev] Removing test_pylint.py and test_bzr_tags.py

2018-10-25 Thread Tomas Groth
Hi, The test_pylint is not as old as you think and is actually responsible for linting on Jenkins on the old setup... Also it should only run if you target that script specifically, so typically not on local setups. If the new CI lint solution is superior it is ok to remove it. The test_bzr_tags