Re: [opennms-devel] Set review required for Pull Requests

2017-02-01 Thread Markus von RĂ¼den
Branches are already protected and can only be written to by committers with the according rights. We already do pull requests and reviews. There is no point to add more complexity and remove flexibility, in case we need it, from my point of view. - Markus > On 30 Jan 2017, at 14:53, Ronny T

Re: [opennms-devel] Set review required for Pull Requests

2017-01-31 Thread Jesse White
Don't we already need "write" permissions to be able to merge a PR? If so, what's to gain by this extra step? -Jesse On 01/30/2017 08:53 AM, Ronny Trommer wrote: Hi Guys, I would like vote for setting up Review required [1] for protected branches like foundation / foundation-2016 / master /

Re: [opennms-devel] Set review required for Pull Requests

2017-01-31 Thread Jesse White
Oups, this was meant for the other thread... On 01/31/2017 09:54 AM, Jesse White wrote: > This sounds like good practice to me. > > I don't see any problems with addressing multiple issues in a single pull > request as long as the commits are related and > properly identified. > > -Jesse > > On 0

Re: [opennms-devel] Set review required for Pull Requests

2017-01-31 Thread Jesse White
This sounds like good practice to me. I don't see any problems with addressing multiple issues in a single pull request as long as the commits are related and properly identified. -Jesse On 01/30/2017 08:53 AM, Ronny Trommer wrote: Hi Guys, I would like vote for setting up Review required [