Re: [PATCH] src/target/semihosting_common.c: add stdfd fd control command

2022-11-24 Thread Paul Fertser
Hi, I know you've already figured it out, so just for the reference in case someone arrives here via an Internet search. On Fri, Nov 25, 2022 at 11:57:32AM +0530, Kautuk Consul wrote: > But now the build is showing that mingw64 compiled fine but the build got > aborted: The build is aborted when

Re: [PATCH] src/target/semihosting_common.c: add stdfd fd control command

2022-11-24 Thread Kautuk Consul
Ok anyway I resolved the issue myself. It is now verified. Thanks for your help! :) On Fri, Nov 25, 2022 at 11:57 AM Kautuk Consul wrote: > Ok, so I have taken in all the comments I could find. > But now the build is showing that mingw64 compiled fine but the build got > aborted: > > https://bui

Re: [PATCH] src/target/semihosting_common.c: add stdfd fd control command

2022-11-24 Thread Kautuk Consul
Ok, so I have taken in all the comments I could find. But now the build is showing that mingw64 compiled fine but the build got aborted: https://build.openocd.org/job/openocd-gerrit-build/16306/console What is the solution for this one ? On Thu, Nov 24, 2022 at 10:40 PM Paul Fertser wrote: >

Re: [PATCH] src/target/semihosting_common.c: add stdfd fd control command

2022-11-24 Thread Paul Fertser
Hi, On Thu, Nov 24, 2022 at 10:10:59PM +0530, Kautuk Consul wrote: > So I managed to create a gerrit account and followed the instructions in > HACKING. Thanks, you did everything right. > But, I got a build failure for mingw64 as given > by: [1]https://build.openocd.org/job/openocd-gerrit-build

Re: [PATCH] src/target/semihosting_common.c: add stdfd fd control command

2022-11-24 Thread Kautuk Consul
Hi Paul, So I managed to create a gerrit account and followed the instructions in HACKING. But, I got a build failure for mingw64 as given by: https://build.openocd.org/job/openocd-gerrit-build/16294/console My patch compiled fine on my system but I am getting a build error email. Do I have to r

Re: [PATCH] src/target/semihosting_common.c: add stdfd fd control command

2022-11-23 Thread Kautuk Consul
Ok, then let me try to find time to post to gerrit as per the HACKING instructions. Sorry, didn't see this file before posting and I am new to this mailing list. Not used to using gerrit. Thanks. On Wed, Nov 23, 2022 at 4:59 PM Paul Fertser wrote: > On Wed, Nov 23, 2022 at 04:40:29PM +0530, Kau

Re: [PATCH] src/target/semihosting_common.c: add stdfd fd control command

2022-11-23 Thread Kautuk Consul
I don't have access to gerrit and I am not a regular contributor. I am doing board bring-up for our RISCV board and I noticed this issue with our internal simulator so I decided to send this patch. Can you please review it ? Thanks and Regards. On Wed, Nov 23, 2022 at 4:36 PM Paul Fertser wrot

Re: [PATCH] src/target/semihosting_common.c: add stdfd fd control command

2022-11-23 Thread Paul Fertser
On Wed, Nov 23, 2022 at 04:40:29PM +0530, Kautuk Consul wrote: > I don't have access to gerrit and I am not a regular contributor. It's open for public, and anybody can send and review patches there. > I am doing board bring-up for our RISCV board and I noticed this issue with > our > internal s

Re: [PATCH] src/target/semihosting_common.c: add stdfd fd control command

2022-11-23 Thread Paul Fertser
Hi, On Tue, Nov 22, 2022 at 12:18:30PM +0530, Kautuk Consul wrote: > Can anyone review my patch ? > This patch can improve performance of semihosting with respect to key-strokes. Thank you for the patch. Have you considered sending it to the project's Gerrit as per instructions in HACKING? Review

Re: [PATCH] src/target/semihosting_common.c: add stdfd fd control command

2022-11-21 Thread Kautuk Consul
Hi, Can anyone review my patch ? This patch can improve performance of semihosting with respect to key-strokes. Thanks. On Tue, Oct 18, 2022 at 10:10 AM Kautuk Consul wrote: > The semihosting->stdin_fd is initially in blocking mode. > Due to this there is a possibility that the system software

[PATCH] src/target/semihosting_common.c: add stdfd fd control command

2022-10-17 Thread Kautuk Consul
The semihosting->stdin_fd is initially in blocking mode. Due to this there is a possibility that the system software blocks waiting for a key-press from the user. This can adversely affect various housekeeping aspects of system software such as the scheduling of the system software tasks/processes/