Re: [Openocd-development] committed - printf() warning fixes

2009-06-19 Thread Zach Welch
On Fri, 2009-06-19 at 19:18 -0400, Duane Ellis wrote: FYI - I committed several cygwin specific printf() warning fixes. Simple cast to fix these where causing -Werror failures on cygwin. I was just about to post some patches to show how to fix all of these correctly, as casts

[Openocd-development] [PATCH 0/2] Minor improvements in types.h.

2009-06-19 Thread Zach Welch
This series includes small patches that improve the core types. 1/2 Include inttypes.h from types.h. 2/2 Demonstrate C99 PRIuN formatting specifiers in trace.c. --- Summary of Patches 1-2: helper/types.h |3 +++ target/trace.c |5 +++-- 2 files changed, 6 insertions(+), 2

[Openocd-development] [PATCH 2/2] Demonstrate C99 PRIuN formatting specifiers in trace.c.

2009-06-19 Thread Zach Welch
Demonstrate C99 PRIuN formatting specifiers in trace.c. --- trace.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) Demonstrate C99 PRIuN formatting specifiers in trace.c. --- trace.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) == only in patch2: unchanged:

Re: [Openocd-development] [Openocd-svn] r2293 - trunk/src/jtag

2009-06-19 Thread Zach Welch
On Sat, 2009-06-20 at 01:16 +0200, du...@mail.berlios.de wrote: Author: duane Date: 2009-06-20 01:15:58 +0200 (Sat, 20 Jun 2009) New Revision: 2293 [snip] +/* + * Local Variables: + * c-basic-offset: 4 + * tab-width: 4 + * End: + */ I think this kind of stuff should be prohibited from

Re: [Openocd-development] committed - printf() warning fixes

2009-06-19 Thread Zach Welch
On Fri, 2009-06-19 at 19:38 -0400, Duane Ellis wrote: Zach Welch wrote: On Fri, 2009-06-19 at 19:18 -0400, Duane Ellis wrote: FYI - I committed several cygwin specific printf() warning fixes. Simple cast to fix these where causing -Werror failures on cygwin. I

Re: [Openocd-development] [Openocd-svn] r2293 - trunk/src/jtag

2009-06-19 Thread Zach Welch
On Fri, 2009-06-19 at 19:49 -0400, Duane Ellis wrote: I think this kind of stuff should be prohibited from source files. This is noise for anyone that does not use one specific editor. I disagree.. - But since you are so proactive ... Please also fix arm-jtag-ew.c - remove the VIM

Re: [Openocd-development] Will the next release 0.2.0 build on FTD2XX support?

2009-06-19 Thread Zach Welch
On Fri, 2009-06-19 at 18:26 +0200, Harald Kipp wrote: Hello all, I may have missed one or the other statement given in that long license discussion thread. Nevertheless, Michael asked me to post my view to this forum. If I'm repeating statements that had been posted already: Sorry for the

Re: [Openocd-development] committed - printf() warning fixes

2009-06-19 Thread Zach Welch
On Fri, 2009-06-19 at 20:31 -0400, Duane Ellis wrote: duane FYI - I committed several cygwin specific printf() warning fixes. duaneSimple cast to fix duane these where causing -Werror failures on cygwin. zach I was just about to post some patches to show how to fix all of these zach

Re: [Openocd-development] committed - printf() warning fixes

2009-06-19 Thread Zach Welch
On Fri, 2009-06-19 at 17:40 -0700, Zach Welch wrote: On Fri, 2009-06-19 at 20:31 -0400, Duane Ellis wrote: duane FYI - I committed several cygwin specific printf() warning fixes. duaneSimple cast to fix duane these where causing -Werror failures on cygwin. zach I was just about

Re: [Openocd-development] [Openocd-svn] r2293 - trunk/src/jtag

2009-06-19 Thread Zach Welch
A-yup. :) On Fri, 2009-06-19 at 18:13 -0700, Rick Altherr wrote: Rather than casting to int, should the printf's be using the PRI* macros for uint32_t? -- Rick Altherr kc8...@kc8apf.net He said he hadn't had a byte in three days. I had a short, so I split it with him. -- Unsigned

Re: [Openocd-development] committed - printf() warning fixes

2009-06-19 Thread Zach Welch
On Fri, 2009-06-19 at 21:24 -0400, Duane Ellis wrote: Zach Welch wrote: On Fri, 2009-06-19 at 20:31 -0400, Duane Ellis wrote: duane FYI - I committed several cygwin specific printf() warning fixes. duaneSimple cast to fix duane these where causing -Werror failures on cygwin

Re: [Openocd-development] [Openocd-svn] r2293 - trunk/src/jtag

2009-06-19 Thread Zach Welch
On Fri, 2009-06-19 at 21:35 -0400, Duane Ellis wrote: Rick Altherr wrote: Rather than casting to int, should the printf's be using the PRI* macros for uint32_t? To be clear, the LOG_INFO() format string is: LOG_INFO(U_tg = %d mV, U_aux = %d mV, U_tgpwr = %d mV, I_tgpwr = %d mA, D1 =

Re: [Openocd-development] committed - printf() warning fixes

2009-06-19 Thread Zach Welch
On Fri, 2009-06-19 at 21:24 -0400, Duane Ellis wrote: [snip] If we had to fix this, what would we do to fix this: Today - we do not have macros, or types like GDB/GCC/GAS. GDB for instance uses CORE_ADDR - and has infrastructure behind it. [snip] This point deserves emphasis. This is the

Re: [Openocd-development] OpenOCD + libftdi on Windows

2009-06-19 Thread Zach Welch
On Sat, 2009-06-20 at 11:13 +0800, Xiaofan Chen wrote: On Fri, Jun 19, 2009 at 3:36 AM, Freddie Chopinfreddie_cho...@op.pl wrote: Anyway, about that equal performance with libftdi: Tested with a ~29kB image on LPC2103 (upload to flash): libftdi: Start address 0x3c, load size 29640

Re: [Openocd-development] r2269 build error (need --disable-werror ?)

2009-06-18 Thread Zach Welch
On Wed, 2009-06-17 at 18:17 -0400, Gene Smith wrote: gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I../.. -I../../src/helper -I../../src/target -g -O2 -Wall -Wstrict-prototypes -Wformat-security -Wextra -Wno-unused-parameter -Wbad-function-cast -Wcast-align -Wredundant-decls -Werror -MT tcl.lo -MD

Re: [Openocd-development] [PATCH 1/5] - Replace 'if(' with 'if ('.

2009-06-18 Thread Zach Welch
On Thu, 2009-06-18 at 00:43 -0700, David Brownell wrote: One of my pet peeves with this source base! Glad to see this stuff vanishing on a more wholesale basis. Clearly, it was one of mine... to the extent that I wrote a new tool to manage the process of producing chains of patches that affect

Re: [Openocd-development] [PATCH 9/11] Transform 'u64' to 'uint64_t'

2009-06-18 Thread Zach Welch
On Thu, 2009-06-18 at 03:17 -0700, David Brownell wrote: On Wednesday 17 June 2009, Zach Welch wrote: --- src/target/trace.h (working copy) +++ src/target/trace.h (working copy) @@ -28,7 +28,7 @@ typedef struct trace_point_s { uint32_t address; - u64 hit_counter

[Openocd-development] symbol cleanup

2009-06-18 Thread Zach Welch
Hi all, For my next trick with my Surpass tool, I intend to try and bring more uniformity to the various OpenOCD APIs. This primarily translates to renaming functions such that they group and sort better, but it should also involve structure and enum names. We could even go so far replace

Re: [Openocd-development] r2269 build error (need --disable-werror ?)

2009-06-18 Thread Zach Welch
On Thu, 2009-06-18 at 09:37 -0400, Gene Smith wrote: Zach Welch wrote: On Wed, 2009-06-17 at 18:17 -0400, Gene Smith wrote: gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I../.. -I../../src/helper -I../../src/target -g -O2 -Wall -Wstrict-prototypes -Wformat-security -Wextra -Wno-unused-parameter

Re: [Openocd-development] [PATCH 9/11] Transform 'u64' to 'uint64_t'

2009-06-18 Thread Zach Welch
On Thu, 2009-06-18 at 13:50 -0700, Rick Altherr wrote: On Jun 18, 2009, at 3:47 AM, Zach Welch wrote: On Thu, 2009-06-18 at 03:17 -0700, David Brownell wrote: On Wednesday 17 June 2009, Zach Welch wrote: --- src/target/trace.h (working copy) +++ src/target/trace.h (working copy

[Openocd-development] [PATCH 0/6] [C99] change types from uN to uintN_t

2009-06-17 Thread Zach Welch
Switch integer types to use C99 portable types. Despite my previous preference for the existing types, the fact remains that the standard types offer sufficient advantages to compel their use. For example, the new number parsing helper functions use these secondary definitions to support range

[Openocd-development] [PATCH 4/6] Transform 'u64' to 'uint64_t'

2009-06-17 Thread Zach Welch
Transform 'u64' to 'uint64_t' - Replace '\([^_]\)u64' with '\1uint64_t'. --- helper/types.h |4 ++-- target/trace.h |2 +- 2 files changed, 3 insertions(+), 3 deletions(-) Transform 'u64' to 'uint64_t' - Replace '\([^_]\)u64' with '\1uint64_t'. --- helper/types.h |4 ++--

[Openocd-development] [PATCH 6/6] Update Style Guide documentation to explain basic type rules.

2009-06-17 Thread Zach Welch
Update Style Guide documentation to explain basic type rules. --- style.txt |7 +++ 1 file changed, 7 insertions(+) Update Style Guide documentation to explain basic type rules. --- style.txt |7 +++ 1 file changed, 7 insertions(+) == only in patch2: unchanged: ---

Re: [Openocd-development] [PATCH 0/6] [C99] change types from uN to uintN_t

2009-06-17 Thread Zach Welch
On Wed, 2009-06-17 at 06:22 -0700, Zach Welch wrote: Switch integer types to use C99 portable types. Despite my previous preference for the existing types, the fact remains that the standard types offer sufficient advantages to compel their use. For example, the new number parsing helper

[Openocd-development] [PATCH 0/11] Change types from uN to uintN_t (take 2)

2009-06-17 Thread Zach Welch
Switch integer types to use C99 portable types. Despite my previous preference for the existing types, the fact remains that the standard types offer sufficient advantages to compel their use. For example, the new number parsing helper functions use these secondary definitions to support range

[Openocd-development] [PATCH 9/11] Transform 'u64' to 'uint64_t'

2009-06-17 Thread Zach Welch
Transform 'u64' to 'uint64_t' - Replace '\([^_]\)u64' with '\1uint64_t'. --- helper/types.h |4 ++-- target/trace.h |2 +- 2 files changed, 3 insertions(+), 3 deletions(-) Transform 'u64' to 'uint64_t' - Replace '\([^_]\)u64' with '\1uint64_t'. --- helper/types.h |4 ++--

[Openocd-development] [PATCH 10/11] Remove redundant typedefs in types.h; include stdint.h unconditionally.

2009-06-17 Thread Zach Welch
Remove redundant typedefs in types.h; include stdint.h unconditionally. --- types.h | 18 -- 1 file changed, 18 deletions(-) Remove redundant typedefs in types.h; include stdint.h unconditionally. --- types.h | 18 -- 1 file changed, 18 deletions(-) ==

[Openocd-development] [PATCH 8/11] Finish transforming 'u32' to 'uint32_t'.

2009-06-17 Thread Zach Welch
Finish transforming 'u32' to 'uint32_t'. - Replace '\([^_]\)u32' with '\1uint32_t'. - Replace '^u32' with 'uint32_t'. --- helper/binarybuffer.c| 18 helper/binarybuffer.h| 14 ++--- helper/fileio.c | 22 ++--

[Openocd-development] [SERIES 0/4] Whitespace Cleaning

2009-06-17 Thread Zach Welch
The following chain of patch series performs tree-wide whitespace clean-up, using systematic search and replacement (i.e. sed). It must be applied on top of the last series that changes the types. The patches in these series have been reviewed to ensure there are no adverse affects. Some

[Openocd-development] [PATCH 2/5] - Replace 'while(' with 'while ('.

2009-06-17 Thread Zach Welch
- Replace 'while(' with 'while ('. --- src/flash/avrf.c |6 +- src/flash/pic32mx.c |2 src/flash/stellaris.c|6 +- src/flash/str7x.c|2 src/flash/str9x.c|2

[Openocd-development] [PATCH 5/5] - Replace 'do{' with 'do ('.

2009-06-17 Thread Zach Welch
- Replace 'do{' with 'do {'. - Replace '}while' with '} while'. --- avrf.c|8 lpc288x.c |2 +- 2 files changed, 5 insertions(+), 5 deletions(-) - Replace 'do{' with 'do {'. - Replace '}while' with '} while'. --- avrf.c|8 lpc288x.c |2 +- 2 files

[Openocd-development] [PATCH 3/5] - Replace 'switch(' with 'switch ('.

2009-06-17 Thread Zach Welch
- Replace 'switch(' with 'switch ('. --- flash/cfi.c | 24 +++--- flash/ecos.c |2 - flash/flash.c |4 +- flash/mflash.c|2 - flash/stm32x.c|8 ++-- helper/jim.c | 78

[Openocd-development] [PATCH 4/5] - Replace 'for(' with 'for ('.

2009-06-17 Thread Zach Welch
- Replace 'for(' with 'for ('. --- src/flash/cfi.c |4 ++-- src/flash/flash.c |4 ++-- src/flash/nand_ecc.c |2 +- src/flash/pic32mx.c |4 ++-- src/helper/jim.c |8

[Openocd-development] [SERIES 2/4] Fix two-character binary operator whitespace

2009-06-17 Thread Zach Welch
Fix two-character binary operator whitespace issues throughout the tree: 1/10- Fixes '-=' whitespace 2/10- Fixes '!=' whitespace 3/10- Fixes '[+]=' whitespace 4/10- Fixes '[*]=' whitespace 5/10- Fixes '' whitespace 6/10- Fixes '=' whitespace 7/10- Fixes '=' whitespace

[Openocd-development] [PATCH 1/10] - Fixes '-=' whitespace

2009-06-17 Thread Zach Welch
- Fixes '-=' whitespace - Replace '\(\w\)\(-=\)(' with '\1 \2 ('. - Replace '\(\w\)\(-=\)\(\w\)' with '\1 \2 \3'. --- server/telnet_server.c |2 +- target/image.c |2 +- target/target.c|8 3 files changed, 6 insertions(+), 6 deletions(-) Fix two-character

[Openocd-development] [PATCH 3/10] - Fixes '[+]=' whitespace

2009-06-17 Thread Zach Welch
- Fixes '[+]=' whitespace - Replace '\(\w\)\([+]=\)(' with '\1 \2 ('. - Replace '\(\w\)\([+]=\)\(\w\)' with '\1 \2 \3'. --- flash/cfi.c|2 +- flash/ecos.c |2 +- flash/mflash.c |2 +- flash/ocl/at91sam7x/main.c |2 +-

[Openocd-development] [PATCH 4/10] - Fixes '[*]=' whitespace

2009-06-17 Thread Zach Welch
- Fixes '[*]=' whitespace - Replace '\(\w\)\([*]=\)\(\w\)' with '\1 \2 \3'. --- cfi.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Fix two-character binary operator whitespace issues throughout the tree: - Fixes '[*]=' whitespace - Replace '\(\w\)\([*]=\)\(\w\)' with '\1 \2 \3'. ---

[Openocd-development] [PATCH 5/10] - Fixes '' whitespace

2009-06-17 Thread Zach Welch
- Fixes '' whitespace - Replace ')\(\)(' with ') \1 ('. - Replace '\(\w\)\(\)(' with '\1 \2 ('. - Replace '\(\w\)\(\)\(\w\)' with '\1 \2 \3'. --- flash/at91sam7.c |2 +- helper/binarybuffer.h |4 ++-- helper/ioutil.c |4 ++-- jtag/core.c

[Openocd-development] [PATCH 7/10] - Fixes '=' whitespace

2009-06-17 Thread Zach Welch
- Fixes '=' whitespace - Replace '\(\w\)\(=\)\(\w\)' with '\1 \2 \3'. --- flash/at91sam7.c |4 ++-- helper/jim.c |4 ++-- jtag/bitq.c|2 +- target/arm7_9_common.c |6 +++--- 4 files changed, 8 insertions(+), 8 deletions(-) Fix two-character binary

[Openocd-development] [SERIES 3/4] Fix one-character binary operator whitespace.

2009-06-17 Thread Zach Welch
Fix one-character binary operator whitespace issues throughout the tree: 1/4 - Fixes '=' whitespace 2/4 - Fixes '+' whitespace 3/4 - Fixes '[|]' whitespace 4/4 - Fixes '[]' whitespace --- Summary of Patches 1-4: doc/manual/style.txt |7 src/ecosboard.c

[Openocd-development] [SERIES 4/4] Fix miscellaneous whitespace issues.

2009-06-17 Thread Zach Welch
Fix miscellaneous whitespace issues. 1/5 Remove whitespace that occurs after '('. 2/5 Remove whitespace that occurs before ')'. 3/5 - Replace '){' with ') {'. 4/5 Remove whitespace at end of lines, step 1. 5/5 Remove whitespace at end of lines, step 2. --- Summary of Patches

[Openocd-development] [PATCH 3/4] - Fixes '[|]' whitespace

2009-06-17 Thread Zach Welch
- Fixes '[|]' whitespace - Replace ')\([|]\)(' with ') \1 ('. - Replace ')\([|]\)\(\w\)' with ') \1 \2'. - Replace '\(\w\)\([|]\)(' with '\1 \2 ('. - Replace '\(\w\)\([|]\)\(\w\)' with '\1 \2 \3'. --- ecosboard.c|2 +- flash/at91sam7.c |6 +++---

Re: [Openocd-development] Problem with r2252 and mww

2009-06-16 Thread Zach Welch
On Tue, 2009-06-16 at 23:16 +0200, Michael Fischer wrote: Hello List, I try to make a smoke test with the r2252. But in case of my SAM7SE512 I got an error: telnet: mww 0xf130 0x mww write memory word addr value [count] Runtime error, file command.c,

Re: [Openocd-development] Performance #'s from Michael Fischer

2009-06-15 Thread Zach Welch
On Mon, 2009-06-15 at 22:43 +0200, Michael Fischer wrote: Hello List, sorry for splitting the thread with the license. But the list will not display the part with the performance. Here is my last try. If it is not working, the list will not use libftdi. From the performance point of

Re: [Openocd-development] OpenOCD license vs D2XX library

2009-06-15 Thread Zach Welch
Nicolas, I figured a simple NACK would not suffice, given the range of topics this thread has covered. This is not all meant for you, as I expect you have heard these arguments once or twice in the past. :) I just wanted to post to this thread once (and for all). On Mon, 2009-06-15 at 00:28

Re: [Openocd-development] OpenOCD license vs D2XX library

2009-06-15 Thread Zach Welch
On Mon, 2009-06-15 at 17:37 -0700, David Brownell wrote: On Monday 15 June 2009, Zach Welch wrote: Others have pointed out that this licensing violation occurs only when distributing the binaries, so I do want to provide assurance that I have no problem supporting these types of features

Re: [Openocd-development] Nit to pick with recent set of cleanups

2009-06-15 Thread Zach Welch
On Mon, 2009-06-15 at 17:01 -0700, Rick Altherr wrote: On Jun 15, 2009, at 4:19 PM, Zach Welch wrote: On Sat, 2009-06-13 at 21:14 -0400, Duane Ellis wrote: bool okay = *str !*end ULLONG_MAX != *ul; In my long career, I have seen too many poor souls - including my self

Re: [Openocd-development] [PATCH 0/6] Improve and extend parse_type helpers.

2009-06-15 Thread Zach Welch
On Mon, 2009-06-15 at 20:31 -0700, z...@superlucidity.net wrote: ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development I seem to have abused the mail system, despite

Re: [Openocd-development] libftdi must install at prefix=/usr on linux (doc issue)

2009-06-15 Thread Zach Welch
On Mon, 2009-06-15 at 11:08 -0400, Gene Smith wrote: I did a default configure/make/make install on the latest libftdi source tarball and it installed at /usr/share/. When I configured openocd with --enable-ft2232_libftdi it complained about unable to build and run the libftdi test program.

Re: [Openocd-development] [patch 1/3] polling updates for disabled TAPs

2009-06-13 Thread Zach Welch
On Fri, 2009-06-12 at 22:58 -0700, David Brownell wrote: On Friday 12 June 2009, Zach Welch wrote: I say most issues since (a) there's no interlock between a polling context and anything else, which may eventually trigger SMP issues; and (b) this is one of several areas where the jtag

Re: [Openocd-development] [patch 3/3] -disabled means after TLR.

2009-06-13 Thread Zach Welch
On Fri, 2009-06-12 at 21:42 -0700, David Brownell wrote: Doc update: say jtag newtap ... -disable records the state after exiting the RESET state, matching the only implementation we're working with so far (TI ICEpick-C). Matching code updates, including a few minor cleanups mostly related

Re: [Openocd-development] [patch] let the TCP ports be disabled (security)

2009-06-13 Thread Zach Welch
On Fri, 2009-06-12 at 22:52 -0700, David Brownell wrote: OpenOCD doesn't actually *need* to be keeping all TCP ports active ... creating security issues in some network configs. Instead, let config file specify e.g. tcl_port 0 (or gdb_port, telnet_port) to disable that particular remote

Re: [Openocd-development] [patch 3/3] -disabled means after TLR.

2009-06-13 Thread Zach Welch
On Sat, 2009-06-13 at 01:46 -0700, David Brownell wrote: On Saturday 13 June 2009, Zach Welch wrote: On Fri, 2009-06-12 at 21:42 -0700, David Brownell wrote: Doc update: say jtag newtap ... -disable records the state after exiting the RESET state, matching the only implementation

Re: [Openocd-development] mips32 big endian fix

2009-06-12 Thread Zach Welch
On Fri, 2009-06-12 at 09:55 +0200, Nico Coesel wrote: -Original Message- From: openocd-development-boun...@lists.berlios.de [mailto:openocd- development-boun...@lists.berlios.de] On Behalf Of David Claffey Sent: donderdag 11 juni 2009 23:18 To: openocd-development Subject:

Re: [Openocd-development] Compiling from svn on ubuntu 8.04 fails...

2009-06-12 Thread Zach Welch
On Fri, 2009-06-12 at 17:16 -0300, Alain Mouette wrote: Unfortunately there is more... I got a message about makeinfo, and solved installing texinfo. Now I have this and no clue about it: Npte that I am using a freshly instlled machine, so I don't have much installed. (Kubuntu 8.04)

Re: [Openocd-development] [patch] openocd.texi - move scan_chain doc forward

2009-06-12 Thread Zach Welch
On Fri, 2009-06-12 at 12:50 -0700, David Brownell wrote: Move the discussion of the scan_chain command up to go with the presentation of that topic in the TAP declaration chapter. This makes the presentation of the TAP and target lists be parallel, which will be something of an aid to

Re: [Openocd-development] [patch] behave better with irlen 16 bits

2009-06-12 Thread Zach Welch
On Fri, 2009-06-12 at 15:15 -0700, David Brownell wrote: On Friday 12 June 2009, Zach Welch wrote: Since you have looked at this code closely, can you tell us how hard would it be to support up to 64 bit IR lengths? My gut tells me that would require more systemic work, but perhaps I am

Re: [Openocd-development] [patch 1/3] polling updates for disabled TAPs

2009-06-12 Thread Zach Welch
On Fri, 2009-06-12 at 21:34 -0700, David Brownell wrote: Fix most of the polling issues relating to disabled targets: - Disable polling while running TAP event handlers ... the handlers rely on state machine transitions which polling will break. - Don't background-poll disabled TAPs

Re: [Openocd-development] ir/drscan and target layering violations

2009-06-11 Thread Zach Welch
On Thu, 2009-06-11 at 08:23 +0200, Øyvind Harboe wrote: I was thinking that pathmove, irscan and drscan commands should fail or at least give a warning if they are invoked while background polling is running. Sounds reasonable. But isn't that a layering violation? It looks like it, yes.

Re: [Openocd-development] [patch] minor fixes for helper/command.c

2009-06-11 Thread Zach Welch
On Thu, 2009-06-11 at 13:31 -0700, David Brownell wrote: Minor bugfix: command_print_sameline() is what the headers declare; make the code match. Minor improvement: make the printf format params always be const. --- src/helper/command.c |6 +++--- src/helper/command.h |6 +++---

Re: [Openocd-development] mips32 big endian fix

2009-06-11 Thread Zach Welch
On Thu, 2009-06-11 at 17:18 -0400, David Claffey wrote: A patch is needed for MIPS big endian (elf32-tradbigmips) targets. Perhaps I'm the first to test trunk with a MIPS big endian target. If -endian big is not set in target create, the endianess defaults to little. mw and md commands

Re: [Openocd-development] added pathmove command

2009-06-10 Thread Zach Welch
On Wed, 2009-06-10 at 09:19 +0200, Øyvind Harboe wrote: Committed. Does OMAP/BeagleBoard need this? This pathmove command is ready for testing feedback. I've done some quick smoketests and it reveals some interesting points in terms of where error checking should go... Discussed

Re: [Openocd-development] RFC: struct cleanup and more

2009-06-10 Thread Zach Welch
On Wed, 2009-06-10 at 21:40 -0400, Duane Ellis wrote: I have developed loadable module support in the past, and it's already on The List here. If I can afford to take the time, OpenOCD will be fully decoupled from its various driver modules. Debugging these things become a *ROYAL*

Re: [Openocd-development] assert vs. error messages

2009-06-09 Thread Zach Welch
On Tue, 2009-06-09 at 07:57 +0200, Øyvind Harboe wrote: How about a clearer policy of using assert()'s? I'm thinking that error()'s should be reserved for real runtime errors. if (!tap_is_state_stable(path[num_states - 1])) { LOG_ERROR(BUG: TAP path

Re: [Openocd-development] assert vs. error messages

2009-06-09 Thread Zach Welch
On Tue, 2009-06-09 at 08:51 +0200, Øyvind Harboe wrote: On Tue, Jun 9, 2009 at 8:29 AM, Zach Welchz...@superlucidity.net wrote: On Tue, 2009-06-09 at 07:57 +0200, Øyvind Harboe wrote: How about a clearer policy of using assert()'s? I'm thinking that error()'s should be reserved for real

[Openocd-development] to extern, or not to extern?

2009-06-09 Thread Zach Welch
Hi all, I want to remove the 'extern' keyword from all function prototypes. The extern keyword is redundant in such contexts, adds bulk, and visually make its difficult to spot real extern declarations. Some may have noticed that I have already stopped adding them to new functions that I am

Re: [Openocd-development] make maintainer-clean is does not work when build != src dir

2009-06-09 Thread Zach Welch
On Tue, 2009-06-09 at 12:00 +0200, Øyvind Harboe wrote: I use a different build openocd src dir, this means make maintainer-clean does not work... Is this old news? This is reproduceable under Linux as well as Cygwin. I tricked myself into believing that make maintainer-clean worked

Re: [Openocd-development] Problems with svn eol line endings and Cygwin when using Windows svn client

2009-06-09 Thread Zach Welch
On Tue, 2009-06-09 at 11:58 +0200, Øyvind Harboe wrote: I've had a bit of problems with Cygwin and svn eol native option. I thought I understood what was going on and I went ahead and did some changes to svn head, but I have since discovered that I do *not* understand what's going on so svn

Re: [Openocd-development] Problems with svn eol line endings and Cygwin when using Windows svn client

2009-06-09 Thread Zach Welch
On Tue, 2009-06-09 at 12:54 +0200, Øyvind Harboe wrote: Some more information about the subject: http://www.cygwin.com/ml/cygwin/2008-12/msg00525.html I particularly like the postscript. :) We are not alone here. I'm just going to close my eyes and hope I never hear of this again

Re: [Openocd-development] Problems with svn eol line endings and Cygwin when using Windows svn client

2009-06-09 Thread Zach Welch
On Tue, 2009-06-09 at 13:07 +0200, Øyvind Harboe wrote: On Tue, Jun 9, 2009 at 1:02 PM, Zach Welchz...@superlucidity.net wrote: On Tue, 2009-06-09 at 12:54 +0200, Øyvind Harboe wrote: Some more information about the subject: http://www.cygwin.com/ml/cygwin/2008-12/msg00525.html

Re: [Openocd-development] cygwin libtool: s/ECHO=/echo=/

2009-06-09 Thread Zach Welch
On Tue, 2009-06-09 at 09:58 -0400, Gene Smith wrote: I think most of the problem I discovered building under cygwin have been addressed today. However, I still have the problem with trunk/libtool needing to be modified manually to change ECHO= to echo=. Seems to be OK in linux. It appears

Re: [Openocd-development] cygwin libtool: s/ECHO=/echo=/

2009-06-09 Thread Zach Welch
On Tue, 2009-06-09 at 11:05 -0400, Gene Smith wrote: Zach Welch wrote: On Tue, 2009-06-09 at 09:58 -0400, Gene Smith wrote: I think most of the problem I discovered building under cygwin have been addressed today. However, I still have the problem with trunk/libtool needing

Re: [Openocd-development] My source [find target, interface etc.] lines in my .cfg files don't work with latest build

2009-06-09 Thread Zach Welch
On Tue, 2009-06-09 at 17:52 -0400, Brian Hutchinson wrote: On Tue, Jun 9, 2009 at 5:26 PM, Brian Hutchinson b.hutch...@gmail.com wrote: I searched and saw the thread on find tcl/target etc. from a week ago but can't figure out what is going on. Do we not use

Re: [Openocd-development] [patch] workaround CFI alignment error traps

2009-06-09 Thread Zach Welch
On Tue, 2009-06-09 at 15:13 -0700, David Brownell wrote: Tweak the csb337 code so that it doesn't enable alignment traps when it completes the reset init sequence. It turns out that the current CFI code reliably triggers such traps. I don't have time now to sort out what flavor bug that is;

Re: [Openocd-development] [patch] add board/csb337.cfg

2009-06-08 Thread Zach Welch
On Mon, 2009-06-08 at 17:50 -0700, David Brownell wrote: Add configuration for an old AT91rm9200 board, the Cogent CSB 337. Worth noting from the OpenOCD perspective: - It got a real hardware trace port connector; wired up here as much as we can, lacking inexpensive trace-aware dongles.

[Openocd-development] STR912 target

2009-06-08 Thread Zach Welch
Hi all, First, let me apologize for the mistaken extra changes in r2134. While I have reverted them in 2135, they do reflect some cleanup and touch-ups required to support my platform, and I have been meaning to take some time to figure out how to integrate these properly. Since this is the

Re: [Openocd-development] [patch] openocd.texi misc cleanup

2009-06-07 Thread Zach Welch
On Thu, 2009-06-04 at 01:59 -0700, David Brownell wrote: Various minor tweaks for the User's guide. - Fix various minor (but repeated) typographic goofs; - Talk about TAP declaration not creation (they exist even if OpenOCD never learns about their board); - Encourage board.cfg for

Re: [Openocd-development] [patch] openocd.texi - final commands (ch12/cpu config)

2009-06-07 Thread Zach Welch
On Fri, 2009-06-05 at 01:06 -0700, David Brownell wrote: Rework chapter 12 (CPU configuration) to use @deffn, match the code more closely, and present things more clearly. Includes the *current* list of targets. Whew ... this should be the last set of reference matter changes, I think all

Re: [Openocd-development] [PATCH] Make mdw output readable again

2009-06-07 Thread Zach Welch
On Thu, 2009-06-04 at 17:34 +0200, Magnus Lundin wrote: Regards Magnus Committed, r2098. Sorry for causing this regression. --Z ___ Openocd-development mailing list Openocd-development@lists.berlios.de

Re: [Openocd-development] [patch] evb_lm3s811 docs

2009-06-07 Thread Zach Welch
On Fri, 2009-06-05 at 02:55 -0700, David Brownell wrote: Clarify docs for the evb_lm3s811 layout: works in two modes, not just one. --- doc/openocd.texi |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) Committed, r2099. --Z ___

Re: [Openocd-development] [patch] just ignore disabled targets

2009-06-07 Thread Zach Welch
On Sat, 2009-06-06 at 19:43 -0700, David Brownell wrote: Let disabled targets be ignored during normal operation: - In target_examine(), ignore disabled TAPs - Reset handling must not poke at them either: * fail $target_name arp_* operations on disabled TAPs * in startup.tcl,

Re: [Openocd-development] [Patch] TAR autoincrement block size and alignment

2009-06-04 Thread Zach Welch
On Thu, 2009-06-04 at 12:49 +0200, Magnus Lundin wrote: Hi The number of bits used for TAR autoincrement when using CSW_ADDRINC_PACKED must be at least 10 according to ARM ADI specifications. Cortex-M3 uses 12 bits (4k blocks) and OMAP35xx uses 10 bits (1k blocks). This patch adds

Re: [Openocd-development] [patch] Files that point to stm32.cfg

2009-06-03 Thread Zach Welch
On Wed, 2009-06-03 at 08:18 +0200, Øyvind Harboe wrote: While it appears I made this realization erroneously with regard to the original thread, I believe the attached patch fixes the real problem that it made me spot. Are these files being used? Hopefully they will be at some point.

Re: [Openocd-development] [patch] Files that point to stm32.cfg

2009-06-03 Thread Zach Welch
On Wed, 2009-06-03 at 08:33 +0200, Øyvind Harboe wrote: On Wed, Jun 3, 2009 at 8:32 AM, Zach Welch z...@superlucidity.net wrote: On Wed, 2009-06-03 at 08:18 +0200, Øyvind Harboe wrote: While it appears I made this realization erroneously with regard to the original thread, I believe

Re: [Openocd-development] OpenOCD now available on FreeBSD

2009-06-03 Thread Zach Welch
On Wed, 2009-06-03 at 13:57 -0700, David Brownell wrote: On Wednesday 03 June 2009, CeDeROM wrote: Got patches for us? :) Do You mean patches for the other cables or to build the package? If You want to build the program, update the port tree with portsnap and type: I suspect he

Re: [Openocd-development] [path 1/5] openocd.texi - str9xpec and mflash updates

2009-06-03 Thread Zach Welch
On Wed, 2009-06-03 at 14:00 -0700, David Brownell wrote: Convert the str9xpec driver info to use @deffn; alphabetize; add the missing part_id command. Convert the mflash support to use @deffn; alphabetize. --- doc/openocd.texi | 159 -

Re: [Openocd-development] [patch 3/5] src/jtag/*c whitespace removal

2009-06-03 Thread Zach Welch
On Wed, 2009-06-03 at 14:02 -0700, David Brownell wrote: Remove pernicious whitespace from src/jtag/*c files; mostly the end-of-line flavor for now, although there's more. --- src/jtag/arm-jtag-ew.c | 14 - src/jtag/bitbang.c |2 src/jtag/ep93xx.c | 14 - src/jtag/jlink.c

Re: [Openocd-development] [patch 4/5] ft2232c whitespace and minor fixes

2009-06-03 Thread Zach Welch
On Wed, 2009-06-03 at 14:03 -0700, David Brownell wrote: Remove pernicious whitespace from ft2232 driver; as usual, end-of-line noise, but here also much line-internal stuff. Committed, r2038. Plus minor cleanup: - make Olimex glue warn about Olimex issues instead of JTAGkey issues; -

Re: [Openocd-development] [patch 2/5] openocd.texi - update interface driver section

2009-06-03 Thread Zach Welch
On Wed, 2009-06-03 at 14:01 -0700, David Brownell wrote: Convert the Interface/Dongle Config chapter's section on drivers to use the @deffn syntax, and integrate the presentation of the driver-specific commands with the relevant driver. Alphabetize. Cross-checked against the code ...

Re: [Openocd-development] [patch 5/5] openocd.texi - general (misc) commands chapter

2009-06-03 Thread Zach Welch
On Wed, 2009-06-03 at 14:07 -0700, David Brownell wrote: Update the General Commands (a.k.a. random stuff) chapter, and associated chunks of other text: - Switch to @deffn and review everything that's documented - Improve descriptions of reset events, with reference to the

Re: [Openocd-development] OpenOCD now available on FreeBSD

2009-06-02 Thread Zach Welch
On Tue, 2009-06-02 at 09:22 +0200, CeDeROM wrote: Hello world! OpenOCD 0.1.0 is now available on FreeBSD platform :-) Not all cables are available though - most of USB dongles work, these that required sys/io.h and microhttpd does not work. If someone needs these cables and want them added,

Re: [Openocd-development] [patch 2/2] openocd.texi - lowlevel jtag commands

2009-06-02 Thread Zach Welch
On Tue, 2009-06-02 at 17:39 -0400, Gene Smith wrote: David Brownell wrote: Update docs for most of the remaining commands in jtag.c: - switch to @deffn - these are just the low level JTAG commands - resolve much goofage! * remove docs for non-existent commands * add

Re: [Openocd-development] [patch] Files that point to stm32.cfg

2009-06-02 Thread Zach Welch
On Tue, 2009-06-02 at 14:52 -0700, Zach Welch wrote: On Tue, 2009-06-02 at 22:45 +0200, Øyvind Harboe wrote: On Tue, Jun 2, 2009 at 9:31 PM, Gene Smith g...@chartertn.net wrote: I see in r2003 that stm32.cfg is now in tcl/ which caused an error for cfg files that attempt to point

Re: [Openocd-development] [patch 1/2] openocd.texi - rework TAP creation doc

2009-06-02 Thread Zach Welch
On Tue, 2009-06-02 at 14:02 -0700, David Brownell wrote: Rework the TAP creation documentation. - Try to use TAP not tap everywhere; it's an acronym. - Update the associated target config files section: * reference the TAP Creation chapter for details * simplify: reference

Re: [Openocd-development] [patch 2/2] openocd.texi - lowlevel jtag commands

2009-06-02 Thread Zach Welch
On Tue, 2009-06-02 at 14:19 -0700, David Brownell wrote: Update docs for most of the remaining commands in jtag.c: - switch to @deffn - these are just the low level JTAG commands - resolve much goofage! * remove docs for non-existent commands * add missing docs for some

Re: [Openocd-development] RFC: struct cleanup and more

2009-06-01 Thread Zach Welch
On Mon, 2009-06-01 at 20:56 +0200, Øyvind Harboe wrote: Is splitting jtag.h somewhere on your list? One jtag.h w/public definitions and another with definitions for drivers eyes and jtag.c only Definitely. I think flash.h deserves similar treatment too. Zach

Re: [Openocd-development] [patch 1/4] other half of r1974

2009-06-01 Thread Zach Welch
On Mon, 2009-06-01 at 15:41 -0700, David Brownell wrote: This is the missing half of the r1974 patch: OSK5912 board support, which was split out from the omap5912 target config. --- tcl/board/osk5912.cfg | 28 tcl/target/omap5912.cfg | 34

Re: [Openocd-development] [patch 3/4] remove evil whitespace in jtag.c

2009-06-01 Thread Zach Welch
On Mon, 2009-06-01 at 15:44 -0700, David Brownell wrote: Whitespace fixes in jtag.c ... mostly end-of-line crap. Flag jtag_device command as obsolete in its helptext. --- src/jtag/jtag.c | 24 +++- 1 file changed, 11 insertions(+), 13 deletions(-) Committed, r1987.

Re: [Openocd-development] RFC: struct cleanup and more

2009-06-01 Thread Zach Welch
On Mon, 2009-06-01 at 11:12 -0700, Rick Altherr wrote: I'm all for removing the type redundancy, but I'd rather see the typedef stay and remove the struct name instead. It reduces typing when specifying the type and gets rid of the unnecessary separation of struct type names from other

Re: [Openocd-development] RFC: struct cleanup and more

2009-06-01 Thread Zach Welch
On Mon, 2009-06-01 at 20:19 -0700, Rick Altherr wrote: On Jun 1, 2009, at 8:08 PM, Zach Welch wrote: On Mon, 2009-06-01 at 11:12 -0700, Rick Altherr wrote: I'm all for removing the type redundancy, but I'd rather see the typedef stay and remove the struct name instead. It reduces typing

<    1   2   3   4   5   6   7   8   9   >