Re: [devel] checkpoint problems

2014-01-09 Thread A V Mahesh
Hi Alex, Use the below patch as workaround for you to proceed your testing . This patch just increases the MDS internal fragmentation value to ~ TIPC_MAX_USER_MSG_SIZE define in tipc.h I will work with Hans to have final patch by considering the both TIPC TCP transports, and testing

Re: [devel] [PATCH 1 of 1] base: memory leaks in base [#712]

2014-01-09 Thread Ramesh Betham
Also please push this fix in 4.3.x too. Thanks, Ramesh. On 1/9/2014 1:49 PM, Ramesh Betham wrote: Ack. Thanks, Ramesh. On 1/8/2014 7:56 PM, reddy.neelaka...@oracle.com wrote: osaf/libs/core/leap/sysf_mem.c| 1 + osaf/libs/core/mbcsv/mbcsv_util.c | 12 ++-- 2 files

Re: [devel] [PATCH 1 of 1] amfd : clear node level admin op related flags during sufailover [#663]

2014-01-09 Thread Hans Feldt
I have a similar problem and solution in my pending patch for http://sourceforge.net/p/opensaf/tickets/601/ I don't think we should return TIMEOUT, this can cause upgrades to fail. I mean the purpose of the LOCK operation (to un-assign the service) has been fulfilled albeit with some errors.

Re: [devel] [PATCH 1 of 1] amf: Donot allow more than 1 csi addition in single ccb [#681]

2014-01-09 Thread Hans Feldt
Hi, As I previously proposed (and even provided patch for) to change the SG FSM state to non stable would solve the problem in a more elegant and standard way. Why can't we just do that instead? And what about the use case, a fact is that no documentation states that only a single CSI per CCB

Re: [devel] [PATCH 00 of 15] Review Request for AMF: Coverity issues in amfd/amfnd [#680]

2014-01-09 Thread Hans Feldt
Is this a patch series for 4.5 or default? The ticket is an enhancement, is the 4.4 window closed? Thanks, Hans On 01/03/2014 06:51 AM, Gary Lee wrote: Summary: AMF: Coverity issues in amfd/amfnd [#680] Review request for Trac Ticket(s): 680 Peer Reviewer(s): Hans N, Hans F, Praveen,

Re: [devel] [PATCH 0 of 4] Review Request for clm: Add CLMNA as a component and support node eviction after opensafd stop [#220]

2014-01-09 Thread Hans Feldt
Then I am confused, CLMNA is now a daemon for what purpose? /Hans -Original Message- From: Mathivanan Naickan Palanivelu [mailto:mathi.naic...@oracle.com] Sent: den 9 januari 2014 13:18 To: Hans Feldt; Ramesh Babu Betham Cc: opensaf-devel@lists.sourceforge.net Subject: RE: [devel]

[devel] [PATCH 0 of 1] Review Request for amfd : clear node level admin op related flags during sufailover [#663]

2014-01-09 Thread praveen . malviya
Summary: amfd : clear node level admin op related flags during sufailover [#663]. Review request for Trac Ticket(s): AMF #663 Peer Reviewer(s): LIST THE TECH REVIEWER(S) / MAINTAINER(S) HERE Pull request to: Hans F., Nagendra Affected branch(es):Default and 4.4 Development branch: IF ANY

Re: [devel] [PATCH 0 of 4] Review Request for clm: Add CLMNA as a component and support node eviction after opensafd stop [#220]

2014-01-09 Thread Mathivanan Naickan Palanivelu
-Original Message- From: Hans Feldt [mailto:hans.fe...@ericsson.com] Sent: Thursday, January 09, 2014 5:45 PM To: Mathivanan Naickan Palanivelu; Ramesh Babu Betham Cc: opensaf-devel@lists.sourceforge.net Subject: RE: [devel] [PATCH 0 of 4] Review Request for clm: Add CLMNA as a

Re: [devel] [PATCH 00 of 15] Review Request for AMF: Coverity issues in amfd/amfnd [#680]

2014-01-09 Thread Gary Lee
Hi There are some memory leaks fixed in the patch series that would be applicable to 4.4. I guess I should extract just the leak fixes for the next 4.4 candidate / correction release? Thanks Gary Quoting Anders Björnerstedt anders.bjornerst...@ericsson.com: Yes 4.4 window is closed since

Re: [devel] [PATCH 00 of 15] Review Request for AMF: Coverity issues in amfd/amfnd [#680]

2014-01-09 Thread Hans Feldt
Yes please do that asap, you do need defect tickets per service also... Thanks, Hans -Original Message- From: Gary Lee [mailto:gary@dektech.com.au] Sent: den 9 januari 2014 13:26 To: Anders Björnerstedt Cc: Hans Feldt; Hans Nordebäck; praveen.malv...@oracle.com;

Re: [devel] [PATCH 08 of 15] amfd: Correct a number of issues identified by Coverity [#680]

2014-01-09 Thread Anders Widell
Hi! Replacing sprintf with snprintf is an improvement, but error handling is still missing in the code below. snprintf() returns -1 in case of an error, and it can return a value larger than or equal to SA_MAX_NAME_LENGTH in case the concatenation below would have overflowed the buffer. In

Re: [devel] [PATCH 00 of 15] Review Request for AMF: Coverity issues in amfd/amfnd [#680]

2014-01-09 Thread Anders Björnerstedt
Yeah, fixes to memory leaks would be fixes of defects, not classed as enhancements. Youn need to write at least one separate defect ticket for the memory leak problems. Defects should be fixed on all supported branches, where applicable. In general, the point with discriminating between the

Re: [devel] checkpoint problems

2014-01-09 Thread Alex Jones
I went back to MAX_SYNC_TRANSFER_SIZE (30 * 1024 * 1024), and made the MDS changes you suggest. This works great guys, even up at 40k and 50k sections. Thanks! Alex On 01/09/2014 04:43 AM, A V Mahesh wrote: Hi Alex, Use the below patch as workaround for you to proceed your testing . This