Re: [devel] [PATCH 1 of 1] amfd: allow change to saAmfSGNumPrefActiveSUs for N+M SG while UNLOCKED [#871]

2014-05-13 Thread Nagendra Kumar
Hi Alex, I couldn't get the below change: + if (value_is_deleted) + sg-saAmfSGNumPrefActiveSUs = sg-saAmfSGNumPrefActiveSUs; + else Thanks -Nagu -Original Message- From: Alex Jones

[devel] [PATCH 1 of 1] amfnd: Not all npi-components are restarted during SuRestart escalation [#885]

2014-05-13 Thread Minh Hon Chau
osaf/services/saf/amf/amfnd/err.cc | 13 ++--- osaf/services/saf/amf/amfnd/susm.cc | 24 ++-- 2 files changed, 28 insertions(+), 9 deletions(-) Problem: In case of npi su restart recovery, the condition to change su presence state is not sufficient. If the

[devel] [PATCH 0 of 1] Review Request for amfnd: Not all npi-components are restarted during SuRestart escalation [#885]

2014-05-13 Thread Minh Hon Chau
Summary: amfnd: Not all npi-components are restarted during SuRestart escalation [#885] Review request for Trac Ticket(s): 885 Peer Reviewer(s): Hans F, Hans N, Nagendra, Praveen Pull request to: Affected branch(es): default Development branch: default Impacted

[devel] [PATCH 0 of 1] Review Request for imm: fix memory leak in IMM library when search handle is closed [#907]

2014-05-13 Thread Zoran Milinkovic
Summary: imm: fix memory leak in IMM library when search handle is closed [#907] Review request for Trac Ticket(s): 907 Peer Reviewer(s): Neelakanta Pull request to: Zoran Affected branch(es): opensaf-4.4.x, default(4.5) Development branch: default(4.5) Impacted

Re: [devel] [PATCH 4 of 5] amfd: add SU::reset_all_comps_assign_flag [#713]

2014-05-13 Thread Nagendra Kumar
Ack -Nagu -Original Message- From: Hans Feldt [mailto:osafde...@gmail.com] Sent: 13 May 2014 11:24 To: Nagendra Kumar; hans.nordeb...@ericsson.com Cc: opensaf-devel@lists.sourceforge.net Subject: [PATCH 4 of 5] amfd: add SU::reset_all_comps_assign_flag [#713]

Re: [devel] [PATCH 5 of 5] amfd: add SU::find_unassigned_comp_that_provides_cstype [#713]

2014-05-13 Thread Nagendra Kumar
Ack -Nagu -Original Message- From: Hans Feldt [mailto:osafde...@gmail.com] Sent: 13 May 2014 11:24 To: Nagendra Kumar; hans.nordeb...@ericsson.com Cc: opensaf-devel@lists.sourceforge.net Subject: [PATCH 5 of 5] amfd: add SU::find_unassigned_comp_that_provides_cstype [#713]

Re: [devel] [PATCH 3 of 5] amfd: move supreinst logic from comp to su [#713]

2014-05-13 Thread Nagendra Kumar
1. Not sure, why you have moved the logic to su from comp. Since component being added in su makes difference of PI/NPI SU. Ideally the code should have been in su. 2. Removing logic whether su is being deleted, will result in ERROR_NOT_EXIST in rt update of su. Any specific reason

Re: [devel] [PATCH 1 of 1] amfnd: Not all npi-components are restarted during SuRestart escalation [#885]

2014-05-13 Thread praveen malviya
Please see inline some comments and at the end a simple patch that fixes the problem with less code. Thanks Praveen On 13-May-14 1:27 PM, Minh Hon Chau wrote: osaf/services/saf/amf/amfnd/err.cc | 13 ++--- osaf/services/saf/amf/amfnd/susm.cc | 24 ++-- 2

Re: [devel] [PATCH 1 of 1] amfnd: Not all npi-components are restarted during SuRestart escalation [#885]

2014-05-13 Thread minhchau
Hi Praveen, My patch has problem about the way npi component is retrieved, it should be retrieved from csi as currently. I just load your patch and test it. I can see components are incurred many extra restarts than expected. Let's look at this case: kill comp #15 #10 #8 #2 - componentRestart

Re: [devel] [PATCH 1 of 1] amfd: allow change to saAmfSGNumPrefActiveSUs for N+M SG while UNLOCKED [#871]

2014-05-13 Thread Alex Jones
Oh. That is really to disallow deleting the attribute. Do I even need it? Alex On 05/13/2014 02:15 AM, Nagendra Kumar wrote: Hi Alex, I couldn't get the below change: + if (value_is_deleted) + sg-saAmfSGNumPrefActiveSUs =

Re: [devel] [PATCH 1 of 1] amfnd: Not all npi-components are restarted during SuRestart escalation [#885]

2014-05-13 Thread minhchau
Hi Praveen, I have added the check to your patch, it works fine now diff--gita/osaf/services/saf/amf/amfnd/susm.cc b/osaf/services/saf/amf/amfnd/susm.cc --- a/osaf/services/saf/amf/amfnd/susm.cc +++ b/osaf/services/saf/amf/amfnd/susm.cc @@ -2637,12