Ack for both the patches.
Thanks,
Praveen
On 09-Jun-14 1:48 PM, Hans Nordeback wrote:
Summary: AMF: remove EDU use in App v2
Review request for Trac Ticket(s): #713
Peer Reviewer(s): Praveen
Pull request to:
Affected branch(es): default
Development branch: default
Review but didn't test.
Ack from me.
Best regards,
Zoran
-Original Message-
From: Anders Bjornerstedt [mailto:anders.bjornerst...@ericsson.com]
Sent: den 9 juni 2014 08:18
To: reddy.neelaka...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: [devel] [PATCH 0 of 1] Review
Summary: amfd: replace patricia tree with stl::maps in node [#713]
Review request for Trac Ticket(s): #713
Peer Reviewer(s): hans.fe...@ericsson.com, hans.nordeb...@ericsson.com,
praveen.malv...@oracle.com
Pull request to:
Affected branch(es): default
Development branch: default
osaf/services/saf/amf/amfd/ckpt_enc.cc| 10 +-
osaf/services/saf/amf/amfd/clm.cc | 15 ++--
osaf/services/saf/amf/amfd/imm.cc | 12 +--
osaf/services/saf/amf/amfd/include/node.h | 11 +--
osaf/services/saf/amf/amfd/main.cc| 8 +-
Please use gcc 4.9 to compile default branch.
Thanks,
Praveen
On 10-Jun-14 9:50 AM, Yao Cheng LIANG wrote:
OK. Thanks. /Ted
-Original Message-
From: Gary Lee [mailto:gary@dektech.com.au]
Sent: Tuesday, June 10, 2014 11:34 AM
To: Yao Cheng LIANG; 'A V Mahesh'
Cc:
ack, one minor comment make copy constructor and assignment operator
private if they are not needed./Regards HansN
On 06/10/14 03:28, Gary Lee wrote:
osaf/services/saf/amf/amfd/include/si.h | 5 +++-
osaf/services/saf/amf/amfd/si.cc| 43
++--
2
ack, code review only/Regards HansN
On 06/10/14 03:28, Gary Lee wrote:
osaf/services/saf/amf/amfd/include/si.h | 5 ++-
osaf/services/saf/amf/amfd/si.cc| 45
2 files changed, 9 insertions(+), 41 deletions(-)
diff --git
Hi!
I have started testing this patch. When I build RPMs and install on
openSUSE 13.2.M0 I get the following log messages:
Jun 10 15:31:19 SC-1 systemd[1]: Configuration file
/usr/lib/systemd/system/opensafd.service is marked executable. Please
remove executable permission bits. Proceeding
Oh great...
After a quick perusal of the systemd changelogs, it looks like they
removed support for ControlGroup in systemd-205, replacing it with
different attributes. ControlGroup is the key attribute that allows RT
threads to work under systemd (which we need!).
Did it start OpenSAF, or
osaf/services/saf/amf/amfd/include/si.h | 7 -
osaf/services/saf/amf/amfd/si.cc| 43 ++--
2 files changed, 40 insertions(+), 10 deletions(-)
diff --git a/osaf/services/saf/amf/amfd/include/si.h
b/osaf/services/saf/amf/amfd/include/si.h
---
Summary: amfd: Add constructor for AVD_SI V2 [#713]
Review request for Trac Ticket(s): 713
Peer Reviewer(s): Hans N.
Pull request to:
Affected branch(es): default
Development branch: default
Impacted area Impact y/n
Docs
Summary: cpsv: set dtaBuff to NULL and readSize to zero in TrackCallback
V2[#733]
Review request for Trac Ticket(s): #733
Peer Reviewer(s): Ramesh
Pull request to: LIST THE PERSON WITH PUSH ACCESS HERE
Affected branch(es): LIST ALL AFFECTED BRANCH(ES)
Development branch: IF ANY GIVE THE REPO URL
osaf/services/saf/cpsv/cpnd/cpnd_evt.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
In case of section deletion dataSize is set to zero in the TrackCallback()
diff --git a/osaf/services/saf/cpsv/cpnd/cpnd_evt.c
b/osaf/services/saf/cpsv/cpnd/cpnd_evt.c
---
Summary: cpsv: set dataSize to zero in case of section deletion in the
TrackCallback [#734]
Review request for Trac Ticket(s): #734
Peer Reviewer(s):Ramesh
Pull request to: LIST THE PERSON WITH PUSH ACCESS HERE
Affected branch(es): 4.4 default
Development branch: default
Ack.
Thanks,
Ramesh.
On 6/11/2014 8:49 AM, mahesh.va...@oracle.com wrote:
osaf/libs/agents/saf/cpa/cpa_proc.c | 2 +-
osaf/services/saf/cpsv/cpnd/cpnd_proc.c | 2 ++
2 files changed, 3 insertions(+), 1 deletions(-)
Now in the TrackCallback() the ioVector dtaBuff is set to NULL
Ack.
Thanks,
Ramesh.
On 6/11/2014 8:51 AM, mahesh.va...@oracle.com wrote:
osaf/services/saf/cpsv/cpnd/cpnd_evt.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
In case of section deletion dataSize is set to zero in the TrackCallback()
diff --git
osaf/services/saf/amf/amfd/include/sg.h | 13 +
osaf/services/saf/amf/amfd/sg_2n_fsm.cc | 23 ++-
osaf/services/saf/amf/amfd/sg_nored_fsm.cc | 22 +-
osaf/services/saf/amf/amfd/sg_npm_fsm.cc | 22 +-
osaf/services/saf/amf/amfd/include/sg.h | 19 +--
osaf/services/saf/amf/amfd/sg_2n_fsm.cc | 27 +--
osaf/services/saf/amf/amfd/sg_nored_fsm.cc | 27 +--
osaf/services/saf/amf/amfd/sg_npm_fsm.cc | 27
Summary: Start of SG refactoring
Review request for Trac Ticket(s): 713
Peer Reviewer(s): AMF developers
Pull request to: LIST THE PERSON WITH PUSH ACCESS HERE
Affected branch(es): default
Development branch: IF ANY GIVE THE REPO URL
Impacted area Impact y/n
Summary: amfd: SI refactoring part 2 [#713]
Review request for Trac Ticket(s): 713
Peer Reviewer(s): AMF maintainers
Pull request to:
Affected branch(es): default
Development branch: default
Impacted area Impact y/n
Docs
osaf/services/saf/amf/amfd/include/si.h | 1 +
osaf/services/saf/amf/amfd/si.cc| 88
2 files changed, 44 insertions(+), 45 deletions(-)
diff --git a/osaf/services/saf/amf/amfd/include/si.h
b/osaf/services/saf/amf/amfd/include/si.h
---
osaf/services/saf/amf/amfd/include/si.h | 1 -
osaf/services/saf/amf/amfd/si.cc| 20
2 files changed, 0 insertions(+), 21 deletions(-)
diff --git a/osaf/services/saf/amf/amfd/include/si.h
b/osaf/services/saf/amf/amfd/include/si.h
---
osaf/services/saf/amf/amfd/include/si.h | 2 +
osaf/services/saf/amf/amfd/si.cc| 46 +++-
2 files changed, 24 insertions(+), 24 deletions(-)
Make avd_si_adjust_si_assignments a class member function of AVD_SI
diff --git
23 matches
Mail list logo
