Summary: amfd: replace patricia tree with stl::maps for node_lists [#713]
Review request for Trac Ticket(s): #713
Peer Reviewer(s): Hans N, Hans F, Praveen
Pull request to: LIST THE PERSON WITH PUSH ACCESS HERE
Affected branch(es): default
Development branch: default
osaf/services/saf/amf/amfd/include/node.h | 2 +-
osaf/services/saf/amf/amfd/main.cc| 10 +-
osaf/services/saf/amf/amfd/ndfsm.cc | 49 +++---
3 files changed, 28 insertions(+), 33 deletions(-)
diff --git a/osaf/services/saf/amf/amfd/include/node.h
Ack, code review only/Regards HansN
-Original Message-
From: nagendr...@oracle.com [mailto:nagendr...@oracle.com]
Sent: den 23 juli 2014 13:01
To: Hans Feldt; Hans Nordebäck; praveen.malv...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1] amfd: replace patricia
Hi Neelakanta,
The reason you are getting these errors is that you didn't enable extended
names on server side.
You must add to immnd.conf:
export SA_ENABLE_EXTENDED_NAMES=1
I'll add this line to immnd.conf.
Best regards,
Zoran
-Original Message-
From: Neelakanta Reddy
Hi Neel.
There is some valuable work done in this patch and most of it is ok.
But in its current state I have to give it a NACK.
It needs some adjustments and extension before it can be pushed.
There are two main problems:
1) The PBE is the main OI for the object involved and we actually want
Hi zoran,
Forgot to export SA_ENABLE_EXTENDED_NAMES=1.
after exporting new immomtest and new immoitest are working fine.
Its good to add SA_ENABLE_EXTENDED_NAMES=1 to immnd.conf
Ack for patch 4.
Thanks,
Neel.
On Wednesday 23 July 2014 08:19 PM, Zoran Milinkovic wrote:
Hi Neelakanta,
The
Hi AndersBj,
Publish the new patch with the below comments.
Thanks,
Neel.
On Wednesday 23 July 2014 08:34 PM, Anders Bjornerstedt wrote:
Hi Neel.
There is some valuable work done in this patch and most of it is ok.
But in its current state I have to give it a NACK.
It needs some
