Hi Vu,
Thanks, I will check this and fix what's needed before pushing.
/Lennart
> -Original Message-
> From: Vu Minh Nguyen [mailto:vu.m.ngu...@dektech.com.au]
> Sent: den 8 december 2015 04:26
> To: 'Mathivanan Naickan Palanivelu'; Lennart Lund
> Cc: opensaf-devel@lists.sourceforge.net
Summary: log: switching to use the C++ compiler [#1624]
Review request for Trac Ticket(s): #1624
Peer Reviewer(s): mathi.naic...@oracle.com; lennart.l...@ericsson.com;
anders.wid...@ericsson.com
Pull request to: Lennart
Affected branch(es): Default
Development branch: <>
Summary: cpsv: improve handling unlink and close non-collocated checkpoint
[#1616]
Review request for Trac Ticket(s): #1616
Peer Reviewer(s): mahesh.va...@oracle.com; anders.wid...@ericsson.com
Pull request to: mahesh.va...@oracle.com
Affected branch(es): 4.6, 4.7, default
Development branch:
Hi,
Ok got it , I will review both cases
-AVM
On 12/9/2015 11:34 AM, Nhat Pham wrote:
> Hi Mahesh,
>
> For 'several problem', I mean 3 use cases where:
> 1,2 : the checkpoint replicas are not deleted immediately even no client
> exists
> 3: the checkpoint is deleted although there is a client
osaf/services/saf/logsv/lgs/Makefile.am| 34 ---
osaf/services/saf/logsv/lgs/lgs.h | 10 ++-
osaf/services/saf/logsv/lgs/lgs_amf.c |4 +-
osaf/services/saf/logsv/lgs/lgs_cb.h |8 +
osaf/services/saf/logsv/lgs/lgs_config.c | 113 ++
Summary: log: switching to use the C++ compiler [#1624] V2
Review request for Trac Ticket(s): #1624
Peer Reviewer(s): mathi.naic...@oracle.com; lennart.l...@ericsson.com;
anders.wid...@ericsson.com
Pull request to: Lennart
Affected branch(es): Default
Development branch: <>
Hi Nhat
>>There are several problems relating to closing and unlinking
non-collocated checkpoint.
I can see only one problem unlinked non-collocated checkpoint is not
getting deleted immediate
even No client exist for that non-collocated checkpoint.
I see 1,2 ,3 are use-case of
Hi Mahesh,
For 'several problem', I mean 3 use cases where:
1,2 : the checkpoint replicas are not deleted immediately even no client
exists
3: the checkpoint is deleted although there is a client using the
checkpoint.
The patch only addresses the problem in these 3 use cases.
Best regards,
Nhat
Ack for the series (code review only) with one minor comment:
amfd/include/ntf.h contains an unused declaration
fill_ntf_header_part(). It can be deleted as AMF uses
fill_ntf_header_part_avd() in ntf.cc.
Thanks,
Praveen
On 02-Dec-15 1:19 PM, Hans Nordeback wrote:
>
