Hi Hoang ,
On 6/30/2016 9:22 AM, Vo Minh Hoang wrote:
> Dear Mahesh,
>
> Now I am updating documents related to CKPT long DN.
> It will be submitted soon.
Ok you can ignore comment one.
I will provide patch by patch clarification & review comments, please
find them for [PATCH 1 of 8]
Hi,
> isRestartError() function has one if statement and it is used in another very
> small function.
Yes, but it makes the code where it is used much easier to read. It is not easy
to see what the if statement do but the usage of the isRestartError() function
makes it clear. I will therefore
Hi Zoran,
I will change the commit message when pushing.
Thanks,
Hung Nguyen - DEK Technologies
From: Zoran Milinkovic zoran.milinko...@ericsson.com
Sent: Wednesday, June 29, 2016 3:38PM
To: Hung Nguyen,
Hi Zoran and Neel,
I will include you comments when pushing.
Thanks,
Hung Nguyen - DEK Technologies
From: Neelakanta Reddy reddy.neelaka...@oracle.com
Sent: Tuesday, June 28, 2016 7:02PM
To: Zoran Milinkovic,
Hi Hung,
Minor comment, shouldn't the subject be ". IMMND killing PBE" instead of
". IMMND killing itself" ?
Reviewed the code.
Ack from me.
Thanks,
Zoran
-Original Message-
From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au]
Sent: Wednesday, June 29, 2016 8:21 AM
To:
ACK,
isRestartError() function has one if statement and it is used in another very
small function.
On 06/17/2016 05:08 PM, Lennart Lund wrote:
> Summary: smf: Lock nodes in parallel
> Review request for Trac Ticket(s): #1634
> Peer Reviewer(s): reddy.neelaka...@oracle.com,
Hi Hung,
Reviewed the patch.
Ack.
/Neel.
On 2016/06/29 11:50 AM, Hung Nguyen wrote:
> Summary: imm: Fix the problem with IMMND killing itself [#1899]
> Review request for Trac Ticket(s): 1899
> Peer Reviewer(s): Zoran, Neel
> Pull request to:
> Affected branch(es): 5.0, 5.1
> Development
Hi Hung,
Reviewed the patch,
Ack.
/Neel.
On 2016/06/24 05:06 PM, Hung Nguyen wrote:
> Summary: immtool: Add missing wrappers for IMM APIs [#1891]
> Review request for Trac Ticket(s): 1891
> Peer Reviewer(s): Zoran, Neel
> Pull request to:
> Affected branch(es): 4.7, 5.0, 5.1
> Development
osaf/services/saf/immsv/immnd/immnd_proc.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
Fix the problem with IMMND killing itself.
diff --git a/osaf/services/saf/immsv/immnd/immnd_proc.c
b/osaf/services/saf/immsv/immnd/immnd_proc.c
--- a/osaf/services/saf/immsv/immnd/immnd_proc.c
Summary: imm: Fix the problem with IMMND killing itself [#1899]
Review request for Trac Ticket(s): 1899
Peer Reviewer(s): Zoran, Neel
Pull request to:
Affected branch(es): 5.0, 5.1
Development branch: 5.1
Impacted area Impact y/n
Hi Lennart,
Reviewed the patch.
Ack.
/Neel.
On 2016/06/28 08:19 PM, Lennart Lund wrote:
> Summary: smf: Lock nodes in parallel
> Review request for Trac Ticket(s): #1634
> Peer Reviewer(s): reddy.neelaka...@oracle.com, rafael.odza...@ericsson.com
> Pull request to: <>
> Affected branch(es): <>
11 matches
Mail list logo
