Re: [devel] [PATCH 1 of 1] amfd: adapt unit tests for long DN support [#1642]

Hi Gary, Ack (Tested). Best regards, Long Nguyen. On 8/24/2016 10:47 AM, Gary Lee wrote: > osaf/services/saf/amf/amfd/tests/test_amfdb.cc| 2 +- > osaf/services/saf/amf/amfd/tests/test_ckpt_enc_dec.cc | 46 > +++--- > 2 files changed, 19 insertions(+), 29

[devel] [PATCH 0 of 1] Review Request for amfd: adapt unit tests for long DN support [#1642]

Summary: amfd: adapt unit tests for long DN support [#1642] Review request for Trac Ticket(s): 1642 Peer Reviewer(s): AMF devs Pull request to: <> Affected branch(es): default Development branch: default Impacted area Impact y/n

[devel] [PATCH 1 of 1] amfd: adapt unit tests for long DN support [#1642]

osaf/services/saf/amf/amfd/tests/test_amfdb.cc| 2 +- osaf/services/saf/amf/amfd/tests/test_ckpt_enc_dec.cc | 46 +++--- 2 files changed, 19 insertions(+), 29 deletions(-) diff --git a/osaf/services/saf/amf/amfd/tests/test_amfdb.cc

Re: [devel] [PATCH 1 of 1] pyosaf: Add __str__ method into non extended SaNameT class [#1737]

Hi, If no more comment, it will be pushed by tomorrow (2016/08/25) Thanks, Quyen -Original Message- From: Hans Nordebäck [mailto:hans.nordeb...@ericsson.com] Sent: Wednesday, August 10, 2016 7:27 PM To: Quyen Dao ; srikanth.revan...@oracle.com Cc:

Re: [devel] [PATCH 2 of 2] AMFND: Admin operation continuation if csi callback completes during headless [#1725 part 1] V1

Hi Praveen, Please let me copy your questions and answer here in email, so it's easier we can add comment in line, please see [Minh]. Thanks, Minh - Hi Minh, I am going through the patches 1725_phase1.tgz. Some initial comments: 1) In patch 2

Re: [devel] [PATCH 2 of 2] AMFND: Admin operation continuation if csi callback completes during headless [#1725 part 1] V1

Thanks Praveen, I have the same thought as yours, the buffered su_si_assignment should be sent when AMFD is in APP_STATE, it's the state AMFD handling non-ncs SU. I'm reusing set_leds msg, which signal veteran node to resend su_si_assignment msg, patch is attached Another thing could be

Re: [devel] [PATCH 2 of 2] AMFND: Admin operation continuation if csi callback completes during headless [#1725 part 1] V1

On 23-Aug-16 5:41 PM, praveen malviya wrote: > > In susi_success_su_oper() there is a check on Readiness state of SU, if > it is inservice then only AMFD performs switchover. Why SUs of a node > that is not synced is becoming IN_SERVICE. > > Also the AMFND where locked SU is hosted, should send

Re: [devel] [PATCH 2 of 2] AMFND: Admin operation continuation if csi callback completes during headless [#1725 part 1] V1

In susi_success_su_oper() there is a check on Readiness state of SU, if it is inservice then only AMFD performs switchover. Why SUs of a node that is not synced is becoming IN_SERVICE. Also the AMFND where locked SU is hosted, should send buffered message only when its NCS SUs are assigned.

Re: [devel] [PATCH 2 of 2] AMFND: Admin operation continuation if csi callback completes during headless [#1725 part 1] V1

Hi Minh, This issue is coming with latest patch also. I am facing this frequently on my setup and not able to proceed for testing. Please look into this on priority. Thanks -Nagu > -Original Message- > From: minh chau [mailto:minh.c...@dektech.com.au] > Sent: 23 August

Re: [devel] [PATCH 1 of 1] MDS: Log TIPC dropped messages [#1957]

Hi Mahesh, Yes, this is my understanding too, if TIPC_DROPPABLE = true tipc may drop messages silently, at receive sock buffer full condition, but do not return any ancillary message. If TIPC_DROPPABLE = false tipc may drop message but will send an ancillary message to inform about

Re: [devel] [PATCH 2 of 2] AMFND: Admin operation continuation if csi callback completes during headless [#1725 part 1] V1

Hi Nagu, I see in the trace you provided, the SU2/SU3 become IN_SERVICE late. If there's a delay in PL4 joining cluster after headless in your test then you could also see it in the latest patches (longDN rebased version) I'm looking in to this issue. Thanks. Minh On 23/08/16 20:24, Nagendra

Re: [devel] [PATCH 1 of 1] amfd: support NplusM model for supported admin ops on NG [#1454]

Hi Praveen, I will use them for test. Thanks, Minh On 23/08/16 16:58, praveen malviya wrote: > Hi Minh, > > I have attached patches for #1454 and #1608 in the ticket #1454. > Please apply them in order. > > Thanks, > Praveen > > On 23-Aug-16 11:56 AM, minh chau wrote: >> Hi Praveen, >> >> Since

Re: [devel] [PATCH 2 of 2] AMFND: Admin operation continuation if csi callback completes during headless [#1725 part 1] V1

Hi Nagu, Please use the patches attached to ticket to test, there are many changes from the version you are testing. https://sourceforge.net/p/opensaf/tickets/_discuss/thread/7b203666/ad7f/attachment/1725_phase_1.tgz It's a rebased longDN version, so you will not have to tested again I just

Re: [devel] [PATCH 2 of 2] AMFND: Admin operation continuation if csi callback completes during headless [#1725 part 1] V1

Please ignore TC #2, my mistake. Thanks -Nagu > -Original Message- > From: Nagendra Kumar > Sent: 23 August 2016 15:49 > To: Minh Hon Chau; hans.nordeb...@ericsson.com; Praveen Malviya; > gary@dektech.com.au; long.hb.ngu...@dektech.com.au > Cc: opensaf-devel@lists.sourceforge.net >

Re: [devel] [PATCH 2 of 2] AMFND: Admin operation continuation if csi callback completes during headless [#1725 part 1] V1

Please consider previous TC as TC #1 TC #2: Same configuration as TC #1. Logs attached in the ticket TC #2. Steps: 1. Same as step #1 of TC #1. 2. After locking SU1, keep delay in avnd_evt_avd_info_su_si_assign_evh and stop SC-1 and SC-2. 3. Start SC-1 and SC-2. SU1 is still in quisced state.

[devel] [PATCH 1 of 1] dtm: Fix cppcheck warnings [#1963]

osaf/services/infrastructure/dtms/dtm/dtm_inter_svc.c|5 +- osaf/services/infrastructure/dtms/dtm/dtm_intra.c| 10 +- osaf/services/infrastructure/dtms/dtm/dtm_intra_svc.c| 18 +- osaf/services/infrastructure/dtms/dtm/dtm_main.c | 18 -

Re: [devel] [PATCH 1 of 1] log: fix failed to recover app streams [#1941]

Hi Vu, ACK, Add TRACE`s in error return cases -AVM On 8/23/2016 3:29 PM, Vu Minh Nguyen wrote: > Hi Mahesh, > > Seems "/var/log/opensaf/saflog" not shared folder? > > To check that, create something (e.g: a file ) in that folder, and check > whether that file > can be seen by all nodes. > >

[devel] [PATCH 0 of 1] Review Request for dtm: Fix cppcheck warnings [#1963]

Summary: dtm: Fix cppcheck warnings [#1963] Review request for Trac Ticket(s): 1963 Peer Reviewer(s): Mahesh Pull request to: Affected branch(es): default(5.1) Development branch: default Impacted area Impact y/n Docs

Re: [devel] [PATCH 1 of 1] log: fix failed to recover app streams [#1941]

Hi Mahesh, Seems "/var/log/opensaf/saflog" not shared folder? To check that, create something (e.g: a file ) in that folder, and check whether that file can be seen by all nodes. To pass the test, the log folder has to be seen by all nodes. Regards, Vu > -Original Message- > From: A V

Re: [devel] [PATCH 0 of 2] Review Request for imm: Use high resolution time measurements [#1704]

Hi Hung, Reviewed and tested the patch. Ack from me. Thanks, Zoran -Original Message- From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au] Sent: den 5 augusti 2016 10:30 To: Zoran Milinkovic; reddy.neelaka...@oracle.com Cc: opensaf-devel@lists.sourceforge.net Subject: [PATCH 0 of 2]

Re: [devel] [PATCH 2 of 2] AMFND: Admin operation continuation if csi callback completes during headless [#1725 part 1] V1

Please note that it is on change set 7846:31417997c82f and I have applied patch of ticket #1894. Thanks -Nagu > -Original Message- > From: Nagendra Kumar > Sent: 23 August 2016 15:15 > To: Minh Hon Chau; hans.nordeb...@ericsson.com; Praveen Malviya; > gary@dektech.com.au;

Re: [devel] [PATCH 2 of 2] AMFND: Admin operation continuation if csi callback completes during headless [#1725 part 1] V1

Hi Minh, The following SU lock case is not working. This issue will exist for all the flows, so please check. Configuration and traces attached in the ticket. Steps: 1. Start SC-1, SC-2, PL-3 and PL-4. Run the following command: immcfg -f /tmp/AppConfig-2N-1725.xml amf-adm unlock-in

Re: [devel] [PATCH 1 of 1] MDS: Log TIPC dropped messages [#1957]

Hi HansN, It seems I am missing some thing , please allow me to under stand If I currently understand you observation : With current Opensaf code ( this #1957 patch NOT applied ) , by default TIPC_DROPPABLE=true ,while running Opensaf with that binary when TIPC_ERR_OVERLOAD occurring, TIPC

Re: [devel] [PATCH 1 of 1] ckpt: fix cppcheck warning [#1874] v2

ACK -AVM On 8/23/2016 2:11 PM, Hoang Vo wrote: > osaf/services/saf/cpsv/cpd/cpd_db.c | 8 ++--- > osaf/services/saf/cpsv/cpd/cpd_evt.c| 4 +- > osaf/services/saf/cpsv/cpd/cpd_imm.c| 2 +- > osaf/services/saf/cpsv/cpd/cpd_tmr.c| 2 +- >

Re: [devel] [PATCH 1 of 1] log: fix failed to recover app streams [#1941]

Hi Vu, In case logRootDirectory is /var/log/opensaf/saflog , and it is available , still getting problem. PL-3:/var/log/opensaf/saflog # /usr/bin/logtest -e 9 Suite 9: LOG Server down / up ;

[devel] [PATCH 0 of 1] Review Request for smfd: Merge rolling to singlestep procedures for several nodes [#1685]

Summary: smfd: Merge rolling to singlestep procedures for several nodes Review request for Trac Ticket(s): #1685 Peer Reviewer(s): lennart, reddy Pull request to: <> Affected branch(es): <> Development branch: <> Impacted area Impact y/n

[devel] [PATCH 1 of 1] smfd: Merge rolling to singlestep procedures for several nodes [#1685]

osaf/services/saf/smfsv/config/smfsv_classes.xml| 13 + osaf/services/saf/smfsv/smfd/Makefile.am|6 +- osaf/services/saf/smfsv/smfd/SmfCampState.cc| 125 +- osaf/services/saf/smfsv/smfd/SmfCampaign.cc | 78 ++-

Re: [devel] [PATCH 1 of 1] amfa: fixed freeing notification buff [#1642]

Hi Praveen, Agree this discussion should be continued, currently it causes a leak. Thanks, Minh On 23/08/16 16:57, praveen malviya wrote: > Hi Minh, > > I am going through the agent code to see if something can be done. I > think, since B.04.01 APIs are not implemented this problem is coming.

Re: [devel] [PATCH 1 of 1] MDS: Log TIPC dropped messages [#1957]

Hi Mahesh, Please see response below with [HansN] /Thanks HansN -Original Message- From: A V Mahesh [mailto:mahesh.va...@oracle.com] Sent: den 23 augusti 2016 08:25 To: Hans Nordebäck ; Anders Widell ; mathi.naic...@oracle.com

[devel] Review Request for amf: update PR doc for long DN support [#1642]

Summary: amf: update PR doc for long DN support [#1642] Review request for Trac Ticket(s): #1642 Peer Reviewer(s): AMF devs Pull request to: AMF maintainers Affected branch(es): default Development branch: default Impacted area Impact y/n

Re: [devel] [PATCH 0 of 8] Review Request for CKPT: Support DNs longer than 255 bytes [#1574] v5

Hi Hoang, Please send the all update patches 1 to 8 & README in single tar, so that I can commit. -AVM On 8/23/2016 12:48 PM, Vo Minh Hoang wrote: > Dear Mahesh, > > I updated README file and sent as attachment to this email. > I also sent update patches following your comments. > > Please

Re: [devel] [PATCH 1 of 1] log: fix failed to recover app streams [#1941]

Hi Mahesh, The folder "/repl_opensaf/saflog/logtest_sc_down_path/" is on UML container. I guess, on your system, the path is different. To get the correct patch to shared log folder, do following: 1) Get the log root folder: # immlist logConfig=1,safApp=safLogService Name

Re: [devel] [PATCH 6 of 8] cpsv: Apply new messages supporting extended SaNameT to CPD, CPND, and CPA [#1574] v4

Hi Hoang, Please send the all update patches 1 to 8 , so that I can commit. -AVM On 8/23/2016 12:46 PM, Vo Minh Hoang wrote: > Dear Mahesh, > > I would like to send updated patch following your comment. > When this is minor comment, I send it as attached file. > > Sincerely, > Hoang > >

Re: [devel] [PATCH 0 of 8] Review Request for CKPT: Support DNs longer than 255 bytes [#1574] v5

Dear Mahesh, I updated README file and sent as attachment to this email. I also sent update patches following your comments. Please help me push these items if there is no further problem. Thank you and best regards, Hoang -Original Message- From: A V Mahesh

Re: [devel] [PATCH 6 of 8] cpsv: Apply new messages supporting extended SaNameT to CPD, CPND, and CPA [#1574] v4

Dear Mahesh, I would like to send updated patch following your comment. When this is minor comment, I send it as attached file. Sincerely, Hoang -Original Message- From: A V Mahesh [mailto:mahesh.va...@oracle.com] Sent: Monday, August 22, 2016 1:02 PM To: Hoang Vo

Re: [devel] [PATCH 4 of 8] cpsv: Add new message to support extended SaNameT [#1574] v3

Dear Mahesh, I would like to send updated patch following your comment. When this is minor comment, I send it as attached file. Sincerely, Hoang -Original Message- From: A V Mahesh [mailto:mahesh.va...@oracle.com] Sent: Monday, August 22, 2016 12:55 PM To: Hoang Vo

Re: [devel] [PATCH 3 of 8] cpa: Add support for extended SaNameT [#1574] v1

Dear Mahesh, I would like to send updated patch following your comment. When this is minor comment, I send it as attached file. Sincerely, Hoang -Original Message- From: A V Mahesh [mailto:mahesh.va...@oracle.com] Sent: Monday, August 22, 2016 12:45 PM To: Hoang Vo

[devel] [PATCH 1 of 1] amf: README file for long DN support [#1642]

osaf/services/saf/amf/README | 72 1 files changed, 72 insertions(+), 0 deletions(-) diff --git a/osaf/services/saf/amf/README b/osaf/services/saf/amf/README new file mode 100755 --- /dev/null +++ b/osaf/services/saf/amf/README @@ -0,0 +1,72 @@ +#

[devel] [PATCH 0 of 1] Review Request for amf: README file for long DN support [#1642]

Summary: amf: README file for long DN support [#1642] Review request for Trac Ticket(s): #1642 Peer Reviewer(s): AMF devs Pull request to: AMF maintainers Affected branch(es): default Development branch: default Impacted area Impact y/n

Re: [devel] [PATCH 1 of 1] amfd: support NplusM model for supported admin ops on NG [#1454]

Hi Minh, I have attached patches for #1454 and #1608 in the ticket #1454. Please apply them in order. Thanks, Praveen On 23-Aug-16 11:56 AM, minh chau wrote: > Hi Praveen, > > Since AMF longDn has been pushed, can you please attach a longDn rebased > version to ticket (both #1454 + #1608) so we

Re: [devel] [PATCH 1 of 1] log: fix failed to recover app streams [#1941]

Hi Vu, This folder doesn't exist , i just created on PL-3 , still failing PL-3:~ # mkdir -p /repl_opensaf/saflog/logtest_sc_down_path/ PL-3:~ # PL-3:~ # /usr/bin/logtest -e 9 Suite 9: LOG Server down / up ; Preparing 8 streams for test. Please wait... Preparing stream 0

Re: [devel] [PATCH 1 of 1] amfa: fixed freeing notification buff [#1642]

Hi Minh, I am going through the agent code to see if something can be done. I think, since B.04.01 APIs are not implemented this problem is coming. But still all longdn patches can be pushed and this discussion can continue. What do you think? Thanks, praveen On 22-Aug-16 12:08 PM, minh

Re: [devel] [PATCH 1 of 1] log: fix failed to recover app streams [#1941]

Hi Mahesh, Can you check if PL node can access the shared log folder? E.g: path on UML test /repl_opensaf/saflog/logtest_sc_down_path/ I guess the problem is caused by PL not able to access the SAF log folder. Regards, Vu > -Original Message- > From: A V Mahesh

Re: [devel] [PATCH 1 of 1] MDS: Log TIPC dropped messages [#1957]

Hi! I don't think the sender would need to unconditionally abort() down in the MDS layer when it gets back an undelivered message from TIPC. We have the message loss callback in MDS, which can be used by the receiver to detect lost messages. The receiver can take an appropriate action when it

Re: [devel] [PATCH 1 of 1] log: fix failed to recover app streams [#1941]

Hi Vu, I got it running on SC , but it is failing on PL with : "cur_logfile_name_get scandir Fail No such file or directorysaLogRecov_prepare_client1_8streams Internal error. Test failed 2 FAILED (expected EXIT_SUCCESS, got EXIT_FAILURE (1))" -AVM On 8/23/2016 12:06 PM, A V Mahesh

Re: [devel] [PATCH 1 of 1] log: fix failed to recover app streams [#1941]

Hi Vu, Why test case is allowed on SC`s ? == SC-1:~ # /usr/bin/logtest -e 9 Suite 9: LOG Server down / up ; Preparing 8 streams for test. Please wait... Preparing stream 0 ... Preparing stream

Re: [devel] [PATCH 1 of 1] amfd: support NplusM model for supported admin ops on NG [#1454]

Hi Praveen, Since AMF longDn has been pushed, can you please attach a longDn rebased version to ticket (both #1454 + #1608) so we can do some test? Thanks, Minh On 23/08/16 15:56, praveen malviya wrote: > Hi Minh, > > Thanks for reviewing the patch. > Please see inline with [Praveen] > >

Re: [devel] [PATCH 1 of 1] MDS: Log TIPC dropped messages [#1957]

Hi HansN Please see response below with [AVM] -AVM On 8/23/2016 11:41 AM, Hans Nordebäck wrote: > Hi Mahesh, > > please see comments below. > > /Thanks HansN > > > On 08/23/2016 07:21 AM, A V Mahesh wrote: >> Hi HansN, >> >> Let us fist discuss the error handling and abort, then we can come >>

Re: [devel] [PATCH 1 of 1] MDS: Log TIPC dropped messages [#1957]

Hi Mahesh, please see comments below. /Thanks HansN On 08/23/2016 07:21 AM, A V Mahesh wrote: > Hi HansN, > > Let us fist discuss the error handling and abort, then we can come > back to > interpretation of TIPC currently does permit OR does not permit an > application to send > a