Re: [devel] [PATCH 1 of 1] imported patch 1967_fix_headless_error_cppcheck.patch

ACK not tested -AVM On 8/25/2016 10:06 AM, Vo Minh Hoang wrote: > Dear Mahesh, > > Logic of this part is complicated so I modified it wrong. > This time I correct it, not a roll back. > That part is subsequence of if clause above. > > Sincerely, > Hoang > > -Original Message- > From: A V

Re: [devel] [PATCH 1 of 1] amf: README file for long DN support [#1642]

Ack. I think implementation details should go in PR doc also(not to mention internal amfd and amfnd changes). Thanks, Praveen On 23-Aug-16 12:44 PM, Long HB Nguyen wrote: > osaf/services/saf/amf/README | 72 > > 1 files changed, 72 insertions(+),

Re: [devel] [PATCH 1 of 1] imported patch 1967_fix_headless_error_cppcheck.patch

Dear Mahesh, Logic of this part is complicated so I modified it wrong. This time I correct it, not a roll back. That part is subsequence of if clause above. Sincerely, Hoang -Original Message- From: A V Mahesh [mailto:mahesh.va...@oracle.com] Sent: Thursday, August 25, 2016 11:21 AM

Re: [devel] [PATCH 0 of 7] Review Request for Support for CSI attribute change callback. [#1553].

Hi All, Please provide your feedback on these patches. Thanks, Praveen On 16-Aug-16 11:20 AM, praveen.malv...@oracle.com wrote: > Summary: Support for CSI attribute change callback. [#1553] > Review request for Trac Ticket(s): #1553 > Peer Reviewer(s): AMF maintainers > Pull request to: <> >

Re: [devel] Review Request for ntf: update PR documentation [#1952]

Ack from me. Thanks, Praveen On 25-Aug-16 8:09 AM, Vu Minh Nguyen wrote: > Hi, > > > > Any comments on the PR? > > > > Regards, Vu > > > > *From:* Vu Minh Nguyen [mailto:vu.m.ngu...@dektech.com.au] > *Sent:* Monday, August 15, 2016 6:46 PM > *To:* Lennart Lund ; 'Minh

Re: [devel] Review Request for log: update OpenSAF_LOG_PR for long DN [#1898]

ACK -AVM On 8/25/2016 8:08 AM, Vu Minh Nguyen wrote: > > Hi Mahesh, > > Any comments on the PR? > > Regards, Vu > > *From:* Lennart Lund [mailto:lennart.l...@ericsson.com] > *Sent:* Wednesday, August 17, 2016 5:50 PM > *To:* Vu Minh Nguyen ; mahesh.va...@oracle.com >

Re: [devel] [PATCH 1 of 1] imported patch 1967_fix_headless_error_cppcheck.patch

Hi Hoang, Is this rollback of `ckpt: fix cppcheck warning [#1874]` ? === @@ -4766,6 +4758,13 @@ static uint32_t cpnd_transfer_replica(CP total_num++; tmp_sec_info =

Re: [devel] Review Request for ntf: update PR documentation [#1952]

Hi, Any comments on the PR? Regards, Vu From: Vu Minh Nguyen [mailto:vu.m.ngu...@dektech.com.au] Sent: Monday, August 15, 2016 6:46 PM To: Lennart Lund ; 'Minh Hon Chau' ; 'praveen malviya' Cc:

Re: [devel] Review Request for log: update OpenSAF_LOG_PR for long DN [#1898]

Hi Mahesh, Any comments on the PR? Regards, Vu From: Lennart Lund [mailto:lennart.l...@ericsson.com] Sent: Wednesday, August 17, 2016 5:50 PM To: Vu Minh Nguyen ; mahesh.va...@oracle.com Cc: opensaf-devel@lists.sourceforge.net Subject: RE: [devel] Review

[devel] [PATCH 1 of 1] imported patch 1967_fix_headless_error_cppcheck.patch

osaf/services/saf/cpsv/cpd/cpd_proc.c | 4 ++-- osaf/services/saf/cpsv/cpnd/cpnd_evt.c | 11 ++- 2 files changed, 4 insertions(+), 11 deletions(-) diff --git a/osaf/services/saf/cpsv/cpd/cpd_proc.c b/osaf/services/saf/cpsv/cpd/cpd_proc.c --- a/osaf/services/saf/cpsv/cpd/cpd_proc.c

Re: [devel] [PATCH 2 of 2] AMFND: Admin operation continuation if csi callback completes during headless [#1725 part 1] V1

Hi Nagu, Second thought, Praveen's one is better I think. You can try with his patch. Thanks Minh On 24/08/16 22:21, minh chau wrote: > Hi Nagu, > > Can you please apply the below patch on top of > 1725_02_V2_bugfix_resend_buffer_in_set_leds.diff? > In your test, PL3 get set_leds, but PL-4 has

Re: [devel] [PATCH 2 of 2] AMFND: Admin operation continuation if csi callback completes during headless [#1725 part 1] V1

Hi Nagu, Can you please apply the below patch on top of 1725_02_V2_bugfix_resend_buffer_in_set_leds.diff? In your test, PL3 get set_leds, but PL-4 has not, so SU2 can not respond su_si msg. @Praveen: Thanks for you help, I guess SU2 need to be ready to send su_si msg at the same as SU1. diff

Re: [devel] [PATCH 2 of 2] AMFND: Admin operation continuation if csi callback completes during headless [#1725 part 1] V1

Hi Minh, Any assignment message should be processed after cluster timer expiry and node sync timer expiry. The bug fix patch 1725_02_V2_bugfix_resend_buffer_in_set_leds.diff honors cluster timer expiry but not node sync timer. After node sync timer expiry, delayed payloads will be rebooted and

Re: [devel] [PATCH 2 of 2] AMFND: Admin operation continuation if csi callback completes during headless [#1725 part 1] V1

The below is the assignments after the test case (SU2 has standby assignment): PM_SC-1:/home/nagu/views/staging-1725 # /etc/init.d/opensafd status safSISU=safSu=SU2\,safSg=AmfDemo_2N\,safApp=AmfDemo1,safSi=AmfDemo1,safApp=AmfDemo1 saAmfSISUHAState=STANDBY(2)

Re: [devel] [PATCH 2 of 2] AMFND: Admin operation continuation if csi callback completes during headless [#1725 part 1] V1

Hi Minh, With 1725_phase_1_V2.tgz, the below email TC has failed. Please find the traces attached along with the configuration in the ticket. Thanks -Nagu > -Original Message- > From: Nagendra Kumar > Sent: 23 August 2016 15:15 > To: Minh Hon Chau; hans.nordeb...@ericsson.com;

Re: [devel] [PATCH 1 of 1] amfd: support NplusM model for supported admin ops on NG [#1454]

Hi Minh, Please responses inline with [Praveen] Thanks, Praveen On 24-Aug-16 2:01 PM, minh chau wrote: > Hi Praveen, > > I have tested the patches in case all SUs of NpM/Nway belong to one > nodegroup, it works for me. Will try the case that SUs are partially > in/out of nodegroup tomorrow. >

Re: [devel] [PATCH 1 of 1] amfd: support NplusM model for supported admin ops on NG [#1454]

Hi Praveen, I have tested the patches in case all SUs of NpM/Nway belong to one nodegroup, it works for me. Will try the case that SUs are partially in/out of nodegroup tomorrow. But please, if you have time, can you try to make NpM's ng_admin under FSM_SG_ADMIN. Addition to my previous

Re: [devel] [PATCH 2 of 2] AMFND: Admin operation continuation if csi callback completes during headless [#1725 part 1] V1

Hi Praveen, I have just attached to ticket the #1725 part 2 that supports fault of node restart/poweroff while headless. Can you help to review it? I will update the patch that adds the logging as you suggested. Thanks for reviewing, Minh On 24/08/16 16:07, praveen malviya wrote: > Hi Minh,

Re: [devel] [PATCH 2 of 2] AMFND: Admin operation continuation if csi callback completes during headless [#1725 part 1] V1

Hi Minh, Please see responses with [Praveen]. Thanks, Praveen On 23-Aug-16 7:18 PM, minh chau wrote: > Hi Praveen, > > Please let me copy your questions and answer here in email, so it's > easier we can add comment in line, please see [Minh]. > > Thanks, > Minh > >

Re: [devel] [PATCH 1 of 1] dtm: Fix cppcheck warnings [#1963]

Hi Anders Widell, ACK Reviewed & tested IPv4 & IPv6 -AVM On 8/23/2016 3:34 PM, Anders Widell wrote: > osaf/services/infrastructure/dtms/dtm/dtm_inter_svc.c|5 +- > osaf/services/infrastructure/dtms/dtm/dtm_intra.c| 10 +- >