[devel] [PATCH 0 of 1] Review Request for imm: Fix problems with removing coordinator role when cluster goes headless [#2296]

2017-02-09 Thread Hung Nguyen
Summary: imm: Fix problems with removing coordinator role when cluster goes headless [#2296] Review request for Trac Ticket(s): 2296 Peer Reviewer(s): Zoran, Neel Pull request to: Affected branch(es): 5.0, 5.1, 5.2 Development branch: 5.2 Impacted area

[devel] [PATCH 1 of 1] imm: Fix problems with removing coordinator role when cluster goes headless [#2296]

2017-02-09 Thread Hung Nguyen
src/imm/immnd/immnd_evt.c | 33 ++--- src/imm/immnd/immnd_proc.c | 22 ++ 2 files changed, 32 insertions(+), 23 deletions(-) When SC comes back too fast, it will fail to change to SEVER_READY state because immnd_proc_server() is not executed.

Re: [devel] [PATCH 1 of 1] cpd: to correct failover behavior of cpsv [#1765] V5

2017-02-09 Thread A V Mahesh
Hi Hoang, The CPD_CPND_DOWN_RETENTION is to recognize, ether CPND temporarily down or permanently down, this is started a CPND is down and based on cpd_evt_proc_timer_expiry(), cpd recognize that the CPND is complete down and do cleanup, else cpnd rejoined with in

Re: [devel] [PATCH 1 of 1] mds: improve MDS logging [#2297]

2017-02-09 Thread A V Mahesh
Hi Zoran, ACK , Not tested. -AVM On 2/9/2017 7:07 PM, Zoran Milinkovic wrote: > src/mds/mds_c_sndrcv.c | 38 +++--- > 1 files changed, 23 insertions(+), 15 deletions(-) > > > Improve MDS logging in mds_mcm_time_wait() and split the common MDS log into >

[devel] [PATCH 1 of 1] mds: improve MDS logging [#2297]

2017-02-09 Thread Zoran Milinkovic
src/mds/mds_c_sndrcv.c | 38 +++--- 1 files changed, 23 insertions(+), 15 deletions(-) Improve MDS logging in mds_mcm_time_wait() and split the common MDS log into timeout and error logs. In other places after mds_mcm_time_wait() calls, the log messages are

[devel] [PATCH 0 of 1] Review Request for mds: improve MDS logging [#2297]

2017-02-09 Thread Zoran Milinkovic
Summary: mds: improve MDS logging [#2297] Review request for Trac Ticket(s): 2297 Peer Reviewer(s): Mahesh Pull request to: Zoran Affected branch(es): default(5.2) Development branch: default(5.2) Impacted area Impact y/n

Re: [devel] [PATCH 1 of 1] amfd: change LOG_ER to LOG_NO [#1749]

2017-02-09 Thread Hans Nordebäck
Ack, code review only/Thanks HansN -Original Message- From: nagendr...@oracle.com [mailto:nagendr...@oracle.com] Sent: den 9 februari 2017 11:25 To: Hans Nordebäck ; praveen.malv...@oracle.com; Minh Hon Chau ; Gary Lee

[devel] [PATCH 0 of 1] Review Request for amfd: change LOG_ER to LOG_NO [#1749]

2017-02-09 Thread nagendra . k
Summary: amfd: change LOG_ER to LOG_NO [#1749] Review request for Trac Ticket(s): #1749 Peer Reviewer(s): Amf Dev Pull request to: <> Affected branch(es): Default Development branch: Default Impacted area Impact y/n Docs

[devel] [PATCH 1 of 1] amfd: change LOG_ER to LOG_NO [#1749]

2017-02-09 Thread nagendra . k
src/amf/amfd/comp.cc | 2 +- src/amf/amfd/imm.cc | 2 +- src/amf/amfd/nodegroup.cc | 6 +++--- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/amf/amfd/comp.cc b/src/amf/amfd/comp.cc --- a/src/amf/amfd/comp.cc +++ b/src/amf/amfd/comp.cc @@ -759,7 +759,7 @@

Re: [devel] [PATCH 1 of 1] ckpt: return SA_AIS_ERR_BAD_HANDLE if ckpt handle is not found in checkpoint open call [#2283]

2017-02-09 Thread Vo Minh Hoang
Dear Zoran, I am sorry if you are waiting for me in this ticket. ACK. Sincerely, Hoang -Original Message- From: Zoran Milinkovic [mailto:zoran.milinko...@ericsson.com] Sent: Wednesday, February 1, 2017 8:13 PM To: A V Mahesh Cc:

[devel] [PATCH 1 of 1] cpd: to correct failover behavior of cpsv [#1765] V5

2017-02-09 Thread Hoang Vo
src/ckpt/ckptd/cpd_proc.c | 11 ++- 1 files changed, 10 insertions(+), 1 deletions(-) problem: In case failover multiple times, the cpnd is down for a moment so there is no cpnd opening specific checkpoint. This lead to retention timer is trigger. When cpnd is up again but has

[devel] [PATCH 0 of 1] Review Request for cpd: to correct failover behavior of cpsv [#1765] V5

2017-02-09 Thread Hoang Vo
Summary: cpd: to correct failover behavior of cpsv [#1765] V5 Review request for Trac Ticket(s): 1765 Peer Reviewer(s): mahesh.va...@oracle.com; zoran.milinko...@ericsson.com Pull request to: mahesh.va...@oracle.com Affected branch(es): default Development branch: default