Hi!
I intend to push this tomorrow unless there are any comments?
regards,
Anders Widell
On 10/06/2017 03:01 PM, Anders Widell wrote:
Summary: dtm: Extract Multicast class for node discovery message handling [#991]
Review request for Ticket(s): 991
Peer Reviewer(s): Alex, Ravi
Pull request t
Dear Alex,
Thank you very much for your very fast response.
Because this is test code, I think we should push it to release also, test
environment should be consistent even it is really not important.
If not, release branch might fail sometimes then cost extra effort for
verifying much mor
Hi Hoang,
Ack from me. Is there a reason this needs to go on the release branch? It's
just test code.
Alex
From: Hoang Vo
Sent: Thursday, October 12, 2017 6:13:44 AM
To: Alex Jones
Cc: opensaf-devel@lists.sourceforge.net; Hoang Vo
Subject: [PATCH 0/1] Revie
Summary: ckpt: add timeout handling for test_ckptOverwrite [#2624]
Review request for Ticket(s): 2624
Peer Reviewer(s): ajo...@genband.com
Pull request to: ajo...@genband.com
Affected branch(es): develop, release
Development branch: ticket-2624
Base revision: 4fbc3261d53914242bdbc5c300caecc53b88365
test_ckptOverwrite verify overwrite behavior and should
handle SA_AIS_ERR_TIMEOUT by retrying operation.
---
src/ckpt/apitest/test_cpa_util.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/ckpt/apitest/test_cpa_util.c b/src/ckpt/apitest/test_cpa_util.c
index 9c1b6ba..66347
Hi Rafael,
not tested, minor comment/question below.
Regards /Hans
On 10/10/2017 02:08 PM, Rafael Odzakow wrote:
Previously named function "check_env" overwrites pid file. Move it to
after running pidofproc for amfnd pid.
---
src/nid/opensafd.in | 4 ++--
1 file changed, 2 insertions(+),