Re: [devel] [PATCH 1/1] amf: Buffer and resend data req messages in Headless state [#2601]

Hi Ravi I’ve started looking at this. My initial thought is that perhaps we need to queue up all messages when is_avd_down == false && amfd_sync_required == true (ie. AMFD has come up but haven’t accepted node_up). What do you think? Will get back to you. /Gary -Original Message-

[devel] [PATCH 0/1] Review Request for pyosaf: Fix various pylint and PEP8 issues of pyosaf utils V2 [#2603]

Summary: pyosaf: Fix various pylint and PEP8 issues of pyosaf utils [#2603] Review request for Ticket(s): 2603 Peer Reviewer(s): Hans Nordeback, Anders Widell, Srinivas Mangipudy Pull request to: Anders Widell Affected branch(es): develop Development branch: ticket-2603 Base revision:

[devel] [PATCH 0/1] Review Request for rde: improve logging in split brain case [#2556]

Summary: rde: improve logging in split brain case [#2556] Review request for Ticket(s): 2556 Peer Reviewer(s): anders.wid...@ericsson.com, hans.fe...@ericsson.com Pull request to: anders.wid...@ericsson.com Affected branch(es): develop Development branch: ticket-2556 Base revision:

[devel] [PATCH 1/1] rde: improve logging in split brain case [#2556]

Add extra CR log when split brain is detected. --- src/rde/rded/rde_main.cc | 1 + 1 file changed, 1 insertion(+) diff --git a/src/rde/rded/rde_main.cc b/src/rde/rded/rde_main.cc index 0298bf3..ded0111 100644 --- a/src/rde/rded/rde_main.cc +++ b/src/rde/rded/rde_main.cc @@ -132,6 +132,7 @@

Re: [devel] [PATCH 3/3] base: Use the OpenSAF internal log service for trace [#2165]

Ok will change these, except using std::unique_ptr since Google C++ Style Guide discourages usage of class type with static storage duration. regards, Anders Widell On 10/17/2017 10:43 AM, Hans Nordebäck wrote: ack, code review only. Minor comments below. /Thanks HansN On 10/10/2017

Re: [devel] [PATCH 1/3] dtm: Support multiple OpenSAF internal log streams [#2165]

Hi! I tried both of these variants on Ubuntu 14.04 (with GCC 4.8.4), and I always get: terminate called after throwing an instance of 'std::regex_error'   what():  regex_error Aborted After googling this a bit, I think the reason could be that ECMAScript types of regular expressions are not

[devel] [PATCH 0/1] Review Request for ckptnd: fix cpnd crash during checkpoint open with large sections [#1510]

Summary: ckptnd: fix crash during checkpoint open timeout with large sections [#1510] Review request for Ticket(s): 1510 Peer Reviewer(s): Hoang Vo Pull request to: Affected branch(es): develop Development branch: ticket-1510 Base revision: 7fe556aebf15eceb0a64e68bb0f02cd081f4bd67 Personal

Re: [devel] [PATCH 2/2] amf: improve error checking and display [#2628]

Ack, Code review only Thanks, RAvi -Original Message- From: Gary Lee [mailto:gary@dektech.com.au] Sent: Tuesday, October 17, 2017 12:44 PM To: hans.nordeb...@ericsson.com; ravisekhar.ko...@oracle.com; minh.c...@dektech.com.au Cc: opensaf-devel@lists.sourceforge.net; Gary Lee

Re: [devel] [PATCH 1/1] amfnd: Add more details for synced SU, SISU from node director [#2575]

ack, code review only/Thanks HansN On 09/11/2017 02:10 AM, Minh Chau wrote: --- src/amf/amfd/sg.cc | 1 + src/amf/amfnd/di.cc | 13 ++--- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/amf/amfd/sg.cc b/src/amf/amfd/sg.cc index 986bb..6019be955 100644 ---

Re: [devel] [PATCH 1/2] amf: fix whitespace issues [#2628]

Ack, code review only/Thanks HansN -Original Message- From: Gary Lee [mailto:gary@dektech.com.au] Sent: den 17 oktober 2017 09:14 To: Hans Nordebäck ; ravisekhar.ko...@oracle.com; Minh Hon Chau Cc:

[devel] [PATCH 0/1] Review Request for smf: refactor smfd folders [#2633]

Summary: smf: refactor smfd folders [#2633] Review request for Ticket(s): 2633 Peer Reviewer(s): lennart Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE *** Affected branch(es): develop Development branch: ticket-2633 Base revision: e7fb995f41a4bfabe3d1e48bda3ba004e2935074 Personal

[devel] [PATCH 1/1] amf: Buffer and resend data req messages in Headless state [#2601]

--- src/amf/amfnd/di.cc | 42 +++--- 1 file changed, 31 insertions(+), 11 deletions(-) diff --git a/src/amf/amfnd/di.cc b/src/amf/amfnd/di.cc index 2dc023c..1e0d682 100644 --- a/src/amf/amfnd/di.cc +++ b/src/amf/amfnd/di.cc @@ -998,21 +998,30 @@ uint32_t

[devel] [PATCH 0/1] Review Request for amf: Buffer and resend data req messages in Headless state [#2601]

Summary: amf: Buffer and resend data req messages in Headless state [#2601] Review request for Ticket(s): 2601 Peer Reviewer(s): minh.c...@dektech.com.au, hans.nordeb...@ericsson.com, gary@dektech.com.au Pull request to: Myself Affected branch(es): develop Development branch: ticket-2601

Re: [devel] [PATCH 2/3] base: Convert logtrace to C++ [#2165]

ack, code review only/Thanks HansN On 10/10/2017 06:44 PM, Anders Widell wrote: --- src/base/Makefile.am | 2 +- src/base/logtrace.c | 268 --- src/base/logtrace.cc | 253

Re: [devel] [PATCH 1/3] dtm: Support multiple OpenSAF internal log streams [#2165]

Hi Anders, the regex should be std::regex is_valid{R"([_[:alpha:]]+\.?\w+)"}; I think. The original function does not handle e.g. "." correctly I guess, but this regex does/Hans On 10/17/2017 12:45 PM, Hans Nordebäck wrote: ack, code review only, minor comment below/Thanks HansN On

Re: [devel] [PATCH 1/3] dtm: Support multiple OpenSAF internal log streams [#2165]

ack, code review only, minor comment below/Thanks HansN On 10/10/2017 06:44 PM, Anders Widell wrote: Extend the OpenSAF internal log service so that it supports multiple log streams in addition to the MDS log. All log streams are received on the same socket and the stream name is extracted

Re: [devel] [PATCH 1/1] smf: smf: Upgrade nodes without using node group [#2592]

Comments inline Complex patch, consider separating logical changes and refactoring into two patches to make it easier. On 09/28/2017 02:58 PM, Lennart Lund wrote: Do not create a node group for lock operations on nodes if only one node (deactivation/activation units). This is needed to make

Re: [devel] [PATCH 3/3] base: Use the OpenSAF internal log service for trace [#2165]

ack, code review only. Minor comments below. /Thanks HansN On 10/10/2017 06:44 PM, Anders Widell wrote: Instead of writing trace messages directly to a file, use the OpenSAF internal log service which is implemented in osaftransportd. As a consequence, the trace files will now be rotated

Re: [devel] [PATCH 1/1] pyosaf: retry SAF initialize() function with original version [#2524]

ack, code review only/Thanks HansN On 10/17/2017 07:47 AM, Hieu Nguyen wrote: --- python/pyosaf/utils/__init__.py | 44 +++ python/pyosaf/utils/clm/__init__.py | 11 + python/pyosaf/utils/immoi/__init__.py | 7 +++---

[devel] [PATCH 0/2] Review Request for amf: improve error checking and display [#2628]

Summary: amf: improve error checking display [#2628] Review request for Ticket(s): 2628 Peer Reviewer(s): AMF devs Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE *** Affected branch(es): develop Development branch: ticket-2628 Base revision: 3d33c10e172b69a989304cc57199e2c714ae4059

[devel] [PATCH 2/2] amf: improve error checking and display [#2628]

* nodes are prefixed with '0x', eg '0x2010f' instead of '2010f' to match input * options 's', 'c', 'u' are incompatible and are rejected when used together --- src/amf/tools/amf_cluster_status.cc | 26 -- 1 file changed, 20 insertions(+), 6 deletions(-) diff --git

[devel] [PATCH 1/2] amf: fix whitespace issues [#2628]

whitespace changes only --- src/amf/tools/amf_cluster_status.cc | 36 ++-- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/src/amf/tools/amf_cluster_status.cc b/src/amf/tools/amf_cluster_status.cc index d54a3d6d6..668e43c01 100644 ---

Re: [devel] [PATCH 1/1] base: double start failed [#2622]

Hi Rafael, Reviewed the patch, but didn't test. Ack from me. Thanks, Zoran -Original Message- From: Rafael Odzakow Sent: den 16 oktober 2017 13:53 To: Zoran Milinkovic ; Hans Nordebäck Cc:

Re: [devel] [PATCH 1/1] pyosaf: retry SAF initialize() function with original version [#2524]

Hi Hieu, Ack from me. Thanks, Quyen On 10/17/2017 12:47 PM, Hieu Nguyen wrote: --- python/pyosaf/utils/__init__.py | 44 +++ python/pyosaf/utils/clm/__init__.py | 11 + python/pyosaf/utils/immoi/__init__.py | 7 +++---