Hi Hans,
Thanks for your very helpful comments. I will fix them before pushing it.
Best regards,
Long Nguyen.
On 11/20/2017 7:54 PM, Hans Nordebäck wrote:
Hi,
ack with some comments below. /Thanks HansN
On 11/10/2017 08:52 AM, Long H Buu Nguyen wrote:
---
python/README_UTILS | 215
Hi,
ack with some comments below. /Thanks HansN
On 11/10/2017 08:52 AM, Long H Buu Nguyen wrote:
---
python/README_UTILS | 215
1 file changed, 215 insertions(+)
create mode 100644 python/README_UTILS
diff --git a/python/README_UTILS
Hi Vijay,
I have started to create a CCB handler handling all types of modifications of
the IMM model where a CCB is involved (object create, modify and delete). It is
created as a “separate module” that handles everything that has to do with IMM.
This means, all steps involved in creating a
Fix pylint and pep8 issues for the following Python files:
./tools/devel/dot/trace2dot
./tools/devel/review/patch-tokenize.py
./src/imm/tools/immxml-merge
./src/imm/tools/immxml-validate
./src/imm/tools/baseimm.py
---
src/imm/tools/baseimm.py | 376 ---
Summary: tools: Fix pylint and pep8 issues for tools written in Python [#2664]
Review request for Ticket(s): 2664
Peer Reviewer(s): Hans Nordeback, Anders Widell, Quyen Dao
Pull request to: Hans Nordeback
Affected branch(es): develop
Development branch: ticket-2664
Base revision:
Ack with comment: add a newline at the end of python/README
regards,
Anders Widell
On 11/17/2017 09:54 AM, Hans Nordeback wrote:
The output format can now be given, e.g.:
make pylint (defaults to text)
make pylint FORMAT=html
make pylint FORMAT=parseable
make pylint FORMAT=json
---
Ack with minor comment: isn't there a missing dollar sign in save_ifd=IFS ?
regards,
Anders Widell
On 11/16/2017 03:46 PM, Hans Nordeback wrote:
---
scripts/opensaf_scale_out | 20 +++-
src/clm/README| 2 +-
src/clm/clmnd/main.c | 9 +
3 files
Hi Hans,
Ack from me. Tested OK with both pylint-1.6.5 and pylint-1.7.4.
I just have one minor suggestion for the README. Please find it inline,
marked with [Nguyen].
Thanks,
Nguyen
On 11/17/2017 6:50 PM, Hans Nordeback wrote:
The output format can now be given, e.g.:
make pylint
Hi Lennart,
In reality myself and Syam are also thinking on the same lines for refactoring
CCB & Admin operations flows.
In addition we need to have an eye on CLI & Customized Callback Actions.
Better we discuss more in detail to baseline the solution. Please suggest.
Regards
