Re: [devel] [PATCH 1/1] amfd: Avoid IMM reinitialization in OpenSAF components termination phase [#2737]

2017-12-20 Thread Ravi Sekhar Reddy Konda
Ack, reviewed & tested Regards, Ravi -Original Message- From: Minh Chau [mailto:minh.c...@dektech.com.au] Sent: Tuesday, December 19, 2017 7:39 AM To: hans.nordeb...@ericsson.com; ravisekhar.ko...@oracle.com; gary@dektech.com.au Cc: opensaf-devel@lists.sourceforge.net; Minh Chau

[devel] [PATCH 1/1] amfnd: Check UNASSIGNED CSI in csi assigment removal [#2741]

2017-12-20 Thread Minh Chau
A csi can be marked as UNASSIGNED from a su restart or this csi is newly added from scaling out. This unassigned csi currently makes the csi assignment removal sequence running non-stop, since the removal sequence is not checking UNASSIGNED state. Patch considers UNASSIGNED state of csi to be

[devel] [PATCH 0/1] Review Request for amfnd: Check UNASSIGNED CSI in csi assigment removal [#2741]

2017-12-20 Thread Minh Chau
Summary: amfnd: Check UNASSIGNED CSI in csi assigment removal [#2741] Review request for Ticket(s): 2741 Peer Reviewer(s): AMF maintainers Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE *** Affected branch(es): develop Development branch: ticket-2741 Base revision:

[devel] [PATCH 0/1] Review Request for smf: PROTOTYPE Add capability to redo CCBs that fail [#1398]

2017-12-20 Thread Lennart Lund
Summary: smf: Add capability to redo CCBs that fail [#1398] Review request for Ticket(s): 1398 Peer Reviewer(s): NA Pull request to: NA Affected branch(es): develop Development branch: ticket-1398 Base revision: c4a934ba77290efcdcc76700cd024fb3871a3ebf Personal repository:

Re: [devel] [PATCH 1/1] imm: change log level for failing to send accept message [#2426]

2017-12-20 Thread Vu Minh Nguyen
Ack from me. Thanks. Regards, Vu > -Original Message- > From: Zoran Milinkovic [mailto:zoran.milinko...@ericsson.com] > Sent: Wednesday, December 20, 2017 2:56 PM > To: vu.m.ngu...@dektech.com.au > Cc: opensaf-devel@lists.sourceforge.net; Zoran Milinkovic >

[devel] [PATCH 1/1] imm: change log level for failing to send accept message [#2426]

2017-12-20 Thread Zoran Milinkovic
Importance log level is changed from error to warning level due to no reaction from IMMD. --- src/imm/immd/immd_evt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/imm/immd/immd_evt.c b/src/imm/immd/immd_evt.c index a0d9319..4c1999b 100644 --- a/src/imm/immd/immd_evt.c

[devel] [PATCH 0/1] Review Request for imm: change log level for failing to send accept message [#2426]

2017-12-20 Thread Zoran Milinkovic
Summary: imm: change log level for failing to send accept message [#2426] Review request for Ticket(s): 2426 Peer Reviewer(s): Vu Pull request to: Zoran Affected branch(es): develop Development branch: ticket-2426 Base revision: 5a520b91f37ef51ddf6fbdd97928a002e2967e0c Personal repository:

Re: [devel] [PATCH 1/1] ais: change default retry in decorator [#2743]

2017-12-20 Thread Hans Nordebäck
ack, review only. One comment/question below. /Regards HansN On 12/20/2017 01:37 PM, Vu Minh Nguyen wrote: Change interval time to 100 miliseconds, and timeout to one minute for the default retry control. --- src/ais/tests/try_again_decorator_test.cc | 8 +---

[devel] [PATCH 0/1] Review Request for ais: change default retry in decorator [#2743]

2017-12-20 Thread Vu Minh Nguyen
Summary: ais: change default retry in decorator [#2743] Review request for Ticket(s): 2743 Peer Reviewer(s): Hans, AndersW Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE *** Affected branch(es): develop Development branch: ticket-2743 Base revision:

[devel] [PATCH 1/1] ais: change default retry in decorator [#2743]

2017-12-20 Thread Vu Minh Nguyen
Change interval time to 100 miliseconds, and timeout to one minute for the default retry control. --- src/ais/tests/try_again_decorator_test.cc | 8 +--- src/ais/try_again_decorator.h | 8 2 files changed, 9 insertions(+), 7 deletions(-) diff --git

Re: [devel] [PATCH 1/1] amfd: Avoid IMM reinitialization in OpenSAF components termination phase [#2737]

2017-12-20 Thread Hans Nordebäck
ack, code review only. /Thanks HansN On 12/19/2017 03:09 AM, Minh Chau wrote: --- src/amf/amfd/imm.cc | 13 + src/amf/amfd/ndfsm.cc | 2 +- 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/src/amf/amfd/imm.cc b/src/amf/amfd/imm.cc index bf7e3d3..aef988f 100644

[devel] [PATCH 1/1] pyosaf: Refactor NTF samples to make use of new pyosaf utils [#2707]

2017-12-20 Thread Nguyen Luu
- Refactor the ntfsend and ntfsubscribe python samples to make use of the new pyosaf utils implementation of enhancement ticket #2602. - Add a new ntfread sample to demonstrate usage of the new NtfReader utils. --- python/samples/ntfread | 411 python/samples/ntfsend

[devel] [PATCH 0/1] Review Request for pyosaf: Refactor NTF samples to make use of new pyosaf utils [#2707]

2017-12-20 Thread Nguyen Luu
Summary: pyosaf: Refactor NTF samples to make use of new pyosaf utils [#2707] Review request for Ticket(s): 2707 Peer Reviewer(s): Hans Nordeback, Srinivas Mangipudy Pull request to: Hans Nordeback Affected branch(es): develop Development branch: ticket-2707 Base revision:

[devel] [PATCH 0/1] Review Request for pyosaf: refactor IMM utils V3[#2683]

2017-12-20 Thread Hieu Nguyen
Summary: pyosaf: refactor IMM utils [#2683] Review request for Ticket(s): 2683 Peer Reviewer(s): Hans, Anders, Sir Pull request to: Hans or Anders Affected branch(es): develop Development branch: ticket-2683 Base revision: 5a520b91f37ef51ddf6fbdd97928a002e2967e0c Personal repository:

[devel] [PATCH 1/1] pyosaf: refactor IMM utils [#2683]

2017-12-20 Thread Hieu Nguyen
+ improve OI utils use a separate instance OM agent + refactor OM utils with Ccb inheritace OmAgent, rename some classes... --- python/Makefile.am | 1 + python/pyosaf/utils/immoi/__init__.py| 531 +++ python/pyosaf/utils/immoi/agent.py

[devel] [PATCH 1/1] pyosaf: Fix some issues in NTF utils [#2682]

2017-12-20 Thread Nguyen Luu
agent.py: - Update some default values for notificationSend. - Correct NtfAgent.finalize() to handle BAD_HANDLE error code. producer.py: - Fix type conversion when assigning value of type SaNtfValueT. - Keep the notification info for reuse after sending notification. - Update the

[devel] [PATCH 0/1] Review Request for pyosaf: Fix some issues in NTF utils [#2682]

2017-12-20 Thread Nguyen Luu
Summary: pyosaf: Fix some issues in NTF utils [#2682] Review request for Ticket(s): 2682 Peer Reviewer(s): Hans Nordeback, Srinivas Mangipudy Pull request to: Hans Nordeback Affected branch(es): develop, release Development branch: ticket-2682 Base revision: