Re: [devel] [PATCH 0/1] Review Request for imm: not allow creating reserved IMM class names [#2771]

2018-01-26 Thread Vu Minh Nguyen
Hi Zoran and Anders, Thanks for your comments. Will send V2 patch for review with your proposals & suggestions. Regards, Vu > -Original Message- > From: Zoran Milinkovic [mailto:zoran.milinko...@ericsson.com] > Sent: Friday, January 26, 2018 1:28 PM > To: anders.bjornerst...@telia.com;

Re: [devel] [PATCH 0/1] Review Request for imm: not allow creating reserved IMM class names [#2771]

2018-01-26 Thread Zoran Milinkovic
Hi, I agree with you that the main check must be on the service side. I've been thinking of adding a parameter in immnd.conf to define reserved class names like: export RESERVED_CLASSES=classes,objects,attr_dflt,attrdef,multi_value_int,etc This will apply as well with the coming change in

Re: [devel] [PATCH 0/1] Review Request for imm: not allow creating reserved IMM class names [#2771]

2018-01-26 Thread Vu Minh Nguyen
Hi Anders Bjornerstedt, Do you mean we should move the validity check to IMMND (e.g: fevs local check) or have additional check at IMMND side? I thought the check here is about validation of user's input parameters, then it could be better to detect invalid ones as early as possible. Regards,

Re: [devel] [PATCH 0/5] Review Request for Add support for split brain prevention V2 [#64]

2018-01-26 Thread Ravi Sekhar Reddy Konda
Hi Gary, Thanks for sharing test cases I am going through Raft Algorithm and etcd implementation, I need some time to review. will get back to you once done. Thanks, Ravi -Original Message- From: Gary Lee [mailto:gary@dektech.com.au] Sent: Thursday, January 25, 2018