Re: [devel] [PATCH 1/1] imm: make version parameter in immutil_xxx non-const [#2830]

Thanks Lennart. I will update the code as your comments before pushing. @Ravi: Any comment from you? Thanks. Regards, Vu > -Original Message- > From: Lennart Lund [mailto:lennart.l...@ericsson.com] > Sent: Thursday, April 12, 2018 8:32 PM > To: Vu Minh Nguyen

Re: [devel] [PATCH 1/1] osaf: Isolate the node in the opensaf_reboot [#2833]

Hi Ravi, I think stonith, implemented in ticket #1859, handles this case. This "flickering" was one the (manual) tests verifying the added stonith support. It is important to have a separate interface for stonith, to be able to perform the remote fencing, similar to use a back plane. Have

[devel] [PATCH 1/1] plmd: use virDomainDestroy and virDomainCreate to reset VM [#2836]

Abrupt restart or unlock-in of child EE does not always work. virDomainReset() does not always work. Use virDomainDestroy() and virDomainCreate() instead. --- src/plm/plmd/plms_virt.cc | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git

[devel] [PATCH 0/1] Review Request for plmd: use virDomainDestroy and virDomainCreate to reset VM [#2836]

Summary: plmd: use virDomainDestroy and virDomainCreate to reset VM [#2836] Review request for Ticket(s): 2836 Peer Reviewer(s): Mathi, Ravi Pull request to: Affected branch(es): develop Development branch: ticket-2836 Base revision: b13a65123bfddcc6f5105fe340131e3bd8a5ac70 Personal repository:

[devel] [PATCH 0/1] Review Request for clmd: pass rootCauseEntity from PLM tracking to CLM tracking clients [#2834]

Summary: clmd: pass rootCauseEntity from PLM tracking to CLM tracking clients [#2834] Review request for Ticket(s): 2834 Peer Reviewer(s): Anders, Mathi Pull request to: Affected branch(es): develop Development branch: ticket-2834 Base revision: aff54ff091727f27830443332b830890668749cf Personal

Re: [devel] [PATCH 0/5] Review Request for split-brain: select active SC from largest network partition V3 [#2795]

Hi On 12/04/18 23:34, Anders Widell wrote: Ack with comments: * There is no need to use "const" when passing function arguments by value. E.g. the argument "const uint64_t cluster_size" should be "uint64_t cluster_size". [GL] Sure, but it doesn't do any harm, and would stop accidental

Re: [devel] [PATCH 0/5] Review Request for split-brain: select active SC from largest network partition V3 [#2795]

Ack with comments: * There is no need to use "const" when passing function arguments by value. E.g. the argument "const uint64_t cluster_size" should be "uint64_t cluster_size". * You assume that all nodes in the cluster have synchronized clocks (probably using NTP). Would it be possible to

Re: [devel] [PATCH 1/1] imm: make version parameter in immutil_xxx non-const [#2830]

> -Original Message- > From: Vu Minh Nguyen [mailto:vu.m.ngu...@dektech.com.au] > Sent: den 12 april 2018 12:37 > To: Lennart Lund ; > ravisekhar.ko...@oracle.com; Hans Nordebäck > ; Anders Widell > >

[devel] [PATCH 1/1] osaf: Isolate the node in the opensaf_reboot [#2833]

--- scripts/opensaf_reboot | 19 +-- 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/scripts/opensaf_reboot b/scripts/opensaf_reboot index df65c26..b219c39 100644 --- a/scripts/opensaf_reboot +++ b/scripts/opensaf_reboot @@ -37,6 +37,9 @@ export

[devel] [PATCH 0/1] Review Request for osaf:Isolate the node in the opensaf_reboot[#2833]

Summary: osaf:Isolate the node in the opensaf_reboot[#2833] Review request for Ticket(s): 2833 Peer Reviewer(s): Anders, Hans Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE *** Affected branch(es): develop Development branch: ticket-2833 Base revision:

Re: [devel] [PATCH 1/1] imm: make version parameter in immutil_xxx non-const [#2830]

Hi Lennart, See my response inline, started with [Vu]. Regards, Vu > -Original Message- > From: Lennart Lund [mailto:lennart.l...@ericsson.com] > Sent: Thursday, April 12, 2018 5:13 PM > To: Vu Minh Nguyen ; > ravisekhar.ko...@oracle.com; Hans Nordebäck >

Re: [devel] [PATCH 1/1] imm: make version parameter in immutil_xxx non-const [#2830]

Hi Vu, Ack, but an important issue to fix. See comments below [Lennart] Thanks Lennart > -Original Message- > From: Vu Minh Nguyen [mailto:vu.m.ngu...@dektech.com.au] > Sent: den 5 april 2018 12:39 > To: ravisekhar.ko...@oracle.com; Hans Nordebäck > ; Anders