Re: [devel] [PATCH 1/2] base: Add support to direct OpenSAF logging to local node file [#2306]

Hi Hans, That's why it needs explicitly "extern C++", I have changed it as your suggestion I have sent out V2, still keep TraceLog in logtrace.h as of now, so it can be included once for either c or c++. Let's see from Anders and Ravi if we have any ideas, I'm happy to move it out of

[devel] [PATCH 1/2] base: Add support to direct OpenSAF logging to local node file V2 [#2306]

Unify TraceLog and MdsLog class to one class (TraceLog) so it can be used as a common log client. Add new instance TraceLog for OpenSAF logging to local file, which can be enabled/disabled via environment variable OSAF_LOCAL_NODE_LOG. --- src/base/logtrace.cc | 175

[devel] [PATCH 2/2] base: Add OSAF_LOCAL_NODE_LOG environment variable to osaf service conf file [#2306]

--- src/amf/amfd/amfd.conf | 5 + src/amf/amfnd/amfnd.conf| 5 + src/amf/amfwd/amfwdog.conf | 5 + src/ckpt/ckptd/ckptd.conf | 5 + src/ckpt/ckptnd/ckptnd.conf | 5 + src/clm/clmd/clmd.conf | 5 + src/clm/clmnd/clmna.conf| 5 +

[devel] [PATCH 0/2] Review Request for base: Add support for OpenSAF local log file V2 [#2306]

Summary: base: Add support to direct OpenSAF logging to local node file V2 [#2306] Review request for Ticket(s): 2306 Peer Reviewer(s): Anders, Hans, Ravi Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE *** Affected branch(es): develop Development branch: ticket-2306 Base revision:

Re: [devel] [PATCH 2/2] base: Example of OSAF_LOCAL_LOG_FILE environment variable in amfd.conf file [#2306]

Thanks Hans, it's absolutely true :) Regards, Minh On 18/04/18 22:58, Hans Nordeback wrote: Hi Minh, ack, review only. Minor suggestions below. /Thanks HansN On 04/12/2018 01:12 AM, Minh Chau wrote: This commit is only an example to show where OSAF_LOCAL_LOG_FILE is configured. This

Re: [devel] [PATCH 1/2] base: Add support to direct OpenSAF logging to local node file [#2306]

Hi Minh, One part of this problem is in mbcsv_papi.h, the #ifdef __cplusplus extern "C" { should at least be after the #include stmts. Fixing this should remove the need for the extern "C++". But moving this part to a separate header file would also be good. As a general comment, (all

Re: [devel] [PATCH 1/2] base: Add support to direct OpenSAF logging to local node file [#2306]

Hi Minh, yes, before this patch logtrace.h was a c header file callable from c and c++. Now it is a c/c++ header file so including it from a c program without the extern "c++" will fail. In the first review comment I suggested to move this part to a separate header file and keep logtrace.h

Re: [devel] [PATCH 1/2] base: Add support to direct OpenSAF logging to local node file [#2306]

Hi Hans, One comment regarding extern C++ as below Thanks, Minh On 18/04/18 23:37, Hans Nordebäck wrote: Hi Minh, See my comments below. /Thanks HansN -Original Message- From: Minh Hon Chau [mailto:minh.c...@dektech.com.au] Sent: den 18 april 2018 15:20 To: Hans Nordebäck

[devel] [PATCH 0/1] Review Request for amfd: if rootCauseEntity is PLM entity don't engage lock/lock-in [#2835]

Summary: amfd: if rootCauseEntity is PLM entity don't engage lock/lock-in [#2835] Review request for Ticket(s): 2835 Peer Reviewer(s): Hans, Gary, Ravi Pull request to: Affected branch(es): develop Development branch: ticket-2835 Base revision: d6d899c39d15a91614ce2a350010c8634134ba0c Personal

[devel] [PATCH 1/1] amfd: if rootCauseEntity is PLM entity don't engage lock/lock-in [#2835]

When using PLM an AMF node mapped to a CLM node mapped to a PLM EE, can get stuck in locked state when rebooting, or going through a PLM EE lock/unlock. When amfd receives a START step from CLM tracking it attempts to gracefully shutdown the AMF node using AMF admin operations lock/lock-in. When

Re: [devel] [PATCH 1/2] base: Add support to direct OpenSAF logging to local node file [#2306]

Hi Minh, See my comments below. /Thanks HansN -Original Message- From: Minh Hon Chau [mailto:minh.c...@dektech.com.au] Sent: den 18 april 2018 15:20 To: Hans Nordebäck ; Anders Widell ; ravisekhar.ko...@oracle.com Cc:

Re: [devel] [PATCH 1/2] base: Add support to direct OpenSAF logging to local node file [#2306]

Hi Hans, Please check my response with [Minh] Thanks Minh On 18/04/18 22:40, Hans Nordeback wrote: Hi Minh, ack, code review only. Some comments below. /Thanks HansN On 04/12/2018 01:12 AM, Minh Chau wrote: Unify TraceLog and MdsLog class to one class (TraceLog) so it can be used as a

Re: [devel] [PATCH 0/5] Review Request for split-brain: select active SC from largest network partition V3 [#2795]

Hi Gary, in general const member functions and using logical constness is to prefer, I think. (If needed mutable can be used). /Regards HansN -Original Message- From: Gary Lee [mailto:gary@dektech.com.au] Sent: den 13 april 2018 09:45 To: Hans Nordebäck

Re: [devel] [PATCH 2/2] base: Example of OSAF_LOCAL_LOG_FILE environment variable in amfd.conf file [#2306]

Hi Minh, ack, review only. Minor suggestions below. /Thanks HansN On 04/12/2018 01:12 AM, Minh Chau wrote: This commit is only an example to show where OSAF_LOCAL_LOG_FILE is configured. This commit will not be pushed. The introduction of OSAF_LOCAL_LOG_FILE for all services will be in

Re: [devel] [PATCH 1/2] base: Add support to direct OpenSAF logging to local node file [#2306]

Hi Minh, ack, code review only. Some comments below. /Thanks HansN On 04/12/2018 01:12 AM, Minh Chau wrote: Unify TraceLog and MdsLog class to one class (TraceLog) so it can be used as a common log client. Add new instance TraceLog for OpenSAF logging to local file, which can be

Re: [devel] [PATCH 1/1] dtm: Add --delete option to osaflog command for deleting log streams [#2837]

HI Anders, Ack, please update the pr doc while pushing to the repo Thanks, Ravi -Original Message- From: Anders Widell [mailto:anders.wid...@ericsson.com] Sent: Friday, April 13, 2018 9:02 PM To: Ravi Sekhar Reddy Konda Cc: