Re: [devel] [PATCH 1/1] smf: use cb_lock to sync cbk count access between threads [#2882]

2018-07-11 Thread Tran Thuan
Hi Nagu, Normally deadlock happens due to: - MDS thread (get MDS lock) then acquire cb_lock - Another Agent thread API call (get cb_lock) then acquire MDS lock. Yes, I guess it's possible cause deadlock in other applications since we don't control them when call API. Best Regards, Thuan

Re: [devel] [PATCH 1/1] base: Limit buffer size by making size of THREAD_TRACE_BUFFER configurable [#2888]

2018-07-11 Thread Gary Lee
Hi Minh ack with 2 minor comments (see below) Thanks Gary On 03/07/18 17:49, Minh Chau wrote: When THREAD_TRACE_BUFFER enables, it uses by default a list 10240 trace string as a circular buffer. There is a concern that how much extra memory of all threads may use. This patch makes

Re: [devel] [PATCH 1/1] amf: change the way amfd handle amfnd down [#2891]

2018-07-11 Thread nagendra
Hi Thuan, Nice work. Ack from me(I am not sure about headless use case.) Thanks, Nagendra, 91-9866424860 www.hasolutions.in https://www.linkedin.com/company/hasolutions/ High Availability Solutions Pvt. Ltd. - OpenSAF support and services - Original

Re: [devel] [PATCH 1/1] tools: fix submit-review.sh not work with subject containing slash [#2887]

2018-07-11 Thread Anders Widell
Ack. regards, Anders Widell mån 2018-07-02 klockan 16:15 +0700 skrev Vu Minh Nguyen: > When user enters subject having slash (/) in, submit-review.sh won't > work > with error message: sed: -e expression #1, char 78: unknown option to > `s' > > This patch ensures that all slashes in the input

[devel] [PATCH 1/1] amf: change the way amfd handle amfnd down [#2891]

2018-07-11 Thread thuan.tran
There is a case that after AMFD send reboot order due to “out of sync window”. AMFD receive CLM track callback but node is not AMF member yet and delete node. Later AMFND MDS down will do nothing since it cannot find the node. When node reboot up, AMFD continue use old msg_id counter send to AMFND

[devel] [PATCH 0/1] Review Request for smf: use cb_lock to sync cbk count access between threads [#2882] V3

2018-07-11 Thread thuan.tran
Summary: smf: use cb_lock to sync cbk count access between threads [#2882] Review request for Ticket(s): 2882 Peer Reviewer(s): Lennart, Gary, Nguyen Pull request to: Lennart, Gary, Nguyen Affected branch(es): develop Development branch: ticket-2882 Base revision:

[devel] [PATCH 1/1] smf: use cb_lock to sync cbk count access between threads [#2882]

2018-07-11 Thread thuan.tran
Sometimes, callback agent dispatch and fail at saSmfReponse() because cbk list is empty, agent by somehow handle evt before increase cbk count. To avoid this, use cb_lock to sync cbk count acess between threads. --- src/smf/agent/smfa_mds.c | 7 ++- 1 file changed, 6 insertions(+), 1

Re: [devel] [PATCH 1/1] smf: use cb_lock to sync cbk count access between threads [#2882]

2018-07-11 Thread Tran Thuan
Hi Gary, Nguyen, OK, so let remove assert(). I will send out next version soon. Best Regards, Thuan -Original Message- From: Nguyen Luu Sent: Wednesday, July 11, 2018 1:32 PM To: Gary Lee ; thuan.tran ; lennart.l...@ericsson.com Cc: opensaf-devel@lists.sourceforge.net Subject: Re:

Re: [devel] [PATCH 1/1] smf: use cb_lock to sync cbk count access between threads [#2882]

2018-07-11 Thread Nguyen Luu
Hi Thuan, I also agree with Gary about removing assert(). Other changes look fine. Thanks, Nguyen On 7/11/2018 12:52 PM, Gary Lee wrote: Hi Thuan Looks OK to me, but I would remove the assert. We shouldn't do that in library code. Thanks Gary On 10/7/18, 6:52 pm, "thuan.tran" wrote: