ack, code review only. Minor comments below. /Thanks HansN
On 11/17/2015 09:56 AM, praveen.malv...@oracle.com wrote:
> osaf/services/saf/amf/amfd/app.cc | 2 +-
> osaf/services/saf/amf/amfd/cluster.cc | 2 +-
> osaf/services/saf/amf/amfd/include/util.h | 3 ++-
>
ack, code review only. /Thanks HansN
On 11/12/2015 06:31 AM, Gary Lee wrote:
> osaf/services/saf/amf/amfd/include/sg.h |2 +
> osaf/services/saf/amf/amfd/sg_npm_fsm.cc | 230
> --
> 2 files changed, 39 insertions(+), 193 deletions(-)
>
>
> diff --git
Ack, code review only/Thanks HansN
-Original Message-
From: praveen.malv...@oracle.com [mailto:praveen.malv...@oracle.com]
Sent: den 28 oktober 2015 13:33
To: Hans Nordebäck; nagendr...@oracle.com; Gary Lee
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1] amfd: adjust NPI
ack, code review only. Minor comment below/Thanks HansN
On 10/30/2015 01:54 PM, nagendr...@oracle.com wrote:
> osaf/services/saf/amf/amfd/node.cc | 6 --
> osaf/services/saf/amf/amfd/nodegroup.cc | 4
> 2 files changed, 8 insertions(+), 2 deletions(-)
>
>
> Amf is not checking
have been changed, it would be good if you can push
> it before someone else apply their patches. Thanks so much.
>
> Best regards,
> Long Nguyen.
>
> On 10/27/2015 7:08 PM, Hans Nordebäck wrote:
>> Ack for the series, code review only/Thanks HansN
>>
>> -Or
Hi Long, patch is now pushed/Thanks HansN
On 11/12/2015 01:30 PM, Long Nguyen wrote:
> Hi Hans,
>
> Can you please also push the code for AMFND? Thanks so much.
>
> Best regards,
> Long Nguyen.
>
> On 10/27/2015 7:09 PM, Hans Nordebäck wrote:
>> Ack for the series,
ack, code review only/Thanks Hans
On 10/29/2015 06:24 AM, praveen.malv...@oracle.com wrote:
> osaf/services/saf/amf/amfd/nodegroup.cc | 10 --
> osaf/services/saf/amf/amfd/util.cc | 2 +-
> 2 files changed, 9 insertions(+), 3 deletions(-)
>
>
> AMF allows creation of NG with
Hi Praveen,
I agreee, ack from me, code review only/Thanks HansN
On 10/29/2015 05:17 AM, praveen malviya wrote:
>
>
> On 29-Oct-15 4:22 AM, Hans Nordebäck wrote:
>> Hi Praveen,
>>
>> trying to understand the problem below, if N-way and
>> saAmfSGMaxStandbySIsperS
ack, code review only. Minor comments inlined/Thanks HansN
On 10/21/2015 02:38 PM, praveen.malv...@oracle.com wrote:
> osaf/services/saf/amf/amfd/comp.cc | 8 +++-
> osaf/services/saf/amf/amfd/include/su.h | 4 +++-
> osaf/services/saf/amf/amfd/sgproc.cc| 6 ++
>
Hi Praveen,
trying to understand the problem below, if N-way and
saAmfSGMaxStandbySIsperSU = 1,
and say there are 2 SUs and 2 SIs with the following assignments:
SU1 SU2
Active Standby Standby Active
^^ ^ ^
| |
Ack, code review only/Thanks HansN
-Original Message-
From: Gary Lee [mailto:gary@dektech.com.au]
Sent: den 23 oktober 2015 07:18
To: Hans Nordebäck; nagendr...@oracle.com; praveen.malv...@oracle.com; Minh
Chau H; Gary Lee
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1
Ack for the series, code review only/Thanks HansN
-Original Message-
From: Long HB Nguyen [mailto:long.hb.ngu...@dektech.com.au]
Sent: den 20 oktober 2015 11:58
To: Hans Nordebäck; Gary Lee; praveen.malv...@oracle.com; nagendr...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject
Ack for the series, code review only/Thanks HansN
-Original Message-
From: Long Buu Nguyen H
Sent: den 19 oktober 2015 13:18
To: Hans Nordebäck; Gary Lee; praveen.malv...@oracle.com; nagendr...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 00 of 48] Review Request
Ack for the series, code review only/Thanks HansN
-Original Message-
From: Long HB Nguyen [mailto:long.hb.ngu...@dektech.com.au]
Sent: den 16 oktober 2015 04:38
To: Hans Nordebäck; Gary Lee; Quyen Dao Q; Minh Chau H;
praveen.malv...@oracle.com; nagendr...@oracle.com
Cc: opensaf-devel
(), [&](AVD_COMP
*comp) -> bool {return comp->saAmfCompPresenceState ==
pres;})) {
return true;
} else {
return false;
}
}
/Thanks HansN
-Original Message-----
From: Hans Nordebäck [mailto:hans.nordeb...@ericsson.com]
Sent: den 27 oktober 2015 15:28
To: praveen.malv...@
ack, code review only/Thanks HansN
On 10/05/2015 12:47 PM, praveen.malv...@oracle.com wrote:
> osaf/services/saf/amf/amfd/sgproc.cc | 21 +
> 1 files changed, 21 insertions(+), 0 deletions(-)
>
>
> NG gets stuck in SHUTTING_DOWN state during shutdown op and controller
>
ack, code review only. Minor comments inlined.
/Thanks HansN
On 09/10/2015 04:03 PM, praveen.malv...@oracle.com wrote:
> osaf/services/saf/amf/amfd/comp.cc |5 +-
> osaf/services/saf/amf/amfd/include/su.h|1 +
> osaf/services/saf/amf/amfd/sgproc.cc |
Hi Gary,
ack, one question, please see inline.
/Thanks HansN
/Thanks Hans
On 09/17/2015 07:22 AM, Gary Lee wrote:
> osaf/services/saf/amf/amfd/sg.cc | 179
> +++---
> 1 files changed, 90 insertions(+), 89 deletions(-)
>
>
> diff --git
ack, code review and tested with AmfDemo configured n-way with 3 SU's 1
SI, saAmfSIPrefStandbyAssignments=2,
(SaAmfSIRankedSU configured).
before si-swap:
safSi=AmfDemo1A,safApp=AmfDemo2 ACTIVE on SC-1
safSi=AmfDemo1A,safApp=AmfDemo2 STANDBY on SC-2
safSi=AmfDemo1A,safApp=AmfDemo2 STANDBY on
Hi,
A general comment, there is a ticket
https://sourceforge.net/p/opensaf/tickets/751/ pyosaf: fix bad pylint rating.
Have you run pylint after these changes? /Thanks HansN
-Original Message-
From: Johan Mårtensson O
Sent: den 15 september 2015 14:34
To: Hans Nordebäck; mathi.naic
Hi Nagu,
yes, I'll change that, but one problem is the application SI's getting
the SI unassigned alarm
when doing shutdown on a node, this is not wanted, so the check for M/W
should be removed.
/Thanks HansN
On 09/16/2015 08:44 AM, Nagendra Kumar wrote:
> Hi Hans N,
> Two comments:
>
> 1.
Hi Gary,
Yes it was wrong before refactoring, I'll correct this before pushing./Thanks
HansN
-Original Message-
From: Gary Lee [mailto:gary@dektech.com.au]
Sent: den 15 september 2015 05:43
To: Hans Nordebäck; praveen.malv...@oracle.com; nagendr...@oracle.com
Cc: opensaf-devel
good, I'll update the patch and then I'll push it/Thanks HansN
On 09/15/2015 01:22 PM, praveen malviya wrote:
> Ack with one minor comment, code review only.
>
> Thanks,
> Praveen
>
> On 14-Sep-15 5:53 PM, Hans Nordeback wrote:
>> osaf/services/saf/amf/amfd/ckpt_dec.cc | 4 +++-
>>
Ack, code review only/Thanks HansN
-Original Message-
From: Gary Lee [mailto:gary@dektech.com.au]
Sent: den 15 september 2015 09:29
To: Hans Nordebäck; nagendr...@oracle.com; Gary Lee
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1] amfd: remove unused variables [#1142
ack, code review only/Thanks HansN
On 08/26/2015 07:21 AM, nagendr...@oracle.com wrote:
> osaf/libs/agents/saf/amfa/ava_api.c | 28 ++--
> 1 files changed, 22 insertions(+), 6 deletions(-)
>
>
> Amf is returning SA_AIS_ERR_INVALID_PARAM for SA_AMF_PM_ABNORMAL_END and
Hi Nagu,
good, yes it is an ack.
/Thanks Hans
On 09/14/2015 08:41 AM, Nagendra Kumar wrote:
> Hi Hans N,
> Thanks for your review, I will add it in function() and commit.
> Is that Ack?
>
> Thanks
> -Nagu
>
>> -Original Message-----
>> From: H
Hi Mathi,
I attach two pictures from the output of:
$./trace2dot -t osafamfd -f saClmDispatch -d amfd_trace.dot
$ dotty amfd_trace.dot
and
$./trace2dot -t osafamfd -d amfd_trace.dot
$ dotty amfd_trace.dot
/Thanks HansN
On 09/10/2015 10:59 AM, Mathivanan Naickan Palanivelu wrote:
Hi Hans,
Hi Mathi,
I use graphviz version 2.36.0. Can you send me your dot file(s), I can
have a look to see if
something is wrong. Anyhow I'll push the patch. /Thanks HansN
On 09/10/2015 11:13 AM, Mathivanan Naickan Palanivelu wrote:
> Looks Good unlike what i see :-). It must be some problem with the
mismatched TRACE_ENTER/TRACE_LEAVE can be
updated.
As we are using C++ in e.g. AMF we can adapt the TRACE_ENTER to the RAII
idiom, then we don't have to
specify any TRACE_LEAVES.
/Thanks HansN
On 09/10/2015 12:10 PM, Hans Nordebäck wrote:
> Hi Mathi,
>
> I use graphviz version 2.36.0. Can y
Hi Nagu,
please see comment below. /Thanks HansN
On 09/10/2015 12:30 PM, Nagendra Kumar wrote:
> Forgot to provide comments in the previous email. Please find comments
> inlined with [Nagu].
>
> Thanks
> -Nagu
>> -Original Message-
>> From: Nagendra Kumar
>> Sent: 10 September 2015
Hi Nagu,
Please see comment inlined/Thanks HansN
-Original Message-
From: Nagendra Kumar [mailto:nagendr...@oracle.com]
Sent: den 10 september 2015 13:04
To: Hans Nordebäck; Praveen Malviya; Gary Lee
Cc: opensaf-devel@lists.sourceforge.net
Subject: RE: [devel] [PATCH 1 of 1] amfd: Don't
Hi Nagu,
you mean the patch is acked and it can be pushed?
/Thanks HansN
On 09/10/2015 01:40 PM, Nagendra Kumar wrote:
> Hi Hans N,
> Comments inlined.
>
> Thanks
> -Nagu
>
>> -Original Message-
>> From: Hans Nordebäck [mailto:hans.norde
see comment below/Thanks HansN
On 09/09/2015 01:53 PM, Nagendra Kumar wrote:
> Thanks for the clarification, few more needed, please check below.
>
>> -Original Message-----
>> From: Hans Nordebäck [mailto:hans.nordeb...@ericsson.com]
>> Sent: 09 September 2015 17:
Hi Nagu,
please see my comment inlined with [HansN] /Thanks HansN
On 09/09/2015 01:13 PM, Nagendra Kumar wrote:
> Please check my comment below
>
> Thanks
> -Nagu
>> -Original Message-----
>> From: Hans Nordebäck [mailto:hans.nordeb...@ericsson.com]
>>
Hi Nagu,
please see comment inlined with [HansN]/Thanks HansN
On 09/09/2015 11:17 AM, Nagendra Kumar wrote:
> Please find comment inlined with [Nagu].
>
> Thanks
> -Nagu
>> -Original Message-
>> From: Hans Nordeback [mailto:hans.nordeb...@ericsson.com]
>> Sent: 14 August 2015 20:20
>>
Hi Nagu,
please see comment below./Thanks HansN
On 09/09/2015 02:10 PM, Nagendra Kumar wrote:
> Please find my comment below:
>
>> -Original Message-----
>> From: Hans Nordebäck [mailto:hans.nordeb...@ericsson.com]
>> Sent: 09 September 2015 17:26
>> To: Nagendr
Hi Nagu,
I wrote a small test program that you can try to explore how
std::erase/std::remove operates. /Thanks HansN
On 09/09/2015 03:15 PM, Hans Nordebäck wrote:
Hi Nagu,
please see comment below./Thanks HansN
On 09/09/2015 02:10 PM, Nagendra Kumar wrote:
Please find my comment below
Good, so it is ack for the whole series, 0-10? /Thanks HansN
-Original Message-
From: Nagendra Kumar [mailto:nagendr...@oracle.com]
Sent: den 9 september 2015 15:44
To: Hans Nordebäck; Praveen Malviya; Gary Lee
Cc: opensaf-devel@lists.sourceforge.net
Subject: RE: [PATCH 10 of 10] amfd
Ack, code review only/Thanks HansN
-Original Message-
From: Gary Lee [mailto:gary@dektech.com.au]
Sent: den 14 augusti 2015 07:56
To: nagendr...@oracle.com; Hans Nordebäck; praveen.malv...@oracle.com; Gary Lee
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1] amfd
Hi Praveen,
I forgot one question, is it correct that the standby amfd also updates imm?
/Thanks HansN
-Original Message-
From: Hans Nordebäck [mailto:hans.nordeb...@ericsson.com]
Sent: den 10 augusti 2015 09:01
To: praveen.malv...@oracle.com; nagendr...@oracle.com
Cc: opensaf-devel
ack/Thanks HansN
On 07/28/2015 11:22 AM, praveen.malv...@oracle.com wrote:
osaf/tools/scripts/amf-find | 116
+-
osaf/tools/scripts/amf-state | 68 -
2 files changed, 136 insertions(+), 48 deletions(-)
1)amf-find is
I added my comments below.
/Thanks HansN
-Original Message-
From: Gary Lee [mailto:gary@dektech.com.au]
Sent: den 26 augusti 2015 07:41
To: Hans Nordebäck; praveen.malv...@oracle.com; nagendr...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 1 of 1] amfd
Hi, please ignore this patch, I´ll send out a version 2. /Thanks HansN
-Original Message-
From: Hans Nordeback [mailto:hans.nordeb...@ericsson.com]
Sent: den 11 augusti 2015 15:11
To: praveen.malv...@oracle.com; nagendr...@oracle.com; Gary Lee
Cc: opensaf-devel@lists.sourceforge.net
Hi Nagu, Praveen,
Is it ok if I push these two patches?/Thanks HansN
-Original Message-
From: Hans Nordeback [mailto:hans.nordeb...@ericsson.com]
Sent: den 7 augusti 2015 08:57
To: nagendr...@oracle.com; praveen.malv...@oracle.com; Gary Lee
Cc: opensaf-devel@lists.sourceforge.net
Ack, code review only, with one comment below/Thanks HansN
-Original Message-
From: praveen.malv...@oracle.com [mailto:praveen.malv...@oracle.com]
Sent: den 31 juli 2015 14:35
To: Hans Nordebäck; nagendr...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1] amfd
ack for the whole series, code review only. Minor comment, all patches
must be applied to compile,
and a question in patch 04. Perhaps we can use c++11 nullptr instead of
NULL for pointers? /Thanks HansN
On 07/29/2015 08:36 AM, Gary Lee wrote:
Summary: amfd: convert AVD_SG_OPER to std::list
ack code review only, one question below, (I may have missed see the
check). /Thanks HansN
On 07/29/2015 08:36 AM, Gary Lee wrote:
osaf/services/saf/amf/amfd/sg_2n_fsm.cc | 99
+++-
1 files changed, 47 insertions(+), 52 deletions(-)
diff --git
ack, one question, in the ticket you mention it can be solved without
recursion in AVD_SI::add_csi_db, why choose the recursion
solution in verify_csi_deps_and_delete_invalid_compcsi()? /Thanks HansN
On 05/15/2015 05:26 AM, praveen.malv...@oracle.com wrote:
ack, code review only/Thanks HansN
On 05/19/2015 12:06 PM, praveen.malv...@oracle.com wrote:
osaf/services/saf/amf/amfd/include/cb.h | 14
osaf/services/saf/amf/amfd/include/si_dep.h | 1 +
osaf/services/saf/amf/amfd/main.cc | 4 +-
ack, code review and tested with amf demo app changed to delay exit at
termination callback. /Thanks HansN
On 06/09/2015 03:47 PM, nagendr...@oracle.com wrote:
osaf/services/saf/amf/amfnd/cbq.cc | 31
+---
osaf/services/saf/amf/amfnd/comp.cc |
]
Sent: den 5 juni 2015 17:33
To: Hans Nordebäck
Cc: ramesh.bet...@oracle.com; opensaf-devel@lists.sourceforge.net;
nagendr...@oracle.com; Anders Widell; praveen.malv...@oracle.com
Subject: Re: [PATCH 0 of 2] Review Request for Add unit test V2 [#1142]
I dont have other comments other than the below
ack, code review only/Thanks HansN
On 06/10/2015 12:53 PM, praveen.malv...@oracle.com wrote:
osaf/services/saf/amf/amfd/util.cc | 25 +
1 files changed, 25 insertions(+), 0 deletions(-)
diff --git a/osaf/services/saf/amf/amfd/util.cc
yes I agree it is better to download and build gtest yourself. I have
incorporated your suggested changes,
it works fine. Is it ok to push these patches now?
/Thanks HansN
On 05/26/2015 02:59 PM, Anders Widell wrote:
Ack (for both patches on this ticket), with some comments:
* Boiler plates
.
Thanks
-Nagu
-Original Message-
From: Hans Nordebäck [mailto:hans.nordeb...@ericsson.com]
Sent: 29 May 2015 13:40
To: Anders Widell; Nagendra Kumar; Praveen Malviya; Mathivanan Naickan
Palanivelu
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 0 of 1] Review Request
Ack, code review only/Thanks HansN
-Original Message-
From: nagendr...@oracle.com [mailto:nagendr...@oracle.com]
Sent: den 21 maj 2015 09:21
To: Hans Nordebäck; praveen.malv...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1] amfd: ignore invalid modification
ack for both patches, tested according to the steps mentioned in the
ticket/ Thanks HansN
On 05/21/2015 03:06 PM, praveen.malv...@oracle.com wrote:
Summary: fix validation of CtCsType [#1302]
Review request for Trac Ticket(s): #1302
Peer Reviewer(s): Hans N., Nagendra
Pull request to: LIST
Any comments on this patch?/Thanks HansN
-Original Message-
From: Hans Nordeback [mailto:hans.nordeb...@ericsson.com]
Sent: den 8 maj 2015 09:56
To: ramesh.bet...@oracle.com; mathi.naic...@oracle.com; Anders Widell
Cc: opensaf-devel@lists.sourceforge.net
Subject: [devel] [PATCH 0 of 1]
Any comments on this patch?/Thanks HansN
-Original Message-
From: Hans Nordeback [mailto:hans.nordeb...@ericsson.com]
Sent: den 8 maj 2015 10:11
To: Anders Widell; nagendr...@oracle.com; praveen.malv...@oracle.com;
mathi.naic...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
[mailto:mathi.naic...@oracle.com]
Sent: den 6 maj 2015 16:47
To: Anders Widell; ramesh.bet...@oracle.com; Hans Nordebäck;
nagendr...@oracle.com; praveen.malv...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1] osaf: During adminrestart of node directors, before
re
ack, code review only/Thanks HansN
On 05/05/2015 12:55 PM, nagendr...@oracle.com wrote:
osaf/services/saf/amf/amfd/role.cc | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
During node failover if node is not found at amfd,
then my_node remains null and amfd access it in the
Hi Mathi,
is it ok to push this patch? I'll add the documentation AndersW
mentioned. /Thanks HansN
On 05/06/2015 12:17 PM, Anders Widell wrote:
Ack with minor comment: The documentation for the function
spawn_wait() should be updated to say that NCSCC_RC_REQ_TIMEOUT is a
possible return
Hi Nagu,
please see below. /Thanks HansN
On 05/06/2015 10:51 AM, Nagendra Kumar wrote:
Hi Hans N,
perhaps the comment above the change need to be updated
I didn’t get it. Please specify the comment you are pointing.
Thanks
-Nagu
*From:*Hans Nordebäck [mailto:hans.nordeb
Hi Praveen,
you mean that we can use version 1 of this patch then add your
modified.patch on top of it and ignore version 2?
/Thanks HansN
On 05/05/2015 03:06 PM, praveen malviya wrote:
On 28-Apr-15 4:39 PM, Hans Nordeback wrote:
osaf/services/saf/amf/amfd/include/node.h |1 +
interval will be the same as for TRY_AGAIN In
immutil.
/Thanks HansN
-Original Message-
From: Nagendra Kumar [mailto:nagendr...@oracle.com]
Sent: den 29 april 2015 12:54
To: Hans Nordebäck; Praveen Malviya
Cc: opensaf-devel@lists.sourceforge.net
Subject: RE: [PATCH 1 of 1] amfd: node
ack, code review only. /Thanks HansN
On 05/04/2015 12:10 PM, praveen.malv...@oracle.com wrote:
osaf/services/saf/amf/amfnd/chc.cc | 2 +-
osaf/services/saf/amf/amfnd/hcdb.cc | 12 +---
2 files changed, 10 insertions(+), 4 deletions(-)
saAmfHealthcheckStart() API fails with
ack, code review only/Thanks HansN
On 04/30/2015 12:24 PM, nagendr...@oracle.com wrote:
osaf/services/saf/amf/amfd/si.cc | 13 +
1 files changed, 5 insertions(+), 8 deletions(-)
Amfd rejects ccb modification operation on si rank if
its current si rank value is being modified
ack, code review only, perhaps the comment above the change need to be
updated/Thanks HansN
On 04/30/2015 02:11 PM, nagendr...@oracle.com wrote:
osaf/services/saf/amf/amfd/ndfsm.cc | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
When Amfd is comming up as Act, it is not
ack, code review only/Thanks HansN
On 04/30/2015 09:02 AM, praveen.malv...@oracle.com wrote:
osaf/services/saf/amf/amfd/nodegroup.cc | 18 --
osaf/services/saf/amf/amfd/sgproc.cc| 2 ++
2 files changed, 18 insertions(+), 2 deletions(-)
If a node is in lock-in
Ack, code review only/Thanks HansN
-Original Message-
From: nagendr...@oracle.com [mailto:nagendr...@oracle.com]
Sent: den 21 april 2015 13:32
To: Hans Nordebäck; praveen.malv...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1] amfa: avoid illigal memory access
Ack with one comment, sirankedsu in the usage text do not correspond to the
siranksu) case stmt. /Thanks HansN
-Original Message-
From: praveen.malv...@oracle.com [mailto:praveen.malv...@oracle.com]
Sent: den 21 april 2015 15:02
To: Hans Nordebäck; nagendr...@oracle.com
Cc: opensaf
Ack, code review only/Thanks HansN
-Original Message-
From: nagendr...@oracle.com [mailto:nagendr...@oracle.com]
Sent: den 27 april 2015 11:19
To: Hans Nordebäck; praveen.malv...@oracle.com; mathi.naic...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1] amfd
it was tested with an LSB compiler, but I can add the ifndef before
pushing. /Thanks HansN
On 04/27/2015 01:20 PM, Anders Widell wrote:
Ack.
Question: Did you try this with an LSB compiler? I am surprised it
didn't complain about PR_SET_DUMPABLE. Maybe it would be good to add
an #ifndef,
ack, code review only/Thanks HansN
On 04/22/2015 01:27 PM, nagendr...@oracle.com wrote:
osaf/services/saf/amf/amfd/node.cc | 14 ++
1 files changed, 14 insertions(+), 0 deletions(-)
Amfd is allowing node to be deleted even if node is being part of node group.
This creates
when 'NCSCC_RC_SUCCESS != rc'.
I agree with your second comment. Setting it to 0 is unnecessary. I'll
remove this.
Thanks
Gary
On 21/04/15 20:47, Hans Nordebäck wrote:
Hi Gary,
two questions, in avnd_msg_content_free it seems that the cbk_info is
not freed if msg-info.ava == 0
Hi Gary,
two questions, in avnd_msg_content_free it seems that the cbk_info is
not freed if msg-info.ava == 0,
it is set to 0 when avnd_mds_send succeeds, so it will not be freed as
that code now has been removed?
The cbk_info is a local variable so it shouldn't be necessary to set it
to 0.
ack, code review only/Thanks HansN
On 04/21/2015 01:31 PM, nagendr...@oracle.com wrote:
osaf/libs/agents/saf/amfa/ava_api.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
While invalid handle is passed to saAmfProtectionGroupTrack_4, code jumps to
done and calls
-
From: Hans Nordebäck [mailto:hans.nordeb...@ericsson.com]
Sent: 09 April 2015 20:02
To: praveen malviya; Nagendra Kumar
Cc: opensaf-devel@lists.sourceforge.net
Subject: RE: [PATCH 1 of 1] amfd: segv in avd_sidep_is_si_failover_possible
#1309
Hi,
The problem has been reproduced
Hi Mathi,
Isn't the problem that the programs nodeinit spawns are in its turn
daemonized, i.e. now owned by the init process.
But the pid from nodeinit's initial fork, service-pid, may now be a
zombie process?
So the /var/run/pid files should be used in both script, daemon and the
process
be a wait added for service-pid? Which branches should the patch
be pushed to?
/Thanks HansN
Från: Mathivanan Naickan Palanivelu [mathi.naic...@oracle.com]
Skickat: den 14 april 2015 16:26
Till: Hans Nordebäck
Kopia: opensaf-devel@lists.sourceforge.net
Ack, code review only/Thanks HansN
-Original Message-
From: nagendr...@oracle.com [mailto:nagendr...@oracle.com]
Sent: den 9 april 2015 14:49
To: Hans Nordebäck; praveen.malv...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1] amfd: avoid calling failover
Hi,
The problem has been reproduced and traces has been provided, I'll come back
with steps how to reproduce the fault/Thanks HansN
-Original Message-
From: praveen malviya [mailto:praveen.malv...@oracle.com]
Sent: den 8 april 2015 11:33
To: Hans Nordebäck; nagendr...@oracle.com
Cc
Thanks Mathi and Anders, I'll update with your review comments, and I guess it
is ok to push this then./Thanks HansN
-Original Message-
From: Anders Widell
Sent: den 9 april 2015 16:09
To: Hans Nordebäck; mathi.naic...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re
Hi Anders,
I updated the patch with your comments and added the pid and uid to the
header output.
Pid and uid will be available if the signal originates from the kill
call otherwise pid and uid will be 0.
/Thanks HansN
On 04/08/2015 02:33 PM, Anders Widell wrote:
Ack with comments.
* Make
ack, code review only/Thanks HansN
On 04/01/2015 02:41 PM, praveen.malv...@oracle.com wrote:
osaf/services/saf/amf/amfd/role.cc | 10 +++---
1 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/osaf/services/saf/amf/amfd/role.cc
b/osaf/services/saf/amf/amfd/role.cc
---
ack, code review only/Thanks HansN
On 03/24/2015 12:49 PM, praveen.malv...@oracle.com wrote:
osaf/services/saf/amf/amfd/role.cc | 70
+
1 files changed, 55 insertions(+), 15 deletions(-)
If two controller switchover occurs during lock operation on
ack, code review only/Thanks HansN
On 03/25/2015 05:44 AM, praveen.malv...@oracle.com wrote:
osaf/services/saf/amf/amfd/node.cc | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/osaf/services/saf/amf/amfd/node.cc
b/osaf/services/saf/amf/amfd/node.cc
---
ack, code review only/Thanks HansN
On 03/19/2015 10:24 AM, nagendr...@oracle.com wrote:
+ m_AVSV_SEND_CKPT_UPDT_ASYNC_UPDT(avd_cb,
su-su_on_node, AVSV_CKPT_AVND_ADMIN_STATE);
--
Dive into
Ack. /Thanks HansN
-Original Message-
From: praveen.malv...@oracle.com [mailto:praveen.malv...@oracle.com]
Sent: den 2 mars 2015 14:35
To: Hans Nordebäck; nagendr...@oracle.com; Bertil Engelholm;
mathi.naic...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 7
Ack, one comment below/Thanks HansN
-Original Message-
From: praveen.malv...@oracle.com [mailto:praveen.malv...@oracle.com]
Sent: den 2 mars 2015 14:35
To: Hans Nordebäck; nagendr...@oracle.com; Bertil Engelholm;
mathi.naic...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject
Ack, code review only/Thanks HansN
-Original Message-
From: praveen.malv...@oracle.com [mailto:praveen.malv...@oracle.com]
Sent: den 2 mars 2015 14:35
To: Hans Nordebäck; nagendr...@oracle.com; Bertil Engelholm;
mathi.naic...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject
ack, code review only/Thanks HansN
On 03/12/2015 08:12 AM, nagendr...@oracle.com wrote:
osaf/services/saf/amf/amfd/main.cc | 6 ++
1 files changed, 6 insertions(+), 0 deletions(-)
During switchover, if payload is being stopped, Standby Amfd crashes
in avd_dec_warm_sync_rsp because
ok, but it should be an enum, not a define./Thanks Hans
On 03/12/2015 01:17 PM, praveen malviya wrote:
On 12-Mar-15 5:38 PM, Hans Nordebäck wrote:
Ack, code review only. Question, why is SA_AMF_NTFID_NG_ADMIN_STATE
not added to SaAmfNotificationMinorIdT enum? /Thanks HansN
Since
Ack, code review only.
/Thanks HansN
-Original Message-
From: praveen.malv...@oracle.com [mailto:praveen.malv...@oracle.com]
Sent: den 5 mars 2015 05:07
To: Hans Nordebäck; nagendr...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1] amfnd: issue remove cbk
Ack, code review only.
/Thanks HansN
-Original Message-
From: praveen.malv...@oracle.com [mailto:praveen.malv...@oracle.com]
Sent: den 29 januari 2015 12:26
To: Hans Nordebäck; nagendr...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1] amfd: do not assign
november 2014 11:43
To: Hans Nordebäck; nagendr...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1] amfd : support for
saAmfNodeFailfastOnInstantiationFailure [964]
osaf/services/saf/amf/amfd/comp.cc | 31 ++-
osaf/services/saf/amf/amfd/node.cc
-Original Message-
From: nagendr...@oracle.com [mailto:nagendr...@oracle.com]
Sent: den 26 februari 2015 07:23
To: Hans Nordebäck; praveen.malv...@oracle.com; mathi.naic...@oracle.com;
Anders Björnerstedt; Anders Widell
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1] amfd: add
Ack, code review only, one minor comment, use strncmp instead of strcmp.
/Thanks HansN
-Original Message-
From: nagendr...@oracle.com [mailto:nagendr...@oracle.com]
Sent: den 20 februari 2015 09:24
To: Hans Nordebäck; praveen.malv...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Ack, code review only/Thanks HansN
-Original Message-
From: praveen.malv...@oracle.com [mailto:praveen.malv...@oracle.com]
Sent: den 13 februari 2015 07:11
To: Hans Nordebäck; nagendr...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1] amfnd: issue remove cbk
Ack, code review only/Thanks HansN
-Original Message-
From: nagendr...@oracle.com [mailto:nagendr...@oracle.com]
Sent: den 20 februari 2015 06:51
To: Hans Feldt; Hans Nordebäck; praveen.malv...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1] amfd: add SG and SU
Ack, code review only/Thanks HansN
-Original Message-
From: praveen.malv...@oracle.com [mailto:praveen.malv...@oracle.com]
Sent: den 23 januari 2015 10:00
To: Hans Nordebäck; nagendr...@oracle.com; Minh Chau H
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1] amfd: fix amfd
401 - 500 of 607 matches
Mail list logo
