Hi Alex,
ACK from me.
Tested with basic behavior.
Sincerely,
Hoang
-Original Message-
From: Alex Jones [mailto:alex.jo...@genband.com]
Sent: Monday, October 23, 2017 10:13 PM
To: hoang.m...@dektech.com.au
Cc: opensaf-devel@lists.sourceforge.net; Alex Jones
PM
To: Vo Minh Hoang <hoang.m...@dektech.com.au>
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 1/1] ckptnd: fix crash during checkpoint open timeout with
large sections [#1510]
Hi Hoang,
I'm not sure what you are asking. Are you saying that all of the code
Dear Alex,
I got confuse with this path as following:
>> sync from the active can timeout with errorcode SA_AIS_ERR_TRY_AGAIN
Does that mean out_evt->info.cpnd.error == SA_AIS_ERR_TRY_AGAIN?
Your current cpnd_ckpt_node_del() is added in ckpt_node_free_error.
If above is true, please consider
Dear Alex,
If there is no further comment, would you please help me push the patch.
Because I do not have the push privilege.
Thank you very much for your kindness.
Sincerely,
Hoang
-Original Message-
From: Vo Minh Hoang [mailto:hoang.m...@dektech.com.au]
Sent: Thursday, October 12
Dear Alex,
Thank you very much for your very fast response.
Because this is test code, I think we should push it to release also, test
environment should be consistent even it is really not important.
If not, release branch might fail sometimes then cost extra effort for
verifying much
...@oracle.com]
Sent: Thursday, April 13, 2017 5:47 PM
To: Vo Minh Hoang <hoang.m...@dektech.com.au>; zoran.milinko...@ericsson.com
Cc: opensaf-devel@lists.sourceforge.net; Ramesh Babu Betham
<ramesh.bet...@oracle.com>
Subject: Re: [PATCH 1 of 1] cpd: to correct failover behavior of cps
replicas gone
- create same name checkpoint again and got SA_AIS_ERR_LIBRARY
Sincerely,
Hoang
-Original Message-
From: A V Mahesh [mailto:mahesh.va...@oracle.com]
Sent: Wednesday, April 12, 2017 3:50 PM
To: Vo Minh Hoang <hoang.m...@dektech.com.au>; zoran.milinko...@ericsson.com
Cc: o
Hi Mahesh,
ACK. Review only.
Sincerely,
Hoang
-Original Message-
From: A V Mahesh [mailto:mahesh.va...@oracle.com]
Sent: Friday, March 10, 2017 12:47 PM
To: hoang.m...@dektech.com.au; ramesh.bet...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1] cpd: update
Dear Anders Widell,
Yes, as you mentioned, this patch offer a change for this behavior.
The reason is as bellowing:
* Currently, when API succeeds, memory is free in user defined
callback, not really by MDS itself. Only in some cases API fails, MDS frees
memory, in some cases MDS
Dear Zoran,
Thank you very much for your checking.
Would you please tell me which test case is failed in your environment
because my current pc return OK for all and no mem leak. That might because
of threading problem.
Further information, please note that this patch should apply after #2174
Dear Mahesh,
Based on what I saw, in this case, retention time cannot detect CPND
temporarily down because its pid changed.
If cpnd is temporary down only, we don't need clean up anything.
If cpnd is permanently down, the bad effect of this proposal is that replica
is not clean up. But if cpnd
Dear Zoran,
I am sorry if you are waiting for me in this ticket.
ACK.
Sincerely,
Hoang
-Original Message-
From: Zoran Milinkovic [mailto:zoran.milinko...@ericsson.com]
Sent: Wednesday, February 1, 2017 8:13 PM
To: A V Mahesh
Cc:
Dear Mahesh and Zoran,
I checked the problem that mentioned in this ticket in newest source code
and cannot reproduce following recorded steps.
I suggest to set #1655 and #1765 to invalid and open new ones if found any
problem.
Is that possible?
Thank you and best regards,
Hoang
-Original
Dear Mahesh,
>> So we can always re-use the existing UN-linked resources by just simply
removing UN-link flag,
>> what is your opinion?
Based on my understanding, new checkpoint even has the same name but might
have different attribute (collocated/non-collocated) and be opened from
Dear Mahesh,
I checked with newest source code, problem still occur.
So it is in different case.
Btw, I found some unexpected characters in submitted patch.
So I will send updated file for review.
Thank you and best regards,
Hoang
-Original Message-
From: Vo Minh Hoang [mailto:hoang.m
Dear Mahesh,
I will check that again.
I have just rebased it when this patch stayed in local PC for too long.
Thank you and best regards,
Hoang
-Original Message-
From: A V Mahesh [mailto:mahesh.va...@oracle.com]
Sent: Thursday, January 19, 2017 2:11 PM
To: Hoang Vo
Dear Mahesh,
I have 2 comments.
Please find with [Hoang] tag and consider.
Sincerely,
Hoang
-Original Message-
From: mahesh.va...@oracle.com [mailto:mahesh.va...@oracle.com]
Sent: Friday, January 6, 2017 7:17 PM
To: hoang.m...@dektech.com.au
Cc: opensaf-devel@lists.sourceforge.net
Dear Mahesh,
Would you please rebase this patch, it seems a little bit out date.
---
patching file src/ckpt/ckptd/cpd_sbevt.c
Hunk #2 FAILED at 497
Hunk #3 FAILED at 511
2 out of 3 hunks FAILED
Hi Zoran,
ACK.
Sincerely,
Hoang
-Original Message-
From: A V Mahesh [mailto:mahesh.va...@oracle.com]
Sent: Wednesday, January 11, 2017 10:59 AM
To: Zoran Milinkovic
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [devel] [PATCH 1 of 1] ckpt: fix
Hi Zoran,
ACK from me.
Sincerely,
Hoang
-Original Message-
From: A V Mahesh [mailto:mahesh.va...@oracle.com]
Sent: Friday, January 13, 2017 10:15 AM
To: Zoran Milinkovic
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [devel] [PATCH 1 of 1] ckpt:
Dear Mahesh,
That information is from Nhat in old version of this patch.
I keep this because I think this is needed error handling.
My update part is:
> - Stop timer of removed node.
> - Update data in patricia trees.
In some cases (ex. Delay of getting node HA state) checkpoint call
Dear Mahesh,
ACK all three patches, tested, found no problem.
Sincerely,
Hoang
-Original Message-
From: mahesh.va...@oracle.com [mailto:mahesh.va...@oracle.com]
Sent: Tuesday, November 29, 2016 5:37 PM
To: hoang.m...@dektech.com.au; ramesh.bet...@oracle.com
Cc:
Dear Mahesh,
I have one small concern about:
Please consider get CB data by ncshm_take_hdl() or pass in ensures_space as
parameter.
When CB is global access, adding it to parameters of many API is a little
bit inconvenient.
And passing CB for just one ensures_space param might confuse the usage
Dear Mahesh,
Unfortunately, I have just receive information that the same core dump still
occur after applying patch.
Here is dump information in short, please tell me if I can do anything in
support:
Program terminated with signal SIGSEGV, Segmentation fault.
#0 0x7fe314aa0109 in
nality the that are not required in
cpnd_ckpt_sec_del(), in case of cpnd_sec_hdr_update() failure .
-AVM
On 11/25/2016 3:58 PM, Vo Minh Hoang wrote:
> Dear Mahesh,
>
> Thank you very much for your review and comments.
> I understood that I missed the point at n_secs calculation.
&g
d_ckpt_sec_del() many time
without affecting system.
Please consider and tell me your judgement.
Best regards,
Hoang
-----Original Message-
From: Vo Minh Hoang [mailto:hoang.m...@dektech.com.au]
Sent: Friday, November 25, 2016 5:14 PM
To: 'A V Mahesh' <mahesh.va...@oracle.com>
Cc: opensaf
TRACE_4("cpnd ckpt hdr update failed");
}
}
=======
-AVM
On 11/25/2016 12:08 PM, Vo Minh Hoang wrote:
> Dear Mahesh,
>
> The first call erase a element with id from map.
> The
Dear Mahesh,
I think this problem is #1712, problem occur when
OSAF_CKPT_SHM_ALLOC_GUARANTEE is not set.
My thinking is that because we provide 2 mode (guarantee or not) so we
should making sure no coredump happened.
Btw, because this is out of my scope of decide, I would like to ask Anders
essage-
From: A V Mahesh [mailto:mahesh.va...@oracle.com]
Sent: Friday, November 25, 2016 1:20 PM
To: Vo Minh Hoang <hoang.m...@dektech.com.au>
Cc: anders.wid...@ericsson.com; opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 1 of 1] cpnd: fix error handling while
section_hdr_update
Dear Mahesh,
Thank you very much for your comment.
Would you please verify again my understanding about this.
Old cpnd_ckpt_sec_del() function and new cpnd_ckpt_sec_del_db() search for
the sectionInfo in 2 maps by its id and remove if found.
In case ckpt_hdr_update_fails, the
Dear Mahesh,
Reviewed and tested with collocated and non-collocated case, saw problem
fixed and could not find any occurrence.
So ACK from me, tested.
Sincerely,
Hoang
-Original Message-
From: mahesh.va...@oracle.com [mailto:mahesh.va...@oracle.com]
Sent: Wednesday, November 16, 2016
unt;
cpd_msg.info.usr_info_2.node_users_cnt = count;
}
Sincerely,
Hoang
-Original Message-
From: A V Mahesh [mailto:mahesh.va...@oracle.com]
Sent: Wednesday, November 16, 2016 3:29 PM
To: Vo Minh Hoang <hoang.m...@dektech.com.au>; anders.wid...@ericsson.com
C
age-
From: A V Mahesh [mailto:mahesh.va...@oracle.com]
Sent: Wednesday, November 16, 2016 11:00 AM
To: Vo Minh Hoang <hoang.m...@dektech.com.au>; anders.wid...@ericsson.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 1 of 1] fix crash problem by checking null pointer
before
Dear Mahesh,
I am sorry that I cannot share the test steps because I cannot reproduce it
in local environment.
I've just received the coredump information point directly to this part,
reviewed source code and found that pointer using is unsafe so I correct it.
Please let me know if you have any
Dear Mahesh,
I tested with cases:
- Old active with new standby
- Old standby with new active
Each case, create checkpoint, create section, write and read section, close
and unlink.
Sincerely,
Hoang
-Original Message-
From: A V Mahesh [mailto:mahesh.va...@oracle.com]
Sent: Thursday,
-
From: A V Mahesh [mailto:mahesh.va...@oracle.com]
Sent: Wednesday, October 26, 2016 11:02 AM
To: Vo Minh Hoang <hoang.m...@dektech.com.au>; anders.wid...@ericsson.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 1 of 1] cpnd: use shared memory based on ckpt name
length [#2108]
Dear Mahesh,
Thank you very much for your checking.
It is very strangle that I tested with 2 following case:
- restart nd by kill -9
- restart node by kill -9
Both cases executed well in my local machine.
Would you please tell me the process to reproduce this error?
It is very strangle that ER
d data can still work with updated pointer with
same behavior.
Thank you and best regards,
Hoang
-Original Message-
From: Vo Minh Hoang [mailto:hoang.m...@dektech.com.au]
Sent: Tuesday, October 18, 2016 2:15 PM
To: 'A V Mahesh' <mahesh.va...@oracle.com>
Cc: 'anders.wid...@ericsson.com'
-Original Message-
From: A V Mahesh [mailto:mahesh.va...@oracle.com]
Sent: Tuesday, October 18, 2016 1:10 PM
To: Vo Minh Hoang <hoang.m...@dektech.com.au>
Cc: anders.wid...@ericsson.com; opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 1 of 1] cpnd: use shared memory based on
hesh [mailto:mahesh.va...@oracle.com]
Sent: Tuesday, October 18, 2016 12:14 PM
To: Vo Minh Hoang <hoang.m...@dektech.com.au>
Cc: anders.wid...@ericsson.com; opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 1 of 1] cpnd: use shared memory based on ckpt name
length [#2108]
Hi Hoan,
On 10/18/2016
Message-
From: A V Mahesh [mailto:mahesh.va...@oracle.com]
Sent: Tuesday, October 18, 2016 10:48 AM
To: Vo Minh Hoang <hoang.m...@dektech.com.au>
Cc: anders.wid...@ericsson.com; opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 1 of 1] cpnd: use shared memory based on ckpt name
Dear Mahesh,
Because of keeping the consistent working behavior of existing function,
only 1 shared memory at a time. If shared memory swapping action occurs, a
new shared memory will replace old one.
Here is the detailed answers to your questions:
>> -The existing `small format shm` will
Dear Mahesh,
Thank you very much for your comment.
The function osaf_is_an_extended_name() just check input SaNameT is longDN
or not.
So it do not have any use here.
It is mostly used for handling encode/decode part.
Best regards,
Hoang
-Original Message-
From: A V Mahesh
Dear Mahesh,
osaf_is_an_extended_name() is just a function to check inside SaNameT struct
and does not affect performance.
cpnd_get_longDnsAllowed_attr() check imm config and cost very much
unnecessary time, Imm verify long DN support after that.
Thank you and best regards,
Hoang
Dear Mahesh,
The submitted patch correct the behavior of cpd_ckpt_db_entry_update()
function to be similar to cpd_sb_proc_ckpt_create() in handling node_info.
So both 2 cases have been considered.
Thank you and best regards,
Hoang
-Original Message-
From: A V Mahesh
Dear Mahesh,
Logic of this part is complicated so I modified it wrong.
This time I correct it, not a roll back.
That part is subsequence of if clause above.
Sincerely,
Hoang
-Original Message-
From: A V Mahesh [mailto:mahesh.va...@oracle.com]
Sent: Thursday, August 25, 2016 11:21 AM
Dear Mahesh,
I updated README file and sent as attachment to this email.
I also sent update patches following your comments.
Please help me push these items if there is no further problem.
Thank you and best regards,
Hoang
-Original Message-
From: A V Mahesh
Dear Mahesh,
I would like to send updated patch following your comment.
When this is minor comment, I send it as attached file.
Sincerely,
Hoang
-Original Message-
From: A V Mahesh [mailto:mahesh.va...@oracle.com]
Sent: Monday, August 22, 2016 1:02 PM
To: Hoang Vo
Dear Mahesh,
I would like to send updated patch following your comment.
When this is minor comment, I send it as attached file.
Sincerely,
Hoang
-Original Message-
From: A V Mahesh [mailto:mahesh.va...@oracle.com]
Sent: Monday, August 22, 2016 12:55 PM
To: Hoang Vo
Dear Mahesh,
I would like to send updated patch following your comment.
When this is minor comment, I send it as attached file.
Sincerely,
Hoang
-Original Message-
From: A V Mahesh [mailto:mahesh.va...@oracle.com]
Sent: Monday, August 22, 2016 12:45 PM
To: Hoang Vo
Dear Mahesh,
I would like to send my ideal about this.
Please consider it.
- I'm agree this modification will enhance writing performance.
- I checked opensaf-4.7.x both newest changeset (7886) and tested changeset
(7640) and found the same source code. So I think that this fixing will not
solve
AM
To: Vo Minh Hoang <hoang.m...@dektech.com.au>
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 6 of 8] cpsv: Apply new messages supporting extended
SaNameT to CPD, CPND, and CPA v1 [#1574]
Hi Hoang,
Please find my responses as [AVM].
-AVM
On 8/15/2016 8:16 AM, Vo Minh Hoang
Dear Mahesh,
Thank you very much for your help.
I send the attached patch that fix missing in encode/decode function.
Thank you and best regards,
Hoang
-Original Message-
From: A V Mahesh [mailto:mahesh.va...@oracle.com]
Sent: Friday, August 12, 2016 10:15 AM
To: Vo Minh Hoang <hoan
Dear Mahesh,
Would you please tell me the case that produce this error?
I review source code and found that encode/decode function missed 1
attribute.
But running test in our environment could not reproduce this problem.
Thank you and best regards,
Hoang
-Original Message-
From: A V
Dear Mahesh,
Encode and decode for new messages are implemented in separate functions
like *_encode() and *_decode() so they do not exist in *_edu.c file.
I find only MDS_CLIENT_MSG_FORMAT_VER and I think that I should not update
this each time adding new message. I am sorry if it is wrong.
the result of this patch.
Thank you and best regards,
Hoang
-Original Message-
From: A V Mahesh [mailto:mahesh.va...@oracle.com]
Sent: Wednesday, July 27, 2016 4:53 PM
To: Vo Minh Hoang <hoang.m...@dektech.com.au>; 'Nhat Pham'
<nhat.p...@dektech.com.au>; anders.wid...@ericsson.com
...@oracle.com]
Sent: Friday, July 29, 2016 1:27 PM
To: Vo Minh Hoang <hoang.m...@dektech.com.au>
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 6 of 8] cpsv: Apply new messages supporting extended
SaNameT to CPD, CPND, and CPA v1 [#1574]
Hi ,
I have proved some code related
Dear Mahesh,
Thank you very much for your comment.
I start working on it from now.
Sincerely,
Hoang
-Original Message-
From: A V Mahesh [mailto:mahesh.va...@oracle.com]
Sent: Friday, July 29, 2016 1:27 PM
To: Vo Minh Hoang <hoang.m...@dektech.com.au>
Cc: opensaf
Dear Mahesh,
We do not have specific test case and environment for in-service update.
So my test work is based on osaftest cases.
I tested with old d - new nd and new d - old nd cases.
There are failed test cases but after investigating, they are intensional
when old one cannot recognize new
Dear Mahesh,
Thank you very much for your provided information.
I will continue investigating this problem.
Sincerely,
Hoang
-Original Message-
From: A V Mahesh [mailto:mahesh.va...@oracle.com]
Sent: Wednesday, July 27, 2016 4:53 PM
To: Vo Minh Hoang <hoang.m...@dektech.com.au>;
Dear Mahesh,
Thank you very much for your checking.
Unfortunately, I unsuccessfully reproduce this problem in our environment.
Would you please send us the trace log of d and nd of both SC-1 and SC-2
when error occur for investigating.
For reference, here is my reproduce steps:
1. prepare SC-1
61 matches
Mail list logo