The OpenSAF community is pleased to announce the availability of the OpenSAF
5.24.02 release.
The source code for OpenSAF 5.24.02 and the corresponding documentation can be
downloaded using the following links:
The OpenSAF community is pleased to announce the availability of the OpenSAF
5.23.07 release. The source code for OpenSAF 5.23.07 and the corresponding
documentation can be downloaded using the following links:
http://sourceforge.net/projects/opensaf/files/releases/opensaf-5.23.07.tar.g
The OpenSAF community is pleased to announce the availability of the OpenSAF
5.23.03 release. The source code for OpenSAF 5.23.03 and the corresponding
documentation can be downloaded using the following links:
http://sourceforge.net/projects/opensaf/files/releases/opensaf-5.23.03.tar.g
The OpenSAF community is pleased to announce the availability of the OpenSAF
5.22.11 release. The source code for OpenSAF 5.22.11 and the corresponding
documentation can be downloaded using the following links:
http://sourceforge.net/projects/opensaf/files/releases/opensaf-5.22.11.tar.g
The OpenSAF community is pleased to announce the availability of the OpenSAF
5.22.06 release. The source code for OpenSAF 5.22.06 and the corresponding
documentation can be downloaded using the following links:
The OpenSAF community is pleased to announce the availability of the
OpenSAF 5.22.01 release. The source code for OpenSAF 5.22.01 and the
corresponding documentation can be downloaded using the following links:
The OpenSAF community is pleased to announce the availability of the
OpenSAF 5.21.09 release. The source code for OpenSAF 5.21.09 and the
corresponding documentation can be downloaded using the following links:
http://sourceforge.net/projects/opensaf/files/releases/opensaf-5.21.09.tar.gz/download
The OpenSAF community is pleased to announce the availability of the
OpenSAF 5.21.06 release. The source code for OpenSAF 5.21.06 and the
corresponding documentation can be downloaded using the following links:
http://sourceforge.net/projects/opensaf/files/releases/opensaf-5.21.06.tar.gz/download
The OpenSAF community is pleased to announce the availability of the
OpenSAF 5.20.11 release. The source code for OpenSAF 5.20.11 and the
corresponding documentation can be downloaded using the following links:
http://sourceforge.net/projects/opensaf/files/releases/opensaf-5.20.11.tar.gz/download
The OpenSAF community is pleased to announce the availability of the
OpenSAF 5.20.08 release. The source code for OpenSAF 5.20.08 and the
corresponding documentation can be downloaded using the following links:
http://sourceforge.net/projects/opensaf/files/releases/opensaf-5.20.08.tar.gz/download
The OpenSAF community is pleased to announce the availability of the
OpenSAF 5.20.05 release. The source code for OpenSAF 5.20.05 and the
corresponding documentation can be downloaded using the following links:
http://sourceforge.net/projects/opensaf/files/releases/opensaf-5.20.05.tar.gz/download
ack (review only)
Thanks
From: Peter McIntyre
Sent: 30 April 2020 18:55
To: Minh Hon Chau ; Thang Duc Nguyen
Cc: opensaf-devel@lists.sourceforge.net
Subject: [devel] [PATCH 1/1] amf: Debug info logged at Emergency level [#3179]
Many places in amf code the
Hi Thuan
One comment inline with [GL].
Thanks
Gary
From: Thuan Tran
Sent: 04 March 2020 18:28
To: Thang Duc Nguyen ; Minh Hon Chau
; Gary Lee
Cc: opensaf-devel@lists.sourceforge.net ;
Thuan Tran
Subject: [PATCH 1/1] amfnd: fix unexpected reboot after split
nks
Gary
From: Thuan Tran
Sent: 20 February 2020 22:21
To: Gary Lee ; Vu Minh Nguyen
; Minh Hon Chau ; Thang
Duc Nguyen
Cc: opensaf-devel@lists.sourceforge.net ;
Thuan Tran
Subject: [PATCH 1/1] osaf: fix etcd3.plugin watch takeover_request [#3158]
After reject a takeover_reques
} else {
+ break;
+}
+ }
Thanks
Gary
From: Thuan Tran
Sent: 18 February 2020 17:38
To: Vu Minh Nguyen ; Minh Hon Chau
; Thang Duc Nguyen ;
Gary Lee
Cc: opensaf-devel@lists.sourceforge.net ;
Thuan Tran
Subject: [PATCH 1/1] clmd: retry once to send message
Hi
Ack (tested)
-Original Message-
From: thang.d.nguyen [mailto:thang.d.ngu...@dektech.com.au]
Sent: Tuesday, 4 February 2020 1:37 PM
To: Gary Lee
Cc: opensaf-devel@lists.sourceforge.net; Thang Duc Nguyen
Subject: [PATCH 1/1] rde: correct to promote node to active [#3108]
If relaxed
Hi Minh
ack
—
From: Minh Chau
Sent: Friday, January 24, 2020 11:35:29 AM
To: Gary Lee
Cc: opensaf-devel@lists.sourceforge.net ;
Minh Hon Chau
Subject: [PATCH 1/1] fmd: Do not send RDE to set active role if
opensaf_quick_reboot is executed [#3146]
If a SC
hanks
Gary
From: Minh Chau
Sent: 16 January 2020 13:06
To: Gary Lee ; hans.nordeb...@ericsson.com
; Vu Minh Nguyen
Cc: opensaf-devel@lists.sourceforge.net ;
Minh Hon Chau
Subject: [PATCH 1/1] rde: Reboot node if another active controller is detected
[#3142]
---
src/rde/rded/r
Hi Minh
ack
From: Minh Chau
Sent: 16 January 2020 13:06
To: Gary Lee ; hans.nordeb...@ericsson.com
; Vu Minh Nguyen
Cc: opensaf-devel@lists.sourceforge.net ;
Minh Hon Chau
Subject: [PATCH 1/1] rde: Reboot node if another active controller is detected
[#3142
Hi Vu
ack (review only)
From: Vu Minh Nguyen
Sent: 09 January 2020 21:51
To: Minh Hon Chau ; Gary Lee
Cc: opensaf-devel@lists.sourceforge.net ;
Vu Minh Nguyen
Subject: [PATCH 1/1] log: fix memory leak that was introduced in 3116 [#3138]
---
src/log/logd
Hi Thuan
Ack
Thanks
Gary
From: thuan.tran
Sent: 30 December 2019 21:20
To: Thang Duc Nguyen ; Gary Lee
; Minh Hon Chau
Cc: opensaf-devel@lists.sourceforge.net ;
Thuan Tran
Subject: [PATCH 1/1] amf: allow update node failover state in cold sync [#3136
Hi Vu
Very, very minor comments with [GL].
Thanks
Gary
-Original Message-
From: Vu Minh Nguyen [mailto:vu.m.ngu...@dektech.com.au]
Sent: Thursday, 28 November 2019 7:24 PM
To: lennart.l...@ericsson.com; Gary Lee ; Minh Hon
Chau
Cc: opensaf-devel@lists.sourceforge.net; Vu Minh Nguyen
Hi Vu
Very minor comments with [GL].
Gary
-Original Message-
From: Vu Minh Nguyen [mailto:vu.m.ngu...@dektech.com.au]
Sent: Thursday, 28 November 2019 7:25 PM
To: lennart.l...@ericsson.com; Gary Lee ; Minh Hon
Chau
Cc: opensaf-devel@lists.sourceforge.net; Vu Minh Nguyen
Subject
Hi
Ack ( review )
thanks
Gary
—
From: phuc.h.chau
Sent: Monday, December 16, 2019 6:59:38 PM
To: Vu Minh Nguyen
Cc: opensaf-devel@lists.sourceforge.net
Subject: [devel] [PATCH 1/1] amfd: Fix the data types of attributes
inconsistency in get_config() [#3128]
revision 4fd8ba91a1943a6ed696f86763b6ee804bccc27c
Author: Gary Lee
Date: Wed, 13 Nov 2019 17:09:35 +1100
osaf: return a help message if no parameter is specified [#3118]
Complete diffstat:
--
src/osaf/consensus/plugins/tcp/tcp.plugin | 7 ++-
1 file changed, 6 insertions(+),
---
src/osaf/consensus/plugins/tcp/tcp.plugin | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/src/osaf/consensus/plugins/tcp/tcp.plugin
b/src/osaf/consensus/plugins/tcp/tcp.plugin
index 1b5ddf5..0be20fc 100755
--- a/src/osaf/consensus/plugins/tcp/tcp.plugin
+++
ack (review only)
On 7/11/19 8:33 pm, thuan.tran wrote:
When cluster stop by immadm, amfnd (is shutting down) may see amfd
down event and order node reboot.
---
src/amf/amfnd/di.cc | 6 ++
1 file changed, 6 insertions(+)
diff --git a/src/amf/amfnd/di.cc b/src/amf/amfnd/di.cc
index
Hi Alex
ack
Thanks
Gary
On 18/10/19 2:56 am, Jones, Alex wrote:
If a component is configured to restart, instead of failover, on failure,
the previous transition descriptor is passed to the CSI set callback after
the restart.
The transition descriptor is not reset by amfnd in this case.
Hi Minh
ack (review only)
Thanks
On 17/10/19 2:00 pm, Minh Chau wrote:
The mds flow control has been disabled for broadcast/mulitcast unfragment
message if tipc multicast is enabled. This patch revisits and continues
with fragment messages.
---
src/mds/mds_tipc_fctrl_intf.cc | 47
Hi Thuan
Looks OK (review only).
Thanks
Gary
On 14/10/19 8:44 pm, thuan.tran wrote:
mdstest for overload
- 2 senders overload one receivers
- one sender overloads 2 receivers
mdstest for SNA (Serial Number Arithmetic)
- without overload, mds sender gradually sends more than 65535 messages
:22 pm, Gary Lee wrote:
---
src/osaf/consensus/plugins/tcp/tcp_server.py | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/src/osaf/consensus/plugins/tcp/tcp_server.py
b/src/osaf/consensus/plugins/tcp/tcp_server.py
index a7f22f2..c10859c 100755
--- a/src/osaf/consensus
revision fed332c489eb687982071013a8cb64e1932960e0
Author: Gary Lee
Date: Fri, 11 Oct 2019 14:08:50 +1100
osaf: perform handshake in tcp_server in new thread [#3099]
Complete diffstat:
--
src/osaf/consensus/plugins/tcp/tcp_server.py | 7 ++-
1 file changed, 6 insertions(+),
---
src/osaf/consensus/plugins/tcp/tcp_server.py | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/src/osaf/consensus/plugins/tcp/tcp_server.py
b/src/osaf/consensus/plugins/tcp/tcp_server.py
index a7f22f2..c10859c 100755
--- a/src/osaf/consensus/plugins/tcp/tcp_server.py
If a takeover_request is created just before the active controller
calls 'watch takeover_request', then it's possible that the
active rded instance is not informed of the request.
When 'watch takeover_request' is called, check if there's already
a takeover_request in 'NEW' state and return
revision 903ebd435993cce00350c60827e35b15a78ca3c8
Author: Gary Lee
Date: Thu, 10 Oct 2019 14:53:41 +1100
osaf: return new takeover_request immediately [#3098]
If a takeover_request is created just before the active controller
calls 'watch takeover_request', then it's possible that the
active rde
f signed cert? /BR Hans
>> On Tue, 2019-10-01 at 12:53 +1000, Gary Lee wrote:
>> ---
>> src/osaf/consensus/plugins/tcp/README | 41 ++
>> src/osaf/consensus/plugins/tcp/certificate.pem | 20 +
>> src/osaf/consensus/plugins/tcp/key.pem | 28 ++
>>
revision 39c8ca156da2acbaecb83ae76ce7d9bc480a4c64
Author: Gary Lee
Date: Thu, 3 Oct 2019 15:07:30 +1000
amf: add asserts to problematic areas identified by codechecker [#3077]
Complete diffstat:
--
src/amf/amfd/sg_nway_fsm.cc | 2 ++
src/amf/amfd/sgtype.cc | 1 +
src
andby/arbitrator is in partition 1. We would end up with dual
actives as the SCs in partition 2 will also become active/standby.
Hope that explains it better.
Gary
On 1/10/19 12:53 pm, Gary Lee wrote:
Summary: osaf: add tcp arbitrator [#3064]
Review request for Ticket(s): 3064
Peer Reviewe
revision feea45602df54671c8e769f2e234b03ad6dcdaeb
Author: Gary Lee
Date: Tue, 1 Oct 2019 12:47:13 +1000
osaf: add tcp arbitrator [#3064]
Added Files:
src/osaf/consensus/plugins/tcp/certificate.pem
src/osaf/consensus/plugins/tcp/key.pem
src/osaf/consensus/plugins/tcp/README
src/osaf/consensus/plugins/tcp/tcp.p
Hi Thang
ack (review only)
Thanks
Gary
On 16/9/19 4:44 pm, thang.d.nguyen wrote:
During stanby SC comes up, AMF config objects are deleted on
active SC. It causes NOT_EXIST error on standby node.
AMFD on standby should ignore this error in this case.
---
src/amf/amfd/app.cc| 29
revision 4a13618129f61b3a24502722d8c7b84bb465639e
Author: Gary Lee
Date: Thu, 12 Sep 2019 17:17:51 +1000
amfd: fix coredump during downgrade if delayed failover is enabled [#3078]
If delayed failover is enabled, and a downgrade to a version without #3060
occurs,
then the standby running a new
If delayed failover is enabled, and a downgrade to a version without #3060
occurs,
then the standby running a newer version with #3060 may complain about an out
of sync error during warm sync.
---
src/amf/amfd/ckpt_dec.cc | 23 +++
1 file changed, 19 insertions(+), 4
If delayed failover is enabled, and a downgrade to a version without #3060
occurs,
then the standby running a newer version with #3060 may complain about an out
of sync error during warm sync.
---
src/amf/amfd/ckpt_dec.cc | 23 +++
1 file changed, 19 insertions(+), 4
revision c6c9d6b8efcd9c8b992b82621bbf7ea8f53865a1
Author: Gary Lee
Date: Thu, 12 Sep 2019 17:08:56 +1000
amfd: fix coredump during downgrade if delayed failover is enabled [#3078]
If delayed failover is enabled, and a downgrade to a version without #3060
occurs,
then the standby running a new
Please ignore the Encode/Decode comment.
On 10/9/19 6:02 pm, Gary Lee wrote:
Hi Minh & Thuan
Some minor comments marked with [GL].
On 14/8/19 4:38 pm, Minh Chau wrote:
This is a collaborative patch of two participants:Thuan, Minh.
Main changes:
- Add mds_tipc_fctrl_in
Hi Minh & Thuan
Some minor comments marked with [GL].
On 14/8/19 4:38 pm, Minh Chau wrote:
This is a collaborative patch of two participants:Thuan, Minh.
Main changes:
- Add mds_tipc_fctrl_intf.h, mds_tipc_fctrl_intf.cc: These two files
introduce new functions which are called in
revision f3aac6813bc4fa002f3dbc726f325ed26a70fda4
Author: Gary Lee
Date: Mon, 9 Sep 2019 11:20:34 +1000
amfd: fix coredump during downgrade if delayed failover is enabled [#3078]
If delayed failover is enabled, and a downgrade to a version without #3060
occurs,
then the standby running a new
If delayed failover is enabled, and a downgrade to a version without #3060
occurs,
then the standby running a newer version with #3060 may complain about an out
of sync error during warm sync.
---
src/amf/amfd/ckpt_dec.cc | 19 +++
1 file changed, 15 insertions(+), 4 deletions(-)
add assertions where pointers should not be null
fix a couple of typos
---
src/amf/amfd/comp.cc | 1 +
src/amf/amfd/csi.cc| 3 ++-
src/amf/amfd/cstype.cc | 2 ++
src/amf/amfd/hlt.cc| 1 +
src/amf/amfd/nodeswbundle.cc | 2 +-
src/amf/amfd/ntf.cc
revision 24b75d78a013c554d5f9731e69a7150c11217ad7
Author: Gary Lee
Date: Tue, 3 Sep 2019 12:06:36 +1000
amf: handle errors identified by codechecker [#3077]
add assertions where pointers should not be null
fix a couple of typos
Complete diffstat:
--
src/amf/amfd/comp.cc | 1 +
src/amf/a
Hi Hans
ack (review only)
Thanks
Gary
On 22/8/19 5:49 pm, Hans Nordebäck wrote:
---
tools/devel/fenced/node_state_hdlr_pl.cc | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/devel/fenced/node_state_hdlr_pl.cc
b/tools/devel/fenced/node_state_hdlr_pl.cc
index
Otherwise, after two controller failovers, unexpected
reboot of previously rebooted payloads may occur.
---
src/amf/amfd/node_state_machine.cc | 6 ++
1 file changed, 6 insertions(+)
diff --git a/src/amf/amfd/node_state_machine.cc
b/src/amf/amfd/node_state_machine.cc
index efe2085..d38f79e
revision 252c36529095306e57a859177f9a74f47809b50d
Author: Gary Lee
Date: Thu, 22 Aug 2019 14:08:39 +1000
amfd: set failover_state on standby [#3072]
Otherwise, after two controller failovers, unexpected
reboot of previously rebooted payloads may occur.
Complete diffstat:
--
src/amf/amfd/node_state_mach
Hi Thuan
ack (review only)
Thanks
Gary
On 14/8/19 8:24 pm, thuan.tran wrote:
---
src/mbc/mbcsv_api.c | 6 +++---
src/mbc/mbcsv_peer.c | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/mbc/mbcsv_api.c b/src/mbc/mbcsv_api.c
index 84a2b8771..3a84fdfda 100644
---
Hi Thuan
ack, will push on your behalf.
Thanks
On 14/8/19 7:42 pm, thuan.tran wrote:
---
src/rde/rded/rde_main.cc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/rde/rded/rde_main.cc b/src/rde/rded/rde_main.cc
index 1a7e58792..6594b3d49 100644
---
Hi Vu
ack (review only)
Thanks
On 1/8/19 12:53 pm, Vu Minh Nguyen wrote:
The tipc-config command is obsolete and no longer being maintained. We should
switch to using the "tipc" command instead
---
Makefile.am | 3 ++-
opensaf.spec.in
Hi Alex
Ack, review only.
Thanks
Gary
On 19/7/19 5:04 am, Jones, Alex wrote:
Summary: amfd: add support for dynamically changing saAmfRank of
SaAmfSIRankedSU [#3058]
Review request for Ticket(s): 3058
Peer Reviewer(s): Nagu, Hans, Gary
Pull request to:
Affected branch(es): develop
revision 9443abefdeaae481dbe483b708db8d467619b8c1
Author: Gary Lee
Date: Fri, 19 Jul 2019 16:02:19 +1000
amfd: include failover info in coldsync [#3060]
Failover information is not currently included in coldsync. This means
if a delayed failover is in progress *before* a standby controller is
Failover information is not currently included in coldsync. This means
if a delayed failover is in progress *before* a standby controller is
available, *and* a controller failover occurs, then information about
the delayed failover is lost.
---
src/amf/amfd/chkop.cc | 4 ++
Add supervision timer so controller will reboot if it cannot obtain
consensus lock within the allocation period
(2* FMS_TAKEOVER_REQUEST_VALID_TIME).
The peer controller can then safely perform a node failover
after this period of time.
---
src/fm/fmd/fm_cb.h| 2 ++
src/fm/fmd/fm_main.cc |
If FMS_TAKEOVER_PRIORITISE_PARTITION_SIZE is enabled,
make the time that we wait for MDS node events configurable.
---
src/fm/fmd/fm_rda.cc| 4 +++-
src/fm/fmd/fmd.conf | 5 +
src/osaf/consensus/consensus.cc | 9 +
src/osaf/consensus/consensus.h | 2 ++
revision 4feee2b631afa3393ae9e53fd6575c3768861dca
Author: Gary Lee
Date: Tue, 9 Jul 2019 14:38:49 +1000
osaf: make wait time configurable [#3029]
If FMS_TAKEOVER_PRIORITISE_PARTITION_SIZE is enabled,
make the time that we wait for MDS node events configurable.
revision 2c419ba5fffb85272f0d15118b561bcfc1de4
Hi Phuc
ack, will push on your behalf.
Thanks
Gary
On 25/6/19 7:13 pm, phuc.h.chau wrote:
Amfd crashes when su is unlocked, The reason for the crash is in the
function avd_snd_susi_msg(),get_comp_capability() is called
with csi and comp as input parameter.
In the function,
---
src/osaf/consensus/consensus.cc | 4
src/osaf/consensus/consensus.h | 2 ++
2 files changed, 6 insertions(+)
diff --git a/src/osaf/consensus/consensus.cc b/src/osaf/consensus/consensus.cc
index 0bebab2..814885e 100644
--- a/src/osaf/consensus/consensus.cc
+++
revision 1f48477cdcd92356cd446ad81741f9373724be7c
Author: Gary Lee
Date: Wed, 3 Jul 2019 16:19:17 +1000
amfd: improve controller failover behavior [#3029]
If consensus service is enabled, only perform node failover
after peer controller has self-fenced
(after 2 * FMS_TAKEOVER_REQUEST_VALID_TI
Add supervision timer so controller will reboot if it cannot obtain
consensus lock within the allocation period
(2* FMS_TAKEOVER_REQUEST_VALID_TIME).
The peer controller can then safely perform a node failover
after this period of time.
---
src/fm/fmd/fm_cb.h| 2 ++
src/fm/fmd/fm_main.cc |
If consensus service is enabled, only perform node failover
after peer controller has self-fenced
(after 2 * FMS_TAKEOVER_REQUEST_VALID_TIME seconds).
This also means if node failover delay is set to a large value,
we do not unnecesarily wait too long before failing over assignments
previously
Hi Thang
ack (review only)
Thanks
Gary
On 2/7/19 12:25 pm, thang.d.nguyen wrote:
During controller goes up, it creats config object from IMM.
In case the object was deleted but comming up amfd still
receives ccb object delete callback. And it validates and
crash due to access to null
Hi Hans
Looks good, ack (review only).
One very, very minor comment:
# systemd services managed by fenced. Separate service names by
whitespace, e.g. "opensafd"
SERVICES_TO_FENCE="opensafd"
I guess you could put a second service in the example :-)
Thanks
Gary
On 5/6/19 6:36 pm, Hans
42fb90a283
Author: Gary Lee
Date: Thu, 20 Jun 2019 12:07:57 +1000
amfd: prevent infinite loop [#3050]
In handle_event_in_failover_state(), we iterate through
queue_evt in a while loop, but process_event() can insert
items into the queue inside the loop, and we may end
up never exiting the
In handle_event_in_failover_state(), we iterate through
queue_evt in a while loop, but process_event() can insert
items into the queue inside the loop, and we may end
up never exiting the while loop.
---
src/amf/amfd/main.cc | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff
/6/19 1:24 pm, Gary Lee wrote:
In handle_event_in_failover_state(), we iterate through
queue_evt in a while loop, but process_event() can insert
items into the queue inside the loop, and we may end
up never exiting the while loop.
---
src/amf/amfd/cb.h | 3 ++-
src/amf/amfd/main.cc | 13
bf2db443fd
Author: Gary Lee
Date: Wed, 19 Jun 2019 13:12:35 +1000
amfd: prevent infinite loop [#3050]
In handle_event_in_failover_state(), we iterate through
queue_evt in a while loop, but process_event() can insert
items into the queue inside the loop, and we may end
up never exiting the
In handle_event_in_failover_state(), we iterate through
queue_evt in a while loop, but process_event() can insert
items into the queue inside the loop, and we may end
up never exiting the while loop.
---
src/amf/amfd/cb.h | 3 ++-
src/amf/amfd/main.cc | 13 +
Hi Minh
On 11/6/19 10:33 am, Minh Hon Chau wrote:
Hi Gary,
Those variables e.g node_sync_window_closed have been used before
headless sync complete. If there is a failover during the headless
sync, the new active will start the headless sync again, so those
variables have not been needed to
Hi Phuc
Some comments below.
Thanks
Gary
On 23/5/19 4:48 pm, phuc.h.chau wrote:
Amfd crashes when su is unlocked, The reason for the crash is in the
function avd_snd_susi_msg(),get_comp_capability() is called
with csi and comp as input parameter.
In the function, get_comp_capability(),
Hi Thanh
I will push on your behalf.
Thanks
Gary
On 5/6/19 12:29 pm, Thanh Nguyen wrote:
Invalid read is from the following
- avnd_evt_mds_ava_dn_evh() (amf/amfnd/comp.cc)
- avsv_create_association_class_dn() (amf/common/util.c)
Other changes are to fix cppcheck error report
---
revision 9d64d3c1d386f1019103d12588ab46fa830ee793
Author: Gary Lee
Date: Wed, 5 Jun 2019 13:49:45 +1000
amfd: do not queue sync messages from 'lost' nodes [#3050]
The 'lost' nodes will be rebooted, thus there is no need
to queue sync messages from these nodes.
In addition, node_sync_window_closed is not reliab
The 'lost' nodes will be rebooted, thus there is no need
to queue sync messages from these nodes.
In addition, node_sync_window_closed is not reliable as it's not
check pointed. We should remove all uses of it in another ticket?
Instead, check if the timer is running.
---
src/amf/amfd/cb.h
Hi Thanh
ack (review only).
Thanks
On 4/6/19 8:48 am, Thanh Nguyen wrote:
Invalid read is from the following
- avnd_evt_mds_ava_dn_evh() (amf/amfnd/comp.cc)
- avsv_create_association_class_dn() (amf/common/util.c)
Other changes are to fix cppcheck error report
---
src/amf/amfnd/comp.cc | 16
Hi Hans
ack (review only)
Thanks
On 20/5/19 10:27 pm, Hans Nordebäck wrote:
---
00-README.conf | 14 +++
src/base/Makefile.am | 1 +
src/base/statistics.h| 88 +
src/mds/Makefile.am | 8 +-
revision f8b4a473feafd23ce9d130a8ad245c5da75ab9b4
Author: Gary Lee
Date: Mon, 27 May 2019 09:54:40 +1000
rded: improve self-fencing response time [#3039]
When connectivity to consensus service is lost, it is recorded
in a state variable. When all RDE peers are lost, the node will
now self-fence immediately.
Complet
When connectivity to consensus service is lost, it is recorded
in a state variable. When all RDE peers are lost, the node will
now self-fence immediately.
---
src/rde/rded/rde_cb.h| 5 +
src/rde/rded/rde_main.cc | 18 --
src/rde/rded/role.cc | 24
Hi Thang
Looks good to me. Nagu, any comments?
Thanks
Gary
On 15/5/19 12:14 am, thang.d.nguyen wrote:
During SC failover, message received on ACTIVE AMFD
can not be checked point to AMFD on STANDBY SC.
But the AMFND still process the message ack for that
message then it remove from queue.
servicesn
Core libraries y
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
-
revision 6bd164279a2fbd881c4700566960f3ede728f4df
Author: Gary Lee
D
ConfigFileReader enables runtime 'reload' of .conf files.
However, if the environment variable is surrounded by quotes,
it adds the quotes to the value which is not the expected behaviour.
export FOO="foo"
FOO should contain just foo, not "foo".
---
src/base/config_file_reader.cc | 15
Hi Alex
ack (review only)
Gary
On 8/5/19 5:46 am, Jones, Alex wrote:
In N+M model CSI-remove responses can get lost if active controller
reboots.
In this case SG will be stuck in unstable state, and standby will
never get
assignments.
We are the active controller, active for N+M, SU
Hi
I will push this on Wednesday if there are no comments.
Thanks
Gary
On 26/3/19 1:16 pm, Gary Lee wrote:
If the active and standby SCs are split into network partitions, it is
possible a RED_UP never arrives even though we have already
received MBC PEER_UP. The service using MBC
revision 4825d97b7e9565daae7b36aaba7a7c8717ff627c
Author: Gary Lee
Date: Tue, 26 Mar 2019 13:08:16 +1100
mbc: prevent infinite peer_up message loop [#3021]
If the active and standby SCs are split into network partitions, it is
possible a RED_UP never arrives even though we have already
received MBC PEER_UP. T
If the active and standby SCs are split into network partitions, it is
possible a RED_UP never arrives even though we have already
received MBC PEER_UP. The service using MBC will then get stuck
in an infinite loop and probably fail health checks.
To cater for 'normal' race conditions between MDS
revision 7034e7149d0cd4e74078287c516fc33fad21076f
Author: Gary Lee
Date: Tue, 26 Mar 2019 10:51:52 +1100
osaf: ensure an error is returned if takeover_request fails [#3023]
if we cannot read the result of a takeover_request, ensure we
return an error
Complete diffstat:
--
src/osaf
if we cannot read the result of a takeover_request, ensure we
return an error
---
src/osaf/consensus/consensus.cc | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/osaf/consensus/consensus.cc b/src/osaf/consensus/consensus.cc
index cf307b3..480f7d2 100644
---
if the initial call to watch takeover request in etcd3.plugin
is made when etcd has already been shutdown (for example,
when etcd is running locally and the node is being shutdown),
the plugin should return 0 with a fake takeover request to ensure
rded shuts down promptly. Otherwise, it will keep
revision ce0af7444b489620bc3f1a5ba5d876f563167b00
Author: Gary Lee
Date: Tue, 12 Mar 2019 11:20:35 +1100
osaf: improve response time in etcd3.plugin [#3016]
if the initial call to watch takeover request in etcd3.plugin
is made when etcd has already been shutdown (for example,
when etcd is running locally and the nod
Hi Canh
One minor comment, KEY_TYPES should probably be called KeyTypes. Also,
can you make it an enum class, rather than plain enum?
Thanks
Gary
On 7/3/19 12:53 am, Hans Nordebäck wrote:
Hi Canh,
ack, review only. I think it would be good to separate the re-factoring
part in a separate
Hi Vu
Ack (review only)
Thanks
On 25/2/19, 6:30 pm, "Vu Minh Nguyen" wrote:
At the time of spliting the cluster into 02 partitions but keeping a node
such as PL-3 connecting with both partitions, just IMMND on PL-3 will get
discard-node messages from both active IMMD on partition
. */
for (;;)
pause();
}
Probably a better fix is to add something similar to opensaf_quick_reboot().
Thanks
Gary
On 20/2/19 11:54 pm, Hans Nordebäck wrote:
Hi Gary,
a question, why was the return's added? /BR HansN
On 2/19/19 05:10, Gary Lee wrote:
do not send
revision 8ccffc2cd9cd117578227e9cd49421e5c578fec6
Author: Gary Lee
Date: Tue, 19 Feb 2019 14:57:53 +1100
rded: do not send SUCCESS to main thread [#3008]
do not send RDE_MSG_ACTIVE_PROMOTION_SUCCESS to
main thread if lock cannot be obtained
revision 28e17d107f4a079155e03d9f875a3c0262ea19f5
Author: Gary Lee
Date: T
do not send RDE_MSG_ACTIVE_PROMOTION_SUCCESS to
main thread if lock cannot be obtained
---
src/rde/rded/role.cc | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/rde/rded/role.cc b/src/rde/rded/role.cc
index 06e93c6..3effc25 100644
--- a/src/rde/rded/role.cc
+++ b/src/rde/rded/role.cc
@@
Improve failover response time if split brain prevention is enabled
but FMS_TAKEOVER_PRIORITISE_PARTITION_SIZE is set to 0.
Also, return immediately if node promotion fails to avoid
sending active role to RDA.
---
src/fm/fmd/fm_rda.cc | 14 +-
1 file changed, 9 insertions(+), 5
1 - 100 of 904 matches
Mail list logo
