[devel] [PATCH 1 of 1] smfd: fix race condition when detecting async failures [#2413]

2017-04-06 Thread Alex Jones
src/lck/Makefile.am |8 +- src/lck/agent/gla_api.c | 96 + src/lck/agent/gla_cb.h|4 + src/lck/agent/gla_evt.h | 11 +- src/lck/agent/gla_init.c | 26 +++ src/lck/agent/gla_mds.c | 55 +++

[devel] [PATCH 0 of 1] Review Request for smfd: fix race condition when detecting async failures [#2413]

2017-04-06 Thread Alex Jones
Summary: smfd: fix race condition during campaign commit Review request for Trac Ticket(s): 2413 Peer Reviewer(s): lennart, rafael, neel Pull request to: Affected branch(es): default Development branch: Impacted area Impact y/n

[devel] [PATCH 1 of 1] smfd: fix race condition when detecting async failures [#2413]

2017-04-06 Thread Alex Jones
src/smf/smfd/SmfCampaignThread.cc | 16 ++-- 1 files changed, 10 insertions(+), 6 deletions(-) smfd core dumps during commit of campaign. If an AMF SU under maintenance fails right as the campaign commit is done, there is a race condition present. Before SMF clears the

[devel] [PATCH 0 of 1] Review Request for smfd: fix race condition when detecting async failures [#2413]

2017-04-06 Thread Alex Jones
Summary: smfd: fix race condition during campaign commit Review request for Trac Ticket(s): 2413 Peer Reviewer(s): rafael, lennart, neel Pull request to: Affected branch(es): default Development branch: Impacted area Impact y/n

[devel] [PATCH 1 of 1] ckpt: Add option OSAF_CKPT_SHM_ALLOC_GUARANTEE=2 for backwards compatibility [#2395]

2017-04-06 Thread Anders Widell
src/ckpt/ckptnd/ckptnd.conf | 6 ++ src/ckpt/ckptnd/cpnd_cb.h | 3 ++- src/ckpt/ckptnd/cpnd_init.c | 3 ++- src/ckpt/ckptnd/cpnd_proc.c | 9 + src/ckpt/ckptnd/cpnd_res.c | 9 + 5 files changed, 20 insertions(+), 10 deletions(-) The setting

[devel] [PATCH 0 of 1] Review Request for ckpt: Add option OSAF_CKPT_SHM_ALLOC_GUARANTEE=2 for backwards compatibility [#2395]

2017-04-06 Thread Anders Widell
Summary: ckpt: Add option OSAF_CKPT_SHM_ALLOC_GUARANTEE=2 for backwards compatibility [#2395] Review request for Trac Ticket(s): 2395 Peer Reviewer(s): Mahesh Pull request to: Affected branch(es): default(5.2) Development branch: default Impacted area

Re: [devel] [PATCH 1 of 1] ckpt: Add option OSAF_CKPT_SHM_ALLOC_GUARANTEE=2 for backwards compatibility [#2395]

2017-04-06 Thread A V Mahesh
One more comment added to previous mail. On 4/7/2017 8:47 AM, A V Mahesh wrote: > Hi Anders Widell, > > Ack with following comments : > > On 4/6/2017 4:55 PM, Anders Widell wrote: >> The setting OSAF_CKPT_SHM_ALLOC_GUARANTEE=0 results in increased >> memory usage, >> whereas the setting

Re: [devel] [PATCH 1 of 1] ckpt: Add option OSAF_CKPT_SHM_ALLOC_GUARANTEE=2 for backwards compatibility [#2395]

2017-04-06 Thread A V Mahesh
Hi Anders Widell, Ack with following comments : On 4/6/2017 4:55 PM, Anders Widell wrote: > The setting OSAF_CKPT_SHM_ALLOC_GUARANTEE=0 results in increased memory usage, > whereas the setting OSAF_CKPT_SHM_ALLOC_GUARANTEE=1 results in lower > performance. Thus, there was no way to configure

Re: [devel] [PATCH 0 of 1] Review Request for smfd: fix race condition when detecting async failures [#2413]

2017-04-06 Thread Rafael Odzakow
Looks like some other code ended up in this patch? On 04/06/2017 05:30 PM, Alex Jones wrote: > Summary: smfd: fix race condition during campaign commit > Review request for Trac Ticket(s): 2413 > Peer Reviewer(s): lennart, rafael, neel > Pull request to: > Affected branch(es): default >